scss-lint 0.25.1 → 0.26.0

data/spec/scss_lint/linter/space_after_property_colon_spec.rb

@@ -0,0 +1,238 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::SpaceAfterPropertyColon do
+  let(:linter_config) { { 'style' => style } }
+
+  context 'when one space is preferred' do
+    let(:style) { 'one_space' }
+
+    context 'when the colon after a property is not followed by space' do
+      let(:css) { <<-CSS }
+        p {
+          margin:0;
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when colon after property is not followed by space and the semicolon is missing' do
+      let(:css) { <<-CSS }
+        p {
+          color:#eee
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when the colon after a property is followed by a space' do
+      let(:css) { <<-CSS }
+        p {
+          margin: 0;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a property is surrounded by spaces' do
+      let(:css) { <<-CSS }
+        p {
+          margin : bold;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a property is followed by multiple spaces' do
+      let(:css) { <<-CSS }
+        p {
+          margin:  bold;
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+  end
+
+  context 'when no spaces are allowed' do
+    let(:style) { 'no_space' }
+
+    context 'when the colon after a property is not followed by space' do
+      let(:css) { <<-CSS }
+        p {
+          margin:0;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when colon after property is not followed by space and the semicolon is missing' do
+      let(:css) { <<-CSS }
+        p {
+          color:#eee
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a property is followed by a space' do
+      let(:css) { <<-CSS }
+        p {
+          margin: 0;
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when the colon after a property is surrounded by spaces' do
+      let(:css) { <<-CSS }
+        p {
+          margin : bold;
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when the colon after a property is followed by multiple spaces' do
+      let(:css) { <<-CSS }
+        p {
+          margin:  bold;
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+  end
+
+  context 'when at least one space is preferred' do
+    let(:style) { 'at_least_one_space' }
+
+    context 'when the colon after a property is not followed by space' do
+      let(:css) { <<-CSS }
+        p {
+          margin:0;
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when colon after property is not followed by space and the semicolon is missing' do
+      let(:css) { <<-CSS }
+        p {
+          color:#eee
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when the colon after a property is followed by a space' do
+      let(:css) { <<-CSS }
+        p {
+          margin: 0;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a property is surrounded by spaces' do
+      let(:css) { <<-CSS }
+        p {
+          margin : bold;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a property is followed by multiple spaces' do
+      let(:css) { <<-CSS }
+        p {
+          margin:  bold;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when aligned property values are preferred' do
+    let(:style) { 'aligned' }
+
+    context 'when the colon after a single property is not followed by space' do
+      let(:css) { <<-CSS }
+        p {
+          margin:0;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when the colon after a single property is followed by a space' do
+      let(:css) { <<-CSS }
+        p {
+          margin: 0;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when properties are not aligned' do
+      let(:css) { <<-CSS }
+        p {
+          content: 'hello';
+          margin: 0;
+          padding: 0;
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when properties aligned but the names are not' do
+      let(:css) { <<-CSS }
+        p {
+          content:  'hello';
+           margin:  0;
+          padding:  0;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when properties aligned but the names with spaces are not' do
+      let(:css) { <<-CSS }
+        p {
+          content :  'hello';
+           margin :  0;
+          padding :  0;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when properties are aligned' do
+      let(:css) { <<-CSS }
+        p {
+          margin:  0;
+          padding: 0;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+end

data/spec/scss_lint/linter/space_after_property_name_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::SpaceAfterPropertyName do
+  context 'when a property name is followed by a space' do
+    let(:css) { <<-CSS }
+      p {
+        margin : 0;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a property name is not followed by a space' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/space_before_brace_spec.rb

@@ -0,0 +1,447 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::SpaceBeforeBrace do
+  context 'with a @at-root block' do
+    context 'when brace is preceded by a space' do
+      let(:css) { <<-CSS }
+        .parent {
+          @at-root .child {
+          }
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when brace is preceded by multiple spaces' do
+      let(:css) { <<-CSS }
+        .parent {
+          @at-root .child  {
+          }
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'when brace is not preceded by a space' do
+      let(:css) { <<-CSS }
+        .parent {
+          @at-root .child{
+          }
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+  end
+
+  context 'with an @each block' do
+    context 'when brace is preceded by a space' do
+      let(:css) { <<-CSS }
+        @each $item in $list {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when brace is preceded by multiple spaces' do
+      let(:css) { <<-CSS }
+        @each $item in $list  {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when brace is not preceded by a space' do
+      let(:css) { <<-CSS }
+        @each $item in $list{
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'with a @for block' do
+    context 'when brace is preceded by a space' do
+      let(:css) { <<-CSS }
+        @for $i from $start to $end {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when brace is preceded by multiple spaces' do
+      let(:css) { <<-CSS }
+        @for $i from $start to $end  {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when brace is not preceded by a space' do
+      let(:css) { <<-CSS }
+        @for $i from $start to $end{
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'with a @while block' do
+    context 'when brace is preceded by a space' do
+      let(:css) { <<-CSS }
+        @while $condition {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when brace is preceded by multiple spaces' do
+      let(:css) { <<-CSS }
+        @while $condition  {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when brace is not preceded by a space' do
+      let(:css) { <<-CSS }
+        @while $condition{
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+  end
+
+  context 'with a rule selector' do
+    context 'when brace is preceded by a space' do
+      let(:css) { <<-CSS }
+        p {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when brace is preceded by multiple spaces' do
+      let(:css) { <<-CSS }
+        p  {
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when brace is not preceded by a space' do
+      let(:css) { <<-CSS }
+        p{
+        }
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when brace is in a single line rule set' do
+      let(:css) { <<-CSS }
+        .single-line-selector{color: #f00;}
+      CSS
+
+      it { should report_lint line: 1 }
+    end
+
+    context 'when brace is following a multi-selector rule set' do
+      let(:css) { <<-CSS }
+        .selector1,
+        .selector2,
+        .selector3{
+        }
+      CSS
+
+      it { should report_lint line: 3 }
+    end
+  end
+
+  context 'with a function declaration' do
+    context 'with arguments' do
+      context 'when brace is preceded by a space' do
+        let(:css) { <<-CSS }
+          @function func($arg, $arg2) {
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+
+      context 'when brace is preceded by multiple spaces' do
+        let(:css) { <<-CSS }
+          @function func($arg, $arg2)  {
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'when brace is not preceded by a space' do
+        let(:css) { <<-CSS }
+          @function func($arg, $arg2){
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+    end
+
+    context 'without arguments' do
+      context 'when brace is preceded by a space' do
+        let(:css) { <<-CSS }
+          @function func() {
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+
+      context 'when brace is preceded by multiple spaces' do
+        let(:css) { <<-CSS }
+          @function func()  {
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'when brace is not preceded by a space' do
+        let(:css) { <<-CSS }
+          @function func(){
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'with a mixin declaration' do
+    context 'with arguments' do
+      context 'when brace is preceded by a space' do
+        let(:css) { <<-CSS }
+          @mixin mixin($arg, $arg2) {
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+
+      context 'when brace is preceded by multiple spaces' do
+        let(:css) { <<-CSS }
+          @mixin mixin($arg, $arg2)  {
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'when brace is not preceded by a space' do
+        let(:css) { <<-CSS }
+          @mixin mixin($arg, $arg2){
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+    end
+
+    context 'without arguments' do
+      context 'when brace is preceded by a space' do
+        let(:css) { <<-CSS }
+          @mixin mixin {
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+
+      context 'when brace is preceded by multiple spaces' do
+        let(:css) { <<-CSS }
+          @mixin mixin  {
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'when brace is not preceded by a space' do
+        let(:css) { <<-CSS }
+          @mixin mixin{
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'with a mixin include with braces' do
+    context 'with arguments' do
+      context 'when brace is preceded by a space' do
+        let(:css) { <<-CSS }
+          @include mixin(arg, arg2) {
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+
+      context 'when brace is preceded by multiple spaces' do
+        let(:css) { <<-CSS }
+          @include mixin(arg, arg2)  {
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'when brace is not preceded by a space' do
+        let(:css) { <<-CSS }
+          @include mixin(arg, arg2){
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+    end
+
+    context 'without arguments' do
+      context 'when brace is preceded by a space' do
+        let(:css) { <<-CSS }
+          @include mixin {
+          }
+        CSS
+
+        it { should_not report_lint }
+      end
+
+      context 'when brace is preceded by multiple spaces' do
+        let(:css) { <<-CSS }
+          @include mixin  {
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+
+      context 'when brace is not preceded by a space' do
+        let(:css) { <<-CSS }
+          @include mixin{
+          }
+        CSS
+
+        it { should report_lint line: 1 }
+      end
+    end
+  end
+
+  context 'with a mixin include with no braces' do
+    context 'with arguments' do
+      let(:css) { <<-CSS }
+        @include mixin(arg, arg2);
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'without arguments' do
+      let(:css) { <<-CSS }
+        @include mixin;
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when curly brace appears in a string' do
+    let(:css) { <<-CSS }
+      a {
+        content: "{";
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when using #{} interpolation' do
+    let(:css) { <<-CSS }
+      @mixin test-mixin($class, $prop, $pixels) {
+        .\#{$class} {
+          \#{$prop}: \#{$pixels}px;
+        }
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when using braces in comments' do
+    let(:css) { '// ({x})' }
+
+    it { should_not report_lint }
+  end
+
+  context 'when blocks occupy a single line' do
+    let(:linter_config) { { 'allow_single_line_padding' => allow_single_line_padding } }
+
+    let(:css) { <<-CSS }
+      p{ }
+      p { }
+      p           { &:before { } }
+      p           { &:before{ } }
+    CSS
+
+    context 'and the `allow_extra_spaces` option is true' do
+      let(:allow_single_line_padding) { true }
+
+      it { should report_lint line: 1 }
+      it { should_not report_lint line: 2 }
+      it { should_not report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+
+    context 'and the `allow_extra_spaces` option is false' do
+      let(:allow_single_line_padding) { false }
+
+      it { should report_lint line: 1 }
+      it { should_not report_lint line: 2 }
+      it { should report_lint line: 3 }
+      it { should report_lint line: 4 }
+    end
+  end
+
+  context 'when curly brace is in single quotes' do
+    let(:css) { <<-CSS }
+      @if $token == '{' {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when curly brace is on own line' do
+    let(:css) { <<-CSS }
+      .class
+      {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+end