scss-lint 0.25.1 → 0.26.0

data/spec/scss_lint/selector_visitor_spec.rb

@@ -0,0 +1,264 @@
+require 'spec_helper'
+
+describe SCSSLint::SelectorVisitor do
+  describe '#visit' do
+    let(:engine) { SCSSLint::Engine.new(css) }
+    before { RuleVisitor.new(visitor).run(engine) }
+
+    # Visits every rule in the given parse tree and passes the parsed selector
+    # to the given `selector_visitor`.
+    class RuleVisitor < Sass::Tree::Visitors::Base
+      def initialize(selector_visitor)
+        @selector_visitor = selector_visitor
+      end
+
+      def run(engine)
+        visit(engine.tree)
+      end
+
+      def visit_rule(node)
+        @selector_visitor.visit_selector(node.parsed_rules)
+        yield # Continue linting children
+      end
+    end
+
+    # Superclass for all the test selector visitors
+    class TrackingSelectorVisitor
+      include SCSSLint::SelectorVisitor
+
+      attr_reader :node_order
+
+      def initialize
+        @node_order = []
+      end
+    end
+
+    context 'when visitor defines visit_attribute' do
+      class TestAttributeVisitor < TrackingSelectorVisitor
+        def visit_attribute(attribute)
+          @node_order << attribute.name.join
+        end
+      end
+
+      let(:visitor) { TestAttributeVisitor.new }
+
+      let(:css) { <<-CSS }
+        [rel="nofollow"] {}
+        a[href="http"] {}
+        .class [data-count] {}
+      CSS
+
+      it 'visits all attribute nodes' do
+        visitor.node_order.should == %w[rel href data-count]
+      end
+    end
+
+    context 'when visitor defines visit_class' do
+      class TestClassVisitor < TrackingSelectorVisitor
+        def visit_class(klass)
+          @node_order << klass.name.join
+        end
+      end
+
+      let(:visitor) { TestClassVisitor.new }
+
+      let(:css) { <<-CSS }
+        a.link {}
+        .menu .menu-item {}
+        .button[data-source], .overlay {}
+      CSS
+
+      it 'visits all class nodes' do
+        visitor.node_order.should == %w[link menu menu-item button overlay]
+      end
+    end
+
+    context 'when visitor defines visit_element' do
+      class TestElementVisitor < TrackingSelectorVisitor
+        def visit_element(element)
+          @node_order << element.name.join
+        end
+      end
+
+      let(:visitor) { TestElementVisitor.new }
+
+      let(:css) { <<-CSS }
+        a, b {}
+        .class {}
+        i + p {}
+      CSS
+
+      it 'visits all element nodes' do
+        visitor.node_order.should == %w[a b i p]
+      end
+    end
+
+    context 'when visitor defines visit_id' do
+      class TestIdVisitor < TrackingSelectorVisitor
+        def visit_id(id)
+          @node_order << id.name.join
+        end
+      end
+
+      let(:visitor) { TestIdVisitor.new }
+
+      let(:css) { <<-CSS }
+        #something, #thing {}
+        #object + #entity {}
+      CSS
+
+      it 'visits all id nodes' do
+        visitor.node_order.should == %w[something thing object entity]
+      end
+    end
+
+    context 'when visitor defines visit_parent' do
+      class TestParentVisitor < TrackingSelectorVisitor
+        def visit_parent(parent)
+          @node_order << parent.line
+        end
+      end
+
+      let(:visitor) { TestParentVisitor.new }
+
+      let(:css) { <<-CSS }
+        p {
+          &.class {}
+          .container & {}
+          .nothing {}
+        }
+      CSS
+
+      it 'visits all parent nodes' do
+        visitor.node_order.should == [2, 3]
+      end
+    end
+
+    context 'when visitor defines visit_placeholder' do
+      class TestPlaceholderVisitor < TrackingSelectorVisitor
+        def visit_placeholder(placeholder)
+          @node_order << placeholder.name.join
+        end
+      end
+
+      let(:visitor) { TestPlaceholderVisitor.new }
+
+      let(:css) { <<-CSS }
+        %placeholder, %other-placeholder {}
+        .button, %button {}
+      CSS
+
+      it 'visits all placeholder nodes' do
+        visitor.node_order.should == %w[placeholder other-placeholder button]
+      end
+    end
+
+    context 'when visitor defines visit_pseudo' do
+      class TestPseudoVisitor < TrackingSelectorVisitor
+        def visit_pseudo(pseudo)
+          @node_order << pseudo.name.join
+        end
+      end
+
+      let(:visitor) { TestPseudoVisitor.new }
+
+      let(:css) { <<-CSS }
+        li:first-child, li:last-child {}
+        p {
+          &:first-letter {}
+        }
+      CSS
+
+      it 'visits all pseudo-selector nodes' do
+        visitor.node_order.should == %w[first-child last-child first-letter]
+      end
+    end
+
+    context 'when visitor defines visit_universal' do
+      class TestUniversalVisitor < TrackingSelectorVisitor
+        def visit_universal(universal)
+          @node_order << universal.line
+        end
+      end
+
+      let(:visitor) { TestUniversalVisitor.new }
+
+      let(:css) { <<-CSS }
+        p > * {}
+        * {}
+        li {}
+        *:first-child {}
+      CSS
+
+      it 'visits all universal-selector nodes' do
+        visitor.node_order.should == [1, 2, 4]
+      end
+    end
+
+    context 'when visitor defines visit_simple_sequence' do
+      class TestSimpleSequenceVisitor < TrackingSelectorVisitor
+        def visit_simple_sequence(seq)
+          @node_order << seq
+        end
+      end
+
+      let(:visitor) { TestSimpleSequenceVisitor.new }
+
+      let(:css) { <<-CSS }
+        a, b, p[lang] {}
+        a.link + b.word {}
+        li {}
+        ul > li {}
+        p span {}
+      CSS
+
+      it 'visits all simple sequences' do
+        visitor.node_order.count.should == 10
+      end
+    end
+
+    context 'when visitor defines visit_sequence' do
+      class TestSequenceVisitor < TrackingSelectorVisitor
+        def visit_sequence(seq)
+          @node_order << seq
+        end
+      end
+
+      let(:visitor) { TestSequenceVisitor.new }
+
+      let(:css) { <<-CSS }
+        a, b, p[lang] {}
+        a.link + b.word {}
+        li {}
+        ul > li {}
+        p span {}
+      CSS
+
+      it 'visits all sequences' do
+        visitor.node_order.count.should == 7
+      end
+    end
+
+    context 'when visitor defines visit_comma_sequence' do
+      class TestCommaSequenceVisitor < TrackingSelectorVisitor
+        def visit_comma_sequence(seq)
+          @node_order << seq
+        end
+      end
+
+      let(:visitor) { TestCommaSequenceVisitor.new }
+
+      let(:css) { <<-CSS }
+        a, b, p[lang] {}
+        a.link + b.word {}
+        li {}
+        ul > li {}
+        p span {}
+      CSS
+
+      it 'visits all comma (i.e. selector) sequences' do
+        visitor.node_order.count.should == 5
+      end
+    end
+  end
+end

data/spec/spec_helper.rb

@@ -0,0 +1,34 @@
+require 'scss_lint'
+require 'nokogiri'
+
+Dir[File.dirname(__FILE__) + '/support/**/*.rb'].each { |f| require f }
+
+RSpec.configure do |config|
+  config.expect_with :rspec do |c|
+    c.syntax = [:expect, :should]
+  end
+
+  config.mock_with :rspec do |c|
+    c.syntax = :should
+  end
+
+  config.before(:each) do
+    # If running a linter spec, run the described linter against the CSS code
+    # for each example. This significantly DRYs up our linter specs to contain
+    # only tests, since all the setup code is now centralized here.
+    if described_class < SCSSLint::Linter
+      initial_indent = css[/\A(\s*)/, 1]
+      normalized_css = css.gsub(/^#{initial_indent}/, '')
+
+      # Use the configuration settings defined by default unless a specific
+      # configuration has been provided for the test.
+      local_config = if respond_to?(:linter_config)
+                       linter_config
+                     else
+                       SCSSLint::Config.default.linter_options(subject)
+                     end
+
+      subject.run(SCSSLint::Engine.new(normalized_css), local_config)
+    end
+  end
+end

data/spec/support/isolated_environment.rb

@@ -0,0 +1,25 @@
+require 'fileutils'
+require 'tmpdir'
+
+shared_context 'isolated environment' do
+  around do |example|
+    Dir.mktmpdir do |tmpdir|
+      original_home = ENV['HOME']
+
+      begin
+        virtual_home = File.expand_path(File.join(tmpdir, 'home'))
+        Dir.mkdir(virtual_home)
+        ENV['HOME'] = virtual_home
+
+        working_dir = File.join(tmpdir, 'work')
+        Dir.mkdir(working_dir)
+
+        Dir.chdir(working_dir) do
+          example.run
+        end
+      ensure
+        ENV['HOME'] = original_home
+      end
+    end
+  end
+end

data/spec/support/matchers/report_lint.rb

@@ -0,0 +1,48 @@
+RSpec::Matchers.define :report_lint do |options|
+  options ||= {}
+  count = options[:count]
+  expected_line = options[:line]
+
+  match do |linter|
+    has_lints?(linter, expected_line, count)
+  end
+
+  failure_message do |linter|
+    'expected that a lint would be reported' +
+      (expected_line ? " on line #{expected_line}" : '') +
+      case linter.lints.count
+      when 0
+        ''
+      when 1
+        ", but was on line #{linter.lints.first.location.line}"
+      else
+        lines = lint_lines(linter)
+        ", but lints were reported on lines #{lines[0...-1].join(', ')} and #{lines.last}"
+      end
+  end
+
+  failure_message_when_negated do
+    'expected that a lint would not be reported'
+  end
+
+  description do
+    'report a lint' + (expected_line ? " on line #{expected_line}" : '')
+  end
+
+  def has_lints?(linter, expected_line, count)
+    if expected_line && count
+      linter.lints.count == count &&
+        lint_lines(linter).all? { |line| line == expected_line }
+    elsif expected_line
+      lint_lines(linter).include?(expected_line)
+    elsif count
+      linter.lints.count == count
+    else
+      linter.lints.count > 0
+    end
+  end
+
+  def lint_lines(linter)
+    linter.lints.map { |lint| lint.location.line }
+  end
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: scss-lint
 version: !ruby/object:Gem::Version
-  version: 0.25.1
+  version: 0.26.0
 platform: ruby
 authors:
 - Causes Engineering
@@ -9,7 +9,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-24 00:00:00.000000000 Z
+date: 2014-07-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rainbow
@@ -32,6 +32,9 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 3.3.0
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 3.3.7
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -39,6 +42,9 @@ dependencies:
     - - ~>
       - !ruby/object:Gem::Version
         version: 3.3.0
+    - - '>='
+      - !ruby/object:Gem::Version
+        version: 3.3.7
 - !ruby/object:Gem::Dependency
   name: nokogiri
   requirement: !ruby/object:Gem::Requirement
@@ -59,28 +65,28 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: '2.0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.0
+        version: 0.24.1
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.23.0
+        version: 0.24.1
 description: Configurable tool for writing clean and consistent SCSS
 email:
 - eng@causes.com
@@ -92,6 +98,7 @@ extra_rdoc_files: []
 files:
 - config/default.yml
 - data/properties.txt
+- data/property-sort-orders/concentric.txt
 - lib/scss_lint/version.rb
 - lib/scss_lint/constants.rb
 - lib/scss_lint/utils.rb
@@ -108,6 +115,7 @@ files:
 - lib/scss_lint/selector_visitor.rb
 - lib/scss_lint/sass/tree.rb
 - lib/scss_lint/sass/script.rb
+- lib/scss_lint/exceptions.rb
 - lib/scss_lint/config.rb
 - lib/scss_lint/linter/compass.rb
 - lib/scss_lint/linter/space_after_comma.rb
@@ -116,7 +124,7 @@ files:
 - lib/scss_lint/linter/hex_length.rb
 - lib/scss_lint/linter/indentation.rb
 - lib/scss_lint/linter/mergeable_selector.rb
-- lib/scss_lint/linter/trailing_semicolon_after_property_value.rb
+- lib/scss_lint/linter/single_line_per_property.rb
 - lib/scss_lint/linter/shorthand.rb
 - lib/scss_lint/linter/final_newline.rb
 - lib/scss_lint/linter/id_with_extraneous_selector.rb
@@ -132,10 +140,12 @@ files:
 - lib/scss_lint/linter/property_spelling.rb
 - lib/scss_lint/linter/url_quotes.rb
 - lib/scss_lint/linter/name_format.rb
+- lib/scss_lint/linter/unnecessary_parent_reference.rb
 - lib/scss_lint/linter/space_between_parens.rb
 - lib/scss_lint/linter/border_zero.rb
 - lib/scss_lint/linter/space_after_property_colon.rb
 - lib/scss_lint/linter/debug_statement.rb
+- lib/scss_lint/linter/trailing_semicolon.rb
 - lib/scss_lint/linter/duplicate_property.rb
 - lib/scss_lint/linter/property_sort_order.rb
 - lib/scss_lint/linter/color_keyword.rb
@@ -151,6 +161,60 @@ files:
 - lib/scss_lint/engine.rb
 - lib/scss_lint/linter_registry.rb
 - lib/scss_lint.rb
+- spec/scss_lint/location_spec.rb
+- spec/scss_lint/reporter/files_reporter_spec.rb
+- spec/scss_lint/reporter/xml_reporter_spec.rb
+- spec/scss_lint/reporter/config_reporter_spec.rb
+- spec/scss_lint/reporter/default_reporter_spec.rb
+- spec/scss_lint/selector_visitor_spec.rb
+- spec/scss_lint/runner_spec.rb
+- spec/scss_lint/engine_spec.rb
+- spec/scss_lint/reporter_spec.rb
+- spec/scss_lint/config_spec.rb
+- spec/scss_lint/linter_registry_spec.rb
+- spec/scss_lint/cli_spec.rb
+- spec/scss_lint/linter/final_newline_spec.rb
+- spec/scss_lint/linter/color_keyword_spec.rb
+- spec/scss_lint/linter/single_line_per_selector_spec.rb
+- spec/scss_lint/linter/empty_rule_spec.rb
+- spec/scss_lint/linter/hex_notation_spec.rb
+- spec/scss_lint/linter/hex_length_spec.rb
+- spec/scss_lint/linter/url_quotes_spec.rb
+- spec/scss_lint/linter/space_between_parens_spec.rb
+- spec/scss_lint/linter/border_zero_spec.rb
+- spec/scss_lint/linter/property_spelling_spec.rb
+- spec/scss_lint/linter/property_sort_order_spec.rb
+- spec/scss_lint/linter/else_placement_spec.rb
+- spec/scss_lint/linter/zero_unit_spec.rb
+- spec/scss_lint/linter/mergeable_selector_spec.rb
+- spec/scss_lint/linter/unnecessary_mantissa_spec.rb
+- spec/scss_lint/linter/name_format_spec.rb
+- spec/scss_lint/linter/capitalization_in_selector_spec.rb
+- spec/scss_lint/linter/duplicate_property_spec.rb
+- spec/scss_lint/linter/hex_validation_spec.rb
+- spec/scss_lint/linter/space_before_brace_spec.rb
+- spec/scss_lint/linter/compass/property_with_mixin_spec.rb
+- spec/scss_lint/linter/placeholder_in_extend_spec.rb
+- spec/scss_lint/linter/debug_statement_spec.rb
+- spec/scss_lint/linter/string_quotes_spec.rb
+- spec/scss_lint/linter/indentation_spec.rb
+- spec/scss_lint/linter/unnecessary_parent_reference_spec.rb
+- spec/scss_lint/linter/empty_line_between_blocks_spec.rb
+- spec/scss_lint/linter/single_line_per_property_spec.rb
+- spec/scss_lint/linter/space_after_property_colon_spec.rb
+- spec/scss_lint/linter/declaration_order_spec.rb
+- spec/scss_lint/linter/leading_zero_spec.rb
+- spec/scss_lint/linter/url_format_spec.rb
+- spec/scss_lint/linter/comment_spec.rb
+- spec/scss_lint/linter/trailing_semicolon_spec.rb
+- spec/scss_lint/linter/selector_depth_spec.rb
+- spec/scss_lint/linter/space_after_comma_spec.rb
+- spec/scss_lint/linter/shorthand_spec.rb
+- spec/scss_lint/linter/id_with_extraneous_selector_spec.rb
+- spec/scss_lint/linter/space_after_property_name_spec.rb
+- spec/support/matchers/report_lint.rb
+- spec/support/isolated_environment.rb
+- spec/spec_helper.rb
 - bin/scss-lint
 homepage: https://github.com/causes/scss-lint
 licenses:
@@ -176,4 +240,58 @@ rubygems_version: 2.0.14
 signing_key: 
 specification_version: 4
 summary: SCSS lint tool
-test_files: []
+test_files:
+- spec/scss_lint/location_spec.rb
+- spec/scss_lint/reporter/files_reporter_spec.rb
+- spec/scss_lint/reporter/xml_reporter_spec.rb
+- spec/scss_lint/reporter/config_reporter_spec.rb
+- spec/scss_lint/reporter/default_reporter_spec.rb
+- spec/scss_lint/selector_visitor_spec.rb
+- spec/scss_lint/runner_spec.rb
+- spec/scss_lint/engine_spec.rb
+- spec/scss_lint/reporter_spec.rb
+- spec/scss_lint/config_spec.rb
+- spec/scss_lint/linter_registry_spec.rb
+- spec/scss_lint/cli_spec.rb
+- spec/scss_lint/linter/final_newline_spec.rb
+- spec/scss_lint/linter/color_keyword_spec.rb
+- spec/scss_lint/linter/single_line_per_selector_spec.rb
+- spec/scss_lint/linter/empty_rule_spec.rb
+- spec/scss_lint/linter/hex_notation_spec.rb
+- spec/scss_lint/linter/hex_length_spec.rb
+- spec/scss_lint/linter/url_quotes_spec.rb
+- spec/scss_lint/linter/space_between_parens_spec.rb
+- spec/scss_lint/linter/border_zero_spec.rb
+- spec/scss_lint/linter/property_spelling_spec.rb
+- spec/scss_lint/linter/property_sort_order_spec.rb
+- spec/scss_lint/linter/else_placement_spec.rb
+- spec/scss_lint/linter/zero_unit_spec.rb
+- spec/scss_lint/linter/mergeable_selector_spec.rb
+- spec/scss_lint/linter/unnecessary_mantissa_spec.rb
+- spec/scss_lint/linter/name_format_spec.rb
+- spec/scss_lint/linter/capitalization_in_selector_spec.rb
+- spec/scss_lint/linter/duplicate_property_spec.rb
+- spec/scss_lint/linter/hex_validation_spec.rb
+- spec/scss_lint/linter/space_before_brace_spec.rb
+- spec/scss_lint/linter/compass/property_with_mixin_spec.rb
+- spec/scss_lint/linter/placeholder_in_extend_spec.rb
+- spec/scss_lint/linter/debug_statement_spec.rb
+- spec/scss_lint/linter/string_quotes_spec.rb
+- spec/scss_lint/linter/indentation_spec.rb
+- spec/scss_lint/linter/unnecessary_parent_reference_spec.rb
+- spec/scss_lint/linter/empty_line_between_blocks_spec.rb
+- spec/scss_lint/linter/single_line_per_property_spec.rb
+- spec/scss_lint/linter/space_after_property_colon_spec.rb
+- spec/scss_lint/linter/declaration_order_spec.rb
+- spec/scss_lint/linter/leading_zero_spec.rb
+- spec/scss_lint/linter/url_format_spec.rb
+- spec/scss_lint/linter/comment_spec.rb
+- spec/scss_lint/linter/trailing_semicolon_spec.rb
+- spec/scss_lint/linter/selector_depth_spec.rb
+- spec/scss_lint/linter/space_after_comma_spec.rb
+- spec/scss_lint/linter/shorthand_spec.rb
+- spec/scss_lint/linter/id_with_extraneous_selector_spec.rb
+- spec/scss_lint/linter/space_after_property_name_spec.rb
+- spec/support/matchers/report_lint.rb
+- spec/support/isolated_environment.rb
+- spec/spec_helper.rb