scss-lint 0.25.1 → 0.26.0

data/spec/scss_lint/linter/trailing_semicolon_spec.rb

@@ -0,0 +1,188 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::TrailingSemicolon do
+  context 'when a property does not end with a semicolon' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a property ends with a semicolon' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a property ends with a space followed by a semicolon' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0 ;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a property ends with a semicolon and is followed by a comment' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0;  // This is a comment
+        padding: 0; /* This is another comment */
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a property contains nested properties' do
+    context 'and there is a value on the namespace' do
+      let(:css) { <<-CSS }
+        p {
+          font: 2px/3px {
+            style: italic;
+            weight: bold;
+          }
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'and there is no value on the namespace' do
+      let(:css) { <<-CSS }
+        p {
+          font: {
+            style: italic;
+            weight: bold;
+          }
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when a nested property does not end with a semicolon' do
+    let(:css) { <<-CSS }
+      p {
+        font: {
+          weight: bold
+        }
+      }
+    CSS
+
+    it { should report_lint line: 3 }
+  end
+
+  context 'when a multi-line property ends with a semicolon' do
+    let(:css) { <<-CSS }
+      p {
+        background:
+          top repeat-x url('top-image.jpg'),
+          right repeat-y url('right-image.jpg'),
+          bottom repeat-x url('bottom-image.jpg'),
+          left repeat-y url('left-image.jpg');
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when a multi-line property does not end with a semicolon' do
+    let(:css) { <<-CSS }
+      p {
+        background:
+          top repeat-x url('top-image.jpg'),
+          right repeat-y url('right-image.jpg'),
+          bottom repeat-x url('bottom-image.jpg'),
+          left repeat-y url('left-image.jpg')
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a oneline rule does not end with a semicolon' do
+    let(:css) { <<-CSS }
+      .foo { border: 0 }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when a oneline rule has a space before a semicolon' do
+    let(:css) { <<-CSS }
+      .foo { border: 0 ; }
+    CSS
+
+    it { should report_lint line: 1 }
+  end
+
+  context 'when @extend does not end with a semicolon' do
+    let(:css) { <<-CSS }
+      .foo {
+        @extend %bar
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when @extend ends with a semicolon' do
+    let(:css) { <<-CSS }
+      .foo {
+        @extend %bar;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when @include does not end with a semicolon' do
+    let(:css) { <<-CSS }
+      .foo {
+        @include bar
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when @extend ends with a semicolon' do
+    let(:css) { <<-CSS }
+      .foo {
+        @include bar;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when variable declaration does not end with a semicolon' do
+    let(:css) { <<-CSS }
+      .foo {
+        $bar: 1
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when @extend ends with a semicolon' do
+    let(:css) { <<-CSS }
+      .foo {
+        $bar: 1;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/unnecessary_mantissa_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::UnnecessaryMantissa do
+  context 'when value is zero' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0;
+        padding: func(0);
+        top: 0em;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when value contains no mantissa' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 1;
+        padding: func(1);
+        top: 1em;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when value contains a mantissa with a zero' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 1.0;
+        padding: func(1.0);
+        top: 1.0em;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+    it { should report_lint line: 4 }
+  end
+
+  context 'when value contains a mantissa with multiple zeroes' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 1.000;
+        padding: func(1.000);
+        top: 1.000em;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+    it { should report_lint line: 3 }
+    it { should report_lint line: 4 }
+  end
+
+  context 'when value contains a mantissa with multiple zeroes followed by a number' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 1.0001;
+        padding: func(1.0001);
+        top: 1.0001em;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/unnecessary_parent_reference_spec.rb

@@ -0,0 +1,67 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::UnnecessaryParentReference do
+  context 'when an amperand precedes a direct descendant operator' do
+    let(:css) { <<-CSS }
+      p {
+        & > a {}
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when an amperand precedes a general child' do
+    let(:css) { <<-CSS }
+      p {
+        & a {}
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when an amperand is chained with class' do
+    let(:css) { <<-CSS }
+      p {
+        &.foo {}
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an amperand follows a direct descendant operator' do
+    let(:css) { <<-CSS }
+      p {
+        .foo > & {}
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an amperand is used in a comma sequence to DRY up code' do
+    let(:css) { <<-CSS }
+      p {
+        &,
+        .foo,
+        .bar {
+          margin: 0;
+        }
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when an ampersand is used by itself' do
+    let(:css) { <<-CSS }
+      p {
+        & {}
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+end

data/spec/scss_lint/linter/url_format_spec.rb

@@ -0,0 +1,55 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::UrlFormat do
+  shared_examples_for 'UrlFormat linter' do
+    context 'when URL contains protocol' do
+      let(:url) { 'https://something.com/image.png' }
+
+      it { should report_lint }
+    end
+
+    context 'when URL contains domain with protocol-less double slashes' do
+      let(:url) { '//something.com/image.png' }
+
+      it { should report_lint }
+    end
+
+    context 'when URL contains absolute path' do
+      let(:url) { '/absolute/path/to/image.png' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when URL contains relative path' do
+      let(:url) { 'relative/path/to/image.png' }
+
+      it { should_not report_lint }
+    end
+
+    context 'when URL is a data URI' do
+      let(:url) { 'data:image/png;base64,iVBORI=' }
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when URL is enclosed in quotes' do
+    let(:css) { <<-CSS }
+      .block {
+        background: url('#{url}');
+      }
+    CSS
+
+    it_should_behave_like 'UrlFormat linter'
+  end
+
+  context 'when URL is not enclosed in quotes' do
+    let(:css) { <<-CSS }
+      .block {
+        background: url(#{url});
+      }
+    CSS
+
+    it_should_behave_like 'UrlFormat linter'
+  end
+end

data/spec/scss_lint/linter/url_quotes_spec.rb

@@ -0,0 +1,63 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::UrlQuotes do
+  context 'when property has a literal URL' do
+    let(:css) { <<-CSS }
+      p {
+        background: url(example.png);
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when property has a URL enclosed in single quotes' do
+    let(:css) { <<-CSS }
+      p {
+        background: url('example.png');
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property has a URL enclosed in double quotes' do
+    let(:css) { <<-CSS }
+      p {
+        background: url("example.png");
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property has a literal URL in a list' do
+    let(:css) { <<-CSS }
+      p {
+        background: transparent url(example.png);
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when property has a single-quoted URL in a list' do
+    let(:css) { <<-CSS }
+      p {
+        background: transparent url('example.png');
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property has a double-quoted URL in a list' do
+    let(:css) { <<-CSS }
+      p {
+        background: transparent url("example.png");
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+end

data/spec/scss_lint/linter/zero_unit_spec.rb

@@ -0,0 +1,113 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::ZeroUnit do
+  context 'when no properties exist' do
+    let(:css) { <<-CSS }
+      p {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when properties with unit-less zeros exist' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when properties with non-zero values exist' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 5px;
+        line-height: 1.5em;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when properties with zero values contain units' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0px;
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when properties with multiple zero values containing units exist' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 5em 0em 2em 0px;
+      }
+    CSS
+
+    it { should report_lint line: 2, count: 2 }
+  end
+
+  context 'when function call contains a zero value with units' do
+    let(:css) { <<-CSS }
+      p {
+        margin: some-function(0em);
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when mixin include contains a zero value with units' do
+    let(:css) { <<-CSS }
+      p {
+        @include some-mixin(0em);
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when string contains a zero value with units' do
+    let(:css) { <<-CSS }
+      p {
+        content: func("0em");
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property value has a ".0" fractional component' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 4.0em;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property value has a color hex with a leading 0' do
+    let(:css) { <<-CSS }
+      p {
+        color: #0af;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property with zero value is a dimension' do
+    let(:css) { <<-CSS }
+      p {
+        transition-delay: 0s;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+end