scss-lint 0.25.1 → 0.26.0

data/spec/scss_lint/linter/duplicate_property_spec.rb

@@ -0,0 +1,176 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::DuplicateProperty do
+  context 'when rule set is empty' do
+    let(:css) { <<-CSS }
+      p {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule set contains no duplicates' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0;
+        padding: 0;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when rule set contains duplicates' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0;
+        padding: 0;
+        margin: 1em;
+      }
+    CSS
+
+    it { should report_lint line: 4 }
+  end
+
+  context 'when rule set contains duplicates but only on vendor-prefixed property values' do
+    let(:css) { <<-CSS }
+      p {
+        background: -moz-linear-gradient(center top , #fff, #000);
+        background: -ms-linear-gradient(center top , #fff, #000);
+        background: -o-linear-gradient(center top , #fff, #000);
+        background: -webkit-gradient(linear, left top, left bottom, from(#fff), to(#000));
+        background: linear-gradient(center top , #fff, #000);
+        margin: 1em;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when placeholder contains duplicates but only on vendor-prefixed values' do
+    let(:css) { <<-CSS }
+      %cursor-grabbing {
+        cursor: -moz-grabbing;
+        cursor: -webkit-grabbing;
+        cursor: grabbing;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when placeholder contains exact duplicates besides for vendor-prefixed values' do
+    let(:css) { <<-CSS }
+      %cursor-grabbing {
+        cursor: grabbing;
+        cursor: grabbing;
+      }
+    CSS
+
+    it { should report_lint line: 3 }
+  end
+
+  context 'when mixin contains duplicates but only on vendor-prefixed values' do
+    let(:css) { <<-CSS }
+      @mixin cursor-grabbing($num) {
+        cursor: -moz-grabbing;
+        cursor: -webkit-grabbing;
+        cursor: grabbing;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when mixin contains duplicates besides for vendor-prefixed values' do
+    let(:css) { <<-CSS }
+      @mixin cursor-grabbing($num) {
+        cursor: grabbing;
+        cursor: grabbing;
+      }
+    CSS
+
+    it { should report_lint line: 3 }
+  end
+
+  context 'when rule set contains exact duplicates besides for vendor-prefixed property values' do
+    let(:css) { <<-CSS }
+      p {
+        background: -moz-linear-gradient(center top , #fff, #000);
+        background: -ms-linear-gradient(center top , #fff, #000);
+        background: -o-linear-gradient(center top , #fff, #000);
+        background: -webkit-gradient(linear, left top, left bottom, from(#fff), to(#000));
+        background: linear-gradient(center top , #fff, #000);
+        background: linear-gradient(center top , #fff, #000);
+        margin: 1em;
+      }
+    CSS
+
+    it { should report_lint line: 7 }
+  end
+
+  context 'when rule set contains non-exact duplicates besides for vendor-prefixed values' do
+    let(:css) { <<-CSS }
+      p {
+        background: -moz-linear-gradient(center top , #fff, #000);
+        background: -ms-linear-gradient(center top , #fff, #000);
+        background: -o-linear-gradient(center top , #fff, #000);
+        background: -webkit-gradient(linear, left top, left bottom, from(#fff), to(#000));
+        background: linear-gradient(center top , #fff, #000);
+        background: linear-gradient-b(center top , #fff, #000);
+        margin: 1em;
+      }
+    CSS
+
+    it { should report_lint line: 7 }
+  end
+
+  context 'when rule set contains multiple duplicates' do
+    let(:css) { <<-CSS }
+      p {
+        margin: 0;
+        padding: 0;
+        margin: 1em;
+        margin: 2em;
+      }
+    CSS
+
+    it { should report_lint line: 4 }
+    it { should report_lint line: 5 }
+  end
+
+  context 'when rule set contains duplicate properties with interpolation' do
+    let(:css) { <<-CSS }
+      p {
+        $direction: 'right';
+        margin-\#{direction}: 0;
+        $direction: 'left';
+        margin-\#{direction}: 0;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property contains a variable' do
+    let(:css) { <<-CSS }
+      p {
+        color: $some-color;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when property contains a duplicate variable' do
+    let(:css) { <<-CSS }
+      p {
+        color: $some-color;
+        color: $some-color;
+      }
+    CSS
+
+    it { should report_lint line: 3 }
+  end
+end

data/spec/scss_lint/linter/else_placement_spec.rb

@@ -0,0 +1,106 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::ElsePlacement do
+  context 'when @if contains no accompanying @else' do
+    let(:css) { <<-CSS }
+      @if $condition {
+        $var: 1;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when @else is on different line' do
+    let(:css) { <<-CSS }
+      @if $condition {
+        $var: 1;
+      }
+      @else {
+        $var: 0;
+      }
+    CSS
+
+    it { should report_lint line: 4 }
+  end
+
+  context 'when @else is on the same line as previous curly' do
+    let(:css) { <<-CSS }
+      @if $condition {
+        $var: 1;
+      } @else {
+        $var: 0;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when `@else if` is on different line' do
+    let(:css) { <<-CSS }
+      @if $condition {
+        $var: 1;
+      }
+      @else if $other_condition {
+        $var: 2;
+      }
+      @else {
+        $var: 0;
+      }
+    CSS
+
+    it { should report_lint line: 4 }
+    it { should report_lint line: 7 }
+  end
+
+  context 'when `@else if` is on the same line as previous curly' do
+    let(:css) { <<-CSS }
+      @if $condition {
+        $var: 1;
+      } @else if $other_condition {
+        $var: 2;
+      } @else {
+        $var: 0;
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when @else is on same line as @if' do
+    let(:css) { <<-CSS }
+      @if $condition { $var: 1; } @else { $var: 0; }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when placement of @else on a new line is preferred' do
+    let(:linter_config) { { 'style' => 'new_line' } }
+
+    context 'when @else is on a new line' do
+      let(:css) { <<-CSS }
+        @if $condition {
+          $var: 1;
+        }
+        @else {
+          $var: 0;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'when @else is on the same line as previous curly brace' do
+      let(:css) { <<-CSS }
+        @if $condition {
+          $var: 1;
+        } @else {
+          $var: 0;
+        }
+      CSS
+
+      it { should report_lint line: 3 }
+    end
+  end
+end

data/spec/scss_lint/linter/empty_line_between_blocks_spec.rb

@@ -0,0 +1,263 @@
+require 'spec_helper'
+
+describe SCSSLint::Linter::EmptyLineBetweenBlocks do
+  context 'when there are multiple rule sets' do
+    context 'with blank lines between them' do
+      let(:css) { <<-CSS }
+        a {
+        }
+
+        b {
+        }
+
+        p {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'with no blank line between them' do
+      let(:css) { <<-CSS }
+        a {
+        }
+        b {
+        }
+        p {
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 4 }
+      it { should_not report_lint line: 6 }
+    end
+  end
+
+  context 'when a rule set contains nested rule sets' do
+    context 'and the nested rule sets have no blank line between them' do
+      let(:css) { <<-CSS }
+        p {
+          a {
+          }
+          b {
+          }
+        }
+      CSS
+
+      it { should report_lint line: 3 }
+      it { should_not report_lint line: 5 }
+    end
+
+    context 'and the nested rule sets have a blank line between them' do
+      let(:css) { <<-CSS }
+        p {
+          a {
+          }
+
+          b {
+          }
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'and the nested rule set has a property preceding it' do
+      let(:css) { <<-CSS }
+        p {
+          margin: 0;
+          a {
+          }
+        }
+      CSS
+
+      it { should report_lint line: 3 }
+    end
+
+    context 'and the nested rule set has a property and empty line preceding it' do
+      let(:css) { <<-CSS }
+        p {
+          margin: 0;
+
+          a {
+          }
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when mixins are defined' do
+    context 'and there is no blank line between them' do
+      let(:css) { <<-CSS }
+        @mixin mixin1() {
+        }
+        @mixin mixin2() {
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'and there is a blank line between them' do
+      let(:css) { <<-CSS }
+        @mixin mixin1() {
+        }
+
+        @mixin mixin2() {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when mixins are included without content' do
+    let(:css) { <<-CSS }
+      p {
+        @include mixin1();
+        property: blah;
+        @include mixin2(4);
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when mixins are included with content' do
+    context 'and there is no blank line between them' do
+      let(:css) { <<-CSS }
+        @include mixin1() {
+          property: value;
+        }
+        @include mixin2() {
+          property: value;
+        }
+      CSS
+
+      it { should report_lint line: 3 }
+    end
+
+    context 'and there is a blank line between them' do
+      let(:css) { <<-CSS }
+        @include mixin1() {
+          property: value;
+        }
+
+        @include mixin2() {
+          property: value;
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when functions are defined' do
+    context 'and there is no blank line between them' do
+      let(:css) { <<-CSS }
+        @function func1() {
+        }
+        @function func2() {
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+    end
+
+    context 'and there is a blank line between them' do
+      let(:css) { <<-CSS }
+        @function func1() {
+        }
+
+        @function func2() {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+  end
+
+  context 'when a rule set is followed by a comment' do
+    let(:css) { <<-CSS }
+      a {
+      }
+      // This is a comment
+      p {
+      }
+    CSS
+
+    it { should report_lint line: 2 }
+  end
+
+  context 'when a rule set is preceded by a comment' do
+    let(:css) { <<-CSS }
+      a {
+      }
+
+      // This is a comment
+      p {
+      }
+    CSS
+
+    it { should_not report_lint }
+  end
+
+  context 'when there are multiple placeholder rule sets' do
+    context 'with blank lines between them' do
+      let(:css) { <<-CSS }
+        %a {
+        }
+
+        %b {
+        }
+
+        %c {
+        }
+      CSS
+
+      it { should_not report_lint }
+    end
+
+    context 'with no blank line between them' do
+      let(:css) { <<-CSS }
+        %a {
+        }
+        %b {
+        }
+        %c {
+        }
+      CSS
+
+      it { should report_lint line: 2 }
+      it { should report_lint line: 4 }
+      it { should_not report_lint line: 6 }
+    end
+  end
+
+  context 'when blocks occupy a single line' do
+    let(:linter_config) { { 'ignore_single_line_blocks' => ignore_single_line_blocks } }
+
+    let(:css) { <<-CSS }
+      .icon-up { &:before { content: '^'; } }
+      .icon-right { &:before { content: '>'; } }
+      @include some-mixin { content: '<'; }
+      @include some-other-mixin { content: 'v'; }
+    CSS
+
+    context 'and the `ignore_single_line_blocks` option is true' do
+      let(:ignore_single_line_blocks) { true }
+
+      it { should_not report_lint }
+    end
+
+    context 'and the `ignore_single_line_blocks` option is false' do
+      let(:ignore_single_line_blocks) { false }
+
+      it { should report_lint line: 1 }
+      it { should report_lint line: 2 }
+      it { should report_lint line: 3 }
+    end
+  end
+end