rubocop 0.8.3 → 0.9.0

data/spec/rubocop/cops/alias_spec.rb

@@ -1,39 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe Alias do
-      let(:a) { Alias.new }
-
-      it 'registers an offence for alias with symbol args' do
-        inspect_source(a,
-                       ['alias :ala :bala'])
-        expect(a.offences.size).to eq(1)
-        expect(a.offences.map(&:message))
-          .to eq([Alias::MSG])
-      end
-
-      it 'registers an offence for alias with bareword args' do
-        inspect_source(a,
-                       ['alias ala bala'])
-        expect(a.offences.size).to eq(1)
-        expect(a.offences.map(&:message))
-          .to eq([Alias::MSG])
-      end
-
-      it 'does not register an offence for alias_method' do
-        inspect_source(a,
-                       ['alias_method :ala, :bala'])
-        expect(a.offences).to be_empty
-      end
-
-      it 'does not register an offence for :alias' do
-        inspect_source(a,
-                       ['[:alias, :ala, :bala]'])
-        expect(a.offences).to be_empty
-      end
-    end
-  end
-end

data/spec/rubocop/cops/align_parameters_spec.rb

@@ -1,197 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe AlignParameters do
-      let(:align) { AlignParameters.new }
-
-      it 'registers an offence for parameters with single indent' do
-        inspect_source(align, ['function(a,',
-                               '  if b then c else d end)'])
-        expect(align.offences.size).to eq(1)
-      end
-
-      it 'registers an offence for parameters with double indent' do
-        inspect_source(align, ['function(a,',
-                               '    if b then c else d end)'])
-        expect(align.offences.size).to eq(1)
-      end
-
-      it 'accepts multiline []= method call' do
-        inspect_source(align, ['Test.config["something"] =',
-                                          ' true'])
-        expect(align.offences).to be_empty
-      end
-
-      it 'accepts correctly aligned parameters' do
-        inspect_source(align, ['function(a,',
-                               '         0, 1,',
-                               '         (x + y),',
-                               '         if b then c else d end)'])
-        expect(align.offences).to be_empty
-      end
-
-      it 'accepts calls that only span one line' do
-        inspect_source(align, ['find(path, s, @special[sexp[0]])'])
-        expect(align.offences).to be_empty
-      end
-
-      it "doesn't get confused by a symbol argument" do
-        inspect_source(align,
-                       ['add_offence(:convention, index,',
-                        '            MSG % kind)'])
-        expect(align.offences).to be_empty
-      end
-
-      it "doesn't get confused by splat operator" do
-        inspect_source(align,
-                       ['func1(*a,',
-                        '      *b,',
-                        '      c)',
-                        'func2(a,',
-                        '     *b,',
-                        '      c)',
-                        'func3(*a)',
-                       ])
-        expect(align.offences.map(&:to_s)).to eq(
-          ['C:  5: Align the parameters of a method call if they span ' +
-           'more than one line.'])
-      end
-
-      it "doesn't get confused by extra comma at the end" do
-        inspect_source(align,
-                       ['func1(a,',
-                        '     b,)'])
-        expect(align.offences.map(&:to_s)).to eq(
-          ['C:  2: Align the parameters of a method call if they span ' +
-           'more than one line.'])
-      end
-
-      it 'can handle a correctly aligned string literal as first argument' do
-        inspect_source(align,
-                       ['add_offence(:convention, x,',
-                        '            a)'])
-        expect(align.offences).to be_empty
-      end
-
-      it 'can handle a string literal as other argument' do
-        inspect_source(align,
-                       ['add_offence(:convention,',
-                        '            "", a)'])
-        expect(align.offences).to be_empty
-      end
-
-      it "doesn't get confused by a line break inside a parameter" do
-        inspect_source(align,
-                       ['read(path, { headers:    true,',
-                        '             converters: :numeric })'])
-        expect(align.offences).to be_empty
-      end
-
-      it "doesn't get confused by symbols with embedded expressions" do
-        inspect_source(align,
-                       ['send(:"#{name}_comments_path")'])
-        expect(align.offences).to be_empty
-      end
-
-      it "doesn't get confused by regexen with embedded expressions" do
-        inspect_source(align,
-                       ['a(/#{name}/)'])
-        expect(align.offences).to be_empty
-      end
-
-      it 'accepts braceless hashes' do
-        inspect_source(align,
-                       ['run(collection, :entry_name => label,',
-                        '                :paginator  => paginator)'])
-        expect(align.offences).to be_empty
-      end
-
-      it 'accepts the first parameter being on a new row' do
-        inspect_source(align,
-                       ['  match(',
-                        '    a,',
-                        '    b',
-                        '  )'])
-        expect(align.offences).to be_empty
-      end
-
-      it 'can handle heredoc strings' do
-        src = ['class_eval(<<-EOS, __FILE__, __LINE__ + 1)',
-               '            def run_#{name}_callbacks(*args)',
-               '              a = 1',
-               '              return value',
-               '            end',
-               '            EOS']
-        inspect_source(align, src)
-        expect(align.offences).to be_empty
-      end
-
-      it 'can handle a method call within a method call' do
-        inspect_source(align,
-                       ['a(a1,',
-                        '  b(b1,',
-                        '    b2),',
-                        '  a2)'])
-        expect(align.offences).to be_empty
-      end
-
-      it 'can handle a call embedded in a string' do
-        inspect_source(align,
-                       ['model("#{index(name)}", child)'])
-        expect(align.offences).to be_empty
-      end
-
-      it 'can handle do-end' do
-        inspect_source(align,
-                       ['      run(lambda do |e|',
-                        "        w = e['warden']",
-                        '      end)'])
-        expect(align.offences).to be_empty
-      end
-
-      it 'can handle a call with a block inside another call' do
-        src = ['new(table_name,',
-               '    exec_query("info(\'#{row[\'name\']}\')").map { |col|',
-               "      col['name']",
-               '    })']
-        inspect_source(align, src)
-        expect(align.offences).to be_empty
-      end
-
-      it 'can handle a ternary condition with a block reference' do
-        src = ['cond ? a : func(&b)']
-        inspect_source(align, src)
-        expect(align.offences).to be_empty
-      end
-
-      it 'can handle parentheses used with no parameters' do
-        src = ['func()']
-        inspect_source(align, src)
-        expect(align.offences).to be_empty
-      end
-
-      it 'can handle a multiline hash as second parameter' do
-        src = ['tag(:input, {',
-               '  :value => value',
-               '})']
-        inspect_source(align, src)
-        expect(align.offences).to be_empty
-      end
-
-      it 'can handle method calls without parentheses' do
-        src = ['a(b c, d)']
-        inspect_source(align, src)
-        expect(align.offences).to be_empty
-      end
-
-      it 'can handle other method calls without parentheses' do
-        src = ['chars(Unicode.apply_mapping @wrapped_string, :uppercase)']
-        inspect_source(align, src)
-        expect(align.offences).to be_empty
-      end
-    end
-  end
-end

data/spec/rubocop/cops/and_or_spec.rb

@@ -1,37 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe AndOr do
-      let(:amp) { AndOr.new }
-
-      it 'registers an offence for OR' do
-        inspect_source(amp,
-                       ['test if a or b'])
-        expect(amp.offences.size).to eq(1)
-        expect(amp.messages).to eq(['Use || instead of or.'])
-      end
-
-      it 'registers an offence for AND' do
-        inspect_source(amp,
-                       ['test if a and b'])
-        expect(amp.offences.size).to eq(1)
-        expect(amp.messages).to eq(['Use && instead of and.'])
-      end
-
-      it 'accepts ||' do
-        inspect_source(amp,
-                       ['test if a || b'])
-        expect(amp.offences).to be_empty
-      end
-
-      it 'accepts &&' do
-        inspect_source(amp,
-                       ['test if a && b'])
-        expect(amp.offences).to be_empty
-      end
-    end
-  end
-end

data/spec/rubocop/cops/ascii_comments_spec.rb

@@ -1,26 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe AsciiComments do
-      let(:ascii) { AsciiComments.new }
-
-      it 'registers an offence for a comment with non-ascii chars' do
-        inspect_source(ascii,
-                       ['# encoding: utf-8',
-                        '# 这是什么？'])
-        expect(ascii.offences.size).to eq(1)
-        expect(ascii.offences.map(&:message))
-          .to eq([AsciiComments::MSG])
-      end
-
-      it 'accepts comments with only ascii chars' do
-        inspect_source(ascii,
-                       ['# AZaz1@$%~,;*_`|'])
-        expect(ascii.offences).to be_empty
-      end
-    end
-  end
-end

data/spec/rubocop/cops/ascii_identifiers_spec.rb

@@ -1,26 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe AsciiIdentifiers do
-      let(:ascii) { AsciiIdentifiers.new }
-
-      it 'registers an offence for a variable name with non-ascii chars' do
-        inspect_source(ascii,
-                       ['# encoding: utf-8',
-                        'älg = 1'])
-        expect(ascii.offences.size).to eq(1)
-        expect(ascii.offences.map(&:message))
-          .to eq([AsciiIdentifiers::MSG])
-      end
-
-      it 'accepts identifiers with only ascii chars' do
-        inspect_source(ascii,
-                       ['x.empty?'])
-        expect(ascii.offences).to be_empty
-      end
-    end
-  end
-end

data/spec/rubocop/cops/avoid_class_vars_spec.rb

@@ -1,25 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe AvoidClassVars do
-      let(:acv) { AvoidClassVars.new }
-
-      it 'registers an offence for class variable declaration' do
-        inspect_source(acv,
-                       ['class TestClass; @@test = 10; end'])
-        expect(acv.offences.size).to eq(1)
-        expect(acv.offences.map(&:message))
-          .to eq(['Replace class var @@test with a class instance var.'])
-      end
-
-      it 'does not register an offence for class variable usage' do
-        inspect_source(acv,
-                       ['@@test.test(20)'])
-        expect(acv.offences).to be_empty
-      end
-    end
-  end
-end

data/spec/rubocop/cops/avoid_for_spec.rb

@@ -1,35 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe AvoidFor do
-      let(:af) { AvoidFor.new }
-
-      it 'registers an offence for for' do
-        inspect_source(af,
-                       ['def func',
-                        '  for n in [1, 2, 3] do',
-                        '    puts n',
-                        '  end',
-                        'end'])
-        expect(af.offences.size).to eq(1)
-        expect(af.offences.map(&:message))
-          .to eq([AvoidFor::MSG])
-      end
-
-      it 'does not register an offence for :for' do
-        inspect_source(af,
-                       ['[:for, :ala, :bala]'])
-        expect(af.offences).to be_empty
-      end
-
-      it 'does not register an offence for def for' do
-        inspect_source(af,
-                       ['def for; end'])
-        expect(af.offences).to be_empty
-      end
-    end
-  end
-end

data/spec/rubocop/cops/avoid_global_vars_spec.rb

@@ -1,32 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe AvoidGlobalVars do
-      let(:ap) { AvoidGlobalVars.new }
-
-      it 'registers an offence for $custom' do
-        inspect_source(ap, ['puts $custom'])
-        expect(ap.offences.size).to eq(1)
-      end
-
-      it 'does not register an offence for $"' do
-        inspect_source(ap, ['puts $"'])
-
-        expect(ap.offences).to be_empty
-      end
-
-      it 'does not register an offence for $ORS' do
-        inspect_source(ap, ['puts $0'])
-        expect(ap.offences).to be_empty
-      end
-
-      it 'does not register an offence for backrefs like $1' do
-        inspect_source(ap, ['puts $1'])
-        expect(ap.offences).to be_empty
-      end
-    end
-  end
-end

data/spec/rubocop/cops/avoid_perl_backrefs_spec.rb

@@ -1,18 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe AvoidPerlBackrefs do
-      let(:ap) { AvoidPerlBackrefs.new }
-
-      it 'registers an offence for $1' do
-        inspect_source(ap, ['puts $1'])
-        expect(ap.offences.size).to eq(1)
-        expect(ap.offences.map(&:message))
-          .to eq(['Prefer the use of MatchData over $1.'])
-      end
-    end
-  end
-end

data/spec/rubocop/cops/avoid_perlisms_spec.rb

@@ -1,44 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe AvoidPerlisms do
-      let(:ap) { AvoidPerlisms.new }
-
-      it 'registers an offence for $:' do
-        inspect_source(ap, ['puts $:'])
-        expect(ap.offences.size).to eq(1)
-        expect(ap.offences.map(&:message))
-          .to eq(['Prefer $LOAD_PATH over $:.'])
-      end
-
-      it 'registers an offence for $"' do
-        inspect_source(ap, ['puts $"'])
-        expect(ap.offences.size).to eq(1)
-        expect(ap.offences.map(&:message))
-          .to eq(['Prefer $LOADED_FEATURES over $".'])
-      end
-
-      it 'registers an offence for $0' do
-        inspect_source(ap, ['puts $0'])
-        expect(ap.offences.size).to eq(1)
-        expect(ap.offences.map(&:message))
-          .to eq(['Prefer $PROGRAM_NAME over $0.'])
-      end
-
-      it 'registers an offence for $$' do
-        inspect_source(ap, ['puts $$'])
-        expect(ap.offences.size).to eq(1)
-        expect(ap.offences.map(&:message))
-          .to eq(['Prefer $PID or $PROCESS_ID from English library over $$.'])
-      end
-
-      it 'does not register an offence for backrefs like $1' do
-        inspect_source(ap, ['puts $1'])
-        expect(ap.offences).to be_empty
-      end
-    end
-  end
-end