rubocop 0.8.3 → 0.9.0

data/lib/rubocop/cop/class_methods.rb

@@ -1,15 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class ClassMethods < Cop
-      MSG = 'Prefer self over class/module for class/module methods.'
-
-      def on_defs(node)
-        definee, _name, _args, _body = *node
-
-        add_offence(:convention, node.loc.line, MSG) if definee.type == :const
-      end
-    end
-  end
-end

data/lib/rubocop/cop/collection_methods.rb

@@ -1,29 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class CollectionMethods < Cop
-      MSG = 'Prefer %s over %s.'
-
-      PREFERRED_METHODS = {
-        collect: 'map',
-        inject: 'reduce',
-        detect: 'find',
-        find_all: 'select'
-      }
-
-      def on_send(node)
-        receiver, method_name, *_args = *node
-
-        # a simple(but flawed way) to reduce false positives
-        if receiver && PREFERRED_METHODS[method_name]
-          add_offence(
-            :convention,
-            node.loc.line,
-            sprintf(MSG, PREFERRED_METHODS[method_name], method_name)
-          )
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/colon_method_call.rb

@@ -1,20 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class ColonMethodCall < Cop
-      MSG = 'Do not use :: for method invocation.'
-
-      def on_send(node)
-        receiver, _method_name, *_args = *node
-
-        # discard methods with nil receivers and op methods(like [])
-        if receiver && node.loc.dot && node.loc.dot.source == '::'
-          add_offence(:convention, node.loc.line, MSG)
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/constant_name.rb

@@ -1,24 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class ConstantName < Cop
-      MSG = 'Use SCREAMING_SNAKE_CASE for constants.'
-      SNAKE_CASE = /^[\dA-Z_]+$/
-
-      def on_casgn(node)
-        _scope, const_name, value = *node
-
-        # we cannot know the result of method calls line
-        # NewClass = something_that_returns_a_class
-        if value.type != :send && const_name !~ SNAKE_CASE
-          add_offence(:convention,
-                      node.loc.line,
-                      MSG)
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/def_parentheses.rb

@@ -1,62 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class DefWithParentheses < Cop
-      MSG = "Omit the parentheses in defs when the method doesn't accept " +
-          'any arguments.'
-
-      def on_def(node)
-        start_line = node.loc.keyword.line
-        end_line = node.loc.end.line
-
-        return if start_line == end_line
-
-        _, args = *node
-        if args.children == [] && args.loc.begin
-          add_offence(:convention, node.loc.line, MSG)
-        end
-
-        super
-      end
-
-      def on_defs(node)
-        start_line = node.loc.keyword.line
-        end_line = node.loc.end.line
-
-        return if start_line == end_line
-
-        _, _, args = *node
-        if args.children == [] && args.loc.begin
-          add_offence(:convention, node.loc.line, MSG)
-        end
-
-        super
-      end
-    end
-
-    class DefWithoutParentheses < Cop
-      MSG = 'Use def with parentheses when there are arguments.'
-
-      def on_def(node)
-        _, args = *node
-
-        if args.children.size > 0 && args.loc.begin.nil?
-          add_offence(:convention, node.loc.line, MSG)
-        end
-
-        super
-      end
-
-      def on_defs(node)
-        _, _, args = *node
-
-        if args.children.size > 0 && args.loc.begin.nil?
-          add_offence(:convention, node.loc.line, MSG)
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/empty_line_between_defs.rb

@@ -1,22 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class EmptyLineBetweenDefs < Cop
-      MSG = 'Use empty lines between defs.'
-
-      def on_def(s)
-        def_start = s.loc.keyword.line
-        def_end = s.loc.end.line
-
-        if @prev_def_end && (def_start - @prev_def_end) < 2
-          add_offence(:convention, def_start, MSG)
-        end
-
-        @prev_def_end = def_end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/empty_lines.rb

@@ -1,34 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class EmptyLines < Cop
-      MSG = 'Extra blank line detected.'
-      LINE_OFFSET = 2
-
-      def inspect(source, tokens, ast, comments)
-        return if tokens.empty?
-
-        prev_line = 1
-
-        tokens.each do |token|
-          cur_line = token.pos.line
-          line_diff = cur_line - prev_line
-
-          if line_diff > LINE_OFFSET
-            # we need to be wary of comments since they
-            # don't show up in the tokens
-            ((prev_line + 1)...cur_line).each do |line|
-              # we check if the prev and current lines are empty
-              if source[line - 2].empty? && source[line - 1].empty?
-                add_offence(:convention, line, MSG)
-              end
-            end
-          end
-
-          prev_line = cur_line
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/empty_literal.rb

@@ -1,49 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class EmptyLiteral < Cop
-      ARR_MSG = 'Use array literal [] instead of Array.new.'
-      HASH_MSG = 'Use hash literal {} instead of Hash.new.'
-      STR_MSG = "Use string literal '' instead of String.new."
-
-      # Empty array node
-      #
-      # (send
-      #   (const nil :Array) :new)
-      ARRAY_NODE = s(:send, s(:const, nil, :Array), :new)
-
-      # Empty hash node
-      #
-      # (send
-      #   (const nil :Hash) :new)
-      HASH_NODE = s(:send, s(:const, nil, :Hash), :new)
-
-      # Empty string node
-      #
-      # (send
-      #   (const nil :String) :new)
-      STR_NODE = s(:send, s(:const, nil, :String), :new)
-
-      def on_send(node)
-        case node
-        when ARRAY_NODE
-          add_offence(:convention,
-                      node.loc.line,
-                      ARR_MSG)
-        when HASH_NODE
-          add_offence(:convention,
-                      node.loc.line,
-                      HASH_MSG)
-        when STR_NODE
-          add_offence(:convention,
-                      node.loc.line,
-                      STR_MSG)
-        end
-      end
-
-      # TODO Check block contents as well
-      alias_method :on_block, :ignore_node
-    end
-  end
-end

data/lib/rubocop/cop/encoding.rb

@@ -1,19 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class Encoding < Cop
-      MSG = 'Missing utf-8 encoding comment.'
-
-      def inspect(source, tokens, ast, comments)
-        unless RUBY_VERSION >= '2.0.0'
-          expected_line = 0
-          expected_line += 1 if source[expected_line] =~ /^#!/
-          unless source[expected_line] =~ /#.*coding: (UTF|utf)-8/
-            add_offence(:convention, 1, MSG)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/end_of_line.rb

@@ -1,15 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class EndOfLine < Cop
-      MSG = 'Carriage return character detected.'
-
-      def inspect(source, tokens, ast, comments)
-        source.each_with_index do |line, index|
-          add_offence(:convention, index + 1, MSG) if line =~ /\r$/
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/ensure_return.rb

@@ -1,19 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class EnsureReturn < Cop
-      MSG = 'Never return from an ensure block.'
-
-      def on_ensure(node)
-        _body, ensure_body = *node
-
-        on_node(:return, ensure_body) do |e|
-          add_offence(:warning, e.loc.line, MSG)
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/eval.rb

@@ -1,19 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class Eval < Cop
-      MSG = 'The use of eval is a serious security risk.'
-
-      def on_send(node)
-        receiver, method_name, = *node
-
-        if receiver.nil? && method_name == :eval
-          add_offence(:security, node.loc.line, MSG)
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/favor_join.rb

@@ -1,22 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class FavorJoin < Cop
-      MSG = 'Favor Array#join over Array#*.'
-
-      def on_send(node)
-        receiver_node, method_name, *arg_nodes = *node
-
-        if receiver_node && receiver_node.type == :array &&
-            method_name == :* && arg_nodes[0].type == :str
-          add_offence(:convention,
-                      node.loc.expression.line,
-                      MSG)
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/favor_modifier.rb

@@ -1,92 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    module FavorModifier
-      # TODO extremely ugly solution that needs lots of polish
-      def check(sexp)
-        case sexp.loc.keyword.source
-        when 'if'     then cond, body, _else = *sexp
-        when 'unless' then cond, _else, body = *sexp
-        else               cond, body = *sexp
-        end
-
-        if length(sexp) > 3
-          false
-        else
-          indentation = sexp.loc.keyword.column
-          cond_length = sexp.loc.keyword.size + cond.loc.expression.size + 1
-          body_length = body_length(body)
-
-          body_length > 0 &&
-            (indentation + cond_length + body_length) <= LineLength.max
-        end
-      end
-
-      def length(sexp)
-        sexp.loc.expression.source.lines.to_a.size
-      end
-
-      def body_length(body)
-        if body && body.loc.expression
-          body.loc.expression.size
-        else
-          0
-        end
-      end
-    end
-
-    class IfUnlessModifier < Cop
-      include FavorModifier
-
-      def error_message
-        'Favor modifier if/unless usage when you have a single-line body. ' +
-          'Another good alternative is the usage of control flow &&/||.'
-      end
-
-      def on_if(node)
-        # discard ternary ops, if/else and modifier if/unless nodes
-        return if ternary_op?(node)
-        return if modifier_if?(node)
-        return if elsif?(node)
-        return if if_else?(node)
-
-        add_offence(:convention, node.loc.line, error_message) if check(node)
-
-        super
-      end
-
-      def ternary_op?(node)
-        node.loc.respond_to?(:question)
-      end
-
-      def modifier_if?(node)
-        node.loc.end.nil?
-      end
-
-      def elsif?(node)
-        node.loc.keyword.source == 'elsif'
-      end
-
-      def if_else?(node)
-        node.loc.respond_to?(:else) && node.loc.else
-      end
-    end
-
-    class WhileUntilModifier < Cop
-      include FavorModifier
-
-      MSG =
-        'Favor modifier while/until usage when you have a single-line body.'
-
-      def inspect(source, tokens, ast, comments)
-        on_node([:while, :until], ast) do |node|
-          # discard modifier while/until
-          next unless node.loc.end
-
-          add_offence(:convention, node.loc.line, MSG) if check(node)
-        end
-      end
-    end
-  end
-end