rubocop 0.8.3 → 0.9.0

data/lib/rubocop/cop/access_control.rb

@@ -1,41 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class AccessControl < Cop
-      INDENT_MSG = 'Indent private and protected as deep as method defs.'
-      BLANK_MSG = 'Keep a blank line before and after private/protected.'
-
-      PRIVATE_NODE = s(:send, nil, :private)
-      PROTECTED_NODE = s(:send, nil, :protected)
-
-      def inspect(source, tokens, ast, comments)
-        on_node([:class, :module, :sclass], ast) do |class_node|
-          class_start_col = class_node.loc.expression.column
-
-          # we'll have to walk all class children nodes
-          # except other class/module nodes
-          class_node.children.compact.each do |node|
-            on_node(:send, node, [:class, :module, :sclass]) do |send_node|
-              if [PRIVATE_NODE, PROTECTED_NODE].include?(send_node)
-                send_start_col = send_node.loc.expression.column
-
-                if send_start_col - 2 != class_start_col
-                  add_offence(:convention,
-                              send_node.loc.line,
-                              INDENT_MSG)
-                end
-
-                send_line = send_node.loc.line
-
-                unless source[send_line].empty? && source[send_line - 2].empty?
-                  add_offence(:convention, send_line, BLANK_MSG)
-                end
-              end
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/alias.rb

@@ -1,17 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class Alias < Cop
-      MSG = 'Use alias_method instead of alias.'
-
-      def on_alias(node)
-        add_offence(:convention,
-                    node.loc.keyword.line,
-                    MSG)
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/align_parameters.rb

@@ -1,37 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class AlignParameters < Cop
-      MSG = 'Align the parameters of a method call if they span ' +
-        'more than one line.'
-
-      def on_send(node)
-        _receiver, method, *args = *node
-
-        if method != :[]= && args.size > 1
-          first_arg_col = args.first.loc.expression.column
-          prev_arg_line = args.first.loc.expression.line
-          prev_arg_col = first_arg_col
-
-          args.each do |arg|
-            cur_arg_line = arg.loc.expression.line
-            cur_arg_col = arg.loc.expression.column
-
-            if cur_arg_line != prev_arg_line &&
-                cur_arg_col != first_arg_col
-              add_offence(:convetion,
-                          cur_arg_line,
-                          MSG)
-            end
-
-            prev_arg_col = cur_arg_col
-            prev_arg_line = cur_arg_line
-          end
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/and_or.rb

@@ -1,36 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class AndOr < Cop
-      MSG = 'Use %s instead of %s.'
-
-      OPS = { 'and' => '&&', 'or' => '||' }
-
-      def on_and(node)
-        process_logical_op(node)
-
-        super
-      end
-
-      def on_or(node)
-        process_logical_op(node)
-
-        super
-      end
-
-      private
-
-      def process_logical_op(node)
-        op = node.loc.operator.source
-        op_type = node.type.to_s
-
-        if op == op_type
-          add_offence(:convention,
-                      node.loc.operator.line,
-                      sprintf(MSG, OPS[op], op))
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/ascii_comments.rb

@@ -1,17 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class AsciiComments < Cop
-      MSG = 'Use only ascii symbols in comments.'
-
-      def inspect(source, tokens, ast, comments)
-        comments.each do |comment|
-          if comment.text =~ /[^\x00-\x7f]/
-            add_offence(:convention, comment.loc.line, MSG)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/ascii_identifiers.rb

@@ -1,19 +0,0 @@
-# encoding: utf-8
-
-# rubocop:disable SymbolName
-
-module Rubocop
-  module Cop
-    class AsciiIdentifiers < Cop
-      MSG = 'Use only ascii symbols in identifiers.'
-
-      def inspect(source, tokens, ast, comments)
-        tokens.each do |t|
-          if t.type == :tIDENTIFIER && t.text =~ /[^\x00-\x7f]/
-            add_offence(:convention, t.pos.line, MSG)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/avoid_class_vars.rb

@@ -1,15 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class AvoidClassVars < Cop
-      MSG = 'Replace class var %s with a class instance var.'
-
-      def on_cvasgn(node)
-        class_var, = *node
-        add_offence(:convention, node.loc.name.line, sprintf(MSG, class_var))
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/avoid_for.rb

@@ -1,17 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class AvoidFor < Cop
-      MSG = 'Prefer *each* over *for*.'
-
-      def on_for(node)
-        add_offence(:convention,
-                    node.loc.keyword.line,
-                    MSG)
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/avoid_global_vars.rb

@@ -1,61 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class AvoidGlobalVars < Cop
-      MSG = 'Do not introduce global variables.'
-
-      # predefined global variables their English aliases
-      # http://www.zenspider.com/Languages/Ruby/QuickRef.html
-      BUILT_IN_VARS = %w(
-        $: $LOAD_PATH
-        $" $LOADED_FEATURES
-        $0 $PROGRAM_NAME
-        $! $ERROR_INFO
-        $@ $ERROR_POSITION
-        $; $FS $FIELD_SEPARATOR
-        $, $OFS $OUTPUT_FIELD_SEPARATOR
-        $/ $RS $INPUT_RECORD_SEPARATOR
-        $\\ $ORS $OUTPUT_RECORD_SEPARATOR
-        $. $NR $INPUT_LINE_NUMBER
-        $_ $LAST_READ_LINE
-        $> $DEFAULT_OUTPUT
-        $< $DEFAULT_INPUT
-        $$ $PID $PROCESS_ID
-        $? $CHILD_STATUS
-        $~ $LAST_MATCH_INFO
-        $= $IGNORECASE
-        $* $ARGV
-        $& $MATCH
-        $` $PREMATCH
-        $' $POSTMATCH
-        $+ $LAST_PAREN_MATCH
-        $stdin $stdout $stderr
-        $DEBUG $FILENAME $VERBOSE
-        $-0 $-a $-d $-F $-i $-I $-l $-p $-v $-w
-      )
-
-      def on_gvar(node)
-        check(node)
-
-        super
-      end
-
-      def on_gvasgn(node)
-        check(node)
-
-        super
-      end
-
-      def check(node)
-        global_var, = *node
-
-        unless BUILT_IN_VARS.include?(global_var.to_s)
-          add_offence(:convention,
-                      node.loc.name.line,
-                      MSG)
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/avoid_perl_backrefs.rb

@@ -1,17 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class AvoidPerlBackrefs < Cop
-      def on_nth_ref(node)
-        backref, = *node
-
-        add_offence(:convention,
-                    node.loc.line,
-                    "Prefer the use of MatchData over $#{backref}.")
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/avoid_perlisms.rb

@@ -1,47 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class AvoidPerlisms < Cop
-      PREFERRED_VARS = {
-        '$:' => '$LOAD_PATH',
-        '$"' => '$LOADED_FEATURES',
-        '$0' => '$PROGRAM_NAME',
-        '$!' => '$ERROR_INFO from English library',
-        '$@' => '$ERROR_POSITION from English library',
-        '$;' => '$FS or $FIELD_SEPARATOR from English library',
-        '$,' => '$OFS or $OUTPUT_FIELD_SEPARATOR from English library',
-        '$/' => '$RS or $INPUT_RECORD_SEPARATOR from English library',
-        '$\\' => '$ORS or $OUTPUT_RECORD_SEPARATOR from English library',
-        '$.' => '$NR or $INPUT_LINE_NUMBER from English library',
-        '$_' => '$LAST_READ_LINE from English library',
-        '$>' => '$DEFAULT_OUTPUT from English library',
-        '$<' => '$DEFAULT_INPUT from English library',
-        '$$' => '$PID or $PROCESS_ID from English library',
-        '$?' => '$CHILD_STATUS from English library',
-        '$~' => '$LAST_MATCH_INFO from English library',
-        '$=' => '$IGNORECASE from English library',
-        '$*' => '$ARGV from English library or ARGV constant',
-        '$&' => '$MATCH from English library',
-        '$`' => '$PREMATCH from English library',
-        '$\'' => '$POSTMATCH from English library',
-        '$+' => '$LAST_PAREN_MATCH from English library'
-      }
-
-      def on_gvar(node)
-        global_var, = *node
-        global_var = global_var.to_s
-
-        if PREFERRED_VARS[global_var]
-          add_offence(
-            :convention,
-            node.loc.line,
-            "Prefer #{PREFERRED_VARS[global_var]} over #{global_var}."
-          )
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/block_comments.rb

@@ -1,17 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class BlockComments < Cop
-      MSG = 'Do not use block comments.'
-
-      def inspect(source, tokens, ast, comments)
-        comments.each do |comment|
-          if comment.text.start_with?('=begin')
-            add_offence(:convention, comment.loc.line, MSG)
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/block_nesting.rb

@@ -1,35 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class BlockNesting < Cop
-      NESTING_BLOCKS = [:case, :if, :while, :until, :for, :resbody]
-
-      def inspect(source, tokens, ast, comments)
-        max = BlockNesting.config['Max']
-        check_nesting_level(ast, max, 0)
-      end
-
-      private
-
-      def check_nesting_level(node, max, current_level)
-        if NESTING_BLOCKS.include?(node.type)
-          current_level += 1
-          if current_level == max + 1
-            add_offence(:convention, node.location.line, message(max))
-            return
-          end
-        end
-        node.children.each do |child|
-          if child.is_a?(Parser::AST::Node)
-            check_nesting_level(child, max, current_level)
-          end
-        end
-      end
-
-      def message(max)
-        "Avoid more than #{max} levels of block nesting."
-      end
-    end
-  end
-end

data/lib/rubocop/cop/blocks.rb

@@ -1,23 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class Blocks < Cop
-      MULTI_LINE_MSG = 'Avoid using {...} for multi-line blocks.'
-      SINGLE_LINE_MSG = 'Prefer {...} over do...end for single-line blocks.'
-
-      def on_block(node)
-        block_length = Util.block_length(node)
-        block_begin = node.loc.begin.source
-
-        if block_length > 0 && block_begin == '{'
-          add_offence(:convention, node.loc.line, MULTI_LINE_MSG)
-        elsif block_length == 0 && block_begin != '{'
-          add_offence(:convention, node.loc.line, SINGLE_LINE_MSG)
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/case_indentation.rb

@@ -1,22 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class CaseIndentation < Cop
-      MSG = 'Indent when as deep as case.'
-
-      def on_case(case_node)
-        _condition, *whens, _else = *case_node
-
-        case_column = case_node.location.keyword.column
-
-        whens.each do |when_node|
-          pos = when_node.loc.keyword
-          add_offence(:convention, pos.line, MSG) if pos.column != case_column
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/class_and_module_camel_case.rb

@@ -1,29 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class ClassAndModuleCamelCase < Cop
-      MSG = 'Use CamelCase for classes and modules.'
-
-      def on_class(node)
-        check_name(node)
-
-        super
-      end
-
-      def on_module(node)
-        check_name(node)
-
-        super
-      end
-
-      private
-
-      def check_name(node)
-        name = node.loc.name.source
-
-        add_offence(:convention, node.loc.line, MSG) if name =~ /_/
-      end
-    end
-  end
-end