rubocop 0.8.3 → 0.9.0

data/lib/rubocop/cop/symbol_array.rb

@@ -1,31 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class SymbolArray < Cop
-      MSG = 'Use %i or %I for array of symbols.'
-
-      def inspect(source, tokens, ast, comments)
-        # %i and %I were introduced in Ruby 2.0
-        unless RUBY_VERSION < '2.0.0'
-          on_node(:array, ast) do |s|
-            next unless s.loc.begin && s.loc.begin.source == '['
-
-            array_elems = s.children
-
-            # no need to check empty arrays
-            next unless array_elems && array_elems.size > 1
-
-            symbol_array = array_elems.all? { |e| e.type == :sym }
-
-            if symbol_array
-              add_offence(:convention,
-                          s.loc.line,
-                          MSG)
-            end
-          end
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/symbol_name.rb

@@ -1,23 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class SymbolName < Cop
-      MSG = 'Use snake_case for symbols.'
-      SNAKE_CASE = /^[\da-z_]+[!?=]?$/
-      CAMEL_CASE = /^[A-Z][A-Za-z\d]*$/
-
-      def allow_camel_case?
-        self.class.config['AllowCamelCase']
-      end
-
-      def on_sym(node)
-        sym_name = node.to_a[0]
-        return unless sym_name =~ /^[a-zA-Z]/
-        return if sym_name =~ SNAKE_CASE
-        return if allow_camel_case? && sym_name =~ CAMEL_CASE
-        add_offence(:convention, node.loc.line, MSG)
-      end
-    end
-  end
-end

data/lib/rubocop/cop/syntax.rb

@@ -1,49 +0,0 @@
-# encoding: utf-8
-
-require 'open3'
-
-module Rubocop
-  module Cop
-    class Syntax < Cop
-      def inspect_file(file)
-        # Starting JRuby processes would be extremely slow
-        # We need to check if rbx returns nice warning messages
-        return unless RUBY_ENGINE == 'ruby'
-
-        stderr = nil
-
-        # it's extremely important to run the syntax check in a
-        # clean environment - otherwise it will be extremely slow
-        if defined? Bundler
-          Bundler.with_clean_env do
-            _, stderr, _ = Open3.capture3("ruby -wc #{file}")
-          end
-        else
-          _, stderr, _ = Open3.capture3("ruby -wc #{file}")
-        end
-
-        stderr.each_line do |line|
-          # discard lines that are not containing relevant info
-          if line =~ /.+:(\d+): (.+)/
-            # Assignment to unused variables beginning with underscore
-            # is reported by Ruby 1.9, but not 2.0. Make 1.9 behave
-            # like 2.0.
-            unless line =~ /assigned but unused variable - _\w+/
-              line_no, severity, message = process_line(line)
-              add_offence(severity, line_no, message)
-            end
-          end
-        end
-      end
-
-      def process_line(line)
-        line_no, message = line.match(/.+:(\d+): (.+)/).captures
-        if message.start_with?('warning: ')
-          [line_no.to_i, :warning, message.sub(/warning: /, '').capitalize]
-        else
-          [line_no.to_i, :error, message.capitalize]
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/tab.rb

@@ -1,15 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class Tab < Cop
-      MSG = 'Tab detected.'
-
-      def inspect(source, tokens, ast, comments)
-        source.each_with_index do |line, index|
-          add_offence(:convention, index + 1, MSG) if line =~ /^ *\t/
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/ternary_operator.rb

@@ -1,43 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class MultilineTernaryOperator < Cop
-      MSG =
-        'Avoid multi-line ?: (the ternary operator); use if/unless instead.'
-
-      def on_if(node)
-        loc = node.loc
-
-        # discard non-ternary ops
-        return unless loc.respond_to?(:question)
-
-        add_offence(:convention, loc.line, MSG) if loc.line != loc.colon.line
-
-        super
-      end
-    end
-
-    class NestedTernaryOperator < Cop
-      MSG = 'Ternary operators must not be nested. Prefer if/else ' +
-          'constructs instead.'
-
-      def on_if(node)
-        loc = node.loc
-
-        # discard non-ternary ops
-        return unless loc.respond_to?(:question)
-
-        node.children.each do |child|
-          on_node(:if, child) do |c|
-            if c.loc.respond_to?(:question)
-              add_offence(:convention, c.loc.line, MSG)
-            end
-          end
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/trailing_whitespace.rb

@@ -1,15 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class TrailingWhitespace < Cop
-      MSG = 'Trailing whitespace detected.'
-
-      def inspect(source, tokens, ast, comments)
-        source.each_with_index do |line, index|
-          add_offence(:convention, index + 1, MSG) if line =~ /.*[ \t]+$/
-        end
-      end
-    end
-  end
-end

data/lib/rubocop/cop/trivial_accessors.rb

@@ -1,26 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class TrivialAccessors < Cop
-      MSG = 'Use attr_%s to define trivial %s methods.'
-
-      def on_def(node)
-        method_name, args, body = *node
-
-        kind = if body.type == :ivar
-                 'reader'
-               elsif args.children.size == 1 && body.type == :ivasgn &&
-                   body.children[1].type == :lvar && method_name != :initialize
-                 'writer'
-               end
-        if kind
-          add_offence(:convention, node.loc.keyword.line,
-                      sprintf(MSG, kind, kind))
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/unless_else.rb

@@ -1,23 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class UnlessElse < Cop
-      MSG = 'Never use unless with else. Rewrite these with the ' +
-        'positive case first.'
-
-      def on_if(node)
-        loc = node.loc
-
-        # discard ternary ops and modifier if/unless nodes
-        return unless loc.respond_to?(:keyword) && loc.respond_to?(:else)
-
-        if loc.keyword.source == 'unless' && loc.else
-          add_offence(:convention, loc.line, MSG)
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/variable_interpolation.rb

@@ -1,29 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class VariableInterpolation < Cop
-      MSG = 'Replace interpolated var %s with expression #{%s}.'
-
-      def on_dstr(node)
-        var_nodes(node.children).each do |v|
-          var = (v.type == :nth_ref ? '$' : '') + v.to_a[0].to_s
-
-          if node.loc.expression.source.include?("##{var}")
-            add_offence(:convention,
-                        v.loc.line,
-                        sprintf(MSG, var, var))
-          end
-        end
-
-        super
-      end
-
-      private
-
-      def var_nodes(nodes)
-        nodes.select { |n| [:ivar, :cvar, :gvar, :nth_ref].include?(n.type) }
-      end
-    end
-  end
-end

data/lib/rubocop/cop/when_then.rb

@@ -1,17 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class WhenThen < Cop
-      MSG = 'Never use "when x;". Use "when x then" instead.'
-
-      def on_when(node)
-        if node.loc.begin && node.loc.begin.source == ';'
-          add_offence(:convention, node.loc.line, MSG)
-        end
-
-        super
-      end
-    end
-  end
-end

data/lib/rubocop/cop/word_array.rb

@@ -1,37 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Cop
-    class WordArray < Cop
-      MSG = 'Use %w or %W for array of words.'
-
-      def on_array(node)
-        return unless node.loc.begin && node.loc.begin.source == '['
-
-        array_elems = node.children
-
-        # no need to check empty arrays
-        return unless array_elems && array_elems.size > 1
-
-        string_array = array_elems.all? { |e| e.type == :str }
-
-        if string_array && !complex_content?(array_elems)
-          add_offence(:convention, node.loc.line, MSG)
-        end
-
-        super
-      end
-
-      private
-
-      def complex_content?(arr_sexp)
-        arr_sexp.each do |s|
-          str_content = Util.strip_quotes(s.loc.expression.source)
-          return true unless str_content =~ /\A[\w-]+\z/
-        end
-
-        false
-      end
-    end
-  end
-end

data/lib/rubocop/report/emacs_style.rb

@@ -1,17 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Report
-    # Plain text report, suitable for display in Emacs *compilation* buffers.
-    class EmacsStyle < PlainText
-      # Generates a string representation of the report
-      def generate
-        report = entries.map do |e|
-          sprintf('%s:%d: %s: %s', @filename,
-                  e.line_number, e.encode_severity, e.message)
-        end
-        report.join("\n")
-      end
-    end
-  end
-end

data/lib/rubocop/report/plain_text.rb

@@ -1,18 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Report
-    # Plain text report, suitable for display in terminals.
-    class PlainText < Report
-      # Generates a string representation of the report
-      def generate
-        report = "== #{filename} ==\n".color(:yellow)
-        report << entries.join("\n")
-      end
-
-      def display(stream = $stdout)
-        stream.puts generate
-      end
-    end
-  end
-end

data/lib/rubocop/report/report.rb

@@ -1,44 +0,0 @@
-# encoding: utf-8
-
-module Rubocop
-  module Report
-    # Creates a Report object, based on the current settings
-    #
-    # @param [String] the filename for the report
-    # @return [Report] a report object
-    def create(file, output_mode = :default)
-      case output_mode
-      when :default     then PlainText.new(file)
-      when :emacs_style then EmacsStyle.new(file)
-      end
-    end
-
-    module_function :create
-
-    class Report
-      attr_reader :filename
-
-      # @param [String] the filename for this report
-      def initialize(filename)
-        @filename = filename
-        @entries = []
-      end
-
-      # Appends offences registered by cops to the report.
-      # @param [Cop] a cop with something to report
-      def <<(cop)
-        cop.offences.each do |entry|
-          @entries << entry
-        end
-      end
-
-      def entries
-        @entries.sort_by(&:line_number)
-      end
-
-      def empty?
-        entries.empty?
-      end
-    end
-  end
-end

data/spec/rubocop/cops/access_control_spec.rb

@@ -1,129 +0,0 @@
-# encoding: utf-8
-
-require 'spec_helper'
-
-module Rubocop
-  module Cop
-    describe AccessControl do
-      let(:a) { AccessControl.new }
-
-      it 'registers an offence for misaligned private' do
-        inspect_source(a,
-                       ['class Test',
-                         '',
-                         'private',
-                         '',
-                         '  def test; end',
-                         'end'])
-        expect(a.offences.size).to eq(1)
-        expect(a.offences.map(&:message))
-          .to eq([AccessControl::INDENT_MSG])
-      end
-
-      it 'registers an offence for misaligned private in module' do
-        inspect_source(a,
-                       ['module Test',
-                        '',
-                        'private',
-                        '',
-                        '  def test; end',
-                        'end'])
-        expect(a.offences.size).to eq(1)
-        expect(a.offences.map(&:message))
-          .to eq([AccessControl::INDENT_MSG])
-      end
-
-      it 'registers an offence for misaligned private in singleton class' do
-        inspect_source(a,
-                       ['class << self',
-                         '',
-                         'private',
-                         '',
-                         '  def test; end',
-                         'end'])
-        expect(a.offences.size).to eq(1)
-        expect(a.offences.map(&:message))
-          .to eq([AccessControl::INDENT_MSG])
-      end
-
-      it 'registers an offence for misaligned protected' do
-        inspect_source(a,
-                       ['class Test',
-                        '',
-                        'protected',
-                        '',
-                        '  def test; end',
-                        'end'])
-        expect(a.offences.size).to eq(1)
-        expect(a.offences.map(&:message))
-          .to eq([AccessControl::INDENT_MSG])
-      end
-
-      it 'accepts properly indented private' do
-        inspect_source(a,
-                       ['class Test',
-                        '',
-                        '  private',
-                        '',
-                        '  def test; end',
-                        'end'])
-        expect(a.offences).to be_empty
-      end
-
-      it 'accepts properly indented protected' do
-        inspect_source(a,
-                       ['class Test',
-                        '',
-                        '  protected',
-                        '',
-                        '  def test; end',
-                        'end'])
-        expect(a.offences).to be_empty
-      end
-
-      it 'handles properly nested classes' do
-        inspect_source(a,
-                       ['class Test',
-                        '',
-                        '  class Nested',
-                        '',
-                        '  private',
-                        '',
-                        '    def a; end',
-                        '  end',
-                        '',
-                        '  protected',
-                        '',
-                        '  def test; end',
-                        'end'])
-        expect(a.offences.size).to eq(1)
-        expect(a.offences.map(&:message))
-          .to eq([AccessControl::INDENT_MSG])
-      end
-
-      it 'requires blank line before private/protected' do
-        inspect_source(a,
-                       ['class Test',
-                        '  protected',
-                        '',
-                        '  def test; end',
-                        'end'])
-        expect(a.offences.size).to eq(1)
-        expect(a.offences.map(&:message))
-          .to eq([AccessControl::BLANK_MSG])
-      end
-
-      it 'requires blank line after private/protected' do
-        inspect_source(a,
-                       ['class Test',
-                        '',
-                        '  protected',
-                        '  def test; end',
-                        'end'])
-        expect(a.offences.size).to eq(1)
-        expect(a.offences.map(&:message))
-          .to eq([AccessControl::BLANK_MSG])
-      end
-    end
-  end
-end