rubocop 0.8.3 → 0.9.0

data/spec/rubocop/cops/style/and_or_spec.rb

@@ -0,0 +1,39 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe AndOr do
+        let(:amp) { AndOr.new }
+
+        it 'registers an offence for OR' do
+          inspect_source(amp,
+                         ['test if a or b'])
+          expect(amp.offences.size).to eq(1)
+          expect(amp.messages).to eq(['Use || instead of or.'])
+        end
+
+        it 'registers an offence for AND' do
+          inspect_source(amp,
+                         ['test if a and b'])
+          expect(amp.offences.size).to eq(1)
+          expect(amp.messages).to eq(['Use && instead of and.'])
+        end
+
+        it 'accepts ||' do
+          inspect_source(amp,
+                         ['test if a || b'])
+          expect(amp.offences).to be_empty
+        end
+
+        it 'accepts &&' do
+          inspect_source(amp,
+                         ['test if a && b'])
+          expect(amp.offences).to be_empty
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/style/ascii_comments_spec.rb

@@ -0,0 +1,28 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe AsciiComments do
+        let(:ascii) { AsciiComments.new }
+
+        it 'registers an offence for a comment with non-ascii chars' do
+          inspect_source(ascii,
+                         ['# encoding: utf-8',
+                          '# 这是什么？'])
+          expect(ascii.offences.size).to eq(1)
+          expect(ascii.offences.map(&:message))
+            .to eq([AsciiComments::MSG])
+        end
+
+        it 'accepts comments with only ascii chars' do
+          inspect_source(ascii,
+                         ['# AZaz1@$%~,;*_`|'])
+          expect(ascii.offences).to be_empty
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/style/ascii_identifiers_spec.rb

@@ -0,0 +1,28 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe AsciiIdentifiers do
+        let(:ascii) { AsciiIdentifiers.new }
+
+        it 'registers an offence for a variable name with non-ascii chars' do
+          inspect_source(ascii,
+                         ['# encoding: utf-8',
+                          'älg = 1'])
+          expect(ascii.offences.size).to eq(1)
+          expect(ascii.offences.map(&:message))
+            .to eq([AsciiIdentifiers::MSG])
+        end
+
+        it 'accepts identifiers with only ascii chars' do
+          inspect_source(ascii,
+                         ['x.empty?'])
+          expect(ascii.offences).to be_empty
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/style/attr_spec.rb

@@ -0,0 +1,20 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe Attr do
+        let(:cop) { Attr.new }
+
+        it 'registers an offence attr' do
+          inspect_source(cop, ['class SomeClass',
+                               '  attr :name',
+                               'end'])
+          expect(cop.offences.size).to eq(1)
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/style/avoid_class_vars_spec.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe AvoidClassVars do
+        let(:acv) { AvoidClassVars.new }
+
+        it 'registers an offence for class variable declaration' do
+          inspect_source(acv,
+                         ['class TestClass; @@test = 10; end'])
+          expect(acv.offences.size).to eq(1)
+          expect(acv.offences.map(&:message))
+            .to eq(['Replace class var @@test with a class instance var.'])
+        end
+
+        it 'does not register an offence for class variable usage' do
+          inspect_source(acv,
+                         ['@@test.test(20)'])
+          expect(acv.offences).to be_empty
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/style/avoid_for_spec.rb

@@ -0,0 +1,37 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe AvoidFor do
+        let(:af) { AvoidFor.new }
+
+        it 'registers an offence for for' do
+          inspect_source(af,
+                         ['def func',
+                          '  for n in [1, 2, 3] do',
+                          '    puts n',
+                          '  end',
+                          'end'])
+          expect(af.offences.size).to eq(1)
+          expect(af.offences.map(&:message))
+            .to eq([AvoidFor::MSG])
+        end
+
+        it 'does not register an offence for :for' do
+          inspect_source(af,
+                         ['[:for, :ala, :bala]'])
+          expect(af.offences).to be_empty
+        end
+
+        it 'does not register an offence for def for' do
+          inspect_source(af,
+                         ['def for; end'])
+          expect(af.offences).to be_empty
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/style/avoid_global_vars_spec.rb

@@ -0,0 +1,34 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe AvoidGlobalVars do
+        let(:ap) { AvoidGlobalVars.new }
+
+        it 'registers an offence for $custom' do
+          inspect_source(ap, ['puts $custom'])
+          expect(ap.offences.size).to eq(1)
+        end
+
+        it 'does not register an offence for $"' do
+          inspect_source(ap, ['puts $"'])
+
+          expect(ap.offences).to be_empty
+        end
+
+        it 'does not register an offence for $ORS' do
+          inspect_source(ap, ['puts $0'])
+          expect(ap.offences).to be_empty
+        end
+
+        it 'does not register an offence for backrefs like $1' do
+          inspect_source(ap, ['puts $1'])
+          expect(ap.offences).to be_empty
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/style/avoid_perl_backrefs_spec.rb

@@ -0,0 +1,20 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe AvoidPerlBackrefs do
+        let(:ap) { AvoidPerlBackrefs.new }
+
+        it 'registers an offence for $1' do
+          inspect_source(ap, ['puts $1'])
+          expect(ap.offences.size).to eq(1)
+          expect(ap.offences.map(&:message))
+            .to eq(['Prefer the use of MatchData over $1.'])
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/style/avoid_perlisms_spec.rb

@@ -0,0 +1,47 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe AvoidPerlisms do
+        let(:ap) { AvoidPerlisms.new }
+
+        it 'registers an offence for $:' do
+          inspect_source(ap, ['puts $:'])
+          expect(ap.offences.size).to eq(1)
+          expect(ap.offences.map(&:message))
+            .to eq(['Prefer $LOAD_PATH over $:.'])
+        end
+
+        it 'registers an offence for $"' do
+          inspect_source(ap, ['puts $"'])
+          expect(ap.offences.size).to eq(1)
+          expect(ap.offences.map(&:message))
+            .to eq(['Prefer $LOADED_FEATURES over $".'])
+        end
+
+        it 'registers an offence for $0' do
+          inspect_source(ap, ['puts $0'])
+          expect(ap.offences.size).to eq(1)
+          expect(ap.offences.map(&:message))
+            .to eq(['Prefer $PROGRAM_NAME over $0.'])
+        end
+
+        it 'registers an offence for $$' do
+          inspect_source(ap, ['puts $$'])
+          expect(ap.offences.size).to eq(1)
+          expect(ap.offences.map(&:message))
+            .to eq(['Prefer $PID or $PROCESS_ID from English library' +
+              ' over $$.'])
+        end
+
+        it 'does not register an offence for backrefs like $1' do
+          inspect_source(ap, ['puts $1'])
+          expect(ap.offences).to be_empty
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/style/begin_block_spec.rb

@@ -0,0 +1,19 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe BeginBlock do
+        let(:cop) { BeginBlock.new }
+
+        it 'reports an offence for a BEGIN block' do
+          src = ['BEGIN { test }']
+          inspect_source(cop, src)
+          expect(cop.offences.size).to eq(1)
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/style/block_comments_spec.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe BlockComments do
+        let(:block) { BlockComments.new }
+
+        it 'registers an offence for block comments' do
+          inspect_source(block,
+                         ['=begin',
+                          'comment',
+                          '=end'])
+          expect(block.offences.size).to eq(1)
+        end
+
+        it 'accepts regular comments' do
+          inspect_source(block,
+                         ['# comment'])
+          expect(block.offences).to be_empty
+        end
+      end
+    end
+  end
+end

data/spec/rubocop/cops/style/block_nesting_spec.rb

@@ -0,0 +1,159 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+module Rubocop
+  module Cop
+    module Style
+      describe BlockNesting do
+        let(:block_nesting) { BlockNesting.new }
+        before { BlockNesting.config = { 'Max' => 2 } }
+
+        it 'accepts `Max` levels of nesting' do
+          source = ['if a',
+                    '  if b',
+                    '    puts b',
+                    '  end',
+                    'end']
+          expect_nesting_offences(source, [])
+        end
+
+        it 'registers an offence for `Max + 1` levels of `if` nesting' do
+          source = ['if a',
+                    '  if b',
+                    '    if c',
+                    '      puts c',
+                    '    end',
+                    '  end',
+                    'end']
+          expect_nesting_offences(source, [3])
+        end
+
+        it 'registers a single offence for `Max + 2` levels of `if` nesting' do
+          source = ['if a',
+                    '  if b',
+                    '    if c',
+                    '      if d',
+                    '        puts d',
+                    '      end',
+                    '    end',
+                    '  end',
+                    'end']
+          expect_nesting_offences(source, [3])
+        end
+
+        it 'registers 2 offences' do
+          source = ['if a',
+                    '  if b',
+                    '    if c',
+                    '      puts c',
+                    '    end',
+                    '  end',
+                    '  if d',
+                    '    if e',
+                    '      puts e',
+                    '    end',
+                    '  end',
+                    'end']
+          expect_nesting_offences(source, [3, 8])
+        end
+
+        it 'registers an offence for nested `case`' do
+          source = ['if a',
+                    '  if b',
+                    '    case c',
+                    '      when C',
+                    '        puts C',
+                    '    end',
+                    '  end',
+                    'end']
+          expect_nesting_offences(source, [3])
+        end
+
+        it 'registers an offence for nested `while`' do
+          source = ['if a',
+                    '  if b',
+                    '    while c',
+                    '      puts c',
+                    '    end',
+                    '  end',
+                    'end']
+          expect_nesting_offences(source, [3])
+        end
+
+        it 'registers an offence for nested modifier `while`' do
+          source = ['if a',
+                    '  if b',
+                    '    begin',
+                    '      puts c',
+                    '    end while c',
+                    '  end',
+                    'end']
+          expect_nesting_offences(source, [3])
+        end
+
+        it 'registers an offence for nested `until`' do
+          source = ['if a',
+                    '  if b',
+                    '    until c',
+                    '      puts c',
+                    '    end',
+                    '  end',
+                    'end']
+          expect_nesting_offences(source, [3])
+        end
+
+        it 'registers an offence for nested modifier `until`' do
+          source = ['if a',
+                    '  if b',
+                    '    begin',
+                    '      puts c',
+                    '    end until c',
+                    '  end',
+                    'end']
+          expect_nesting_offences(source, [3])
+        end
+
+        it 'registers an offence for nested `for`' do
+          source = ['if a',
+                    '  if b',
+                    '    for c in [1,2] do',
+                    '      puts c',
+                    '    end',
+                    '  end',
+                    'end']
+          expect_nesting_offences(source, [3])
+        end
+
+        it 'registers an offence for nested `rescue`' do
+          source = ['if a',
+                    '  if b',
+                    '    begin',
+                    '      puts c',
+                    '    rescue',
+                    '      puts x',
+                    '    end',
+                    '  end',
+                    'end']
+          expect_nesting_offences(source, [5])
+        end
+
+        it 'accepts if/elsif' do
+          source = ['if a',
+                    'elsif b',
+                    'elsif c',
+                    'elsif d',
+                    'end']
+          expect_nesting_offences(source, [])
+        end
+
+        def expect_nesting_offences(source, lines)
+          inspect_source(block_nesting, source)
+          expect(block_nesting.offences.map(&:line)).to eq(lines)
+          expect(block_nesting.messages).to eq(
+            ['Avoid more than 2 levels of block nesting.'] * lines.length)
+        end
+      end
+    end
+  end
+end