rubocop 0.8.3 → 0.9.0

data/rubocop.gemspec

@@ -10,7 +10,6 @@ Gem::Specification.new do |s|
   s.platform = Gem::Platform::RUBY
   s.required_ruby_version = '>= 1.9.2'
   s.authors = ['Bozhidar Batsov']
-  s.date = '2013-04-17'
   s.description = <<-EOF
     Automatic Ruby code style checking tool.
     Aims to enforce the community-driven Ruby Style Guide.
@@ -28,7 +27,7 @@ Gem::Specification.new do |s|
   s.summary = 'Automatic Ruby code style checking tool.'
 
   s.add_runtime_dependency('rainbow', '>= 1.1.4')
-  s.add_runtime_dependency('parser', ['2.0.0.beta5'])
+  s.add_runtime_dependency('parser', '2.0.0.beta9')
   s.add_development_dependency('rake', '~> 10.0')
   s.add_development_dependency('rspec', '~> 2.13')
   s.add_development_dependency('yard', '~> 0.8')

data/spec/.rubocop.yml

@@ -0,0 +1,5 @@
+inherit_from: ../.rubocop.yml
+
+# The documentation check doesn't make sense for test code
+Documentation:
+  Enabled: false

data/spec/project_spec.rb

@@ -3,25 +3,22 @@
 require 'spec_helper'
 
 describe 'RuboCop Project' do
-  describe '.rubocop.yml' do
+  describe 'default configuration file' do
     it 'has configuration for all cops' do
       cop_names = Rubocop::Cop::Cop.all.map(&:cop_name)
-      expect(Rubocop::Config.load_file('.rubocop.yml').keys.sort)
+      expect(Rubocop::Config.load_file('config/default.yml').keys.sort)
         .to eq((['AllCops'] + cop_names).sort)
     end
   end
 
-  describe 'source codes', broken: true do
+  describe 'source codes' do
     before { $stdout = StringIO.new }
     after  { $stdout = STDOUT }
 
     it 'has no violations' do
       # Need to pass an empty array explicitly
       # so that the CLI does not refer arguments of `rspec`
-      Rubocop::CLI.new.run([])
-      expect($stdout.string).to match(
-        /files inspected, no offences detected\n/
-      )
+      expect(Rubocop::CLI.new.run([])).to eq(0)
     end
   end
 end

data/spec/rubocop/cli_spec.rb

@@ -9,21 +9,51 @@ module Rubocop
     include FileHelper
 
     let(:cli) { CLI.new }
-    before(:each) { $stdout = StringIO.new }
-    after(:each) { $stdout = STDOUT }
+
+    before(:each) do
+      $stdout = StringIO.new
+      $stderr = StringIO.new
+    end
+
+    after(:each) do
+      $stdout = STDOUT
+      $stderr = STDERR
+    end
+
+    def abs(path)
+      File.expand_path(path)
+    end
 
     it 'exits cleanly when -h is used' do
       expect { cli.run ['-h'] }.to exit_with_code(0)
       expect { cli.run ['--help'] }.to exit_with_code(0)
-      message = ['Usage: rubocop [options] [file1, file2, ...]',
-                 '    -d, --debug                      Display debug info',
-                 '    -e, --emacs                      Emacs style output',
-                 '    -c, --config FILE                Configuration file',
-                 '        --only COP                   Run just one cop',
-                 '    -s, --silent                     Silence summary',
-                 '    -n, --no-color                   Disable color output',
-                 '    -v, --version                    Display version']
-      expect($stdout.string).to eq((message * 2).join("\n") + "\n")
+      message = <<-END
+Usage: rubocop [options] [file1, file2, ...]
+    -d, --debug                      Display debug info.
+    -c, --config FILE                Specify configuration file.
+        --only COP                   Run just one cop.
+    -f, --format FORMATTER           Choose an output formatter. This option
+                                     can be specified multiple times to enable
+                                     multiple formatters at the same time.
+                                       [p]rogress (default)
+                                       [s]imple
+                                       [c]lang
+                                       [e]macs
+                                       [j]son
+                                       custom formatter class name
+    -o, --out FILE                   Write output to a file instead of STDOUT.
+                                     This option applies to the previously
+                                     specified --format, or the default format
+                                     if no format is specified.
+    -r, --require FILE               Require Ruby file.
+    -R, --rails                      Run extra Rails cops.
+    -a, --auto-correct               Auto-correct offences.
+    -s, --silent                     Silence summary.
+    -n, --no-color                   Disable color output.
+    -v, --version                    Display version.
+    -V, --verbose-version            Display verbose version.
+      END
+      expect($stdout.string).to eq(message * 2)
     end
 
     it 'exits cleanly when -v is used' do
@@ -38,78 +68,65 @@ module Rubocop
       end
     end
 
-    context 'when interrupted with Ctrl-C' do
+    describe '#trap_interrupt' do
       before do
         @interrupt_handlers = []
         Signal.stub(:trap).with('INT') do |&block|
           @interrupt_handlers << block
         end
-
-        $stderr = StringIO.new
-
-        create_file('example.rb', '# encoding: utf-8')
-      end
-
-      after do
-        $stderr = STDERR
-        @cli_thread.terminate if @cli_thread
       end
 
       def interrupt
         @interrupt_handlers.each(&:call)
       end
 
-      def cli_run_in_thread
-        @cli_thread = Thread.new do
-          cli.run(['--debug'])
-        end
-
-        # Wait for start.
-        loop { break unless $stdout.string.empty? }
-
-        @cli_thread
-      end
-
-      it 'exits with status 1' do
-        cli_thread = cli_run_in_thread
-        interrupt
-        expect(cli_thread.value).to eq(1)
+      it 'adds a handler for SIGINT' do
+        expect(@interrupt_handlers).to be_empty
+        cli.trap_interrupt
+        expect(@interrupt_handlers).to have(1).item
       end
 
-      it 'exits gracefully without dumping backtraces' do
-        cli_thread = cli_run_in_thread
-        interrupt
-        cli_thread.join
-        expect($stderr.string).not_to match(/from .+:\d+:in /)
-      end
+      context 'with SIGINT once' do
+        it 'sets #wants_to_quit? to true' do
+          cli.trap_interrupt
+          expect(cli.wants_to_quit?).to be_false
+          interrupt
+          expect(cli.wants_to_quit?).to be_true
+        end
 
-      context 'with Ctrl-C once' do
-        it 'reports summary' do
-          cli_thread = cli_run_in_thread
+        it 'does not exit immediately' do
+          Object.any_instance.should_not_receive(:exit)
+          Object.any_instance.should_not_receive(:exit!)
+          cli.trap_interrupt
           interrupt
-          cli_thread.join
-          expect($stdout.string).to match(/files? inspected/)
         end
       end
 
-      context 'with Ctrl-C twice' do
+      context 'with SIGINT twice' do
         it 'exits immediately' do
           Object.any_instance.should_receive(:exit!).with(1)
-          cli_thread = cli_run_in_thread
+          cli.trap_interrupt
           interrupt
           interrupt
-          cli_thread.join
         end
       end
     end
 
+    context 'when #wants_to_quit? is true' do
+      it 'returns 1' do
+        create_file('example.rb', '# encoding: utf-8')
+        cli.wants_to_quit = true
+        expect(cli.run(['example.rb'])).to eq(1)
+      end
+    end
+
     it 'checks a given correct file and returns 0' do
       create_file('example.rb', [
         '# encoding: utf-8',
         'x = 0',
         'puts x'
       ])
-      expect(cli.run(['example.rb'])).to eq(0)
+      expect(cli.run(['--format', 'simple', 'example.rb'])).to eq(0)
       expect($stdout.string)
         .to eq("\n1 file inspected, no offences detected\n")
     end
@@ -120,10 +137,10 @@ module Rubocop
         'x = 0 ',
         'puts x'
       ])
-      expect(cli.run(['example.rb'])).to eq(1)
+      expect(cli.run(['--format', 'simple', 'example.rb'])).to eq(1)
       expect($stdout.string)
         .to eq ['== example.rb ==',
-                'C:  2: Trailing whitespace detected.',
+                'C:  2:  6: Trailing whitespace detected.',
                 '',
                 '1 file inspected, 1 offence detected',
                 ''].join("\n")
@@ -139,15 +156,17 @@ module Rubocop
         "\tx = 0",
         'puts x'
       ])
-      expect(cli.run(['--emacs', 'example1.rb', 'example2.rb'])).to eq(1)
+      expect(cli.run(['--format', 'emacs', 'example1.rb', 'example2.rb']))
+        .to eq(1)
       expect($stdout.string)
         .to eq(
-        ['example1.rb:1: C: Missing utf-8 encoding comment.',
-         'example1.rb:1: C: Trailing whitespace detected.',
-         "example1.rb:1: C: Surrounding space missing for operator '='.",
-         'example1.rb:2: C: Trailing whitespace detected.',
-         'example2.rb:1: C: Missing utf-8 encoding comment.',
-         'example2.rb:1: C: Tab detected.',
+        ["#{abs('example1.rb')}:1:1: C: Missing utf-8 encoding comment.",
+         "#{abs('example1.rb')}:1:2: C: Surrounding space missing" +
+         " for operator '='.",
+         "#{abs('example1.rb')}:1:5: C: Trailing whitespace detected.",
+         "#{abs('example1.rb')}:2:2: C: Trailing whitespace detected.",
+         "#{abs('example2.rb')}:1:1: C: Missing utf-8 encoding comment.",
+         "#{abs('example2.rb')}:1:1: C: Tab detected.",
          '',
          '2 files inspected, 6 offences detected',
          ''].join("\n"))
@@ -163,18 +182,55 @@ module Rubocop
         "\tx = 0",
         'puts x'
       ])
-      expect(cli.run(['--emacs', 'example1.rb', 'example2.rb'])).to eq(1)
+      expect(cli.run(['--format', 'emacs', 'example1.rb', 'example2.rb']))
+        .to eq(1)
       expect($stdout.string)
         .to eq(
-        ['example1.rb:1: C: Trailing whitespace detected.',
-         "example1.rb:1: C: Surrounding space missing for operator '='.",
-         'example1.rb:2: C: Trailing whitespace detected.',
-         'example2.rb:1: C: Tab detected.',
+        ["#{abs('example1.rb')}:1:2: C: Surrounding space missing" +
+         " for operator '='.",
+         "#{abs('example1.rb')}:1:5: C: Trailing whitespace detected.",
+         "#{abs('example1.rb')}:2:2: C: Trailing whitespace detected.",
+         "#{abs('example2.rb')}:1:1: C: Tab detected.",
          '',
          '2 files inspected, 4 offences detected',
          ''].join("\n"))
     end
 
+    it 'can report in clang style' do
+      create_file('example1.rb', ['# encoding: utf-8',
+                                  'x= 0 ',
+                                  '#' * 85,
+                                  'y ',
+                                  'puts x'])
+      create_file('example2.rb', ['# encoding: utf-8',
+                                  "\tx = 0",
+                                  'puts x'])
+      expect(cli.run(['--format', 'clang', 'example1.rb', 'example2.rb']))
+        .to eq(1)
+      expect($stdout.string)
+        .to eq(['example1.rb:2:2: C: Surrounding space missing for operator ' +
+                "'='.",
+                'x= 0 ',
+                ' ^',
+                'example1.rb:2:5: C: Trailing whitespace detected.',
+                'x= 0 ',
+                '    ^',
+                'example1.rb:3:80: C: Line is too long. [85/79]',
+                '###########################################################' +
+                '##########################',
+                '                                                           ' +
+                '                    ^^^^^^',
+                'example1.rb:4:2: C: Trailing whitespace detected.',
+                'y ',
+                ' ^',
+                'example2.rb:2:1: C: Tab detected.',
+                "\tx = 0",
+                '^',
+                '',
+                '2 files inspected, 5 offences detected',
+                ''].join("\n"))
+    end
+
     it 'runs just one cop if --only is passed' do
       create_file('example.rb', ['if x== 0 ',
                                  "\ty",
@@ -182,12 +238,13 @@ module Rubocop
       # IfUnlessModifier depends on the configuration of LineLength.
       # That configuration might have been set by other spec examples
       # so we reset it to emulate a start from scratch.
-      Cop::LineLength.config = nil
+      Cop::Style::LineLength.config = nil
 
-      expect(cli.run(['--only', 'IfUnlessModifier', 'example.rb'])).to eq(1)
+      expect(cli.run(['--format', 'simple',
+                      '--only', 'IfUnlessModifier', 'example.rb'])).to eq(1)
       expect($stdout.string)
         .to eq(['== example.rb ==',
-                'C:  1: Favor modifier if/unless usage when you have a ' +
+                'C:  1:  1: Favor modifier if/unless usage when you have a ' +
                 'single-line body. Another good alternative is the usage of ' +
                 'control flow &&/||.',
                 '',
@@ -197,45 +254,48 @@ module Rubocop
 
     it 'exits with error if an incorrect cop name is passed to --only' do
       expect(cli.run(%w(--only 123))).to eq(1)
-      expect($stdout.string).to eq("Unrecognized cop name: 123.\n")
+      expect($stderr.string).to eq("Unrecognized cop name: 123.\n")
     end
 
     it 'ommits summary when --silent passed', ruby: 1.9 do
       create_file('example1.rb', 'puts 0 ')
       create_file('example2.rb', "\tputs 0")
-      expect(cli.run(['--emacs',
+      expect(cli.run(['--format',
+                      'emacs',
                       '--silent',
                       'example1.rb',
                       'example2.rb'])).to eq(1)
       expect($stdout.string).to eq(
-        ['example1.rb:1: C: Missing utf-8 encoding comment.',
-         'example1.rb:1: C: Trailing whitespace detected.',
-         'example2.rb:1: C: Missing utf-8 encoding comment.',
-         'example2.rb:1: C: Tab detected.',
+        ["#{abs('example1.rb')}:1:1: C: Missing utf-8 encoding comment.",
+         "#{abs('example1.rb')}:1:7: C: Trailing whitespace detected.",
+         "#{abs('example2.rb')}:1:1: C: Missing utf-8 encoding comment.",
+         "#{abs('example2.rb')}:1:1: C: Tab detected.",
          ''].join("\n"))
     end
 
     it 'ommits summary when --silent passed', ruby: 2.0 do
       create_file('example1.rb', 'puts 0 ')
       create_file('example2.rb', "\tputs 0")
-      expect(cli.run(['--emacs',
+      expect(cli.run(['--format',
+                      'emacs',
                       '--silent',
                       'example1.rb',
                       'example2.rb'])).to eq(1)
       expect($stdout.string).to eq(
-        ['example1.rb:1: C: Trailing whitespace detected.',
-         'example2.rb:1: C: Tab detected.',
+        ["#{abs('example1.rb')}:1:7: C: Trailing whitespace detected.",
+         "#{abs('example2.rb')}:1:1: C: Tab detected.",
          ''].join("\n"))
     end
 
     it 'shows cop names when --debug is passed', ruby: 2.0 do
       create_file('example1.rb', "\tputs 0")
-      expect(cli.run(['--emacs',
+      expect(cli.run(['--format',
+                      'emacs',
                       '--silent',
                       '--debug',
                       'example1.rb'])).to eq(1)
       expect($stdout.string.lines[-1]).to eq(
-        ['example1.rb:1: C: Tab: Tab detected.',
+        ["#{abs('example1.rb')}:1:1: C: Tab: Tab detected.",
          ''].join("\n"))
     end
 
@@ -248,10 +308,11 @@ module Rubocop
         'CaseIndentation:',
         '  Enabled: false'
       ])
-      expect(cli.run(['-c', 'rubocop.yml', 'example1.rb'])).to eq(1)
+      expect(cli.run(['--format', 'simple',
+                      '-c', 'rubocop.yml', 'example1.rb'])).to eq(1)
       expect($stdout.string).to eq(
         ['== example1.rb ==',
-         'C:  1: Trailing whitespace detected.',
+         'C:  1:  7: Trailing whitespace detected.',
          '',
          '1 file inspected, 1 offence detected',
          ''].join("\n"))
@@ -268,11 +329,13 @@ module Rubocop
         'LineLength:',
         '  Enabled: false'
       ])
-      result = cli.run(['-c', 'rubocop.yml', 'example1.rb'])
+      result = cli.run(['--format', 'simple',
+                        '-c', 'rubocop.yml', 'example1.rb'])
       expect($stdout.string).to eq(
         ['== example1.rb ==',
-         'C:  1: Favor modifier if/unless usage when you have a single-line ' +
-         'body. Another good alternative is the usage of control flow &&/||.',
+         'C:  1:  1: Favor modifier if/unless usage when you have a ' +
+         'single-line body. Another good alternative is the usage of ' +
+         'control flow &&/||.',
          '',
          '1 file inspected, 1 offence detected',
          ''].join("\n"))
@@ -288,10 +351,11 @@ module Rubocop
         'CaseIndentation:',
         '  Enabled: false'
       ])
-      expect(cli.run(['example_src/example1.rb'])).to eq(1)
+      expect(cli.run(['--format', 'simple',
+                      'example_src/example1.rb'])).to eq(1)
       expect($stdout.string).to eq(
         ['== example_src/example1.rb ==',
-         'C:  1: Trailing whitespace detected.',
+         'C:  1:  7: Trailing whitespace detected.',
          '',
          '1 file inspected, 1 offence detected',
          ''].join("\n"))
@@ -307,7 +371,8 @@ module Rubocop
         '  Enabled: true',
         '  Max: 100'
       ])
-      expect(cli.run(['example_src/example1.rb'])).to eq(0)
+      expect(cli.run(['--format', 'simple',
+                      'example_src/example1.rb'])).to eq(0)
       expect($stdout.string).to eq(
         ['', '1 file inspected, no offences detected',
          ''].join("\n"))
@@ -325,10 +390,10 @@ module Rubocop
         '  Enabled: true',
         '  Max: 100'
       ])
-      expect(cli.run(['example'])).to eq(1)
+      expect(cli.run(%w(--format simple example))).to eq(1)
       expect($stdout.string).to eq(
         ['== example/lib/example1.rb ==',
-         'C:  2: Line is too long. [90/79]',
+         'C:  2: 80: Line is too long. [90/79]',
          '',
          '2 files inspected, 1 offence detected',
          ''].join("\n"))
@@ -349,7 +414,8 @@ module Rubocop
         '  Enabled: true',
         '  Max: 80'
       ])
-      expect(cli.run(['example_src/example1.rb'])).to eq(0)
+      expect(cli.run(['--format', 'simple',
+                      'example_src/example1.rb'])).to eq(0)
       expect($stdout.string).to eq(
         ['', '1 file inspected, no offences detected',
          ''].join("\n"))
@@ -371,10 +437,10 @@ module Rubocop
         '    - tmp/spec/**'
       ])
 
-      expect(cli.run(['example'])).to eq(1)
+      expect(cli.run(%w(--format simple example))).to eq(1)
       expect($stdout.string).to eq(
         ['== example/tmp/test/example1.rb ==',
-         'C:  2: Line is too long. [90/79]',
+         'C:  2: 80: Line is too long. [90/79]',
          '',
          '1 file inspected, 1 offence detected',
          ''].join("\n"))
@@ -392,12 +458,12 @@ module Rubocop
         '  Max: 100'
       ])
 
-      expect(cli.run(['example'])).to eq(1)
+      expect(cli.run(%w(--format simple example))).to eq(1)
       expect($stdout.string).to eq(
         ['Warning: unrecognized cop LyneLenth found in ' +
          File.expand_path('example/.rubocop.yml'),
          '== example/example1.rb ==',
-         'C:  2: Line is too long. [90/79]',
+         'C:  2: 80: Line is too long. [90/79]',
          '',
          '1 file inspected, 1 offence detected',
          ''].join("\n"))
@@ -415,41 +481,52 @@ module Rubocop
         '  Min: 10'
       ])
 
-      expect(cli.run(['example'])).to eq(1)
+      expect(cli.run(%w(--format simple example))).to eq(1)
       expect($stdout.string).to eq(
         ['Warning: unrecognized parameter LineLength:Min found in ' +
          File.expand_path('example/.rubocop.yml'),
          '== example/example1.rb ==',
-         'C:  2: Line is too long. [90/79]',
+         'C:  2: 80: Line is too long. [90/79]',
          '',
          '1 file inspected, 1 offence detected',
          ''].join("\n"))
     end
 
     it 'registers an offence for a syntax error' do
-      pending
       create_file('example.rb', [
         '# encoding: utf-8',
         'class Test',
         'en'
       ])
-      expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
-      unexpected_part = RUBY_VERSION >= '2.0' ? 'end-of-input' : '$end'
-      expect($stdout.string).to eq(
-        ["example.rb:3: E: Syntax error, unexpected #{unexpected_part}, " +
-         'expecting keyword_end',
-         '',
-         '1 file inspected, 1 offence detected',
-         ''].join("\n"))
+      expect(cli.run(['--format', 'emacs', 'example.rb'])).to eq(1)
+      expect($stdout.string)
+        .to eq(["#{abs('example.rb')}:3:3: E: unexpected " +
+                'token $end',
+                '',
+                '1 file inspected, 1 offence detected',
+                ''].join("\n"))
+    end
+
+    it 'registers an offence for Parser warnings' do
+      create_file('example.rb', [
+                                 '# encoding: utf-8',
+                                 'puts *test'
+                                ])
+      expect(cli.run(['--format', 'emacs', 'example.rb'])).to eq(1)
+      expect($stdout.string)
+        .to eq(["#{abs('example.rb')}:2:6: W: " +
+                "`*' interpreted as argument prefix",
+                '',
+                '1 file inspected, 1 offence detected',
+                ''].join("\n"))
     end
 
     it 'can process a file with an invalid UTF-8 byte sequence' do
-      pending
       create_file('example.rb', [
         '# encoding: utf-8',
         "# #{'f9'.hex.chr}#{'29'.hex.chr}"
       ])
-      expect(cli.run(['--emacs', 'example.rb'])).to eq(0)
+      expect(cli.run(['--format', 'emacs', 'example.rb'])).to eq(0)
     end
 
     it 'can have all cops disabled in a code section' do
@@ -466,13 +543,13 @@ module Rubocop
         '  y("123")',
         'end'
       ])
-      expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
+      expect(cli.run(['--format', 'emacs', 'example.rb'])).to eq(1)
       # all cops were disabled, then 2 were enabled again, so we
       # should get 2 offences reported.
       expect($stdout.string).to eq(
-        ['example.rb:8: C: Line is too long. [95/79]',
-         "example.rb:10: C: Prefer single-quoted strings when you don't " +
-         'need string interpolation or special symbols.',
+        ["#{abs('example.rb')}:8:80: C: Line is too long. [95/79]",
+         "#{abs('example.rb')}:10:5: C: Prefer single-quoted strings when " +
+         "you don't need string interpolation or special symbols.",
          '',
          '1 file inspected, 2 offences detected',
          ''].join("\n"))
@@ -492,13 +569,13 @@ module Rubocop
         '  y("123")',
         'end'
       ])
-      expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
+      expect(cli.run(['--format', 'emacs', 'example.rb'])).to eq(1)
       # 3 cops were disabled, then 2 were enabled again, so we
       # should get 2 offences reported.
       expect($stdout.string).to eq(
-        ['example.rb:8: C: Line is too long. [95/79]',
-         "example.rb:10: C: Prefer single-quoted strings when you don't " +
-         'need string interpolation or special symbols.',
+        ["#{abs('example.rb')}:8:80: C: Line is too long. [95/79]",
+         "#{abs('example.rb')}:10:5: C: Prefer single-quoted strings when " +
+         "you don't need string interpolation or special symbols.",
          '',
          '1 file inspected, 2 offences detected',
          ''].join("\n"))
@@ -509,7 +586,7 @@ module Rubocop
         '# encoding: utf-8',
         'y("123", 123456) # rubocop:disable all'
       ])
-      expect(cli.run(['--emacs', 'example.rb'])).to eq(0)
+      expect(cli.run(['--format', 'emacs', 'example.rb'])).to eq(0)
       expect($stdout.string).to eq(
         ['',
          '1 file inspected, no offences detected',
@@ -523,9 +600,9 @@ module Rubocop
         '#' * 95,
         'y("123") # rubocop:disable LineLength,StringLiterals'
       ])
-      expect(cli.run(['--emacs', 'example.rb'])).to eq(1)
+      expect(cli.run(['--format', 'emacs', 'example.rb'])).to eq(1)
       expect($stdout.string).to eq(
-        ['example.rb:3: C: Line is too long. [95/79]',
+        ["#{abs('example.rb')}:3:80: C: Line is too long. [95/79]",
          '',
          '1 file inspected, 1 offence detected',
          ''].join("\n"))
@@ -538,9 +615,7 @@ module Rubocop
         'x = 0',
         'puts x'
       ])
-      # Need to pass an empty array explicitly
-      # so that the CLI does not refer arguments of `rspec`
-      expect(cli.run([])).to eq(0)
+      expect(cli.run(%w(--format simple))).to eq(0)
       expect($stdout.string).to eq(
         ['', '1 file inspected, no offences detected',
          ''].join("\n"))
@@ -563,9 +638,7 @@ module Rubocop
         '    - example',
         '    - !ruby/regexp /regexp$/'
       ])
-      # Need to pass an empty array explicitly
-      # so that the CLI does not refer arguments of `rspec`
-      expect(cli.run([])).to eq(0)
+      expect(cli.run(%w(--format simple))).to eq(0)
       expect($stdout.string).to eq(
         ['', '2 files inspected, no offences detected',
          ''].join("\n"))
@@ -595,37 +668,201 @@ module Rubocop
         '    - !ruby/regexp /regexp.rb$/',
         '    - "exclude_*"'
       ])
-      # Need to pass an empty array explicitly
-      # so that the CLI does not refer arguments of `rspec`
-      expect(cli.run([])).to eq(0)
+      expect(cli.run(%w(--format simple))).to eq(0)
+      expect($stdout.string).to eq(
+        ['', '0 files inspected, no offences detected',
+         ''].join("\n"))
+    end
+
+    # With rubinius 2.0.0.rc1 + rspec 2.13.1,
+    # File.stub(:open).and_call_original causes SystemStackError.
+    it 'does not read files in excluded list', broken: :rbx do
+      %w(rb.rb non-rb.ext without-ext).each do |filename|
+        create_file("example/ignored/#{filename}", [
+            '# encoding: utf-8',
+            '#' * 90
+        ])
+      end
+
+      create_file('example/.rubocop.yml', [
+          'AllCops:',
+          '  Excludes:',
+          '    - ignored/**',
+      ])
+      File.should_not_receive(:open).with(%r(/ignored/))
+      File.stub(:open).and_call_original
+      expect(cli.run(%w(--format simple example))).to eq(0)
       expect($stdout.string).to eq(
         ['', '0 files inspected, no offences detected',
          ''].join("\n"))
     end
 
-    describe '#display_summary' do
-      it 'handles pluralization correctly' do
-        cli.display_summary(0, 0, [])
-        expect($stdout.string).to eq(
-          "\n0 files inspected, no offences detected\n")
-        $stdout = StringIO.new
-        cli.display_summary(1, 0, [])
-        expect($stdout.string).to eq(
-          "\n1 file inspected, no offences detected\n")
-        $stdout = StringIO.new
-        cli.display_summary(1, 1, [])
-        expect($stdout.string).to eq(
-          "\n1 file inspected, 1 offence detected\n")
-        $stdout = StringIO.new
-        cli.display_summary(2, 2, [])
-        expect($stdout.string).to eq(
-          "\n2 files inspected, 2 offences detected\n")
+    describe '--require option' do
+      let(:required_file_path) { './path/to/required_file.rb' }
+
+      before do
+        create_file('example.rb', '# encoding: utf-8')
+
+        create_file(required_file_path, [
+          '# encoding: utf-8',
+          "puts 'Hello from required file!'"
+        ])
+      end
+
+      it 'requires the passed path' do
+        cli.run(['--require', required_file_path, 'example.rb'])
+        expect($stdout.string).to start_with('Hello from required file!')
+      end
+    end
+
+    describe '-f/--format option' do
+      let(:target_file) { 'example.rb' }
+
+      before do
+        create_file(target_file, [
+          '# encoding: utf-8',
+          '#' * 90
+        ])
       end
 
+      describe 'builtin formatters' do
+        context 'when simple format is specified' do
+          it 'outputs with simple format' do
+            cli.run(['--format', 'simple', 'example.rb'])
+            expect($stdout.string).to include([
+              "== #{target_file} ==",
+              'C:  2: 80: Line is too long. [90/79]'
+            ].join("\n"))
+          end
+        end
+
+        context 'when emacs format is specified' do
+          it 'outputs with emacs format' do
+            cli.run(['--format', 'emacs', 'example.rb'])
+            expect($stdout.string).to include(
+              "#{abs(target_file)}:2:80: C: Line is too long. [90/79]")
+          end
+        end
+
+        context 'when unknown format name is specified' do
+          it 'aborts with error message' do
+            expect { cli.run(['--format', 'unknown', 'example.rb']) }
+              .to exit_with_code(1)
+            expect($stderr.string)
+              .to include('No formatter for "unknown"')
+          end
+        end
+      end
+
+      describe 'custom formatter' do
+        let(:target_file) { abs('example.rb') }
+
+        context 'when a class name is specified' do
+          it 'uses the class as a formatter' do
+            module ::MyTool
+              class RubocopFormatter < Rubocop::Formatter::BaseFormatter
+                def started(all_files)
+                  output.puts "started: #{all_files.join(',')}"
+                end
+
+                def file_started(file, options)
+                  output.puts "file_started: #{file}"
+                end
+
+                def file_finished(file, offences)
+                  output.puts "file_finished: #{file}"
+                end
+
+                def finished(processed_files)
+                  output.puts "finished: #{processed_files.join(',')}"
+                end
+              end
+            end
+
+            cli.run(['--format', 'MyTool::RubocopFormatter', 'example.rb'])
+            expect($stdout.string).to eq([
+              "started: #{target_file}",
+              "file_started: #{target_file}",
+              "file_finished: #{target_file}",
+              "finished: #{target_file}",
+              ''
+            ].join("\n"))
+          end
+        end
+
+        context 'when unknown class name is specified' do
+          it 'aborts with error message' do
+            expect { cli.run(['--format', 'UnknownFormatter', 'example.rb']) }
+              .to exit_with_code(1)
+            expect($stderr.string).to include('UnknownFormatter')
+          end
+        end
+      end
+
+      it 'can be used multiple times' do
+        cli.run(['--format', 'simple', '--format', 'emacs', 'example.rb'])
+        expect($stdout.string).to include([
+          "== #{target_file} ==",
+          'C:  2: 80: Line is too long. [90/79]',
+          "#{abs(target_file)}:2:80: C: Line is too long. [90/79]"
+        ].join("\n"))
+      end
+    end
+
+    unless Rubocop::Version::STRING.start_with?('0')
+      describe '-e/--emacs option' do
+        it 'is dropped in RuboCop 1.0.0' do
+          # This spec can be removed once the option is dropped.
+          expect(cli.run(['--emacs'])).to eq(1)
+          expect($stderr.string).to include('invalid option: --emacs')
+        end
+      end
+    end
+
+    describe '-o/--out option' do
+      let(:target_file) { 'example.rb' }
+
+      before do
+        create_file(target_file, [
+          '# encoding: utf-8',
+          '#' * 90
+        ])
+      end
+
+      it 'redirects output to the specified file' do
+        cli.run(['--out', 'output.txt', target_file])
+        expect(File.read('output.txt')).to include('Line is too long.')
+      end
+
+      it 'is applied to the previously specified formatter' do
+        cli.run([
+          '--format', 'simple',
+          '--format', 'emacs', '--out', 'emacs_output.txt',
+          target_file
+        ])
+
+        expect($stdout.string).to eq([
+          "== #{target_file} ==",
+          'C:  2: 80: Line is too long. [90/79]',
+          '',
+          '1 file inspected, 1 offence detected',
+          ''
+        ].join("\n"))
+
+        expect(File.read('emacs_output.txt')).to eq([
+          "#{abs(target_file)}:2:80: C: Line is too long. [90/79]",
+          '',
+          '1 file inspected, 1 offence detected',
+          ''
+        ].join("\n"))
+      end
+    end
+
+    describe '#display_error_summary' do
       it 'displays an error message when errors are present' do
         msg = 'An error occurred while Encoding cop was inspecting file.rb.'
-        cli.display_summary(1, 1, [msg])
-        expect($stdout.string.lines.to_a[-4..-3])
+        cli.display_error_summary([msg])
+        expect($stdout.string.lines.to_a[-6..-5])
           .to eq(["1 error occurred:\n", "#{msg}\n"])
       end
     end