ridecharge-rubocop 0.0.1
Sign up to get free protection for your applications and to get access to all the features.
- checksums.yaml +7 -0
- data/.gitignore +22 -0
- data/.rspec +1 -0
- data/.travis.yml +14 -0
- data/CHANGELOG.md +0 -0
- data/Gemfile +4 -0
- data/LICENSE.txt +22 -0
- data/README.md +35 -0
- data/Rakefile +22 -0
- data/bin/ridecharge-rubocop +49 -0
- data/config/0default.yml +8 -0
- data/config/fleet-magic-todo.yml +380 -0
- data/config/rc-todo.yml +190 -0
- data/config/ridecharge-rubocop_todo.yml +73 -0
- data/config/rubocop/default.yml +308 -0
- data/config/rubocop/disabled.yml +9 -0
- data/config/rubocop/enabled.yml +648 -0
- data/config/standard-todo.yml +24 -0
- data/config/tabs.yml +15 -0
- data/config/vehicle-todo.yml +195 -0
- data/lib/ridecharge/rubocop.rb +2 -0
- data/lib/ridecharge/rubocop/version.rb +5 -0
- data/lib/rubocop/config_loader_monkeypatch.rb +117 -0
- data/lib/rubocop/ridecharge.rb +1 -0
- data/ridecharge-rubocop.gemspec +25 -0
- data/spec/isolated_environment_spec.rb +24 -0
- data/spec/project_spec.rb +118 -0
- data/spec/rubocop/cli_spec.rb +1385 -0
- data/spec/rubocop/config_loader_spec.rb +328 -0
- data/spec/rubocop/config_spec.rb +179 -0
- data/spec/rubocop/config_store_spec.rb +53 -0
- data/spec/rubocop/cop/commissioner_spec.rb +83 -0
- data/spec/rubocop/cop/cop_spec.rb +114 -0
- data/spec/rubocop/cop/corrector_spec.rb +59 -0
- data/spec/rubocop/cop/lint/ambiguous_operator_spec.rb +113 -0
- data/spec/rubocop/cop/lint/ambiguous_regexp_literal_spec.rb +35 -0
- data/spec/rubocop/cop/lint/assignment_in_condition_spec.rb +107 -0
- data/spec/rubocop/cop/lint/block_alignment_spec.rb +411 -0
- data/spec/rubocop/cop/lint/condition_position_spec.rb +49 -0
- data/spec/rubocop/cop/lint/debugger_spec.rb +39 -0
- data/spec/rubocop/cop/lint/else_layout_spec.rb +65 -0
- data/spec/rubocop/cop/lint/empty_ensure_spec.rb +27 -0
- data/spec/rubocop/cop/lint/end_alignment_spec.rb +136 -0
- data/spec/rubocop/cop/lint/end_in_method_spec.rb +29 -0
- data/spec/rubocop/cop/lint/ensure_return_spec.rb +39 -0
- data/spec/rubocop/cop/lint/eval_spec.rb +35 -0
- data/spec/rubocop/cop/lint/handle_exceptions_spec.rb +30 -0
- data/spec/rubocop/cop/lint/invalid_character_literal_spec.rb +33 -0
- data/spec/rubocop/cop/lint/literal_in_condition_spec.rb +63 -0
- data/spec/rubocop/cop/lint/loop_spec.rb +27 -0
- data/spec/rubocop/cop/lint/parentheses_as_grouped_expression_spec.rb +57 -0
- data/spec/rubocop/cop/lint/require_parentheses_spec.rb +82 -0
- data/spec/rubocop/cop/lint/rescue_exception_spec.rb +131 -0
- data/spec/rubocop/cop/lint/shadowing_outer_local_variable_spec.rb +237 -0
- data/spec/rubocop/cop/lint/syntax_spec.rb +34 -0
- data/spec/rubocop/cop/lint/unreachable_code_spec.rb +63 -0
- data/spec/rubocop/cop/lint/useless_assignment_spec.rb +1570 -0
- data/spec/rubocop/cop/lint/useless_comparison_spec.rb +30 -0
- data/spec/rubocop/cop/lint/useless_else_without_rescue_spec.rb +48 -0
- data/spec/rubocop/cop/lint/useless_setter_call_spec.rb +149 -0
- data/spec/rubocop/cop/lint/void_spec.rb +57 -0
- data/spec/rubocop/cop/offence_spec.rb +133 -0
- data/spec/rubocop/cop/rails/default_scope_spec.rb +37 -0
- data/spec/rubocop/cop/rails/has_and_belongs_to_many_spec.rb +13 -0
- data/spec/rubocop/cop/rails/output_spec.rb +41 -0
- data/spec/rubocop/cop/rails/read_attribute_spec.rb +13 -0
- data/spec/rubocop/cop/rails/validation_spec.rb +21 -0
- data/spec/rubocop/cop/style/access_modifier_indentation_spec.rb +361 -0
- data/spec/rubocop/cop/style/accessor_method_name_spec.rb +81 -0
- data/spec/rubocop/cop/style/alias_spec.rb +59 -0
- data/spec/rubocop/cop/style/align_array_spec.rb +75 -0
- data/spec/rubocop/cop/style/align_hash_spec.rb +310 -0
- data/spec/rubocop/cop/style/align_parameters_spec.rb +222 -0
- data/spec/rubocop/cop/style/and_or_spec.rb +57 -0
- data/spec/rubocop/cop/style/ascii_comments_spec.rb +22 -0
- data/spec/rubocop/cop/style/ascii_identifiers_spec.rb +36 -0
- data/spec/rubocop/cop/style/attr_spec.rb +19 -0
- data/spec/rubocop/cop/style/begin_block_spec.rb +13 -0
- data/spec/rubocop/cop/style/block_comments_spec.rb +21 -0
- data/spec/rubocop/cop/style/block_nesting_spec.rb +156 -0
- data/spec/rubocop/cop/style/blocks_spec.rb +99 -0
- data/spec/rubocop/cop/style/braces_around_hash_parameters_spec.rb +284 -0
- data/spec/rubocop/cop/style/case_equality_spec.rb +12 -0
- data/spec/rubocop/cop/style/case_indentation_spec.rb +289 -0
- data/spec/rubocop/cop/style/character_literal_spec.rb +37 -0
- data/spec/rubocop/cop/style/class_and_module_camel_case_spec.rb +40 -0
- data/spec/rubocop/cop/style/class_length_spec.rb +131 -0
- data/spec/rubocop/cop/style/class_methods_spec.rb +45 -0
- data/spec/rubocop/cop/style/class_vars_spec.rb +19 -0
- data/spec/rubocop/cop/style/collection_methods_spec.rb +48 -0
- data/spec/rubocop/cop/style/colon_method_call_spec.rb +60 -0
- data/spec/rubocop/cop/style/comment_annotation_spec.rb +86 -0
- data/spec/rubocop/cop/style/constant_name_spec.rb +65 -0
- data/spec/rubocop/cop/style/cyclomatic_complexity_spec.rb +204 -0
- data/spec/rubocop/cop/style/def_with_parentheses_spec.rb +39 -0
- data/spec/rubocop/cop/style/documentation_spec.rb +123 -0
- data/spec/rubocop/cop/style/dot_position_spec.rb +94 -0
- data/spec/rubocop/cop/style/empty_line_between_defs_spec.rb +127 -0
- data/spec/rubocop/cop/style/empty_lines_around_access_modifier_spec.rb +56 -0
- data/spec/rubocop/cop/style/empty_lines_around_body_spec.rb +131 -0
- data/spec/rubocop/cop/style/empty_lines_spec.rb +40 -0
- data/spec/rubocop/cop/style/empty_literal_spec.rb +100 -0
- data/spec/rubocop/cop/style/encoding_spec.rb +56 -0
- data/spec/rubocop/cop/style/end_block_spec.rb +13 -0
- data/spec/rubocop/cop/style/end_of_line_spec.rb +47 -0
- data/spec/rubocop/cop/style/even_odd_spec.rb +75 -0
- data/spec/rubocop/cop/style/favor_join_spec.rb +31 -0
- data/spec/rubocop/cop/style/favor_sprintf_spec.rb +47 -0
- data/spec/rubocop/cop/style/favor_unless_over_negated_if_spec.rb +76 -0
- data/spec/rubocop/cop/style/favor_until_over_negated_while_spec.rb +41 -0
- data/spec/rubocop/cop/style/final_newline_spec.rb +30 -0
- data/spec/rubocop/cop/style/flip_flop_spec.rb +23 -0
- data/spec/rubocop/cop/style/for_spec.rb +105 -0
- data/spec/rubocop/cop/style/global_vars_spec.rb +34 -0
- data/spec/rubocop/cop/style/hash_methods_spec.rb +45 -0
- data/spec/rubocop/cop/style/hash_syntax_spec.rb +131 -0
- data/spec/rubocop/cop/style/if_unless_modifier_spec.rb +128 -0
- data/spec/rubocop/cop/style/if_with_semicolon_spec.rb +19 -0
- data/spec/rubocop/cop/style/indentation_consistency_spec.rb +490 -0
- data/spec/rubocop/cop/style/indentation_width_spec.rb +470 -0
- data/spec/rubocop/cop/style/lambda_call_spec.rb +65 -0
- data/spec/rubocop/cop/style/lambda_spec.rb +41 -0
- data/spec/rubocop/cop/style/leading_comment_space_spec.rb +64 -0
- data/spec/rubocop/cop/style/line_end_concatenation_spec.rb +34 -0
- data/spec/rubocop/cop/style/line_length_spec.rb +20 -0
- data/spec/rubocop/cop/style/method_call_parentheses_spec.rb +59 -0
- data/spec/rubocop/cop/style/method_called_on_do_end_block_spec.rb +60 -0
- data/spec/rubocop/cop/style/method_def_parentheses_spec.rb +106 -0
- data/spec/rubocop/cop/style/method_length_spec.rb +147 -0
- data/spec/rubocop/cop/style/method_name_spec.rb +125 -0
- data/spec/rubocop/cop/style/module_function_spec.rb +24 -0
- data/spec/rubocop/cop/style/multiline_block_chain_spec.rb +78 -0
- data/spec/rubocop/cop/style/multiline_if_then_spec.rb +107 -0
- data/spec/rubocop/cop/style/multiline_ternary_operator_spec.rb +18 -0
- data/spec/rubocop/cop/style/nested_ternary_operator_spec.rb +21 -0
- data/spec/rubocop/cop/style/nil_comparison_spec.rb +30 -0
- data/spec/rubocop/cop/style/not_spec.rb +22 -0
- data/spec/rubocop/cop/style/numeric_literals_spec.rb +64 -0
- data/spec/rubocop/cop/style/one_line_conditional_spec.rb +13 -0
- data/spec/rubocop/cop/style/op_method_spec.rb +74 -0
- data/spec/rubocop/cop/style/parameter_lists_spec.rb +44 -0
- data/spec/rubocop/cop/style/parentheses_around_condition_spec.rb +122 -0
- data/spec/rubocop/cop/style/perl_backrefs_spec.rb +17 -0
- data/spec/rubocop/cop/style/predicate_name_spec.rb +25 -0
- data/spec/rubocop/cop/style/proc_spec.rb +27 -0
- data/spec/rubocop/cop/style/raise_args_spec.rb +82 -0
- data/spec/rubocop/cop/style/redundant_begin_spec.rb +57 -0
- data/spec/rubocop/cop/style/redundant_exception_spec.rb +27 -0
- data/spec/rubocop/cop/style/redundant_return_spec.rb +171 -0
- data/spec/rubocop/cop/style/redundant_self_spec.rb +142 -0
- data/spec/rubocop/cop/style/regexp_literal_spec.rb +83 -0
- data/spec/rubocop/cop/style/rescue_modifier_spec.rb +116 -0
- data/spec/rubocop/cop/style/semicolon_spec.rb +100 -0
- data/spec/rubocop/cop/style/signal_exception_spec.rb +266 -0
- data/spec/rubocop/cop/style/single_line_block_params_spec.rb +68 -0
- data/spec/rubocop/cop/style/single_line_methods_spec.rb +52 -0
- data/spec/rubocop/cop/style/space_after_colon_spec.rb +38 -0
- data/spec/rubocop/cop/style/space_after_comma_spec.rb +30 -0
- data/spec/rubocop/cop/style/space_after_control_keyword_spec.rb +84 -0
- data/spec/rubocop/cop/style/space_after_method_name_spec.rb +70 -0
- data/spec/rubocop/cop/style/space_after_not_spec.rb +22 -0
- data/spec/rubocop/cop/style/space_after_semicolon_spec.rb +23 -0
- data/spec/rubocop/cop/style/space_around_block_braces_spec.rb +283 -0
- data/spec/rubocop/cop/style/space_around_equals_in_parameter_default_spec.rb +33 -0
- data/spec/rubocop/cop/style/space_around_operators_spec.rb +325 -0
- data/spec/rubocop/cop/style/space_before_modifier_keyword_spec.rb +70 -0
- data/spec/rubocop/cop/style/space_inside_brackets_spec.rb +52 -0
- data/spec/rubocop/cop/style/space_inside_hash_literal_braces_spec.rb +138 -0
- data/spec/rubocop/cop/style/space_inside_parens_spec.rb +34 -0
- data/spec/rubocop/cop/style/special_global_vars_spec.rb +56 -0
- data/spec/rubocop/cop/style/string_literals_spec.rb +212 -0
- data/spec/rubocop/cop/style/symbol_array_spec.rb +37 -0
- data/spec/rubocop/cop/style/tab_spec.rb +17 -0
- data/spec/rubocop/cop/style/trailing_blank_lines_spec.rb +43 -0
- data/spec/rubocop/cop/style/trailing_comma_spec.rb +230 -0
- data/spec/rubocop/cop/style/trailing_whitespace_spec.rb +30 -0
- data/spec/rubocop/cop/style/trivial_accessors_spec.rb +415 -0
- data/spec/rubocop/cop/style/unless_else_spec.rb +25 -0
- data/spec/rubocop/cop/style/variable_interpolation_spec.rb +47 -0
- data/spec/rubocop/cop/style/variable_name_spec.rb +107 -0
- data/spec/rubocop/cop/style/when_then_spec.rb +41 -0
- data/spec/rubocop/cop/style/while_until_do_spec.rb +53 -0
- data/spec/rubocop/cop/style/while_until_modifier_spec.rb +75 -0
- data/spec/rubocop/cop/style/word_array_spec.rb +97 -0
- data/spec/rubocop/cop/team_spec.rb +156 -0
- data/spec/rubocop/cop/util_spec.rb +49 -0
- data/spec/rubocop/cop/variable_inspector/assignment_spec.rb +213 -0
- data/spec/rubocop/cop/variable_inspector/locatable_spec.rb +734 -0
- data/spec/rubocop/cop/variable_inspector/scope_spec.rb +184 -0
- data/spec/rubocop/cop/variable_inspector/variable_spec.rb +73 -0
- data/spec/rubocop/cop/variable_inspector/variable_table_spec.rb +269 -0
- data/spec/rubocop/cop/variable_inspector_spec.rb +29 -0
- data/spec/rubocop/file_inspector_spec.rb +78 -0
- data/spec/rubocop/formatter/base_formatter_spec.rb +191 -0
- data/spec/rubocop/formatter/clang_style_formatter_spec.rb +114 -0
- data/spec/rubocop/formatter/colorizable_spec.rb +107 -0
- data/spec/rubocop/formatter/disabled_config_formatter_spec.rb +50 -0
- data/spec/rubocop/formatter/emacs_style_formatter_spec.rb +62 -0
- data/spec/rubocop/formatter/file_list_formatter_spec.rb +33 -0
- data/spec/rubocop/formatter/formatter_set_spec.rb +132 -0
- data/spec/rubocop/formatter/json_formatter_spec.rb +148 -0
- data/spec/rubocop/formatter/offence_count_formatter_spec.rb +52 -0
- data/spec/rubocop/formatter/progress_formatter_spec.rb +182 -0
- data/spec/rubocop/formatter/simple_text_formatter_spec.rb +123 -0
- data/spec/rubocop/options_spec.rb +145 -0
- data/spec/rubocop/path_util_spec.rb +42 -0
- data/spec/rubocop/processed_source_spec.rb +114 -0
- data/spec/rubocop/source_parser_spec.rb +139 -0
- data/spec/rubocop/target_finder_spec.rb +180 -0
- data/spec/rubocop/token_spec.rb +25 -0
- data/spec/spec_helper.rb +136 -0
- data/spec/support/ast_helper.rb +15 -0
- data/spec/support/file_helper.rb +21 -0
- data/spec/support/isolated_environment.rb +34 -0
- data/spec/support/mri_syntax_checker.rb +73 -0
- data/spec/support/shared_context.rb +22 -0
- data/spec/support/shared_examples.rb +33 -0
- data/spec/support/statement_modifier_helper.rb +41 -0
- metadata +511 -0
@@ -0,0 +1,490 @@
|
|
1
|
+
# encoding: utf-8
|
2
|
+
|
3
|
+
require 'spec_helper'
|
4
|
+
|
5
|
+
describe Rubocop::Cop::Style::IndentationConsistency do
|
6
|
+
subject(:cop) { described_class.new }
|
7
|
+
|
8
|
+
context 'with if statement' do
|
9
|
+
it 'registers an offence for bad indentation in an if body' do
|
10
|
+
inspect_source(cop,
|
11
|
+
['if cond',
|
12
|
+
' func',
|
13
|
+
' func',
|
14
|
+
'end'])
|
15
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
16
|
+
end
|
17
|
+
|
18
|
+
it 'registers an offence for bad indentation in an else body' do
|
19
|
+
inspect_source(cop,
|
20
|
+
['if cond',
|
21
|
+
' func1',
|
22
|
+
'else',
|
23
|
+
' func2',
|
24
|
+
' func2',
|
25
|
+
'end'])
|
26
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
27
|
+
end
|
28
|
+
|
29
|
+
it 'registers an offence for bad indentation in an elsif body' do
|
30
|
+
inspect_source(cop,
|
31
|
+
['if a1',
|
32
|
+
' b1',
|
33
|
+
'elsif a2',
|
34
|
+
' b2',
|
35
|
+
'b3',
|
36
|
+
'else',
|
37
|
+
' c',
|
38
|
+
'end'])
|
39
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
40
|
+
end
|
41
|
+
|
42
|
+
it 'accepts a one line if statement' do
|
43
|
+
inspect_source(cop,
|
44
|
+
['if cond then func1 else func2 end'])
|
45
|
+
expect(cop.offences).to be_empty
|
46
|
+
end
|
47
|
+
|
48
|
+
it 'accepts a correctly aligned if/elsif/else/end' do
|
49
|
+
inspect_source(cop,
|
50
|
+
['if a1',
|
51
|
+
' b1',
|
52
|
+
'elsif a2',
|
53
|
+
' b2',
|
54
|
+
'else',
|
55
|
+
' c',
|
56
|
+
'end'])
|
57
|
+
expect(cop.offences).to be_empty
|
58
|
+
end
|
59
|
+
|
60
|
+
it 'accepts if/elsif/else/end laid out as a table' do
|
61
|
+
inspect_source(cop,
|
62
|
+
['if @io == $stdout then str << "$stdout"',
|
63
|
+
'elsif @io == $stdin then str << "$stdin"',
|
64
|
+
'elsif @io == $stderr then str << "$stderr"',
|
65
|
+
'else str << @io.class.to_s',
|
66
|
+
'end'])
|
67
|
+
expect(cop.offences).to be_empty
|
68
|
+
end
|
69
|
+
|
70
|
+
it 'accepts if/then/else/end laid out as another table' do
|
71
|
+
inspect_source(cop,
|
72
|
+
["if File.exist?('config.save')",
|
73
|
+
'then ConfigTable.load',
|
74
|
+
'else ConfigTable.new',
|
75
|
+
'end'])
|
76
|
+
expect(cop.offences).to be_empty
|
77
|
+
end
|
78
|
+
|
79
|
+
it 'accepts an empty if' do
|
80
|
+
inspect_source(cop,
|
81
|
+
['if a',
|
82
|
+
'else',
|
83
|
+
'end'])
|
84
|
+
expect(cop.offences).to be_empty
|
85
|
+
end
|
86
|
+
|
87
|
+
it 'accepts an if in assignment with end aligned with variable' do
|
88
|
+
inspect_source(cop,
|
89
|
+
['var = if a',
|
90
|
+
' 0',
|
91
|
+
'end',
|
92
|
+
'@var = if a',
|
93
|
+
' 0',
|
94
|
+
'end',
|
95
|
+
'$var = if a',
|
96
|
+
' 0',
|
97
|
+
'end',
|
98
|
+
'var ||= if a',
|
99
|
+
' 0',
|
100
|
+
'end',
|
101
|
+
'var &&= if a',
|
102
|
+
' 0',
|
103
|
+
'end',
|
104
|
+
'var -= if a',
|
105
|
+
' 0',
|
106
|
+
'end',
|
107
|
+
'VAR = if a',
|
108
|
+
' 0',
|
109
|
+
'end'])
|
110
|
+
expect(cop.offences).to be_empty
|
111
|
+
end
|
112
|
+
|
113
|
+
it 'accepts an if/else in assignment with end aligned with variable' do
|
114
|
+
inspect_source(cop,
|
115
|
+
['var = if a',
|
116
|
+
' 0',
|
117
|
+
'else',
|
118
|
+
' 1',
|
119
|
+
'end'])
|
120
|
+
expect(cop.offences).to be_empty
|
121
|
+
end
|
122
|
+
|
123
|
+
it 'accepts an if/else in assignment with end aligned with variable ' \
|
124
|
+
'and chaining after the end' do
|
125
|
+
inspect_source(cop,
|
126
|
+
['var = if a',
|
127
|
+
' 0',
|
128
|
+
'else',
|
129
|
+
' 1',
|
130
|
+
'end.abc.join("")'])
|
131
|
+
expect(cop.offences).to be_empty
|
132
|
+
end
|
133
|
+
|
134
|
+
it 'accepts an if/else in assignment with end aligned with variable ' \
|
135
|
+
'and chaining with a block after the end' do
|
136
|
+
inspect_source(cop,
|
137
|
+
['var = if a',
|
138
|
+
' 0',
|
139
|
+
'else',
|
140
|
+
' 1',
|
141
|
+
'end.abc.tap {}'])
|
142
|
+
expect(cop.offences).to be_empty
|
143
|
+
end
|
144
|
+
|
145
|
+
it 'accepts an if in assignment with end aligned with if' do
|
146
|
+
inspect_source(cop,
|
147
|
+
['var = if a',
|
148
|
+
' 0',
|
149
|
+
' end'])
|
150
|
+
expect(cop.offences).to be_empty
|
151
|
+
end
|
152
|
+
|
153
|
+
it 'accepts an if/else in assignment with end aligned with if' do
|
154
|
+
inspect_source(cop,
|
155
|
+
['var = if a',
|
156
|
+
' 0',
|
157
|
+
' else',
|
158
|
+
' 1',
|
159
|
+
' end'])
|
160
|
+
expect(cop.offences).to be_empty
|
161
|
+
end
|
162
|
+
|
163
|
+
it 'accepts an if/else in assignment on next line with end aligned ' \
|
164
|
+
'with if' do
|
165
|
+
inspect_source(cop,
|
166
|
+
['var =',
|
167
|
+
' if a',
|
168
|
+
' 0',
|
169
|
+
' else',
|
170
|
+
' 1',
|
171
|
+
' end'])
|
172
|
+
expect(cop.offences).to be_empty
|
173
|
+
end
|
174
|
+
|
175
|
+
it 'accepts an if/else branches with rescue clauses' do
|
176
|
+
# Because of how the rescue clauses come out of Parser, these are
|
177
|
+
# special and need to be tested.
|
178
|
+
inspect_source(cop,
|
179
|
+
['if a',
|
180
|
+
' a rescue nil',
|
181
|
+
'else',
|
182
|
+
' a rescue nil',
|
183
|
+
'end'])
|
184
|
+
expect(cop.offences).to be_empty
|
185
|
+
end
|
186
|
+
end
|
187
|
+
|
188
|
+
context 'with unless' do
|
189
|
+
it 'registers an offence for bad indentation in an unless body' do
|
190
|
+
inspect_source(cop,
|
191
|
+
['unless cond',
|
192
|
+
' func',
|
193
|
+
' func',
|
194
|
+
'end'])
|
195
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
196
|
+
end
|
197
|
+
|
198
|
+
it 'accepts an empty unless' do
|
199
|
+
inspect_source(cop,
|
200
|
+
['unless a',
|
201
|
+
'else',
|
202
|
+
'end'])
|
203
|
+
expect(cop.offences).to be_empty
|
204
|
+
end
|
205
|
+
end
|
206
|
+
|
207
|
+
context 'with case' do
|
208
|
+
it 'registers an offence for bad indentation in a case/when body' do
|
209
|
+
inspect_source(cop,
|
210
|
+
['case a',
|
211
|
+
'when b',
|
212
|
+
' c',
|
213
|
+
' d',
|
214
|
+
'end'])
|
215
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
216
|
+
end
|
217
|
+
|
218
|
+
it 'registers an offence for bad indentation in a case/else body' do
|
219
|
+
inspect_source(cop,
|
220
|
+
['case a',
|
221
|
+
'when b',
|
222
|
+
' c',
|
223
|
+
'when d',
|
224
|
+
' e',
|
225
|
+
'else',
|
226
|
+
' f',
|
227
|
+
' g',
|
228
|
+
'end'])
|
229
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
230
|
+
end
|
231
|
+
|
232
|
+
it 'accepts correctly indented case/when/else' do
|
233
|
+
inspect_source(cop,
|
234
|
+
['case a',
|
235
|
+
'when b',
|
236
|
+
' c',
|
237
|
+
' c',
|
238
|
+
'when d',
|
239
|
+
'else',
|
240
|
+
' f',
|
241
|
+
'end'])
|
242
|
+
expect(cop.offences).to be_empty
|
243
|
+
end
|
244
|
+
|
245
|
+
it 'accepts case/when/else laid out as a table' do
|
246
|
+
inspect_source(cop,
|
247
|
+
['case sexp.loc.keyword.source',
|
248
|
+
"when 'if' then cond, body, _else = *sexp",
|
249
|
+
"when 'unless' then cond, _else, body = *sexp",
|
250
|
+
'else cond, body = *sexp',
|
251
|
+
'end'])
|
252
|
+
expect(cop.offences).to be_empty
|
253
|
+
end
|
254
|
+
|
255
|
+
it 'accepts case/when/else with then beginning a line' do
|
256
|
+
inspect_source(cop,
|
257
|
+
['case sexp.loc.keyword.source',
|
258
|
+
"when 'if'",
|
259
|
+
'then cond, body, _else = *sexp',
|
260
|
+
'end'])
|
261
|
+
expect(cop.offences).to be_empty
|
262
|
+
end
|
263
|
+
|
264
|
+
it 'accepts indented when/else plus indented body' do
|
265
|
+
# "Indent when as deep as case" is the job of another cop.
|
266
|
+
inspect_source(cop,
|
267
|
+
['case code_type',
|
268
|
+
" when 'ruby', 'sql', 'plain'",
|
269
|
+
' code_type',
|
270
|
+
" when 'erb'",
|
271
|
+
" 'ruby; html-script: true'",
|
272
|
+
' when "html"',
|
273
|
+
" 'xml'",
|
274
|
+
' else',
|
275
|
+
" 'plain'",
|
276
|
+
'end'])
|
277
|
+
expect(cop.offences).to be_empty
|
278
|
+
end
|
279
|
+
end
|
280
|
+
|
281
|
+
context 'with while/until' do
|
282
|
+
it 'registers an offence for bad indentation in a while body' do
|
283
|
+
inspect_source(cop,
|
284
|
+
['while cond',
|
285
|
+
' func',
|
286
|
+
' func',
|
287
|
+
'end'])
|
288
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
289
|
+
end
|
290
|
+
|
291
|
+
it 'registers an offence for bad indentation in begin/end/while' do
|
292
|
+
inspect_source(cop,
|
293
|
+
['something = begin',
|
294
|
+
' func1',
|
295
|
+
' func2',
|
296
|
+
'end while cond'])
|
297
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
298
|
+
end
|
299
|
+
|
300
|
+
it 'registers an offence for bad indentation in an until body' do
|
301
|
+
inspect_source(cop,
|
302
|
+
['until cond',
|
303
|
+
' func',
|
304
|
+
' func',
|
305
|
+
'end'])
|
306
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
307
|
+
end
|
308
|
+
|
309
|
+
it 'accepts an empty while' do
|
310
|
+
inspect_source(cop,
|
311
|
+
['while a',
|
312
|
+
'end'])
|
313
|
+
expect(cop.offences).to be_empty
|
314
|
+
end
|
315
|
+
end
|
316
|
+
|
317
|
+
context 'with for' do
|
318
|
+
it 'registers an offence for bad indentation in a for body' do
|
319
|
+
inspect_source(cop,
|
320
|
+
['for var in 1..10',
|
321
|
+
' func',
|
322
|
+
'func',
|
323
|
+
'end'])
|
324
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
325
|
+
end
|
326
|
+
|
327
|
+
it 'accepts an empty for' do
|
328
|
+
inspect_source(cop,
|
329
|
+
['for var in 1..10',
|
330
|
+
'end'])
|
331
|
+
expect(cop.offences).to be_empty
|
332
|
+
end
|
333
|
+
end
|
334
|
+
|
335
|
+
context 'with def/defs' do
|
336
|
+
it 'registers an offence for bad indentation in a def body' do
|
337
|
+
inspect_source(cop,
|
338
|
+
['def test',
|
339
|
+
' func1',
|
340
|
+
' func2',
|
341
|
+
'end'])
|
342
|
+
expect(cop.messages)
|
343
|
+
.to eq(['Inconsistent indentation detected.'])
|
344
|
+
end
|
345
|
+
|
346
|
+
it 'registers an offence for bad indentation in a defs body' do
|
347
|
+
inspect_source(cop,
|
348
|
+
['def self.test',
|
349
|
+
' func',
|
350
|
+
' func',
|
351
|
+
'end'])
|
352
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
353
|
+
end
|
354
|
+
|
355
|
+
it 'accepts an empty def body' do
|
356
|
+
inspect_source(cop,
|
357
|
+
['def test',
|
358
|
+
'end'])
|
359
|
+
expect(cop.offences).to be_empty
|
360
|
+
end
|
361
|
+
|
362
|
+
it 'accepts an empty defs body' do
|
363
|
+
inspect_source(cop,
|
364
|
+
['def self.test',
|
365
|
+
'end'])
|
366
|
+
expect(cop.offences).to be_empty
|
367
|
+
end
|
368
|
+
end
|
369
|
+
|
370
|
+
context 'with class' do
|
371
|
+
it 'registers an offence for bad indentation in a class body' do
|
372
|
+
inspect_source(cop,
|
373
|
+
['class Test',
|
374
|
+
' def func1',
|
375
|
+
' end',
|
376
|
+
' def func2',
|
377
|
+
' end',
|
378
|
+
'end'])
|
379
|
+
expect(cop.messages)
|
380
|
+
.to eq(['Inconsistent indentation detected.'])
|
381
|
+
end
|
382
|
+
|
383
|
+
it 'accepts an empty class body' do
|
384
|
+
inspect_source(cop,
|
385
|
+
['class Test',
|
386
|
+
'end'])
|
387
|
+
expect(cop.offences).to be_empty
|
388
|
+
end
|
389
|
+
|
390
|
+
it 'accepts indented public, protected, and private' do
|
391
|
+
inspect_source(cop,
|
392
|
+
['class Test',
|
393
|
+
' public',
|
394
|
+
'',
|
395
|
+
' def e',
|
396
|
+
' end',
|
397
|
+
'',
|
398
|
+
' protected',
|
399
|
+
'',
|
400
|
+
' def f',
|
401
|
+
' end',
|
402
|
+
'',
|
403
|
+
' private',
|
404
|
+
'',
|
405
|
+
' def g',
|
406
|
+
' end',
|
407
|
+
'end'])
|
408
|
+
expect(cop.offences).to be_empty
|
409
|
+
end
|
410
|
+
|
411
|
+
it 'registers an offence for bad indentation in def but not for ' \
|
412
|
+
'outdented public, protected, and private' do
|
413
|
+
inspect_source(cop,
|
414
|
+
['class Test',
|
415
|
+
'public',
|
416
|
+
'',
|
417
|
+
' def e',
|
418
|
+
' end',
|
419
|
+
'',
|
420
|
+
'protected',
|
421
|
+
'',
|
422
|
+
' def f',
|
423
|
+
' end',
|
424
|
+
'',
|
425
|
+
'private',
|
426
|
+
'',
|
427
|
+
' def g',
|
428
|
+
' end',
|
429
|
+
'end'])
|
430
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
431
|
+
expect(cop.highlights).to eq([' '])
|
432
|
+
end
|
433
|
+
end
|
434
|
+
|
435
|
+
context 'with module' do
|
436
|
+
it 'registers an offence for bad indentation in a module body' do
|
437
|
+
inspect_source(cop,
|
438
|
+
['module Test',
|
439
|
+
' def func1',
|
440
|
+
' end',
|
441
|
+
' def func2',
|
442
|
+
' end',
|
443
|
+
'end'])
|
444
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
445
|
+
end
|
446
|
+
|
447
|
+
it 'accepts an empty module body' do
|
448
|
+
inspect_source(cop,
|
449
|
+
['module Test',
|
450
|
+
'end'])
|
451
|
+
expect(cop.offences).to be_empty
|
452
|
+
end
|
453
|
+
end
|
454
|
+
|
455
|
+
context 'with block' do
|
456
|
+
it 'registers an offence for bad indentation in a do/end body' do
|
457
|
+
inspect_source(cop,
|
458
|
+
['a = func do',
|
459
|
+
' b',
|
460
|
+
' c',
|
461
|
+
'end'])
|
462
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
463
|
+
end
|
464
|
+
|
465
|
+
it 'registers an offence for bad indentation in a {} body' do
|
466
|
+
inspect_source(cop,
|
467
|
+
['func {',
|
468
|
+
' b',
|
469
|
+
' c',
|
470
|
+
'}'])
|
471
|
+
expect(cop.messages).to eq(['Inconsistent indentation detected.'])
|
472
|
+
end
|
473
|
+
|
474
|
+
it 'accepts a correctly indented block body' do
|
475
|
+
inspect_source(cop,
|
476
|
+
['a = func do',
|
477
|
+
' b',
|
478
|
+
' c',
|
479
|
+
'end'])
|
480
|
+
expect(cop.offences).to be_empty
|
481
|
+
end
|
482
|
+
|
483
|
+
it 'accepts an empty block body' do
|
484
|
+
inspect_source(cop,
|
485
|
+
['a = func do',
|
486
|
+
'end'])
|
487
|
+
expect(cop.offences).to be_empty
|
488
|
+
end
|
489
|
+
end
|
490
|
+
end
|