ridecharge-rubocop 0.0.1

data/spec/rubocop/cop/rails/has_and_belongs_to_many_spec.rb

@@ -0,0 +1,13 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Rails::HasAndBelongsToMany do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for has_and_belongs_to_many' do
+    inspect_source(cop,
+                   ['has_and_belongs_to_many :groups'])
+    expect(cop.offences.size).to eq(1)
+  end
+end

data/spec/rubocop/cop/rails/output_spec.rb

@@ -0,0 +1,41 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Rails::Output, :config do
+  subject(:cop) { described_class.new(config) }
+  let(:cop_config) { { 'Ignore' => ['^.*\.rake$'] } }
+
+  it 'should record an offence for puts statements' do
+    source = ['p "edmond dantes"',
+              'puts "sinbad"',
+              'print "abbe busoni"',
+              'pp "monte cristo"']
+    inspect_source(cop, source)
+    expect(cop.offences.size).to eq(4)
+  end
+
+  it 'should not record an offence for methods' do
+    source = ['obj.print',
+              'something.p',
+              'nothing.pp']
+    inspect_source(cop, source)
+    expect(cop.offences).to be_empty
+  end
+
+  it 'should not record an offence for comments' do
+    source = ['# print "test"',
+              '# p']
+    inspect_source(cop, source)
+    expect(cop.offences).to be_empty
+  end
+
+  it 'should ignore certain files' do
+    source = ['print 1']
+    processed_source = parse_source(source)
+    allow(processed_source.buffer)
+      .to receive(:name).and_return('/var/lib/test.rake')
+    _investigate(cop, processed_source)
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/rails/read_attribute_spec.rb

@@ -0,0 +1,13 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Rails::ReadAttribute do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for read_attribute' do
+    inspect_source(cop,
+                   ['res = read_attribute(:test)'])
+    expect(cop.offences.size).to eq(1)
+  end
+end

data/spec/rubocop/cop/rails/validation_spec.rb

@@ -0,0 +1,21 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Rails::Validation do
+  subject(:cop) { described_class.new }
+
+  described_class::BLACKLIST.each do |validation|
+    it "registers an offence for #{validation}" do
+      inspect_source(cop,
+                     ["#{validation} :name"])
+      expect(cop.offences.size).to eq(1)
+    end
+  end
+
+  it 'accepts sexy validations' do
+    inspect_source(cop,
+                   ['validates :name'])
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/style/access_modifier_indentation_spec.rb

@@ -0,0 +1,361 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::AccessModifierIndentation, :config do
+  subject(:cop) { described_class.new(config) }
+
+  context 'when EnforcedStyle is set to indent' do
+    let(:cop_config) { { 'EnforcedStyle' => 'indent' } }
+
+    it 'registers an offence for misaligned private' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like private.'])
+      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' => 'outdent')
+    end
+
+    it 'registers an offence for misaligned private in module' do
+      inspect_source(cop,
+                     ['module Test',
+                      '',
+                      ' private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq(['Indent access modifiers like private.'])
+      # Not aligned according to `indent` or `outdent` style:
+      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+    end
+
+    it 'registers an offence for correct + opposite alignment' do
+      inspect_source(cop,
+                     ['module Test',
+                      '',
+                      '  public',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq(['Indent access modifiers like private.'])
+      # No EnforcedStyle can allow both aligments:
+      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+    end
+
+    it 'registers an offence for opposite + correct alignment' do
+      inspect_source(cop,
+                     ['module Test',
+                      '',
+                      'public',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq(['Indent access modifiers like public.'])
+      # No EnforcedStyle can allow both aligments:
+      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+    end
+
+    it 'registers an offence for misaligned private in singleton class' do
+      inspect_source(cop,
+                     ['class << self',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like private.'])
+    end
+
+    it 'registers an offence for misaligned private in class ' \
+       'defined with Class.new' do
+      inspect_source(cop,
+                     ['Test = Class.new do',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like private.'])
+    end
+
+    it 'registers an offence for misaligned private in module ' \
+       'defined with Module.new' do
+      inspect_source(cop,
+                     ['Test = Module.new do',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like private.'])
+    end
+
+    it 'registers an offence for misaligned protected' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      'protected',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like protected.'])
+    end
+
+    it 'accepts properly indented private' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts properly indented protected' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      '  protected',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts an empty class' do
+      inspect_source(cop,
+                     ['class Test',
+                      'end'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'handles properly nested classes' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      '  class Nested',
+                      '',
+                      '  private',
+                      '',
+                      '    def a; end',
+                      '  end',
+                      '',
+                      '  protected',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages)
+        .to eq(['Indent access modifiers like private.'])
+    end
+
+    it 'auto-corrects incorrectly indented access modifiers' do
+      corrected = autocorrect_source(cop, ['class Test',
+                                           '',
+                                           'public',
+                                           ' private',
+                                           '   protected',
+                                           '',
+                                           '  def test; end',
+                                           'end'])
+      expect(corrected).to eq(['class Test',
+                               '',
+                               '  public',
+                               '  private',
+                               '  protected',
+                               '',
+                               '  def test; end',
+                               'end'].join("\n"))
+    end
+  end
+
+  context 'when EnforcedStyle is set to outdent' do
+    let(:cop_config) { { 'EnforcedStyle' => 'outdent' } }
+    let(:indent_msg) { 'Outdent access modifiers like private.' }
+
+    it 'registers offence for private indented to method depth in a class' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' => 'indent')
+    end
+
+    it 'registers offence for private indented to method depth in a module' do
+      inspect_source(cop,
+                     ['module Test',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+    end
+
+    it 'registers offence for private indented to method depth in singleton' \
+       'class' do
+      inspect_source(cop,
+                     ['class << self',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+    end
+
+    it 'registers offence for private indented to method depth in class ' \
+       'defined with Class.new' do
+      inspect_source(cop,
+                     ['Test = Class.new do',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+    end
+
+    it 'registers offence for private indented to method depth in module ' \
+       'defined with Module.new' do
+      inspect_source(cop,
+                     ['Test = Module.new do',
+                      '',
+                      '  private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+    end
+
+    it 'accepts private indented to the containing class indent level' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      'private',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts protected indented to the containing class indent level' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      'protected',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'handles properly nested classes' do
+      inspect_source(cop,
+                     ['class Test',
+                      '',
+                      '  class Nested',
+                      '',
+                      '    private',
+                      '',
+                      '    def a; end',
+                      '  end',
+                      '',
+                      'protected',
+                      '',
+                      '  def test; end',
+                      'end'])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages).to eq([indent_msg])
+    end
+
+    it 'auto-corrects incorrectly indented access modifiers' do
+      corrected = autocorrect_source(cop, ['module M',
+                                           '  class Test',
+                                           '',
+                                           'public',
+                                           ' private',
+                                           '     protected',
+                                           '',
+                                           '    def test; end',
+                                           '  end',
+                                           'end'])
+      expect(corrected).to eq(['module M',
+                               '  class Test',
+                               '',
+                               '  public',
+                               '  private',
+                               '  protected',
+                               '',
+                               '    def test; end',
+                               '  end',
+                               'end'].join("\n"))
+    end
+
+    it 'auto-corrects private in complicated case' do
+      corrected = autocorrect_source(cop, ['class Hello',
+                                           '  def foo',
+                                           "    'hi'",
+                                           '  end',
+                                           '',
+                                           '  def bar',
+                                           '    Module.new do',
+                                           '',
+                                           '     private',
+                                           '',
+                                           '      def hi',
+                                           "        'bye'",
+                                           '      end',
+                                           '    end',
+                                           '  end',
+                                           'end'])
+      expect(corrected).to eq(['class Hello',
+                               '  def foo',
+                               "    'hi'",
+                               '  end',
+                               '',
+                               '  def bar',
+                               '    Module.new do',
+                               '',
+                               '    private',
+                               '',
+                               '      def hi',
+                               "        'bye'",
+                               '      end',
+                               '    end',
+                               '  end',
+                               'end'].join("\n"))
+    end
+  end
+end