ridecharge-rubocop 0.0.1

data/spec/rubocop/cop/lint/condition_position_spec.rb

@@ -0,0 +1,49 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Lint::ConditionPosition do
+  subject(:cop) { described_class.new }
+
+  %w(if unless while until).each do |keyword|
+    it 'registers an offence for condition on the next line' do
+      inspect_source(cop,
+                     ["#{keyword}",
+                      'x == 10',
+                      'end'
+                    ])
+      expect(cop.offences.size).to eq(1)
+    end
+
+    it 'accepts condition on the same line' do
+      inspect_source(cop,
+                     ["#{keyword} x == 10",
+                      ' bala',
+                      'end'
+                    ])
+      expect(cop.offences).to be_empty
+    end
+  end
+
+  it 'registers an offence for elsif condition on the next line' do
+    inspect_source(cop,
+                   ['if something',
+                    '  test',
+                    'elsif',
+                    '  something',
+                    '  test',
+                    'end'
+                  ])
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'handles ternary ops' do
+    inspect_source(cop, ['x ? a : b'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'handles modifier forms' do
+    inspect_source(cop, ['x if something'])
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/lint/debugger_spec.rb

@@ -0,0 +1,39 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Lint::Debugger do
+  subject(:cop) { described_class.new  }
+
+  it 'reports an offence for a debugger call' do
+    src = ['debugger']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'reports an offence for pry bindings' do
+    src = ['binding.pry',
+           'binding.remote_pry']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(2)
+  end
+
+  it 'does not report an offence for non-pry binding' do
+    src = ['binding.pirate']
+    inspect_source(cop, src)
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not report an offence for debugger in comments' do
+    src = ['# debugger']
+    inspect_source(cop, src)
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not report an offence for a debugger or pry method' do
+    src = ['code.debugger',
+           'door.pry']
+    inspect_source(cop, src)
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/lint/else_layout_spec.rb

@@ -0,0 +1,65 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Lint::ElseLayout do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for expr on same line as else' do
+    inspect_source(cop,
+                   ['if something',
+                    '  test',
+                    'else ala',
+                    '  something',
+                    '  test',
+                    'end'
+                  ])
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'accepts proper else' do
+    inspect_source(cop,
+                   ['if something',
+                    '  test',
+                    'else',
+                    '  something',
+                    '  test',
+                    'end'
+                  ])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'accepts single-expr else regardless of layout' do
+    inspect_source(cop,
+                   ['if something',
+                    '  test',
+                    'else bala',
+                    'end'
+                  ])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'can handle elsifs' do
+    inspect_source(cop,
+                   ['if something',
+                    '  test',
+                    'elsif something',
+                    '  bala',
+                    'else ala',
+                    '  something',
+                    '  test',
+                    'end'
+                  ])
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'handles ternary ops' do
+    inspect_source(cop, 'x ? a : b')
+    expect(cop.offences).to be_empty
+  end
+
+  it 'handles modifier forms' do
+    inspect_source(cop, 'x if something')
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/lint/empty_ensure_spec.rb

@@ -0,0 +1,27 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Lint::EmptyEnsure do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for empty ensure' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    'ensure',
+                    'end'])
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'does not register an offence for non-empty ensure' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    '  return',
+                    'ensure',
+                    '  file.close',
+                    'end'])
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/lint/end_alignment_spec.rb

@@ -0,0 +1,136 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Lint::EndAlignment, :config do
+  subject(:cop) { described_class.new(config) }
+  let(:cop_config) { {} }
+  let(:cop_config) { { 'AlignWith' => 'keyword' } }
+  let(:opposite) do
+    cop_config['AlignWith'] == 'keyword' ? 'variable' : 'keyword'
+  end
+
+  shared_examples 'misaligned' do |alignment_base, arg, end_kw, name|
+    name ||= alignment_base
+    it "registers an offence for mismatched #{name} ... end" do
+      inspect_source(cop, ["#{alignment_base} #{arg}",
+                           end_kw])
+      expect(cop.offences.size).to eq(1)
+      expect(cop.messages.first)
+        .to match(/end at 2, \d+ is not aligned with #{alignment_base} at 1,/)
+      expect(cop.highlights.first).to eq('end')
+      expect(cop.config_to_allow_offences).to eq('AlignWith' => opposite)
+    end
+  end
+
+  shared_examples 'aligned' do |alignment_base, arg, end_kw, name|
+    name ||= alignment_base
+    it "accepts matching #{name} ... end" do
+      inspect_source(cop, ["#{alignment_base} #{arg}",
+                           end_kw])
+      expect(cop.offences).to be_empty
+    end
+  end
+
+  include_examples 'misaligned', 'class',  'Test',      '  end'
+  include_examples 'misaligned', 'module', 'Test',      '  end'
+  include_examples 'misaligned', 'def',    'test',      '  end'
+  include_examples 'misaligned', 'def',    'Test.test', '  end', 'defs'
+  include_examples 'misaligned', 'if',     'test',      '  end'
+  include_examples 'misaligned', 'unless', 'test',      '  end'
+  include_examples 'misaligned', 'while',  'test',      '  end'
+  include_examples 'misaligned', 'until',  'test',      '  end'
+
+  include_examples 'aligned', 'class',  'Test',      'end'
+  include_examples 'aligned', 'module', 'Test',      'end'
+  include_examples 'aligned', 'def',    'test',      'end'
+  include_examples 'aligned', 'def',    'Test.test', 'end', 'defs'
+  include_examples 'aligned', 'if',     'test',      'end'
+  include_examples 'aligned', 'unless', 'test',      'end'
+  include_examples 'aligned', 'while',  'test',      'end'
+  include_examples 'aligned', 'until',  'test',      'end'
+
+  context 'in ruby 2.1 or later' do
+    include_examples 'aligned', 'public def',          'test', 'end'
+    include_examples 'aligned', 'protected def',       'test', 'end'
+    include_examples 'aligned', 'private def',         'test', 'end'
+    include_examples 'aligned', 'module_function def', 'test', 'end'
+
+    include_examples('misaligned',
+                     'public def', 'test',
+                     '       end')
+    include_examples('misaligned',
+                     'protected def', 'test',
+                     '          end')
+    include_examples('misaligned',
+                     'private def', 'test',
+                     '        end')
+    include_examples('misaligned',
+                     'module_function def', 'test',
+                     '                end')
+  end
+
+  it 'can handle ternary if' do
+    inspect_source(cop, 'a = cond ? x : y')
+    expect(cop.offences).to be_empty
+  end
+
+  it 'can handle modifier if' do
+    inspect_source(cop, 'a = x if cond')
+    expect(cop.offences).to be_empty
+  end
+
+  it 'registers an offence for correct + opposite' do
+    inspect_source(cop, ['x = if a',
+                         '      a1',
+                         '    end',
+                         'y = if b',
+                         '  b1',
+                         'end'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages.first)
+      .to eq('end at 6, 0 is not aligned with y = if at 4, 4')
+    expect(cop.highlights.first).to eq('end')
+    expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+  end
+
+  context 'regarding assignment' do
+    context 'when AlignWith is keyword' do
+      include_examples 'misaligned', 'var = if',     'test', 'end'
+      include_examples 'misaligned', 'var = unless', 'test', 'end'
+      include_examples 'misaligned', 'var = while',  'test', 'end'
+      include_examples 'misaligned', 'var = until',  'test', 'end'
+
+      include_examples 'aligned', 'var = if',     'test', '      end'
+      include_examples 'aligned', 'var = unless', 'test', '      end'
+      include_examples 'aligned', 'var = while',  'test', '      end'
+      include_examples 'aligned', 'var = until',  'test', '      end'
+    end
+
+    context 'when AlignWith is variable' do
+      let(:cop_config) { { 'AlignWith' => 'variable' } }
+
+      include_examples 'aligned', 'var = if',     'test', 'end'
+      include_examples 'aligned', 'var = unless', 'test', 'end'
+      include_examples 'aligned', 'var = while',  'test', 'end'
+      include_examples 'aligned', 'var = until',  'test', 'end'
+      include_examples 'aligned', 'var = until',  'test', 'end.abc.join("")'
+      include_examples 'aligned', 'var = until',  'test', 'end.abc.tap {}'
+
+      include_examples 'misaligned', 'var = if',     'test', '      end'
+      include_examples 'misaligned', 'var = unless', 'test', '      end'
+      include_examples 'misaligned', 'var = while',  'test', '      end'
+      include_examples 'misaligned', 'var = until',  'test', '      end'
+      include_examples 'misaligned', 'var = until',  'test', '      end.join'
+
+      include_examples 'aligned', '@var = if',  'test', 'end'
+      include_examples 'aligned', '@@var = if', 'test', 'end'
+      include_examples 'aligned', '$var = if',  'test', 'end'
+      include_examples 'aligned', 'CNST = if',  'test', 'end'
+      include_examples 'aligned', 'a, b = if',  'test', 'end'
+      include_examples 'aligned', 'var ||= if', 'test', 'end'
+      include_examples 'aligned', 'var &&= if', 'test', 'end'
+      include_examples 'aligned', 'var += if',  'test', 'end'
+    end
+  end
+end

data/spec/rubocop/cop/lint/end_in_method_spec.rb

@@ -0,0 +1,29 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Lint::EndInMethod do
+  subject(:cop) { described_class.new }
+
+  it 'reports an offence for def with an END inside' do
+    src = ['def test',
+           '  END { something }',
+           'end']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'reports an offence for defs with an END inside' do
+    src = ['def self.test',
+           '  END { something }',
+           'end']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'accepts END outside of def(s)' do
+    src = ['END { something }']
+    inspect_source(cop, src)
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/lint/ensure_return_spec.rb

@@ -0,0 +1,39 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Lint::EnsureReturn do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for return in ensure' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    'ensure',
+                    '  file.close',
+                    '  return',
+                    'end'])
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'does not register an offence for return outside ensure' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    '  return',
+                    'ensure',
+                    '  file.close',
+                    'end'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not check when ensure block has no body' do
+    expect do
+      inspect_source(cop,
+                     ['begin',
+                      '  something',
+                      'ensure',
+                      'end'])
+    end.to_not raise_exception
+  end
+end

data/spec/rubocop/cop/lint/eval_spec.rb

@@ -0,0 +1,35 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Lint::Eval do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for eval as function' do
+    inspect_source(cop,
+                   ['eval(something)'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['The use of eval is a serious security risk.'])
+  end
+
+  it 'registers an offence for eval as command' do
+    inspect_source(cop,
+                   ['eval something'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['The use of eval is a serious security risk.'])
+  end
+
+  it 'does not register an offence for eval as variable' do
+    inspect_source(cop,
+                   ['eval = something'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not register an offence for eval as method' do
+    inspect_source(cop,
+                   ['something.eval'])
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/lint/handle_exceptions_spec.rb

@@ -0,0 +1,30 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Lint::HandleExceptions do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for empty rescue block' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    'rescue',
+                    '  #do nothing',
+                    'end'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Do not suppress exceptions.'])
+  end
+
+  it 'does not register an offence for rescue with body' do
+    inspect_source(cop,
+                   ['begin',
+                    '  something',
+                    '  return',
+                    'rescue',
+                    '  file.close',
+                    'end'])
+    expect(cop.offences).to be_empty
+  end
+end