ridecharge-rubocop 0.0.1

data/spec/rubocop/cop/style/space_around_equals_in_parameter_default_spec.rb

@@ -0,0 +1,33 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::SpaceAroundEqualsInParameterDefault do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for default value assignment without space' do
+    inspect_source(cop, ['def f(x, y=0, z=1)', 'end'])
+    expect(cop.messages).to eq(
+      ['Surrounding space missing in default value assignment.'] * 2)
+  end
+
+  it 'registers an offence for assignment empty string without space' do
+    inspect_source(cop, ['def f(x, y="", z=1)', 'end'])
+    expect(cop.offences.size).to eq(2)
+  end
+
+  it 'registers an offence for assignment of empty list without space' do
+    inspect_source(cop, ['def f(x, y=[])', 'end'])
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'accepts default value assignment with space' do
+    inspect_source(cop, ['def f(x, y = 0, z = {})', 'end'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'auto-corrects missing space' do
+    new_source = autocorrect_source(cop, ['def f(x, y=0, z=1)', 'end'])
+    expect(new_source).to eq(['def f(x, y = 0, z = 1)', 'end'].join("\n"))
+  end
+end

data/spec/rubocop/cop/style/space_around_operators_spec.rb

@@ -0,0 +1,325 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::SpaceAroundOperators do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for assignment without space on both sides' do
+    inspect_source(cop, ['x=0', 'y= 0', 'z =0'])
+    expect(cop.messages).to eq(
+      ["Surrounding space missing for operator '='."] * 3)
+  end
+
+  it 'auto-corrects assignment without space on both sides' do
+    new_source = autocorrect_source(cop, ['x=0', 'y= 0', 'z =0'])
+    expect(new_source).to eq(['x = 0', 'y = 0', 'z = 0'].join("\n"))
+  end
+
+  it 'registers an offence for ternary operator without space' do
+    inspect_source(cop, ['x == 0?1:2'])
+    expect(cop.messages).to eq(
+      ["Surrounding space missing for operator '?'.",
+       "Surrounding space missing for operator ':'."])
+  end
+
+  it 'auto-corrects a ternary operator without space' do
+    new_source = autocorrect_source(cop, 'x == 0?1:2')
+    expect(new_source).to eq('x == 0 ? 1 : 2')
+  end
+
+  it 'registers an offence in presence of modifier if statement' do
+    check_modifier('if')
+  end
+
+  it 'registers an offence in presence of modifier unless statement' do
+    check_modifier('unless')
+  end
+
+  it 'registers an offence in presence of modifier while statement' do
+    check_modifier('unless')
+  end
+
+  it 'registers an offence in presence of modifier until statement' do
+    check_modifier('unless')
+  end
+
+  def check_modifier(keyword)
+    src = ["a=1 #{keyword} condition",
+           'c=2']
+    inspect_source(cop, src)
+    expect(cop.offences.map(&:line)).to eq([1, 2])
+    expect(cop.messages).to eq(
+      ["Surrounding space missing for operator '='."] * 2)
+
+    new_source = autocorrect_source(cop, src)
+    expect(new_source)
+      .to eq(src.map { |line| line.sub(/=/, ' = ') }.join("\n"))
+  end
+
+  it 'registers an offence for binary operators that could be unary' do
+    inspect_source(cop, ['a-3', 'x&0xff', 'z+0'])
+    expect(cop.messages).to eq(
+      ["Surrounding space missing for operator '-'.",
+       "Surrounding space missing for operator '&'.",
+       "Surrounding space missing for operator '+'."])
+  end
+
+  it 'auto-corrects missing space in binary operators that could be unary' do
+    new_source = autocorrect_source(cop, ['a-3', 'x&0xff', 'z+0'])
+    expect(new_source).to eq(['a - 3', 'x & 0xff', 'z + 0'].join("\n"))
+  end
+
+  it 'registers an offence for arguments to a method' do
+    inspect_source(cop, ['puts 1+2'])
+    expect(cop.messages).to eq(
+      ["Surrounding space missing for operator '+'."])
+  end
+
+  it 'auto-corrects missing space in arguments to a method' do
+    new_source = autocorrect_source(cop, 'puts 1+2')
+    expect(new_source).to eq('puts 1 + 2')
+  end
+
+  it 'accepts operator surrounded by tabs' do
+    inspect_source(cop, ["a\t+\tb"])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts operator symbols' do
+    inspect_source(cop, ['func(:-)'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts ranges' do
+    inspect_source(cop, ['a, b = (1..2), (1...3)'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts scope operator' do
+    source = ['@io.class == Zlib::GzipWriter']
+    inspect_source(cop, source)
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts ::Kernel::raise' do
+    source = ['::Kernel::raise IllegalBlockError.new']
+    inspect_source(cop, source)
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts exclamation point negation' do
+    inspect_source(cop, ['x = !a&&!b'])
+    expect(cop.messages).to eq(
+      ["Surrounding space missing for operator '&&'."])
+  end
+
+  it 'accepts exclamation point definition' do
+    inspect_source(cop, ['  def !',
+                         '    !__getobj__',
+                         '  end'])
+    expect(cop.offences).to be_empty
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts a unary' do
+    inspect_source(cop,
+                   ['  def bm(label_width = 0, *labels, &blk)',
+                    '    benchmark(CAPTION, label_width, FORMAT,',
+                    '              *labels, &blk)',
+                    '  end',
+                    '',
+                    '  def each &block',
+                    '  end',
+                    '',
+                    '  def self.search *args',
+                    '  end',
+                    '',
+                    '  def each *args',
+                    '  end',
+                    ''])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts splat operator' do
+    inspect_source(cop, ['return *list if options'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts def of operator' do
+    inspect_source(cop, ['def +(other); end',
+                         'def self.===(other); end'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts an operator at the end of a line' do
+    inspect_source(cop,
+                   ["['Favor unless over if for negative ' +",
+                    " 'conditions.'] * 2"])
+    expect(cop.messages).to eq([])
+  end
+
+  it 'accepts an assignment with spaces' do
+    inspect_source(cop, ['x = 0'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'accepts an operator called with method syntax' do
+    inspect_source(cop, ['Date.today.+(1).to_s'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'registers an offence for operators without spaces' do
+    inspect_source(cop,
+                   ['x+= a+b-c*d/e%f^g|h&i||j',
+                    'y -=k&&l'])
+    expect(cop.messages)
+      .to eq(["Surrounding space missing for operator '+='.",
+              "Surrounding space missing for operator '+'.",
+              "Surrounding space missing for operator '-'.",
+              "Surrounding space missing for operator '*'.",
+              "Surrounding space missing for operator '/'.",
+              "Surrounding space missing for operator '%'.",
+              "Surrounding space missing for operator '^'.",
+              "Surrounding space missing for operator '|'.",
+              "Surrounding space missing for operator '&'.",
+              "Surrounding space missing for operator '||'.",
+              "Surrounding space missing for operator '-='.",
+              "Surrounding space missing for operator '&&'."])
+  end
+
+  it 'auto-corrects missing space' do
+    new_source = autocorrect_source(cop, ['x+= a+b-c*d/e%f^g|h&i||j',
+                                          'y -=k&&l'])
+    expect(new_source).to eq(['x += a + b - c * d / e % f ^ g | h & i || j',
+                              'y -= k && l'].join("\n"))
+  end
+
+  it 'accepts operators with spaces' do
+    inspect_source(cop,
+                   ['x += a + b - c * d / e % f ^ g | h & i || j',
+                    'y -= k && l'])
+    expect(cop.messages).to eq([])
+  end
+
+  it "accepts some operators that are exceptions & don't need spaces" do
+    inspect_source(cop, ['(1..3)',
+                         'ActionController::Base',
+                         'each { |s, t| }'])
+    expect(cop.messages).to eq([])
+  end
+
+  it 'accepts an assignment followed by newline' do
+    inspect_source(cop, ['x =', '0'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'registers an offences for exponent operator with spaces' do
+    inspect_source(cop, ['x = a * b ** 2'])
+    expect(cop.messages).to eq(
+      ['Space around operator ** detected.'])
+  end
+
+  it 'auto-corrects unwanted space around **' do
+    new_source = autocorrect_source(cop, ['x = a * b ** 2',
+                                          'y = a * b** 2'])
+    expect(new_source).to eq(['x = a * b**2',
+                              'y = a * b**2'].join("\n"))
+  end
+
+  it 'accepts exponent operator without spaces' do
+    inspect_source(cop, ['x = a * b**2'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'registers an offence for a setter call without spaces' do
+    inspect_source(cop, ['x.y=2'])
+    expect(cop.messages).to eq(
+      ["Surrounding space missing for operator '='."])
+  end
+
+  it 'registers an offence for a hash rocket without spaces' do
+    inspect_source(cop, ['{ 1=>2, a: b }'])
+    expect(cop.messages).to eq(
+      ["Surrounding space missing for operator '=>'."])
+  end
+
+  it 'accepts unary operators without space' do
+    inspect_source(cop, ['[].map(&:size)',
+                         '-3',
+                         'arr.collect { |e| -e }',
+                         'x = +2'])
+    expect(cop.messages).to eq([])
+  end
+
+  it 'accepts [] without space' do
+    inspect_source(cop, ['files[2]'])
+    expect(cop.messages).to eq([])
+  end
+
+  it 'accepts argument default values without space' do
+    # These are handled by SpaceAroundEqualsInParameterDefault,
+    # so SpaceAroundOperators leaves them alone.
+    inspect_source(cop,
+                   ['def init(name=nil)',
+                    'end'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts the construct class <<self with no space after <<' do
+    inspect_source(cop, ['class <<self',
+                         'end'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'registers an offence for match operators without space' do
+    inspect_source(cop, ['x=~/abc/', 'y !~/abc/'])
+    expect(cop.messages)
+      .to eq(["Surrounding space missing for operator '=~'.",
+              "Surrounding space missing for operator '!~'."])
+  end
+
+  it 'registers an offence for various assignments without space' do
+    inspect_source(cop, ['x||=0', 'y&&=0', 'z*=2',
+                         '@a=0', '@@a=0', 'a,b=0', 'A=0', 'x[3]=0', '$A=0'])
+    expect(cop.messages)
+      .to eq(["Surrounding space missing for operator '||='.",
+              "Surrounding space missing for operator '&&='.",
+              "Surrounding space missing for operator '*='.",
+              "Surrounding space missing for operator '='.",
+              "Surrounding space missing for operator '='.",
+              "Surrounding space missing for operator '='.",
+              "Surrounding space missing for operator '='.",
+              "Surrounding space missing for operator '='.",
+              "Surrounding space missing for operator '='."])
+  end
+
+  it 'registers an offence for equality operators without space' do
+    inspect_source(cop, ['x==0', 'y!=0', 'Hash===z'])
+    expect(cop.messages)
+      .to eq(["Surrounding space missing for operator '=='.",
+              "Surrounding space missing for operator '!='.",
+              "Surrounding space missing for operator '==='."])
+  end
+
+  it 'registers an offence for - without space with negative lhs operand' do
+    inspect_source(cop, ['-1-arg'])
+    expect(cop.messages)
+      .to eq(["Surrounding space missing for operator '-'."])
+  end
+
+  it 'registers an offence for inheritance < without space' do
+    inspect_source(cop, ['class ShowSourceTestClass<ShowSourceTestSuperClass',
+                         'end'])
+    expect(cop.messages)
+      .to eq(["Surrounding space missing for operator '<'."])
+  end
+
+  it 'registers an offence for hash rocket without space at rescue' do
+    inspect_source(cop, ['begin',
+                         'rescue Exception=>e',
+                         'end'])
+    expect(cop.messages)
+      .to eq(["Surrounding space missing for operator '=>'."])
+  end
+end

data/spec/rubocop/cop/style/space_before_modifier_keyword_spec.rb

@@ -0,0 +1,70 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::SpaceBeforeModifierKeyword do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for missing space before if/unless' do
+    inspect_source(cop, ['(a = 3)if a == 2',
+                         'a = "test"if a == 2',
+                         'a = 42unless a == 2',
+                         'a = [1,2,3]unless a == 2',
+                         'a = {:a => "b"}if a == 2'])
+    expect(cop.highlights).to eq([')', '"', '2', ']', '}'])
+  end
+
+  it 'registers an offence for missing space before while/until' do
+    inspect_source(cop, ['(a = 3)while b',
+                         'a = "test"until b',
+                         'a = 42while b',
+                         'a = [1,2,3]until b',
+                         'a = {:a => "b"}while b'])
+    expect(cop.highlights).to eq([')', '"', '2', ']', '}'])
+  end
+
+  it 'accepts modifiers with preceding space' do
+    inspect_source(cop, ['(a = 3) if b',
+                         'a = "test" unless b',
+                         'a = 42 while b',
+                         'a = [1,2,3] until b'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'accepts elsif at beginning of line' do
+    inspect_source(cop, ["if RUBY_VERSION.between?('1.9.2', '2.0.0')",
+                         "  require 'testing/performance/ruby/yarv'",
+                         'elsif RUBY_VERSION.between?("1.8.6", "1.9")',
+                         "  require 'testing/performance/ruby/mri'",
+                         'end'])
+    expect(cop.highlights).to eq([])
+  end
+
+  it 'does not crash on ternary conditionals' do
+    inspect_source(cop, 'a ? b : c')
+    expect(cop.offences).to be_empty
+  end
+
+  it 'auto-corrects missing space' do
+    new_source = autocorrect_source(cop, ['(a = 3)if a == 2',
+                                          'a = "test"if a == 2',
+                                          'a = 42unless a == 2',
+                                          'a = [1,2,3]unless a == 2',
+                                          'a = {:a => "b"}if a == 2',
+                                          '(a = 3)while b',
+                                          'a = "test"until b',
+                                          'a = 42while b',
+                                          'a = [1,2,3]until b',
+                                          'a = {:a => "b"}while b'])
+    expect(new_source).to eq(['(a = 3) if a == 2',
+                              'a = "test" if a == 2',
+                              'a = 42 unless a == 2',
+                              'a = [1,2,3] unless a == 2',
+                              'a = {:a => "b"} if a == 2',
+                              '(a = 3) while b',
+                              'a = "test" until b',
+                              'a = 42 while b',
+                              'a = [1,2,3] until b',
+                              'a = {:a => "b"} while b'].join("\n"))
+  end
+end

data/spec/rubocop/cop/style/space_inside_brackets_spec.rb

@@ -0,0 +1,52 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::SpaceInsideBrackets do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for an array literal with spaces inside' do
+    inspect_source(cop, ['a = [1, 2 ]',
+                         'b = [ 1, 2]'])
+    expect(cop.messages).to eq(
+      ['Space inside square brackets detected.',
+       'Space inside square brackets detected.'])
+  end
+
+  it 'accepts space inside strings within square brackets' do
+    inspect_source(cop, ["['Encoding:',",
+                         " '  Enabled: false']"])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts space inside square brackets if on its own row' do
+    inspect_source(cop, ['a = [',
+                         '     1, 2',
+                         '    ]'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts square brackets as method name' do
+    inspect_source(cop, ['def Vector.[](*array)',
+                         'end'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts square brackets called with method call syntax' do
+    inspect_source(cop, ['subject.[](0)'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'only reports a single space once' do
+    inspect_source(cop, ['[ ]'])
+    expect(cop.messages).to eq(
+      ['Space inside square brackets detected.'])
+  end
+
+  it 'auto-corrects unwanted space' do
+    new_source = autocorrect_source(cop, ['a = [1, 2 ]',
+                                          'b = [ 1, 2]'])
+    expect(new_source).to eq(['a = [1, 2]',
+                              'b = [1, 2]'].join("\n"))
+  end
+end