ridecharge-rubocop 0.0.1

data/spec/rubocop/cop/style/encoding_spec.rb

@@ -0,0 +1,56 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::Encoding do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence when no encoding present', ruby: 1.9 do
+    inspect_source(cop, ['def foo() end'])
+
+    expect(cop.messages).to eq(
+      ['Missing utf-8 encoding comment.'])
+  end
+
+  it 'accepts encoding on first line', ruby: 1.9 do
+    inspect_source(cop, ['# encoding: utf-8',
+                         'def foo() end'])
+
+    expect(cop.offences).to be_empty
+  end
+
+  it 'accepts encoding on second line when shebang present', ruby: 1.9 do
+    inspect_source(cop, ['#!/usr/bin/env ruby',
+                         '# encoding: utf-8',
+                         'def foo() end'])
+
+    expect(cop.messages).to be_empty
+  end
+
+  it 'books an offence when encoding is in the wrong place', ruby: 1.9 do
+    inspect_source(cop, ['def foo() end',
+                         '# encoding: utf-8'])
+
+    expect(cop.messages).to eq(
+      ['Missing utf-8 encoding comment.'])
+  end
+
+  it 'does not register an offence on Ruby 2.0', ruby: 2.0 do
+    inspect_source(cop, ['def foo() end'])
+
+    expect(cop.offences).to be_empty
+  end
+
+  it 'accepts encoding inserted by magic_encoding gem', ruby: 1.9 do
+    inspect_source(cop, ['# -*- encoding : utf-8 -*-',
+                         'def foo() end'])
+
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts vim-style encoding comments', ruby: 1.9 do
+    inspect_source(cop, ['# vim:fileencoding=utf-8',
+                         'def foo() end'])
+    expect(cop.messages).to be_empty
+  end
+end

data/spec/rubocop/cop/style/end_block_spec.rb

@@ -0,0 +1,13 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::EndBlock do
+  subject(:cop) { described_class.new }
+
+  it 'reports an offence for an END block' do
+    src = ['END { test }']
+    inspect_source(cop, src)
+    expect(cop.offences.size).to eq(1)
+  end
+end

data/spec/rubocop/cop/style/end_of_line_spec.rb

@@ -0,0 +1,47 @@
+# encoding: utf-8
+
+require 'spec_helper'
+require 'tempfile'
+
+describe Rubocop::Cop::Style::EndOfLine do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for CR+LF' do
+    inspect_source_file(cop, ['x=0', '', "y=1\r"])
+    expect(cop.messages).to eq(['Carriage return character detected.'])
+  end
+
+  it 'highlights the whole offendng line' do
+    inspect_source_file(cop, ['x=0', '', "y=1\r"])
+    expect(cop.highlights).to eq(["y=1\r"])
+  end
+
+  it 'registers an offence for CR at end of file' do
+    inspect_source_file(cop, ["x=0\r"])
+    expect(cop.messages).to eq(['Carriage return character detected.'])
+  end
+
+  context 'when there are many lines ending with CR+LF' do
+    it 'registers only one offence' do
+      inspect_source_file(cop, ['x=0', '', 'y=1'].join("\r\n"))
+      expect(cop.messages.size).to eq(1)
+    end
+  end
+
+  context 'when the default external encoding is US_ASCII' do
+    before(:each) do
+      @orig_encoding = Encoding.default_external
+      Encoding.default_external = Encoding::US_ASCII
+    end
+    after(:each) { Encoding.default_external = @orig_encoding }
+
+    it 'does not crash on UTF-8 encoded non-ascii characters' do
+      inspect_source_file(cop,
+                          ['# encoding: UTF-8',
+                           'class Epd::ReportsController < EpdAreaController',
+                           "  'terecht bij uw ROM-coördinator.'",
+                           'end'].join("\n"))
+      expect(cop.offences).to be_empty
+    end
+  end
+end

data/spec/rubocop/cop/style/even_odd_spec.rb

@@ -0,0 +1,75 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::EvenOdd do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for x % 2 == 0' do
+    inspect_source(cop,
+                   ['x % 2 == 0'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages).to eq(['Use Fixnum.even?'])
+  end
+
+  it 'registers an offence for x % 2 != 0' do
+    inspect_source(cop,
+                   ['x % 2 != 0'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages).to eq(['Use Fixnum.odd?'])
+  end
+
+  it 'registers an offence for (x % 2) == 0' do
+    inspect_source(cop,
+                   ['(x % 2) == 0'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages).to eq(['Use Fixnum.even?'])
+  end
+
+  it 'registers an offence for (x % 2) != 0' do
+    inspect_source(cop,
+                   ['(x % 2) != 0'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages).to eq(['Use Fixnum.odd?'])
+  end
+
+  it 'registers an offence for x % 2 == 1' do
+    inspect_source(cop,
+                   ['x % 2 == 1'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages).to eq(['Use Fixnum.odd?'])
+  end
+
+  it 'registers an offence for x % 2 != 1' do
+    inspect_source(cop,
+                   ['x % 2 != 1'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages).to eq(['Use Fixnum.even?'])
+  end
+
+  it 'registers an offence for (x % 2) == 1' do
+    inspect_source(cop,
+                   ['(x % 2) == 1'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages).to eq(['Use Fixnum.odd?'])
+  end
+
+  it 'registers an offence for (x % 2) != 1' do
+    inspect_source(cop,
+                   ['(x % 2) != 1'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages).to eq(['Use Fixnum.even?'])
+  end
+
+  it 'accepts x % 3 == 0' do
+    inspect_source(cop,
+                   ['x % 3 == 0'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'accepts x % 3 != 0' do
+    inspect_source(cop,
+                   ['x % 3 != 0'])
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/style/favor_join_spec.rb

@@ -0,0 +1,31 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::FavorJoin do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for an array followed by string' do
+    inspect_source(cop,
+                   ['%w(one two three) * ", "'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Favor Array#join over Array#*.'])
+  end
+
+  it 'does not register an offence for numbers' do
+    inspect_source(cop,
+                   ['%w(one two three) * 4'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not register an offence for ambiguous cases' do
+    inspect_source(cop,
+                   ['test * ", "'])
+    expect(cop.offences).to be_empty
+
+    inspect_source(cop,
+                   ['%w(one two three) * test'])
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/style/favor_sprintf_spec.rb

@@ -0,0 +1,47 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::FavorSprintf do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for a string followed by something' do
+    inspect_source(cop,
+                   ['puts "%d" % 10'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Favor sprintf over String#%.'])
+  end
+
+  it 'registers an offence for something followed by an array' do
+    inspect_source(cop,
+                   ['puts x % [10, 11]'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Favor sprintf over String#%.'])
+  end
+
+  it 'does not register an offence for numbers' do
+    inspect_source(cop,
+                   ['puts 10 % 4'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not register an offence for ambiguous cases' do
+    inspect_source(cop,
+                   ['puts x % 4'])
+    expect(cop.offences).to be_empty
+
+    inspect_source(cop,
+                   ['puts x % Y'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'works if the first operand contains embedded expressions' do
+    inspect_source(cop,
+                   ['puts "#{x * 5} %d #{@test}" % 10'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Favor sprintf over String#%.'])
+  end
+end

data/spec/rubocop/cop/style/favor_unless_over_negated_if_spec.rb

@@ -0,0 +1,76 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::FavorUnlessOverNegatedIf do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for if with exclamation point condition' do
+    inspect_source(cop,
+                   ['if !a_condition',
+                    '  some_method',
+                    'end',
+                    'some_method if !a_condition'
+                   ])
+    expect(cop.messages).to eq(
+      ['Favor unless (or control flow or) over if for negative ' \
+       'conditions.'] * 2)
+  end
+
+  it 'registers an offence for if with "not" condition' do
+    inspect_source(cop,
+                   ['if not a_condition',
+                    '  some_method',
+                    'end',
+                    'some_method if not a_condition'])
+    expect(cop.messages).to eq(
+      ['Favor unless (or control flow or) over if for negative ' \
+       'conditions.'] * 2)
+    expect(cop.offences.map(&:line)).to eq([1, 4])
+  end
+
+  it 'accepts an if/else with negative condition' do
+    inspect_source(cop,
+                   ['if !a_condition',
+                    '  some_method',
+                    'else',
+                    '  something_else',
+                    'end',
+                    'if not a_condition',
+                    '  some_method',
+                    'elsif other_condition',
+                    '  something_else',
+                    'end'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'accepts an if where only part of the contition is negated' do
+    inspect_source(cop,
+                   ['if !condition && another_condition',
+                    '  some_method',
+                    'end',
+                    'if not condition or another_condition',
+                    '  some_method',
+                    'end',
+                    'some_method if not condition or another_condition'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'is not confused by negated elsif' do
+    inspect_source(cop,
+                   ['if test.is_a?(String)',
+                    '  3',
+                    'elsif test.is_a?(Array)',
+                    '  2',
+                    'elsif !test.nil?',
+                    '  1',
+                    'end'])
+
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not blow up for ternary ops' do
+    inspect_source(cop, 'a ? b : c')
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/style/favor_until_over_negated_while_spec.rb

@@ -0,0 +1,41 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::FavorUntilOverNegatedWhile do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for while with exclamation point condition' do
+    inspect_source(cop,
+                   ['while !a_condition',
+                    '  some_method',
+                    'end',
+                    'some_method while !a_condition'
+                   ])
+    expect(cop.messages).to eq(
+      ['Favor until over while for negative conditions.'] * 2)
+  end
+
+  it 'registers an offence for while with "not" condition' do
+    inspect_source(cop,
+                   ['while (not a_condition)',
+                    '  some_method',
+                    'end',
+                    'some_method while not a_condition'])
+    expect(cop.messages).to eq(
+      ['Favor until over while for negative conditions.'] * 2)
+    expect(cop.offences.map(&:line)).to eq([1, 4])
+  end
+
+  it 'accepts an while where only part of the contition is negated' do
+    inspect_source(cop,
+                   ['while !a_condition && another_condition',
+                    '  some_method',
+                    'end',
+                    'while not a_condition or another_condition',
+                    '  some_method',
+                    'end',
+                    'some_method while not a_condition or other_cond'])
+    expect(cop.messages).to be_empty
+  end
+end

data/spec/rubocop/cop/style/final_newline_spec.rb

@@ -0,0 +1,30 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::FinalNewline do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for missing final newline' do
+    source = ['x = 0', 'top']
+    inspect_source(cop, source)
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'accepts a final newline' do
+    source = ['x = 0', 'top', '']
+    inspect_source(cop, source)
+    expect(cop.offences).to be_empty
+  end
+
+  it 'accepts an empty file' do
+    source = ['']
+    inspect_source(cop, source)
+    expect(cop.offences).to be_empty
+  end
+
+  it 'auto-corrects missing newline' do
+    new_source = autocorrect_source(cop, ['x = 0'])
+    expect(new_source).to eq(['x = 0', ''].join("\n"))
+  end
+end

data/spec/rubocop/cop/style/flip_flop_spec.rb

@@ -0,0 +1,23 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::FlipFlop do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for inclusive flip flops' do
+    inspect_source(cop,
+                   ['DATA.each_line do |line|',
+                    'print line if (line =~ /begin/)..(line =~ /end/)',
+                    'end'])
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'registers an offence for exclusive flip flops' do
+    inspect_source(cop,
+                   ['DATA.each_line do |line|',
+                    'print line if (line =~ /begin/)...(line =~ /end/)',
+                    'end'])
+    expect(cop.offences.size).to eq(1)
+  end
+end