ridecharge-rubocop 0.0.1

data/spec/rubocop/cop/style/space_inside_hash_literal_braces_spec.rb

@@ -0,0 +1,138 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::SpaceInsideHashLiteralBraces, :config do
+  subject(:cop) { described_class.new(config) }
+  let(:cop_config) { { 'EnforcedStyle' => 'space' } }
+
+  context 'with space inside empty braces not allowed' do
+    let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'no_space' } }
+
+    it 'accepts empty braces with no space inside' do
+      inspect_source(cop, ['h = {}'])
+      expect(cop.messages).to be_empty
+    end
+
+    it 'registers an offence for empty braces with space inside' do
+      inspect_source(cop, ['h = { }'])
+      expect(cop.messages)
+        .to eq(['Space inside empty hash literal braces detected.'])
+      expect(cop.highlights).to eq([' '])
+    end
+
+    it 'auto-corrects unwanted space' do
+      new_source = autocorrect_source(cop, 'h = { }')
+      expect(new_source).to eq('h = {}')
+    end
+  end
+
+  context 'with space inside empty braces allowed' do
+    let(:cop_config) { { 'EnforcedStyleForEmptyBraces' => 'space' } }
+
+    it 'accepts empty braces with space inside' do
+      inspect_source(cop, ['h = { }'])
+      expect(cop.messages).to be_empty
+    end
+
+    it 'registers an offence for empty braces with no space inside' do
+      inspect_source(cop, ['h = {}'])
+      expect(cop.messages)
+        .to eq(['Space inside empty hash literal braces missing.'])
+      expect(cop.highlights).to eq(['{'])
+    end
+
+    it 'auto-corrects missing space' do
+      new_source = autocorrect_source(cop, 'h = {}')
+      expect(new_source).to eq('h = { }')
+    end
+  end
+
+  it 'registers an offence for hashes with no spaces if so configured' do
+    inspect_source(cop,
+                   ['h = {a: 1, b: 2}',
+                    'h = {a => 1}'])
+    expect(cop.messages).to eq(['Space inside { missing.',
+                                'Space inside } missing.',
+                                'Space inside { missing.',
+                                'Space inside } missing.'])
+    expect(cop.highlights).to eq(['{', '}', '{', '}'])
+    expect(cop.config_to_allow_offences).to eq('EnforcedStyle' => 'no_space')
+  end
+
+  it 'registers an offence for correct + opposite' do
+    inspect_source(cop,
+                   ['h = { a: 1}'])
+    expect(cop.messages).to eq(['Space inside } missing.'])
+    expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+  end
+
+  it 'auto-corrects missing space' do
+    new_source = autocorrect_source(cop, ['h = {a: 1, b: 2}',
+                                          'h = {a => 1 }'])
+    expect(new_source).to eq(['h = { a: 1, b: 2 }',
+                              'h = { a => 1 }'].join("\n"))
+  end
+
+  context 'when EnforcedStyle is no_space' do
+    let(:cop_config) { { 'EnforcedStyle' => 'no_space' } }
+
+    it 'registers an offence for hashes with spaces' do
+      inspect_source(cop,
+                     ['h = { a: 1, b: 2 }'])
+      expect(cop.messages).to eq(['Space inside { detected.',
+                                  'Space inside } detected.'])
+      expect(cop.highlights).to eq([' ', ' '])
+      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' => 'space')
+    end
+
+    it 'registers an offence for opposite + correct' do
+      inspect_source(cop,
+                     ['h = {a: 1 }'])
+      expect(cop.messages).to eq(['Space inside } detected.'])
+      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+    end
+
+    it 'auto-corrects unwanted space' do
+      new_source = autocorrect_source(cop, ['h = { a: 1, b: 2 }',
+                                            'h = {a => 1 }'])
+      expect(new_source).to eq(['h = {a: 1, b: 2}',
+                                'h = {a => 1}'].join("\n"))
+    end
+
+    it 'accepts hashes with no spaces' do
+      inspect_source(cop,
+                     ['h = {a: 1, b: 2}',
+                      'h = {a => 1}'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts multiline hashes for no space' do
+      inspect_source(cop,
+                     ['h = {',
+                      '      a: 1,',
+                      '      b: 2,',
+                      '}'])
+      expect(cop.offences).to be_empty
+    end
+  end
+
+  it 'accepts hashes with spaces by default' do
+    inspect_source(cop,
+                   ['h = { a: 1, b: 2 }',
+                    'h = { a => 1 }'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'accepts hash literals with no braces' do
+    inspect_source(cop, ['x(a: b.c)'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'can handle interpolation in a braceless hash literal' do
+    # A tricky special case where the closing brace of the
+    # interpolation risks getting confused for a hash literal brace.
+    inspect_source(cop, ['f(get: "#{x}")'])
+    expect(cop.offences).to be_empty
+  end
+end

data/spec/rubocop/cop/style/space_inside_parens_spec.rb

@@ -0,0 +1,34 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::SpaceInsideParens do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for spaces inside parens' do
+    inspect_source(cop, ['f( 3)',
+                         'g(3 )'])
+    expect(cop.messages).to eq(
+      ['Space inside parentheses detected.',
+       'Space inside parentheses detected.'])
+  end
+
+  it 'accepts parentheses in block parameter list' do
+    inspect_source(cop,
+                   ['list.inject(Tms.new) { |sum, (label, item)|',
+                    '}'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'accepts parentheses with no spaces' do
+    inspect_source(cop, ['split("\n")'])
+    expect(cop.messages).to be_empty
+  end
+
+  it 'auto-corrects unwanted space' do
+    new_source = autocorrect_source(cop, ['f( 3)',
+                                          'g(3 )'])
+    expect(new_source).to eq(['f(3)',
+                              'g(3)'].join("\n"))
+  end
+end

data/spec/rubocop/cop/style/special_global_vars_spec.rb

@@ -0,0 +1,56 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::SpecialGlobalVars do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for $:' do
+    inspect_source(cop, ['puts $:'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Prefer $LOAD_PATH over $:.'])
+  end
+
+  it 'registers an offence for $"' do
+    inspect_source(cop, ['puts $"'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Prefer $LOADED_FEATURES over $".'])
+  end
+
+  it 'registers an offence for $0' do
+    inspect_source(cop, ['puts $0'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Prefer $PROGRAM_NAME over $0.'])
+  end
+
+  it 'registers an offence for $$' do
+    inspect_source(cop, ['puts $$'])
+    expect(cop.offences.size).to eq(1)
+    expect(cop.messages)
+      .to eq(['Prefer $PROCESS_ID or $PID from the English library over $$.'])
+  end
+
+  it 'is clear about variables from the English library vs those not' do
+    inspect_source(cop, ['puts $*'])
+    expect(cop.messages)
+      .to eq(['Prefer $ARGV from the English library, or ARGV over $*.'])
+  end
+
+  it 'does not register an offence for backrefs like $1' do
+    inspect_source(cop, ['puts $1'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'auto-corrects $: to $LOAD_PATH' do
+    new_source = autocorrect_source(cop, '$:')
+    expect(new_source).to eq('$LOAD_PATH')
+  end
+
+  it 'auto-corrects $/ to $INPUT_RECORD_SEPARATOR' do
+    new_source = autocorrect_source(cop, '$/')
+    expect(new_source).to eq('$INPUT_RECORD_SEPARATOR')
+  end
+end

data/spec/rubocop/cop/style/string_literals_spec.rb

@@ -0,0 +1,212 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::StringLiterals, :config do
+  subject(:cop) { described_class.new(config) }
+
+  context 'configured with single quotes preferred' do
+    let(:cop_config) { { 'EnforcedStyle' => 'single_quotes' } }
+
+    it 'registers offence for double quotes when single quotes ' \
+      'suffice' do
+      inspect_source(cop, ['s = "abc"',
+                           'x = "a\\\\b"',
+                           'y ="\\\\b"',
+                           'z = "a\\\\"'])
+      expect(cop.highlights).to eq(['"abc"',
+                                    '"a\\\\b"',
+                                    '"\\\\b"',
+                                    '"a\\\\"'])
+      expect(cop.messages)
+        .to eq(["Prefer single-quoted strings when you don't need " \
+                'string interpolation or special symbols.'] * 4)
+      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' =>
+                                                 'double_quotes')
+    end
+
+    it 'registers offence for correct + opposite' do
+      inspect_source(cop, ['s = "abc"',
+                           "x = 'abc'"])
+      expect(cop.messages)
+        .to eq(["Prefer single-quoted strings when you don't need " \
+                'string interpolation or special symbols.'])
+      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+    end
+
+    it 'accepts single quotes' do
+      inspect_source(cop, ["a = 'x'"])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts %q and %Q quotes' do
+      inspect_source(cop, ['a = %q(x) + %Q[x]'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts % quotes' do
+      inspect_source(cop, ['a = %(x)'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts heredocs' do
+      inspect_source(cop,
+                     ['execute <<-SQL',
+                      '  SELECT name from users',
+                      'SQL'])
+
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts double quotes when they are needed' do
+      src = ['a = "\n"',
+             'b = "#{encode_severity}:' \
+             '#{sprintf("%3d", line_number)}: #{m}"',
+             'c = "\'"',
+             'd = "#@test"',
+             'e = "#$test"',
+             'f = "\e"',
+             'g = "#@@test"']
+      inspect_source(cop, src)
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts double quotes at the start of regexp literals' do
+      inspect_source(cop, ['s = /"((?:[^\\"]|\\.)*)"/'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts double quotes with some other special symbols' do
+      # "Substitutions in double-quoted strings"
+      # http://www.ruby-doc.org/docs/ProgrammingRuby/html/language.html
+      src = ['g = "\xf9"',
+             'copyright = "\u00A9"']
+      inspect_source(cop, src)
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts " in a %w' do
+      inspect_source(cop, ['%w(")'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts \\\\\n in a string' do # this would be: "\\\n"
+      inspect_source(cop, ['"foo \\\\\n bar"'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'can handle double quotes within embedded expression' do
+      src = ['"#{"A"}"']
+      inspect_source(cop, src)
+      expect(cop.offences).to be_empty
+    end
+
+    it 'can handle a built-in constant parsed as string' do
+      # Parser will produce str nodes for constants such as __FILE__.
+      src = ['if __FILE__ == $PROGRAM_NAME',
+             'end']
+      inspect_source(cop, src)
+      expect(cop.offences).to be_empty
+    end
+
+    it 'can handle character literals' do
+      src = 'a = ?/'
+      inspect_source(cop, src)
+      expect(cop.offences).to be_empty
+    end
+
+    it 'auto-corrects " with \'' do
+      new_source = autocorrect_source(cop, 's = "abc"')
+      expect(new_source).to eq("s = 'abc'")
+    end
+  end
+
+  context 'configured with double quotes preferred' do
+    let(:cop_config) { { 'EnforcedStyle' => 'double_quotes' } }
+
+    it 'registers offence for single quotes when double quotes would ' \
+      'be equivalent' do
+      inspect_source(cop, ["s = 'abc'"])
+      expect(cop.highlights).to eq(["'abc'"])
+      expect(cop.messages)
+        .to eq(['Prefer double-quoted strings unless you need ' \
+                'single quotes to avoid extra backslashes for ' +
+                'escaping.'])
+      expect(cop.config_to_allow_offences).to eq('EnforcedStyle' =>
+                                                 'single_quotes')
+    end
+
+    it 'registers offence for opposite + correct' do
+      inspect_source(cop, ['s = "abc"',
+                           "x = 'abc'"])
+      expect(cop.messages)
+        .to eq(['Prefer double-quoted strings unless you need ' \
+                'single quotes to avoid extra backslashes for ' +
+                'escaping.'])
+      expect(cop.config_to_allow_offences).to eq('Enabled' => false)
+    end
+
+    it 'accepts double quotes' do
+      inspect_source(cop, ['a = "x"'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts %q and %Q quotes' do
+      inspect_source(cop, ['a = %q(x) + %Q[x]'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts % quotes' do
+      inspect_source(cop, ['a = %(x)'])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts heredocs' do
+      inspect_source(cop,
+                     ['execute <<-SQL',
+                      '  SELECT name from users',
+                      'SQL'])
+
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts single quotes when they are needed' do
+      src = ["a = '\\n'",
+             "b = '\"'"]
+      inspect_source(cop, src)
+      expect(cop.offences).to be_empty
+    end
+
+    it 'accepts single quotes at the start of regexp literals' do
+      inspect_source(cop, ["s = /'((?:[^\\']|\\.)*)'/"])
+      expect(cop.offences).to be_empty
+    end
+
+    it "accepts ' in a %w" do
+      inspect_source(cop, ["%w(')"])
+      expect(cop.offences).to be_empty
+    end
+
+    it 'can handle a built-in constant parsed as string' do
+      # Parser will produce str nodes for constants such as __FILE__.
+      src = ['if __FILE__ == $PROGRAM_NAME',
+             'end']
+      inspect_source(cop, src)
+      expect(cop.offences).to be_empty
+    end
+
+    it "auto-corrects ' with \"" do
+      new_source = autocorrect_source(cop, "s = 'abc'")
+      expect(new_source).to eq('s = "abc"')
+    end
+  end
+
+  context 'when configured with a bad value' do
+    let(:cop_config) { { 'EnforcedStyle' => 'other' } }
+
+    it 'fails' do
+      expect { inspect_source(cop, ['a = "b"']) }
+        .to raise_error(RuntimeError)
+    end
+  end
+end

data/spec/rubocop/cop/style/symbol_array_spec.rb

@@ -0,0 +1,37 @@
+# encoding: utf-8
+
+require 'spec_helper'
+
+describe Rubocop::Cop::Style::SymbolArray do
+  subject(:cop) { described_class.new }
+
+  it 'registers an offence for arrays of symbols', ruby: 2.0 do
+    inspect_source(cop,
+                   ['[:one, :two, :three]'])
+    expect(cop.offences.size).to eq(1)
+  end
+
+  it 'does not reg an offence for array with non-syms', ruby: 2.0 do
+    inspect_source(cop,
+                   ['[:one, :two, "three"]'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not reg an offence for array starting with %i', ruby: 2.0 do
+    inspect_source(cop,
+                   ['%i(one two three)'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does not reg an offence for array with one element', ruby: 2.0 do
+    inspect_source(cop,
+                   ['[:three]'])
+    expect(cop.offences).to be_empty
+  end
+
+  it 'does nothing on Ruby 1.9', ruby: 1.9 do
+    inspect_source(cop,
+                   ['[:one, :two, :three]'])
+    expect(cop.offences).to be_empty
+  end
+end