netsuite 0.3.0 → 0.3.1

data/README.md

@@ -86,7 +86,7 @@ customer_support_reps = [12345, 12346]
 
 task = NetSuite::Records::Task.new(
 	:title => 'Take Care of a Customer',
-	:assigned => NetSuite::Records::RecordRef.new(customer_support_reps.sample),
+	:assigned => NetSuite::Records::RecordRef.new(internal_id: customer_support_reps.sample),
 	:due_date => DateTime.now + 1,
 	:message => "Take care of this"
 )

data/lib/netsuite.rb

@@ -91,7 +91,6 @@ module NetSuite
     autoload :Customer,                         'netsuite/records/customer'
     autoload :CustomerAddressbook,              'netsuite/records/customer_addressbook'
     autoload :CustomerAddressbookList,          'netsuite/records/customer_addressbook_list'
-    autoload :CustomerCategory,                 'netsuite/records/customer_category'
     autoload :CustomerDeposit,                  'netsuite/records/customer_deposit'
     autoload :CustomerPayment,                  'netsuite/records/customer_payment'
     autoload :CustomerPaymentApply,             'netsuite/records/customer_payment_apply'

data/lib/netsuite/actions/search.rb

@@ -124,6 +124,11 @@ module NetSuite
                 }
               }
 
+              # https://github.com/NetSweet/netsuite/commit/54d7b011d9485dad33504135dfe8153c86cae9a0#commitcomment-8443976
+              if NetSuite::Configuration.api_version < "2013_2"
+                h[element_name][:attributes!]['platformCore:customField']['internalId'] = h[element_name][:attributes!]['platformCore:customField'].delete('scriptId')
+              end
+
               # === END CUSTOM FIELD
             else
               if condition[:value].is_a?(Array) && condition[:value].first.respond_to?(:to_record)

data/lib/netsuite/records/file.rb

@@ -1,9 +1,7 @@
 module NetSuite
   module Records
-    class File
-      include Support::Fields
+    class File < NetSuite::Support::Base
       include Support::RecordRefs
-      include Support::Records
       include Support::Actions
       include Namespaces::FileCabinet
 
@@ -17,11 +15,8 @@ module NetSuite
 
       read_only_fields :url
 
-      def initialize(attributes = {})
-        @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
-        @external_id = attributes.delete(:external_id) || attributes.delete(:@external_id)
-        initialize_from_attributes_hash(attributes)
-      end
+      attr_reader   :internal_id
+      attr_accessor :external_id
     end
   end
 end

data/lib/netsuite/support/country.rb

@@ -252,8 +252,8 @@ module NetSuite
         'ZW' => '_zimbabwe'
       }
 
-      def initialize(iso_or_name)
-        if iso_or_name =~ /[A-Z]{2}/
+      def initialize(iso_or_name = '')
+        if iso_or_name =~ /^[A-Z]{2}/
           @id = ISO_TO_NETSUITE.fetch(iso_or_name)
         else
           @id = iso_or_name

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module Netsuite
-  VERSION = '0.3.0'
+  VERSION = '0.3.1'
 end

data/netsuite.gemspec

@@ -17,5 +17,5 @@ Gem::Specification.new do |gem|
 
   gem.add_dependency 'savon', '~> 2.3.0'
 
-  gem.add_development_dependency 'rspec', '~> 2.99'
+  gem.add_development_dependency 'rspec', '~> 3.1.0'
 end

data/spec/netsuite/actions/add_spec.rb

@@ -27,8 +27,8 @@ describe NetSuite::Actions::Add do
 
     it 'returns a valid Response object' do
       response = NetSuite::Actions::Add.call([customer])
-      response.should be_kind_of(NetSuite::Response)
-      response.should be_success
+      expect(response).to be_kind_of(NetSuite::Response)
+      expect(response).to be_success
     end
   end
 
@@ -55,8 +55,8 @@ describe NetSuite::Actions::Add do
 
       it 'returns a valid Response object' do
         response = NetSuite::Actions::Add.call([invoice])
-        response.should be_kind_of(NetSuite::Response)
-        response.should be_success
+        expect(response).to be_kind_of(NetSuite::Response)
+        expect(response).to be_success
       end
     end
 
@@ -76,15 +76,15 @@ describe NetSuite::Actions::Add do
         invoice.add
         error = invoice.errors.first
 
-        error.should be_kind_of(NetSuite::Error)
-        error.type.should eq('ERROR')
-        error.code.should eq('INVALID_INITIALIZE_REF')
-        error.message.should eq('You can not initialize invoice: invalid reference 7281.')
+        expect(error).to be_kind_of(NetSuite::Error)
+        expect(error.type).to eq('ERROR')
+        expect(error.code).to eq('INVALID_INITIALIZE_REF')
+        expect(error.message).to eq('You can not initialize invoice: invalid reference 7281.')
       end
 
       it 'provides an error method on the response' do
         response = NetSuite::Actions::Add.call([invoice])
-        response.errors.first.should be_kind_of(NetSuite::Error)
+        expect(response.errors.first).to be_kind_of(NetSuite::Error)
       end
     end
 
@@ -102,14 +102,14 @@ describe NetSuite::Actions::Add do
 
       it 'provides an error method on the object with details about the error' do
         invoice.add
-        invoice.errors.length.should eq(2)
+        expect(invoice.errors.length).to eq(2)
 
         error = invoice.errors.first
 
-        error.should be_kind_of(NetSuite::Error)
-        error.type.should eq('ERROR')
-        error.code.should eq('ERROR')
-        error.message.should eq('Some message')
+        expect(error).to be_kind_of(NetSuite::Error)
+        expect(error.type).to eq('ERROR')
+        expect(error.code).to eq('ERROR')
+        expect(error.message).to eq('Some message')
       end
     end
   end

data/spec/netsuite/actions/delete_spec.rb

@@ -25,8 +25,8 @@ describe NetSuite::Actions::Delete do
 
     it 'returns a valid Response object' do
       response = NetSuite::Actions::Delete.call([customer])
-      response.should be_kind_of(NetSuite::Response)
-      response.should be_success
+      expect(response).to be_kind_of(NetSuite::Response)
+      expect(response).to be_success
     end
   end
 

data/spec/netsuite/actions/get_spec.rb

@@ -24,7 +24,7 @@ describe NetSuite::Actions::Get do
 
       it 'returns a valid Response object' do
         response = NetSuite::Actions::Get.call([NetSuite::Records::Customer, :external_id => 1])
-        response.should be_kind_of(NetSuite::Response)
+        expect(response).to be_kind_of(NetSuite::Response)
       end
     end
 
@@ -43,7 +43,7 @@ describe NetSuite::Actions::Get do
 
       it "makes a valid request to the NetSuite API" do
         customer = NetSuite::Records::Customer.get(1)
-        customer.balance.should == '100.0'
+        expect(customer.balance).to eq('100.0')
       end
     end
   end
@@ -65,7 +65,7 @@ describe NetSuite::Actions::Get do
 
     it 'returns a valid Response object' do
       response = NetSuite::Actions::Get.call([NetSuite::Records::Invoice, :external_id => 1])
-      response.should be_kind_of(NetSuite::Response)
+      expect(response).to be_kind_of(NetSuite::Response)
     end
   end
 

data/spec/netsuite/actions/initialize_spec.rb

@@ -27,8 +27,8 @@ describe NetSuite::Actions::Initialize do
 
   it 'returns a valid Response object' do
     response = NetSuite::Actions::Initialize.call([NetSuite::Records::Customer, customer])
-    response.should be_kind_of(NetSuite::Response)
-    response.should be_success
+    expect(response).to be_kind_of(NetSuite::Response)
+    expect(response).to be_success
   end
 
 end

data/spec/netsuite/actions/search_spec.rb

@@ -30,8 +30,8 @@ describe NetSuite::Actions::Search do
 
       it "should handle a ID only search" do
         result = NetSuite::Records::Customer.search(saved: 500)
-        result.results.size.should == 1
-        result.results.first.email.should == 'aemail@gmail.com'
+        expect(result.results.size).to eq(1)
+        expect(result.results.first.email).to eq('aemail@gmail.com')
       end
 
       it "merges preferences gracefully" do
@@ -81,7 +81,7 @@ describe NetSuite::Actions::Search do
 
                   :attributes! => {
                     "platformCore:customField" => {
-                      "scriptId" => ["custentity_customerandcontacttypelist", "custentity_relatedthing"],
+                      "internalId" => ["custentity_customerandcontacttypelist", "custentity_relatedthing"],
                       "operator" => ["anyOf", "anyOf"],
                       "xsi:type" => ["platformCore:SearchMultiSelectCustomField", "platformCore:SearchMultiSelectCustomField"]
                     }
@@ -137,9 +137,9 @@ describe NetSuite::Actions::Search do
         ]
       })
 
-      search.results.size.should == 2
-      search.results.first.alt_name.should == 'A Awesome Name'
-      search.results.last.email.should == 'alessawesome@gmail.com'
+      expect(search.results.size).to eq(2)
+      expect(search.results.first.alt_name).to eq('A Awesome Name')
+      expect(search.results.last.email).to eq('alessawesome@gmail.com')
     end
   end
 

data/spec/netsuite/actions/update_spec.rb

@@ -32,8 +32,8 @@ describe NetSuite::Actions::Update do
 
       it 'returns a valid Response object' do
         response = NetSuite::Actions::Update.call([NetSuite::Records::Customer, attributes])
-        response.should be_kind_of(NetSuite::Response)
-        response.should be_success
+        expect(response).to be_kind_of(NetSuite::Response)
+        expect(response).to be_success
       end
 
     end
@@ -48,15 +48,15 @@ describe NetSuite::Actions::Update do
         customer.update(attributes)
         error = customer.errors.first
 
-        error.should be_kind_of(NetSuite::Error)
-        error.type.should eq('ERROR')
-        error.code.should eq('INSUFFICIENT_PERMISSION')
-        error.message.should eq('You do not have permissions to set a value for element addrtext due to one of the following reasons: 1) The field is read-only; 2) An associated feature is disabled; 3) The field is available either when a record is created or updated, but not in both cases.')
+        expect(error).to be_kind_of(NetSuite::Error)
+        expect(error.type).to eq('ERROR')
+        expect(error.code).to eq('INSUFFICIENT_PERMISSION')
+        expect(error.message).to eq('You do not have permissions to set a value for element addrtext due to one of the following reasons: 1) The field is read-only; 2) An associated feature is disabled; 3) The field is available either when a record is created or updated, but not in both cases.')
       end
 
       it 'provides an errors method on the response' do
         response = NetSuite::Actions::Update.call([NetSuite::Records::Customer, attributes])
-        response.errors.first.should be_kind_of(NetSuite::Error)
+        expect(response.errors.first).to be_kind_of(NetSuite::Error)
       end
 
     end
@@ -69,19 +69,19 @@ describe NetSuite::Actions::Update do
 
       it 'provides an errors method on the object with details about the errors' do
         customer.update(attributes)
-        customer.errors.length.should eq(2)
+        expect(customer.errors.length).to eq(2)
 
         first_error = customer.errors.first
-        first_error.should be_kind_of(NetSuite::Error)
-        first_error.type.should eq('ERROR')
-        first_error.code.should eq('First error code')
-        first_error.message.should eq('First error message')
+        expect(first_error).to be_kind_of(NetSuite::Error)
+        expect(first_error.type).to eq('ERROR')
+        expect(first_error.code).to eq('First error code')
+        expect(first_error.message).to eq('First error message')
 
         second_error = customer.errors.last
-        second_error.should be_kind_of(NetSuite::Error)
-        second_error.type.should eq('WARNING')
-        second_error.code.should eq('Second error code')
-        second_error.message.should eq('Second error message')
+        expect(second_error).to be_kind_of(NetSuite::Error)
+        expect(second_error.type).to eq('WARNING')
+        expect(second_error.code).to eq('Second error code')
+        expect(second_error.message).to eq('Second error message')
 
       end
     end

data/spec/netsuite/actions/upsert_list_spec.rb

@@ -30,8 +30,8 @@ describe NetSuite::Actions::UpsertList do
 
       it 'returns a valid Response object' do
         response = NetSuite::Actions::UpsertList.call(customers)
-        response.should be_kind_of(NetSuite::Response)
-        response.should be_success
+        expect(response).to be_kind_of(NetSuite::Response)
+        expect(response).to be_success
       end
     end
 
@@ -68,8 +68,8 @@ describe NetSuite::Actions::UpsertList do
 
       it 'returns a valid Response object' do
         response = NetSuite::Actions::UpsertList.call(customers)
-        response.should be_kind_of(NetSuite::Response)
-        response.should be_success
+        expect(response).to be_kind_of(NetSuite::Response)
+        expect(response).to be_success
       end
     end
   end

data/spec/netsuite/actions/upsert_spec.rb

@@ -27,8 +27,8 @@ describe NetSuite::Actions::Upsert do
 
     it 'returns a valid Response object' do
       response = NetSuite::Actions::Upsert.call([customer])
-      response.should be_kind_of(NetSuite::Response)
-      response.should be_success
+      expect(response).to be_kind_of(NetSuite::Response)
+      expect(response).to be_success
     end
   end
 
@@ -55,8 +55,8 @@ describe NetSuite::Actions::Upsert do
 
       it 'returns a valid Response object' do
         response = NetSuite::Actions::Upsert.call([invoice])
-        response.should be_kind_of(NetSuite::Response)
-        response.should be_success
+        expect(response).to be_kind_of(NetSuite::Response)
+        expect(response).to be_success
       end
     end
 
@@ -76,15 +76,15 @@ describe NetSuite::Actions::Upsert do
         invoice.upsert
         error = invoice.errors.first
 
-        error.should be_kind_of(NetSuite::Error)
-        error.type.should eq('ERROR')
-        error.code.should eq('INVALID_KEY_OR_REF')
-        error.message.should eq('The specified key is invalid.')
+        expect(error).to be_kind_of(NetSuite::Error)
+        expect(error.type).to eq('ERROR')
+        expect(error.code).to eq('INVALID_KEY_OR_REF')
+        expect(error.message).to eq('The specified key is invalid.')
       end
 
       it 'provides an error method on the response' do
         response = NetSuite::Actions::Upsert.call([invoice])
-        response.errors.first.should be_kind_of(NetSuite::Error)
+        expect(response.errors.first).to be_kind_of(NetSuite::Error)
       end
     end
 
@@ -102,14 +102,14 @@ describe NetSuite::Actions::Upsert do
 
       it 'provides an error method on the object with details about the error' do
         invoice.upsert
-        invoice.errors.length.should eq(2)
+        expect(invoice.errors.length).to eq(2)
 
         error = invoice.errors.first
 
-        error.should be_kind_of(NetSuite::Error)
-        error.type.should eq('ERROR')
-        error.code.should eq('ERROR')
-        error.message.should eq('Some message')
+        expect(error).to be_kind_of(NetSuite::Error)
+        expect(error.type).to eq('ERROR')
+        expect(error.code).to eq('ERROR')
+        expect(error.message).to eq('Some message')
       end
     end
   end

data/spec/netsuite/configuration_spec.rb

@@ -10,9 +10,9 @@ describe NetSuite::Configuration do
   describe '#reset!' do
     it 'clears the attributes hash' do
       config.attributes[:blah] = 'something'
-      config.attributes.should_not be_empty
+      expect(config.attributes).not_to be_empty
       config.reset!
-      config.attributes.should be_empty
+      expect(config.attributes).to be_empty
     end
   end
 
@@ -23,7 +23,7 @@ describe NetSuite::Configuration do
       config.password 'me@example.com'
       config.account 1023
 
-      config.connection.should be_kind_of(Savon::Client)
+      expect(config.connection).to be_kind_of(Savon::Client)
     end
   end
 
@@ -34,13 +34,13 @@ describe NetSuite::Configuration do
       end
 
       it 'returns a path to the WSDL to use for the API' do
-        config.wsdl.should eql('https://system.sandbox.netsuite.com/wsdl/v2011_2_0/netsuite.wsdl')
+        expect(config.wsdl).to eql('https://system.sandbox.netsuite.com/wsdl/v2011_2_0/netsuite.wsdl')
       end
     end
 
     context 'when the wsdl has not been set' do
       it 'returns a path to the WSDL to use for the API' do
-        config.wsdl.should match(/.*\/netsuite\/wsdl\/2011_2\.wsdl/)
+        expect(config.wsdl).to match(/.*\/netsuite\/wsdl\/2011_2\.wsdl/)
       end
     end
 
@@ -48,7 +48,7 @@ describe NetSuite::Configuration do
       it 'should correctly return the full HTTP sandbox URL' do
         config.api_version '2013_1'
         config.sandbox false
-        config.wsdl.should eql('https://webservices.netsuite.com/wsdl/v2013_1_0/netsuite.wsdl')
+        expect(config.wsdl).to eql('https://webservices.netsuite.com/wsdl/v2013_1_0/netsuite.wsdl')
       end
     end
   end
@@ -61,7 +61,7 @@ describe NetSuite::Configuration do
     end
 
     it 'returns a hash representation of the authentication header' do
-      config.auth_header.should eql({
+      expect(config.auth_header).to eql({
         'platformMsgs:passport' => {
           'platformCore:email'    => 'user@example.com',
           'platformCore:password' => 'myPassword',
@@ -85,7 +85,7 @@ describe NetSuite::Configuration do
           'platformMsgs:ignoreReadOnlyFields' => true,
         }
       }
-      config.soap_header.should eql({
+      expect(config.soap_header).to eql({
         'platformMsgs:preferences' => {
           'platformMsgs:ignoreReadOnlyFields' => true,
         }
@@ -100,15 +100,15 @@ describe NetSuite::Configuration do
       end
 
       it 'returns the email' do
-        config.email.should eql('test@example.com')
+        expect(config.email).to eql('test@example.com')
       end
     end
 
     context 'when the email has not been set' do
       it 'raises a ConfigurationError' do
-        lambda {
+        expect {
           config.email
-        }.should raise_error(NetSuite::ConfigurationError,
+        }.to raise_error(NetSuite::ConfigurationError,
           '#email is a required configuration value. Please set it by calling NetSuite::Configuration.email = "me@example.com"')
       end
     end
@@ -121,15 +121,15 @@ describe NetSuite::Configuration do
       end
 
       it 'returns the password' do
-        config.password.should eql('password')
+        expect(config.password).to eql('password')
       end
     end
 
     context 'when the password has not been set' do
       it 'raises a ConfigurationError' do
-        lambda {
+        expect {
           config.password
-        }.should raise_error(NetSuite::ConfigurationError,
+        }.to raise_error(NetSuite::ConfigurationError,
           '#password is a required configuration value. Please set it by calling NetSuite::Configuration.password = "my_pass"')
       end
     end
@@ -142,15 +142,15 @@ describe NetSuite::Configuration do
       end
 
       it 'returns the account' do
-        config.account.should eql(4321)
+        expect(config.account).to eql(4321)
       end
     end
 
     context 'when the account has not been set' do
       it 'raises a ConfigurationError' do
-        lambda {
+        expect {
           config.account
-        }.should raise_error(NetSuite::ConfigurationError,
+        }.to raise_error(NetSuite::ConfigurationError,
           '#account is a required configuration value. Please set it by calling NetSuite::Configuration.account = 1234')
       end
     end
@@ -160,7 +160,7 @@ describe NetSuite::Configuration do
   describe '#role' do
     context 'when no role is defined' do
       it 'defaults to "3"' do
-        config.role.should == "3"
+        expect(config.role).to eq("3")
       end
     end
   end
@@ -168,14 +168,14 @@ describe NetSuite::Configuration do
   describe '#role=' do
     it 'sets the role according to the input value' do
       config.role = "6"
-      config.role.should == "6"
+      expect(config.role).to eq("6")
     end
   end
 
   describe '#api_version' do
     context 'when no api_version is defined' do
       it 'defaults to 2011_2' do
-        config.api_version.should == '2011_2'
+        expect(config.api_version).to eq('2011_2')
       end
     end
   end
@@ -184,7 +184,7 @@ describe NetSuite::Configuration do
     context 'when api version is defined' do
       it 'sets the api_version of the application' do
         config.api_version = '2012_1'
-        config.api_version.should == '2012_1'
+        expect(config.api_version).to eq('2012_1')
       end
     end
   end