netsuite 0.3.0 → 0.3.1

data/spec/netsuite/records/customer_spec.rb

@@ -22,7 +22,7 @@ describe NetSuite::Records::Customer do
       :territory, :third_party_acct, :third_party_country, :third_party_zipcode, :title, :unbilled_orders, :url,
       :vat_reg_number, :visits, :web_lead
     ].each do |field|
-      customer.should have_field(field)
+      expect(customer).to have_field(field)
     end
   end
 
@@ -30,7 +30,7 @@ describe NetSuite::Records::Customer do
     [
       :custom_form, :entity_status, :partner
     ].each do |record_ref|
-      customer.should have_record_ref(record_ref)
+      expect(customer).to have_record_ref(record_ref)
     end
   end
 
@@ -54,14 +54,14 @@ describe NetSuite::Records::Customer do
           :zip              => '90007'
         }
       }
-      customer.addressbook_list.should be_kind_of(NetSuite::Records::CustomerAddressbookList)
-      customer.addressbook_list.addressbooks.length.should eql(1)
+      expect(customer.addressbook_list).to be_kind_of(NetSuite::Records::CustomerAddressbookList)
+      expect(customer.addressbook_list.addressbooks.length).to eql(1)
     end
 
     it 'can be set from a CustomerAddressbookList object' do
       customer_addressbook_list = NetSuite::Records::CustomerAddressbookList.new
       customer.addressbook_list = customer_addressbook_list
-      customer.addressbook_list.should eql(customer_addressbook_list)
+      expect(customer.addressbook_list).to eql(customer_addressbook_list)
     end
   end
 
@@ -74,14 +74,14 @@ describe NetSuite::Records::Customer do
         }
       }
       customer.custom_field_list = attributes
-      customer.custom_field_list.should be_kind_of(NetSuite::Records::CustomFieldList)
-      customer.custom_field_list.custom_fields.length.should eql(1)
+      expect(customer.custom_field_list).to be_kind_of(NetSuite::Records::CustomFieldList)
+      expect(customer.custom_field_list.custom_fields.length).to eql(1)
     end
 
     it 'can be set from a CustomFieldList object' do
       custom_field_list = NetSuite::Records::CustomFieldList.new
       customer.custom_field_list = custom_field_list
-      customer.custom_field_list.should eql(custom_field_list)
+      expect(customer.custom_field_list).to eql(custom_field_list)
     end
   end
 
@@ -90,10 +90,10 @@ describe NetSuite::Records::Customer do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :is_person => true }) }
 
       it 'returns a Customer instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Customer, {:external_id => 1}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Customer, {:external_id => 1}], {}).and_return(response)
         customer = NetSuite::Records::Customer.get(:external_id => 1)
-        customer.should be_kind_of(NetSuite::Records::Customer)
-        customer.is_person.should be_truthy
+        expect(customer).to be_kind_of(NetSuite::Records::Customer)
+        expect(customer.is_person).to be_truthy
       end
     end
 
@@ -101,10 +101,10 @@ describe NetSuite::Records::Customer do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Customer, {:external_id => 1}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Customer, {:external_id => 1}], {}).and_return(response)
+        expect {
           NetSuite::Records::Customer.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::Customer with OPTIONS=(.*) could not be found/)
       end
     end
@@ -117,10 +117,10 @@ describe NetSuite::Records::Customer do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([customer], {}).
             and_return(response)
-        customer.add.should be_truthy
+        expect(customer.add).to be_truthy
       end
     end
 
@@ -128,10 +128,10 @@ describe NetSuite::Records::Customer do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([customer], {}).
             and_return(response)
-        customer.add.should be_falsey
+        expect(customer.add).to be_falsey
       end
     end
   end
@@ -141,10 +141,10 @@ describe NetSuite::Records::Customer do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([customer], {}).
             and_return(response)
-        customer.delete.should be_truthy
+        expect(customer.delete).to be_truthy
       end
     end
 
@@ -152,10 +152,10 @@ describe NetSuite::Records::Customer do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([customer], {}).
             and_return(response)
-        customer.delete.should be_falsey
+        expect(customer.delete).to be_falsey
       end
     end
   end
@@ -164,7 +164,7 @@ describe NetSuite::Records::Customer do
     let(:customer) { NetSuite::Records::Customer.new(:entity_id => 'TEST CUSTOMER', :is_person => true) }
 
     it 'returns a hash of attributes that can be used in a SOAP request' do
-      customer.to_record.should eql({
+      expect(customer.to_record).to eql({
         'listRel:entityId' => 'TEST CUSTOMER',
         'listRel:isPerson' => true
       })
@@ -173,7 +173,7 @@ describe NetSuite::Records::Customer do
 
   describe '#record_type' do
     it 'returns a string type for the record to be used in a SOAP request' do
-      customer.record_type.should eql('listRel:Customer')
+      expect(customer.record_type).to eql('listRel:Customer')
     end
   end
 

data/spec/netsuite/records/department_spec.rb

@@ -7,7 +7,7 @@ describe NetSuite::Records::Department do
     [
       :name, :is_inactive
     ].each do |field|
-      department.should have_field(field)
+      expect(department).to have_field(field)
     end
   end
 
@@ -15,7 +15,7 @@ describe NetSuite::Records::Department do
     [
       :parent
     ].each do |record_ref|
-      department.should have_record_ref(record_ref)
+      expect(department).to have_record_ref(record_ref)
     end
   end
 
@@ -24,10 +24,10 @@ describe NetSuite::Records::Department do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :name => 'Department 1' }) }
 
       it 'returns a Department instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Department, {:external_id => 1}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Department, {:external_id => 1}], {}).and_return(response)
         department = NetSuite::Records::Department.get(:external_id => 1)
-        department.should be_kind_of(NetSuite::Records::Department)
-        department.name.should eql('Department 1')
+        expect(department).to be_kind_of(NetSuite::Records::Department)
+        expect(department.name).to eql('Department 1')
       end
     end
 
@@ -35,10 +35,10 @@ describe NetSuite::Records::Department do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Department, {:external_id => 1}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Department, {:external_id => 1}], {}).and_return(response)
+        expect {
           NetSuite::Records::Department.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::Department with OPTIONS=(.*) could not be found/)
       end
     end
@@ -52,10 +52,10 @@ describe NetSuite::Records::Department do
 
       it 'returns true' do
         department = NetSuite::Records::Department.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([department], {}).
             and_return(response)
-        department.add.should be_truthy
+        expect(department.add).to be_truthy
       end
     end
 
@@ -64,10 +64,10 @@ describe NetSuite::Records::Department do
 
       it 'returns false' do
         department = NetSuite::Records::Department.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([department], {}).
             and_return(response)
-        department.add.should be_falsey
+        expect(department.add).to be_falsey
       end
     end
   end
@@ -80,10 +80,10 @@ describe NetSuite::Records::Department do
 
       it 'returns true' do
         department = NetSuite::Records::Department.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([department], {}).
             and_return(response)
-        department.delete.should be_truthy
+        expect(department.delete).to be_truthy
       end
     end
 
@@ -92,10 +92,10 @@ describe NetSuite::Records::Department do
 
       it 'returns false' do
         department = NetSuite::Records::Department.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([department], {}).
             and_return(response)
-        department.delete.should be_falsey
+        expect(department.delete).to be_falsey
       end
     end
   end

data/spec/netsuite/records/deposit_spec.rb

@@ -9,7 +9,7 @@ describe NetSuite::Records::Deposit do
     [
       :created_date, :last_modified_date, :currency_name, :tran_id, :total, :tran_date, :memo, :to_be_printed
     ].each do |field|
-      deposit.should have_field(field)
+      expect(deposit).to have_field(field)
     end
   end
 
@@ -17,7 +17,7 @@ describe NetSuite::Records::Deposit do
     [
       :custom_form, :account, :posting_period, :subsidiary, :department, :klass, :location
     ].each do |record_ref|
-      deposit.should have_record_ref(record_ref)
+      expect(deposit).to have_record_ref(record_ref)
     end
   end
 
@@ -31,14 +31,14 @@ describe NetSuite::Records::Deposit do
         }
       }
       deposit.payment_list.payment = attributes
-      deposit.payment_list.should be_kind_of(NetSuite::Records::DepositPaymentList)
-      deposit.payment_list.payments.length.should eql(1)
+      expect(deposit.payment_list).to be_kind_of(NetSuite::Records::DepositPaymentList)
+      expect(deposit.payment_list.payments.length).to eql(1)
     end
 
     it 'can be set from a DepositItemList object' do
       item_list = NetSuite::Records::DepositPaymentList.new
       deposit.payment_list = item_list
-      deposit.payment_list.should eql(item_list)
+      expect(deposit.payment_list).to eql(item_list)
     end
   end
 
@@ -49,14 +49,14 @@ describe NetSuite::Records::Deposit do
         memo: "test"
       }
       deposit.cash_back_list.cashback = attributes
-      deposit.cash_back_list.should be_kind_of(NetSuite::Records::DepositCashBackList)
-      deposit.cash_back_list.cashbacks.length.should eql(1)
+      expect(deposit.cash_back_list).to be_kind_of(NetSuite::Records::DepositCashBackList)
+      expect(deposit.cash_back_list.cashbacks.length).to eql(1)
     end
 
     it 'can be set from a DepositCashBackList object' do
       item_list = NetSuite::Records::DepositCashBackList.new
       deposit.cash_back_list = item_list
-      deposit.cash_back_list.should eql(item_list)
+      expect(deposit.cash_back_list).to eql(item_list)
     end
   end
 
@@ -65,10 +65,10 @@ describe NetSuite::Records::Deposit do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :memo => 'transfer for subscriptions' }) }
 
       it 'returns a Deposit instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Deposit, {:external_id => 1}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Deposit, {:external_id => 1}], {}).and_return(response)
         deposit = NetSuite::Records::Deposit.get(:external_id => 1)
-        deposit.should be_kind_of(NetSuite::Records::Deposit)
-        deposit.memo.should eql('transfer for subscriptions')
+        expect(deposit).to be_kind_of(NetSuite::Records::Deposit)
+        expect(deposit.memo).to eql('transfer for subscriptions')
       end
     end
 
@@ -76,10 +76,10 @@ describe NetSuite::Records::Deposit do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Deposit, {:external_id => 1}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Deposit, {:external_id => 1}], {}).and_return(response)
+        expect {
           NetSuite::Records::Deposit.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::Deposit with OPTIONS=(.*) could not be found/)
       end
     end
@@ -93,10 +93,10 @@ describe NetSuite::Records::Deposit do
 
       it 'returns true' do
         deposit = NetSuite::Records::Deposit.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([deposit], {}).
             and_return(response)
-        deposit.add.should be_truthy
+        expect(deposit.add).to be_truthy
       end
     end
 
@@ -105,10 +105,10 @@ describe NetSuite::Records::Deposit do
 
       it 'returns false' do
         deposit = NetSuite::Records::Deposit.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([deposit], {}).
             and_return(response)
-        deposit.add.should be_falsey
+        expect(deposit.add).to be_falsey
       end
     end
   end
@@ -121,10 +121,10 @@ describe NetSuite::Records::Deposit do
 
       it 'returns true' do
         deposit = NetSuite::Records::Deposit.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([deposit], {}).
             and_return(response)
-        deposit.delete.should be_truthy
+        expect(deposit.delete).to be_truthy
       end
     end
 
@@ -133,10 +133,10 @@ describe NetSuite::Records::Deposit do
 
       it 'returns false' do
         deposit = NetSuite::Records::Deposit.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([deposit], {}).
             and_return(response)
-        deposit.delete.should be_falsey
+        expect(deposit.delete).to be_falsey
       end
     end
   end
@@ -151,13 +151,13 @@ describe NetSuite::Records::Deposit do
         'tranBank:memo'  => 'something@example.com',
         'tranBank:tranId' => '4'
       }
-      deposit.to_record.should eql(record)
+      expect(deposit.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string representation of the SOAP type' do
-      deposit.record_type.should eql('tranBank:Deposit')
+      expect(deposit.record_type).to eql('tranBank:Deposit')
     end
   end
 

data/spec/netsuite/records/discount_item_spec.rb

@@ -8,11 +8,11 @@ describe NetSuite::Records::DiscountItem do
       :available_to_partners, :created_date, :description, :display_name, :include_children, :is_inactive, :is_pretax,
       :item_id, :last_modified_date, :non_posting, :rate, :upc_code, :vendor_name
     ].each do |field|
-      item.should have_field(field)
+      expect(item).to have_field(field)
     end
 
     # TODO there is a probably a more robust way to test this
-    item.custom_field_list.class.should == NetSuite::Records::CustomFieldList
+    expect(item.custom_field_list.class).to eq(NetSuite::Records::CustomFieldList)
   end
 
   it 'has the right record_refs' do
@@ -21,7 +21,7 @@ describe NetSuite::Records::DiscountItem do
       :income_account, :issue_product, :klass, :location, :parent, :rev_rec_schedule, :sales_tax_code,
       :subsidiary_list, :tax_schedule
     ].each do |record_ref|
-      item.should have_record_ref(record_ref)
+      expect(item).to have_record_ref(record_ref)
     end
   end
 
@@ -30,10 +30,10 @@ describe NetSuite::Records::DiscountItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :item_id => 'penguins' }) }
 
       it 'returns a DiscountItem instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::DiscountItem, :external_id => 20], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::DiscountItem, :external_id => 20], {}).and_return(response)
         customer = NetSuite::Records::DiscountItem.get(:external_id => 20)
-        customer.should be_kind_of(NetSuite::Records::DiscountItem)
-        customer.item_id.should eql('penguins')
+        expect(customer).to be_kind_of(NetSuite::Records::DiscountItem)
+        expect(customer.item_id).to eql('penguins')
       end
     end
 
@@ -41,10 +41,10 @@ describe NetSuite::Records::DiscountItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::DiscountItem, :external_id => 20], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::DiscountItem, :external_id => 20], {}).and_return(response)
+        expect {
           NetSuite::Records::DiscountItem.get(:external_id => 20)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::DiscountItem with OPTIONS=(.*) could not be found/)
       end
     end
@@ -57,10 +57,10 @@ describe NetSuite::Records::DiscountItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.add.should be_truthy
+        expect(item.add).to be_truthy
       end
     end
 
@@ -68,10 +68,10 @@ describe NetSuite::Records::DiscountItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.add.should be_falsey
+        expect(item.add).to be_falsey
       end
     end
   end
@@ -81,10 +81,10 @@ describe NetSuite::Records::DiscountItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.delete.should be_truthy
+        expect(item.delete).to be_truthy
       end
     end
 
@@ -92,10 +92,10 @@ describe NetSuite::Records::DiscountItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.delete.should be_falsey
+        expect(item.delete).to be_falsey
       end
     end
   end
@@ -111,13 +111,13 @@ describe NetSuite::Records::DiscountItem do
         'listAcct:itemId' => 'penguins',
         'listAcct:isInactive'     => true
       }
-      item.to_record.should eql(record)
+      expect(item.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string of the SOAP type' do
-      item.record_type.should eql('listAcct:DiscountItem')
+      expect(item.record_type).to eql('listAcct:DiscountItem')
     end
   end