netsuite 0.3.0 → 0.3.1

data/spec/netsuite/records/campaign_spec.rb

@@ -11,7 +11,7 @@ describe NetSuite::Records::Campaign do
       :offer, :owner, :profit, :promotion_code, :roi, :search_engine, :start_date, :title,
       :total_revenue, :unique_visitors, :url, :vertical
     ].each do |field|
-      campaign.should have_field(field)
+      expect(campaign).to have_field(field)
     end
   end
 
@@ -20,10 +20,10 @@ describe NetSuite::Records::Campaign do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :message => 'Message 1' }) }
 
       it 'returns a Campaign instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Campaign, {:external_id => 1}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Campaign, {:external_id => 1}], {}).and_return(response)
         campaign = NetSuite::Records::Campaign.get(:external_id => 1)
-        campaign.should be_kind_of(NetSuite::Records::Campaign)
-        campaign.message.should eql('Message 1')
+        expect(campaign).to be_kind_of(NetSuite::Records::Campaign)
+        expect(campaign.message).to eql('Message 1')
       end
     end
 
@@ -31,10 +31,10 @@ describe NetSuite::Records::Campaign do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Campaign, {:external_id => 1}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Campaign, {:external_id => 1}], {}).and_return(response)
+        expect {
           NetSuite::Records::Campaign.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::Campaign with OPTIONS=(.*) could not be found/)
       end
     end

data/spec/netsuite/records/classification_spec.rb

@@ -7,7 +7,7 @@ describe NetSuite::Records::Classification do
     [
       :name, :include_children, :is_inactive, :class_translation_list, :subsidiary_list, :custom_field_list
     ].each do |field|
-      classification.should have_field(field)
+      expect(classification).to have_field(field)
     end
   end
 
@@ -16,9 +16,9 @@ describe NetSuite::Records::Classification do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :name => 'Retail' }) }
 
       it 'returns an Invoice instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Classification, {:external_id => 10}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Classification, {:external_id => 10}], {}).and_return(response)
         invoice = NetSuite::Records::Classification.get(:external_id => 10)
-        invoice.should be_kind_of(NetSuite::Records::Classification)
+        expect(invoice).to be_kind_of(NetSuite::Records::Classification)
       end
     end
 
@@ -26,10 +26,10 @@ describe NetSuite::Records::Classification do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Classification, {:external_id => 10}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Classification, {:external_id => 10}], {}).and_return(response)
+        expect {
           NetSuite::Records::Classification.get(:external_id => 10)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::Classification with OPTIONS=(.*) could not be found/)
       end
     end
@@ -43,10 +43,10 @@ describe NetSuite::Records::Classification do
 
       it 'returns true' do
         classification = NetSuite::Records::Classification.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([classification], {}).
             and_return(response)
-        classification.delete.should be_truthy
+        expect(classification.delete).to be_truthy
       end
     end
 
@@ -55,10 +55,10 @@ describe NetSuite::Records::Classification do
 
       it 'returns false' do
         classification = NetSuite::Records::Classification.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([classification], {}).
             and_return(response)
-        classification.delete.should be_falsey
+        expect(classification.delete).to be_falsey
       end
     end
   end

data/spec/netsuite/records/credit_memo_apply_list_spec.rb

@@ -4,7 +4,7 @@ describe NetSuite::Records::CreditMemoApplyList do
   let(:list) { NetSuite::Records::CreditMemoApplyList.new }
 
   it 'has a applies attribute' do
-    list.applies.should be_kind_of(Array)
+    expect(list.applies).to be_kind_of(Array)
   end
 
   describe '#to_record' do
@@ -22,7 +22,7 @@ describe NetSuite::Records::CreditMemoApplyList do
           }
         }
       ]
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
   end
 end

data/spec/netsuite/records/credit_memo_apply_spec.rb

@@ -7,7 +7,7 @@ describe NetSuite::Records::CreditMemoApply do
     [
       :amount, :apply, :apply_date, :currency, :doc, :due, :job, :line, :ref_num, :total, :type
     ].each do |field|
-      apply.should have_field(field)
+      expect(apply).to have_field(field)
     end
   end
 

data/spec/netsuite/records/credit_memo_item_list_spec.rb

@@ -4,7 +4,7 @@ describe NetSuite::Records::CreditMemoItemList do
   let(:list) { NetSuite::Records::CreditMemoItemList.new }
 
   it 'has a items attribute' do
-    list.items.should be_kind_of(Array)
+    expect(list.items).to be_kind_of(Array)
   end
 
   describe '#to_record' do
@@ -22,7 +22,7 @@ describe NetSuite::Records::CreditMemoItemList do
           }
         }
       ]
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
   end
 end

data/spec/netsuite/records/credit_memo_item_spec.rb

@@ -11,7 +11,7 @@ describe NetSuite::Records::CreditMemoItem do
       :tax1_amt, :tax_rate1, :tax_rate2, :vsoe_allocation, :vsoe_amount, :vsoe_deferral, :vsoe_delivered, :vsoe_permit_discount,
       :vsoe_price
     ].each do |field|
-      item.should have_field(field)
+      expect(item).to have_field(field)
     end
   end
 
@@ -19,7 +19,7 @@ describe NetSuite::Records::CreditMemoItem do
     [
       :department, :item, :job, :klass, :location, :price, :rev_rec_schedule, :tax_code, :units
     ].each do |record_ref|
-      item.should have_record_ref(record_ref)
+      expect(item).to have_record_ref(record_ref)
     end
   end
 

data/spec/netsuite/records/credit_memo_spec.rb

@@ -16,7 +16,7 @@ describe NetSuite::Records::CreditMemo do
       :sync_sales_teams, :tax2_total, :tax_rate, :tax_total, :to_be_emailed, :to_be_faxed, :to_be_printed, :total,
       :total_cost_estimate, :tran_date, :tran_id, :tran_is_vsoe_bundle, :unapplied, :vat_reg_num, :vsoe_auto_calc
     ].each do |field|
-      memo.should have_field(field)
+      expect(memo).to have_field(field)
     end
   end
 
@@ -26,7 +26,7 @@ describe NetSuite::Records::CreditMemo do
       :handling_tax_code, :job, :klass, :lead_source, :location, :message_sel, :partner, :posting_period, :promo_code,
       :sales_group, :sales_rep, :ship_method, :shipping_tax_code, :subsidiary, :tax_item
     ].each do |record_ref|
-      memo.should have_record_ref(record_ref)
+      expect(memo).to have_record_ref(record_ref)
     end
   end
 
@@ -38,14 +38,14 @@ describe NetSuite::Records::CreditMemo do
         }
       }
       memo.item_list = attributes
-      memo.item_list.should be_kind_of(NetSuite::Records::CreditMemoItemList)
-      memo.item_list.items.length.should eql(1)
+      expect(memo.item_list).to be_kind_of(NetSuite::Records::CreditMemoItemList)
+      expect(memo.item_list.items.length).to eql(1)
     end
 
     it 'can be set from a CreditMemoItemList object' do
       item_list = NetSuite::Records::CreditMemoItemList.new
       memo.item_list = item_list
-      memo.item_list.should eql(item_list)
+      expect(memo.item_list).to eql(item_list)
     end
   end
 
@@ -57,14 +57,14 @@ describe NetSuite::Records::CreditMemo do
         }
       }
       memo.apply_list = attributes
-      memo.apply_list.should be_kind_of(NetSuite::Records::CreditMemoApplyList)
-      memo.apply_list.applies.length.should eql(1)
+      expect(memo.apply_list).to be_kind_of(NetSuite::Records::CreditMemoApplyList)
+      expect(memo.apply_list.applies.length).to eql(1)
     end
 
     it 'can be set from a CreditMemoApplyList object' do
       apply_list = NetSuite::Records::CreditMemoApplyList.new
       memo.apply_list = apply_list
-      memo.apply_list.should eql(apply_list)
+      expect(memo.apply_list).to eql(apply_list)
     end
   end
 
@@ -98,10 +98,10 @@ describe NetSuite::Records::CreditMemo do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :alt_shipping_cost => 100 }) }
 
       it 'returns a CreditMemo instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::CreditMemo, {:external_id => 1}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::CreditMemo, {:external_id => 1}], {}).and_return(response)
         memo = NetSuite::Records::CreditMemo.get(:external_id => 1)
-        memo.should be_kind_of(NetSuite::Records::CreditMemo)
-        memo.alt_shipping_cost.should eql(100)
+        expect(memo).to be_kind_of(NetSuite::Records::CreditMemo)
+        expect(memo.alt_shipping_cost).to eql(100)
       end
     end
 
@@ -109,10 +109,10 @@ describe NetSuite::Records::CreditMemo do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::CreditMemo, {:external_id => 1}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::CreditMemo, {:external_id => 1}], {}).and_return(response)
+        expect {
           NetSuite::Records::CreditMemo.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::CreditMemo with OPTIONS=(.*) could not be found/)
       end
     end
@@ -121,9 +121,9 @@ describe NetSuite::Records::CreditMemo do
   describe '.initialize' do
     context 'when the request is successful' do
       it 'returns an initialized credit memo from the customer entity' do
-        NetSuite::Actions::Initialize.should_receive(:call).with([NetSuite::Records::CreditMemo, customer], {}).and_return(response)
+        expect(NetSuite::Actions::Initialize).to receive(:call).with([NetSuite::Records::CreditMemo, customer], {}).and_return(response)
         invoice = NetSuite::Records::CreditMemo.initialize(customer)
-        invoice.should be_kind_of(NetSuite::Records::CreditMemo)
+        expect(invoice).to be_kind_of(NetSuite::Records::CreditMemo)
       end
     end
 
@@ -140,10 +140,10 @@ describe NetSuite::Records::CreditMemo do
 
       it 'returns true' do
         memo = NetSuite::Records::CreditMemo.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([memo], {}).
             and_return(response)
-        memo.add.should be_truthy
+        expect(memo.add).to be_truthy
       end
     end
 
@@ -152,10 +152,10 @@ describe NetSuite::Records::CreditMemo do
 
       it 'returns false' do
         memo = NetSuite::Records::CreditMemo.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([memo], {}).
             and_return(response)
-        memo.add.should be_falsey
+        expect(memo.add).to be_falsey
       end
     end
   end
@@ -168,10 +168,10 @@ describe NetSuite::Records::CreditMemo do
 
       it 'returns true' do
         memo = NetSuite::Records::CreditMemo.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([memo], {}).
             and_return(response)
-        memo.delete.should be_truthy
+        expect(memo.delete).to be_truthy
       end
     end
 
@@ -180,10 +180,10 @@ describe NetSuite::Records::CreditMemo do
 
       it 'returns false' do
         memo = NetSuite::Records::CreditMemo.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([memo], {}).
             and_return(response)
-        memo.delete.should be_falsey
+        expect(memo.delete).to be_falsey
       end
     end
   end
@@ -198,13 +198,13 @@ describe NetSuite::Records::CreditMemo do
         'tranCust:email'  => 'something@example.com',
         'tranCust:tranId' => '4'
       }
-      memo.to_record.should eql(record)
+      expect(memo.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string representation of the SOAP type' do
-      memo.record_type.should eql('tranCust:CreditMemo')
+      expect(memo.record_type).to eql('tranCust:CreditMemo')
     end
   end
 

data/spec/netsuite/records/custom_field_list_spec.rb

@@ -4,31 +4,31 @@ describe NetSuite::Records::CustomFieldList do
   let(:list) { NetSuite::Records::CustomFieldList.new }
 
   it 'has a custom_fields attribute' do
-    list.custom_fields.should be_kind_of(Array)
+    expect(list.custom_fields).to be_kind_of(Array)
   end
 
   context 'writing convience methods' do
     it "should create a custom field entry when none exists" do
       list.custrecord_somefield = 'a value'
-      list.custom_fields.size.should == 1
-      list.custom_fields.first.value.should == 'a value'
-      list.custom_fields.first.type.should == 'platformCore:StringCustomFieldRef'
+      expect(list.custom_fields.size).to eq(1)
+      expect(list.custom_fields.first.value).to eq('a value')
+      expect(list.custom_fields.first.type).to eq('platformCore:StringCustomFieldRef')
     end
 
     it "should handle date custom field creation" do
       list.custrecord_somefield = Date.parse("12/12/2012")
-      list.custom_fields.first.value.should == '2012-12-12T00:00:00+00:00'
+      expect(list.custom_fields.first.value).to eq('2012-12-12T00:00:00+00:00')
     end
 
     it "should handle datetime custom field creation" do
       list.custrecord_somefield = DateTime.parse("12/12/2012 10:05am")
-      list.custom_fields.first.value.should == '2012-12-12T10:05:00+00:00'
+      expect(list.custom_fields.first.value).to eq('2012-12-12T10:05:00+00:00')
     end
 
     it "should convert a list of numbers into a list of custom field refs" do
       list.custrecord_somefield = [1,2]
-      list.custom_fields.first.type.should == 'platformCore:MultiSelectCustomFieldRef'
-      list.custom_fields.first.value.map(&:to_record).should eql([
+      expect(list.custom_fields.first.type).to eq('platformCore:MultiSelectCustomFieldRef')
+      expect(list.custom_fields.first.value.map(&:to_record)).to eql([
         NetSuite::Records::CustomRecordRef.new(:internal_id => 1),
         NetSuite::Records::CustomRecordRef.new(:internal_id => 2)
       ].map(&:to_record))
@@ -75,8 +75,8 @@ describe NetSuite::Records::CustomFieldList do
         ]
       }
 
-      list.to_record.should eql(record)
-      list.to_record.length.should == 1
+      expect(list.to_record).to eql(record)
+      expect(list.to_record.length).to eq(1)
     end
   end
 

data/spec/netsuite/records/custom_list_spec.rb

@@ -4,7 +4,7 @@ describe NetSuite::Records::CustomList do
   let(:custom_list) { NetSuite::Records::CustomList.new }
 
   it 'has all the right fields' do
-    custom_list.should have_field(:script_id)
+    expect(custom_list).to have_field(:script_id)
   end
 
   it "should handle the #custom_value_list" do
@@ -15,7 +15,7 @@ describe NetSuite::Records::CustomList do
       }
     ]}
 
-    custom_list.custom_value_list.should be_kind_of(NetSuite::Support::Sublist)
-    custom_list.custom_value_list.custom_value.first.should be_kind_of(NetSuite::Records::CustomListCustomValue)
+    expect(custom_list.custom_value_list).to be_kind_of(NetSuite::Support::Sublist)
+    expect(custom_list.custom_value_list.custom_value.first).to be_kind_of(NetSuite::Records::CustomListCustomValue)
   end
 end

data/spec/netsuite/records/custom_record_spec.rb

@@ -12,7 +12,7 @@ describe NetSuite::Records::CustomRecord do
       :show_creation_date_on_list, :show_id, :show_last_modified, :show_last_modified_on_list, :show_notes, :show_owner,
       :show_owner_allow_change, :show_owner_on_list, :use_permissions
     ].each do |field|
-      record.should have_field(field)
+      expect(record).to have_field(field)
     end
   end
 
@@ -20,7 +20,7 @@ describe NetSuite::Records::CustomRecord do
     [
       :custom_form, :owner
     ].each do |record_ref|
-      record.should have_record_ref(record_ref)
+      expect(record).to have_record_ref(record_ref)
     end
   end
 
@@ -33,15 +33,15 @@ describe NetSuite::Records::CustomRecord do
         }
       }
       record.custom_field_list = attributes
-      record.custom_field_list.should be_kind_of(NetSuite::Records::CustomFieldList)
-      record.custom_field_list.custom_fields.length.should eql(1)
-      record.custom_field_list.custfield_amount.attributes[:amount].should eq(10)
+      expect(record.custom_field_list).to be_kind_of(NetSuite::Records::CustomFieldList)
+      expect(record.custom_field_list.custom_fields.length).to eql(1)
+      expect(record.custom_field_list.custfield_amount.attributes[:amount]).to eq(10)
     end
 
     it 'can be set from a CustomFieldList object' do
       custom_field_list = NetSuite::Records::CustomFieldList.new
       record.custom_field_list = custom_field_list
-      record.custom_field_list.should eql(custom_field_list)
+      expect(record.custom_field_list).to eql(custom_field_list)
     end
   end
 
@@ -50,12 +50,12 @@ describe NetSuite::Records::CustomRecord do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :allow_quick_search => true }) }
 
       it 'returns a Customer instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).
+        expect(NetSuite::Actions::Get).to receive(:call).
           with([NetSuite::Records::CustomRecord, {:external_id => 1, :type_id => nil, :custom => true}], {}).
           and_return(response)
         customer = NetSuite::Records::CustomRecord.get(:external_id => 1)
-        customer.should be_kind_of(NetSuite::Records::CustomRecord)
-        customer.allow_quick_search.should be_truthy
+        expect(customer).to be_kind_of(NetSuite::Records::CustomRecord)
+        expect(customer.allow_quick_search).to be_truthy
       end
     end
 
@@ -63,12 +63,12 @@ describe NetSuite::Records::CustomRecord do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).
+        expect(NetSuite::Actions::Get).to receive(:call).
           with([NetSuite::Records::CustomRecord, {:external_id => 1, :type_id => nil, :custom => true}], {}).
           and_return(response)
-        lambda {
+        expect {
           NetSuite::Records::CustomRecord.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::CustomRecord with OPTIONS=(.*) could not be found/)
       end
     end
@@ -79,10 +79,10 @@ describe NetSuite::Records::CustomRecord do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([record], {}).
             and_return(response)
-        record.add.should be_truthy
+        expect(record.add).to be_truthy
       end
     end
 
@@ -90,10 +90,10 @@ describe NetSuite::Records::CustomRecord do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([record], {}).
             and_return(response)
-        record.add.should be_falsey
+        expect(record.add).to be_falsey
       end
     end
   end
@@ -103,10 +103,10 @@ describe NetSuite::Records::CustomRecord do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([record, { :custom => true }], {}).
             and_return(response)
-        record.delete.should be_truthy
+        expect(record.delete).to be_truthy
       end
     end
 
@@ -114,10 +114,10 @@ describe NetSuite::Records::CustomRecord do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([record, { :custom => true }], {}).
             and_return(response)
-        record.delete.should be_falsey
+        expect(record.delete).to be_falsey
       end
     end
   end