netsuite 0.3.0 → 0.3.1

data/spec/netsuite/records/duration_spec.rb

@@ -7,7 +7,7 @@ describe NetSuite::Records::Duration do
     [
       :time_span, :unit
     ].each do |field|
-      duration.should have_field(field)
+      expect(duration).to have_field(field)
     end
   end
 

data/spec/netsuite/records/inventory_item_spec.rb

@@ -27,7 +27,7 @@ describe NetSuite::Records::InventoryItem do
       :transfer_price, :upc_code, :url_component, :use_bins, :use_marginal_rates, :vendor_name, :vsoe_deferral, :vsoe_delivered,
       :vsoe_permit_discount, :vsoe_price, :weight, :weight_unit, :weight_units
     ].each do |field|
-      item.should have_field(field)
+      expect(item).to have_field(field)
     end
   end
 
@@ -35,7 +35,7 @@ describe NetSuite::Records::InventoryItem do
     [
       :alternate_demand_source_item, :asset_account, :bill_exch_rate_variance_acct, :bill_price_variance_acct, :bill_qty_variance_acct, :billing_schedule, :cogs_account, :cost_category, :custom_form, :deferred_revenue_account, :demand_source, :department, :expense_account, :gain_loss_account, :income_account, :issue_product, :klass, :location, :parent, :preferred_location, :pricing_group, :purchase_price_variance_acct, :purchase_tax_code, :purchase_unit, :quantity_pricing_schedule, :rev_rec_schedule, :sale_unit, :sales_tax_code, :ship_package, :soft_descriptor, :stock_unit, :store_display_image, :store_display_thumbnail, :store_item_template, :supply_lot_sizing_method, :supply_replenishment_method, :supply_type, :tax_schedule, :units_type, :vendor
     ].each do |record_ref|
-      item.should have_record_ref(record_ref)
+      expect(item).to have_record_ref(record_ref)
     end
   end
 
@@ -104,10 +104,10 @@ describe NetSuite::Records::InventoryItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :cost => 100 }) }
 
       it 'returns a InventoryItem instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::InventoryItem, {:external_id => 1}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::InventoryItem, {:external_id => 1}], {}).and_return(response)
         item = NetSuite::Records::InventoryItem.get(:external_id => 1)
-        item.should be_kind_of(NetSuite::Records::InventoryItem)
-        item.cost.should eql(100)
+        expect(item).to be_kind_of(NetSuite::Records::InventoryItem)
+        expect(item.cost).to eql(100)
       end
     end
 
@@ -115,10 +115,10 @@ describe NetSuite::Records::InventoryItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::InventoryItem, {:external_id => 1}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::InventoryItem, {:external_id => 1}], {}).and_return(response)
+        expect {
           NetSuite::Records::InventoryItem.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::InventoryItem with OPTIONS=(.*) could not be found/)
       end
     end
@@ -131,10 +131,10 @@ describe NetSuite::Records::InventoryItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.add.should be_truthy
+        expect(item.add).to be_truthy
       end
     end
 
@@ -142,10 +142,10 @@ describe NetSuite::Records::InventoryItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.add.should be_falsey
+        expect(item.add).to be_falsey
       end
     end
   end
@@ -155,10 +155,10 @@ describe NetSuite::Records::InventoryItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.delete.should be_truthy
+        expect(item.delete).to be_truthy
       end
     end
 
@@ -166,10 +166,10 @@ describe NetSuite::Records::InventoryItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.delete.should be_falsey
+        expect(item.delete).to be_falsey
       end
     end
   end
@@ -184,13 +184,13 @@ describe NetSuite::Records::InventoryItem do
         'listAcct:cost'       => 100,
         'listAcct:isInactive' => false
       }
-      item.to_record.should eql(record)
+      expect(item.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string representation of the SOAP type' do
-      item.record_type.should eql('listAcct:InventoryItem')
+      expect(item.record_type).to eql('listAcct:InventoryItem')
     end
   end
 

data/spec/netsuite/records/inventory_transfer_spec.rb

@@ -7,7 +7,7 @@ describe NetSuite::Records::InventoryTransfer do
     [
       :created_date, :last_modified_date, :tran_date, :tran_id, :memo
     ].each do |field|
-      inventory_transfer.should have_field(field)
+      expect(inventory_transfer).to have_field(field)
     end
   end
 
@@ -15,7 +15,7 @@ describe NetSuite::Records::InventoryTransfer do
     [
       :posting_period, :location, :transfer_location, :department, :subsidiary
     ].each do |record_ref|
-      inventory_transfer.should have_record_ref(record_ref)
+      expect(inventory_transfer).to have_record_ref(record_ref)
     end
   end
 
@@ -37,8 +37,8 @@ describe NetSuite::Records::InventoryTransfer do
         }]
       }
       inventory_transfer.inventory_list = attributes
-      inventory_transfer.inventory_list.should be_kind_of(NetSuite::Records::InventoryTransferInventoryList)
-      inventory_transfer.inventory_list.inventory.length.should eql(1)
+      expect(inventory_transfer.inventory_list).to be_kind_of(NetSuite::Records::InventoryTransferInventoryList)
+      expect(inventory_transfer.inventory_list.inventory.length).to eql(1)
 
       expect(
         inventory_transfer.inventory_list.inventory.first.inventory_detail.inventory_assignment_list.inventory_assignment.first.quantity
@@ -52,7 +52,7 @@ describe NetSuite::Records::InventoryTransfer do
     it 'can be set from a InventoryTransferInventoryList object' do
       inventory_list = NetSuite::Records::InventoryTransferInventoryList.new
       inventory_transfer.inventory_list = inventory_list
-      inventory_transfer.inventory_list.should eql(inventory_list)
+      expect(inventory_transfer.inventory_list).to eql(inventory_list)
     end
   end
 end

data/spec/netsuite/records/invoice_item_list_spec.rb

@@ -7,9 +7,9 @@ describe NetSuite::Records::InvoiceItemList do
   it 'can have items be added to it' do
     list.items << item
     item_list = list.items
-    item_list.should be_kind_of(Array)
-    item_list.length.should eql(1)
-    item_list.each { |i| i.should be_kind_of(NetSuite::Records::InvoiceItem) }
+    expect(item_list).to be_kind_of(Array)
+    expect(item_list.length).to eql(1)
+    item_list.each { |i| expect(i).to be_kind_of(NetSuite::Records::InvoiceItem) }
   end
 
   describe '#to_record' do
@@ -17,7 +17,7 @@ describe NetSuite::Records::InvoiceItemList do
       record = {
         'tranSales:item' => []
       }
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
   end
 

data/spec/netsuite/records/invoice_item_spec.rb

@@ -13,7 +13,7 @@ describe NetSuite::Records::InvoiceItem do
       :tax1_amt, :tax_rate1, :tax_rate2, :vsoe_allocation, :vsoe_amount, :vsoe_deferral, :vsoe_delivered, :vsoe_permit_discount,
       :vsoe_price
     ].each do |field|
-      item.should have_field(field)
+      expect(item).to have_field(field)
     end
   end
 
@@ -22,16 +22,16 @@ describe NetSuite::Records::InvoiceItem do
       :department, :item, :job, :location, :price, :rev_rec_schedule, :ship_address, :ship_method, :tax_code, :units,
       :klass
     ].each do |record_ref|
-      item.should have_record_ref(record_ref)
+      expect(item).to have_record_ref(record_ref)
     end
   end
 
   it 'can initialize from a record' do
     record = NetSuite::Records::InvoiceItem.new(:amount => 123, :cost_estimate => 234)
     item   = NetSuite::Records::InvoiceItem.new(record)
-    item.should be_kind_of(NetSuite::Records::InvoiceItem)
-    item.amount.should eql(123)
-    item.cost_estimate.should eql(234)
+    expect(item).to be_kind_of(NetSuite::Records::InvoiceItem)
+    expect(item.amount).to eql(123)
+    expect(item.cost_estimate).to eql(234)
   end
 
   describe '#custom_field_list' do
@@ -43,15 +43,15 @@ describe NetSuite::Records::InvoiceItem do
         }
       }
       item.custom_field_list = attributes
-      item.custom_field_list.should be_kind_of(NetSuite::Records::CustomFieldList)
-      item.custom_field_list.custom_fields.length.should eql(1)
-      item.custom_field_list.custfield_value.attributes[:value].should eq(10)
+      expect(item.custom_field_list).to be_kind_of(NetSuite::Records::CustomFieldList)
+      expect(item.custom_field_list.custom_fields.length).to eql(1)
+      expect(item.custom_field_list.custfield_value.attributes[:value]).to eq(10)
     end
 
     it 'can be set from a CustomFieldList object' do
       custom_field_list = NetSuite::Records::CustomFieldList.new
       item.custom_field_list = custom_field_list
-      item.custom_field_list.should eql(custom_field_list)
+      expect(item.custom_field_list).to eql(custom_field_list)
     end
   end
 
@@ -66,13 +66,13 @@ describe NetSuite::Records::InvoiceItem do
         'tranSales:amount'      => '7',
         'tranSales:description' => 'Some thingy'
       }
-      item.to_record.should eql(record)
+      expect(item.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string of the SOAP record type' do
-      item.record_type.should eql('tranSales:InvoiceItem')
+      expect(item.record_type).to eql('tranSales:InvoiceItem')
     end
   end
 

data/spec/netsuite/records/invoice_spec.rb

@@ -28,7 +28,7 @@ describe NetSuite::Records::Invoice do
       :to_be_printed, :total_cost_estimate, :tracking_numbers, :tran_date, :tran_id, :tran_is_vsoe_bundle,
       :vat_reg_num, :vsoe_auto_calc
     ].each do |field|
-      invoice.should have_field(field)
+      expect(invoice).to have_field(field)
     end
   end
 
@@ -37,7 +37,7 @@ describe NetSuite::Records::Invoice do
       :sub_total, :discount_total, :total, :alt_handling_cost, :alt_shipping_cost, :gift_cert_applied, :tax_rate,
       :handling_cost, :recognized_revenue, :amount_remaining, :amount_paid
     ].each do |field|
-      NetSuite::Records::Invoice.should have_read_only_field(field)
+      expect(NetSuite::Records::Invoice).to have_read_only_field(field)
     end
   end
 
@@ -46,7 +46,7 @@ describe NetSuite::Records::Invoice do
       :account, :bill_address_list, :custom_form, :department, :entity, :klass, :posting_period, :ship_address_list, :terms,
       :created_from, :location, :sales_rep, :ship_method, :tax_item, :partner
     ].each do |record_ref|
-      invoice.should have_record_ref(record_ref)
+      expect(invoice).to have_record_ref(record_ref)
     end
   end
 
@@ -59,14 +59,14 @@ describe NetSuite::Records::Invoice do
         }
       }
       invoice.custom_field_list = attributes
-      invoice.custom_field_list.should be_kind_of(NetSuite::Records::CustomFieldList)
-      invoice.custom_field_list.custom_fields.length.should eql(1)
+      expect(invoice.custom_field_list).to be_kind_of(NetSuite::Records::CustomFieldList)
+      expect(invoice.custom_field_list.custom_fields.length).to eql(1)
     end
 
     it 'can be set from a CustomFieldList object' do
       custom_field_list = NetSuite::Records::CustomFieldList.new
       invoice.custom_field_list = custom_field_list
-      invoice.custom_field_list.should eql(custom_field_list)
+      expect(invoice.custom_field_list).to eql(custom_field_list)
     end
   end
 
@@ -78,14 +78,14 @@ describe NetSuite::Records::Invoice do
         }
       }
       invoice.item_list = attributes
-      invoice.item_list.should be_kind_of(NetSuite::Records::InvoiceItemList)
-      invoice.item_list.items.length.should eql(1)
+      expect(invoice.item_list).to be_kind_of(NetSuite::Records::InvoiceItemList)
+      expect(invoice.item_list.items.length).to eql(1)
     end
 
     it 'can be set from a CustomFieldList object' do
       item_list = NetSuite::Records::InvoiceItemList.new
       invoice.item_list = item_list
-      invoice.item_list.should eql(item_list)
+      expect(invoice.item_list).to eql(item_list)
     end
   end
 
@@ -99,14 +99,14 @@ describe NetSuite::Records::Invoice do
         :bill_state               => 'CA',
         :bill_zip                 => '90007'
       }
-      invoice.transaction_bill_address.should be_kind_of(NetSuite::Records::BillAddress)
-      invoice.transaction_bill_address.bill_city.should eql('Los Angeles')
+      expect(invoice.transaction_bill_address).to be_kind_of(NetSuite::Records::BillAddress)
+      expect(invoice.transaction_bill_address.bill_city).to eql('Los Angeles')
     end
 
     it 'can be set with a BillAddress object' do
       bill_address = NetSuite::Records::BillAddress.new
       invoice.transaction_bill_address = bill_address
-      invoice.transaction_bill_address.should eql(bill_address)
+      expect(invoice.transaction_bill_address).to eql(bill_address)
     end
   end
 
@@ -121,14 +121,14 @@ describe NetSuite::Records::Invoice do
         :ship_state               => 'CA',
         :ship_zip                 => '90007'
       }
-      invoice.transaction_ship_address.should be_kind_of(NetSuite::Records::ShipAddress)
-      invoice.transaction_ship_address.ship_addr1.should eql('123 Happy Lane')
+      expect(invoice.transaction_ship_address).to be_kind_of(NetSuite::Records::ShipAddress)
+      expect(invoice.transaction_ship_address.ship_addr1).to eql('123 Happy Lane')
     end
 
     it 'can be set with a ShipAddress object' do
       ship_address = NetSuite::Records::ShipAddress.new
       invoice.transaction_ship_address = ship_address
-      invoice.transaction_ship_address.should eql(ship_address)
+      expect(invoice.transaction_ship_address).to eql(ship_address)
     end
   end
 
@@ -137,9 +137,9 @@ describe NetSuite::Records::Invoice do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :is_person => true }) }
 
       it 'returns an Invoice instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Invoice, {:external_id => 10}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Invoice, {:external_id => 10}], {}).and_return(response)
         invoice = NetSuite::Records::Invoice.get(:external_id => 10)
-        invoice.should be_kind_of(NetSuite::Records::Invoice)
+        expect(invoice).to be_kind_of(NetSuite::Records::Invoice)
       end
     end
 
@@ -147,10 +147,10 @@ describe NetSuite::Records::Invoice do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Invoice, {:external_id => 10}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Invoice, {:external_id => 10}], {}).and_return(response)
+        expect {
           NetSuite::Records::Invoice.get(:external_id => 10)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::Invoice with OPTIONS=(.*) could not be found/)
       end
     end
@@ -159,9 +159,9 @@ describe NetSuite::Records::Invoice do
   describe '.initialize' do
     context 'when the request is successful' do
       it 'returns an initialized invoice from the customer entity' do
-        NetSuite::Actions::Initialize.should_receive(:call).with([NetSuite::Records::Invoice, customer], {}).and_return(response)
+        expect(NetSuite::Actions::Initialize).to receive(:call).with([NetSuite::Records::Invoice, customer], {}).and_return(response)
         invoice = NetSuite::Records::Invoice.initialize(customer)
-        invoice.should be_kind_of(NetSuite::Records::Invoice)
+        expect(invoice).to be_kind_of(NetSuite::Records::Invoice)
       end
     end
 
@@ -178,10 +178,10 @@ describe NetSuite::Records::Invoice do
 
       it 'returns true' do
         invoice = NetSuite::Records::Invoice.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([invoice], {}).
             and_return(response)
-        invoice.add.should be_truthy
+        expect(invoice.add).to be_truthy
       end
     end
 
@@ -190,10 +190,10 @@ describe NetSuite::Records::Invoice do
 
       it 'returns false' do
         invoice = NetSuite::Records::Invoice.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([invoice], {}).
             and_return(response)
-        invoice.add.should be_falsey
+        expect(invoice.add).to be_falsey
       end
     end
   end
@@ -204,10 +204,10 @@ describe NetSuite::Records::Invoice do
 
       it 'returns true' do
         invoice = NetSuite::Records::Invoice.new
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([invoice], {}).
             and_return(response)
-        invoice.delete.should be_truthy
+        expect(invoice.delete).to be_truthy
       end
     end
 
@@ -216,10 +216,10 @@ describe NetSuite::Records::Invoice do
 
       it 'returns false' do
         invoice = NetSuite::Records::Invoice.new
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([invoice], {}).
             and_return(response)
-        invoice.delete.should be_falsey
+        expect(invoice.delete).to be_falsey
       end
     end
   end
@@ -234,13 +234,13 @@ describe NetSuite::Records::Invoice do
         'tranSales:email'  => 'something@example.com',
         'tranSales:tranId' => '4'
       }
-      invoice.to_record.should eql(record)
+      expect(invoice.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string representation of the SOAP type' do
-      invoice.record_type.should eql('tranSales:Invoice')
+      expect(invoice.record_type).to eql('tranSales:Invoice')
     end
   end
 

data/spec/netsuite/records/item_fulfillment_package_list_spec.rb

@@ -4,7 +4,7 @@ describe NetSuite::Records::ItemFulfillmentPackageList do
   let(:list) { NetSuite::Records::ItemFulfillmentPackageList.new }
 
   it 'has a packages attribute' do
-    list.packages.should be_kind_of(Array)
+    expect(list.packages).to be_kind_of(Array)
   end
 
   describe '#to_record' do
@@ -21,7 +21,7 @@ describe NetSuite::Records::ItemFulfillmentPackageList do
           ]
         }
       
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
   end
 end