netsuite 0.3.0 → 0.3.1

data/spec/netsuite/records/non_inventory_sale_item_spec.rb

@@ -20,12 +20,12 @@ describe NetSuite::Records::NonInventorySaleItem do
       :store_detailed_description, :store_display_name, :translations_list, :upc_code, :url_component, :use_marginal_rates,
       :vsoe_deferral, :vsoe_delivered, :vsoe_permit_discount, :vsoe_price, :weight, :weight_unit, :weight_units
     ].each do |field|
-      item.should have_field(field)
+      expect(item).to have_field(field)
     end
 
     # TODO there is a probably a more robust way to test this
-    item.custom_field_list.class.should == NetSuite::Records::CustomFieldList
-    item.pricing_matrix.class.should == NetSuite::Records::PricingMatrix
+    expect(item.custom_field_list.class).to eq(NetSuite::Records::CustomFieldList)
+    expect(item.pricing_matrix.class).to eq(NetSuite::Records::PricingMatrix)
   end
 
   it 'has the right record_refs' do
@@ -35,7 +35,7 @@ describe NetSuite::Records::NonInventorySaleItem do
       :rev_rec_schedule, :sale_unit, :sales_tax_code, :ship_package, :store_display_image, :store_display_thumbnail,
       :store_item_template, :subsidiary_list, :tax_schedule, :units_type
     ].each do |record_ref|
-      item.should have_record_ref(record_ref)
+      expect(item).to have_record_ref(record_ref)
     end
   end
 
@@ -44,10 +44,10 @@ describe NetSuite::Records::NonInventorySaleItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :manufacturer_zip => '90401' }) }
 
       it 'returns a NonInventorySaleItem instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::NonInventorySaleItem, {:external_id => 20}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::NonInventorySaleItem, {:external_id => 20}], {}).and_return(response)
         customer = NetSuite::Records::NonInventorySaleItem.get(:external_id => 20)
-        customer.should be_kind_of(NetSuite::Records::NonInventorySaleItem)
-        customer.manufacturer_zip.should eql('90401')
+        expect(customer).to be_kind_of(NetSuite::Records::NonInventorySaleItem)
+        expect(customer.manufacturer_zip).to eql('90401')
       end
     end
 
@@ -55,10 +55,10 @@ describe NetSuite::Records::NonInventorySaleItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::NonInventorySaleItem, {:external_id => 20}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::NonInventorySaleItem, {:external_id => 20}], {}).and_return(response)
+        expect {
           NetSuite::Records::NonInventorySaleItem.get(:external_id => 20)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::NonInventorySaleItem with OPTIONS=(.*) could not be found/)
       end
     end
@@ -71,10 +71,10 @@ describe NetSuite::Records::NonInventorySaleItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.add.should be_truthy
+        expect(item.add).to be_truthy
       end
     end
 
@@ -82,10 +82,10 @@ describe NetSuite::Records::NonInventorySaleItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.add.should be_falsey
+        expect(item.add).to be_falsey
       end
     end
   end
@@ -95,10 +95,10 @@ describe NetSuite::Records::NonInventorySaleItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.delete.should be_truthy
+        expect(item.delete).to be_truthy
       end
     end
 
@@ -106,10 +106,10 @@ describe NetSuite::Records::NonInventorySaleItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.delete.should be_falsey
+        expect(item.delete).to be_falsey
       end
     end
   end
@@ -125,13 +125,13 @@ describe NetSuite::Records::NonInventorySaleItem do
         'listAcct:handlingCost' => 100.0,
         'listAcct:isOnline'     => true
       }
-      item.to_record.should eql(record)
+      expect(item.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string of the SOAP type' do
-      item.record_type.should eql('listAcct:NonInventorySaleItem')
+      expect(item.record_type).to eql('listAcct:NonInventorySaleItem')
     end
   end
 

data/spec/netsuite/records/payment_method_spec.rb

@@ -8,7 +8,7 @@ describe NetSuite::Records::PaymentMethod do
       :credit_card, :express_checkout_arrangement, :is_debit_card, :is_inactive, :is_online, :name, :pay_pal_email_address,
       :undep_funds, :use_express_checkout
     ].each do |field|
-      payment_method.should have_field(field)
+      expect(payment_method).to have_field(field)
     end
   end
 
@@ -16,7 +16,7 @@ describe NetSuite::Records::PaymentMethod do
     [
       :account
     ].each do |record_ref|
-      payment_method.should have_record_ref(record_ref)
+      expect(payment_method).to have_record_ref(record_ref)
     end
   end
 
@@ -30,10 +30,10 @@ describe NetSuite::Records::PaymentMethod do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :is_debit_card => true }) }
 
       it 'returns an PaymentMethod instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::PaymentMethod, :external_id => 10], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::PaymentMethod, :external_id => 10], {}).and_return(response)
         payment_method = NetSuite::Records::PaymentMethod.get(:external_id => 10)
-        payment_method.should be_kind_of(NetSuite::Records::PaymentMethod)
-        payment_method.is_debit_card.should be_truthy
+        expect(payment_method).to be_kind_of(NetSuite::Records::PaymentMethod)
+        expect(payment_method.is_debit_card).to be_truthy
       end
     end
 
@@ -41,10 +41,10 @@ describe NetSuite::Records::PaymentMethod do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::PaymentMethod, :external_id => 10], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::PaymentMethod, :external_id => 10], {}).and_return(response)
+        expect {
           NetSuite::Records::PaymentMethod.get(:external_id => 10)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::PaymentMethod with OPTIONS=(.*) could not be found/)
       end
     end

data/spec/netsuite/records/phone_call_spec.rb

@@ -5,13 +5,13 @@ describe NetSuite::Records::PhoneCall do
 
   it "has the right fields" do
     [:title, :message, :phone, :status, :priority, :start_date, :end_date, :completed_date, :timed_event, :access_level].each do |f|
-      phone_call.should have_field(f)
+      expect(phone_call).to have_field(f)
     end
   end
 
   it 'has the right record refs' do
     [:assigned, :owner, :company, :contact].each do |rr|
-      phone_call.should have_record_ref(rr)
+      expect(phone_call).to have_record_ref(rr)
     end
   end
 end

data/spec/netsuite/records/pomo_code_spec.rb

@@ -8,7 +8,7 @@ describe NetSuite::Records::PromotionCode do
              :exclude_items, :is_inactive, :is_public, :minimum_order_amount, :name, :number_to_generate,
              :rate, :start_date
     ].each do |field|
-      promo_code.should have_field(field)
+      expect(promo_code).to have_field(field)
     end
   end
 
@@ -17,10 +17,10 @@ describe NetSuite::Records::PromotionCode do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :code => 'SUMMERSALE' }) }
 
       it 'returns a Campaign instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::PromotionCode, {:external_id => 1}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::PromotionCode, {:external_id => 1}], {}).and_return(response)
         promo_code = NetSuite::Records::PromotionCode.get(:external_id => 1)
-        promo_code.should be_kind_of(NetSuite::Records::PromotionCode)
-        promo_code.code.should eql('SUMMERSALE')
+        expect(promo_code).to be_kind_of(NetSuite::Records::PromotionCode)
+        expect(promo_code.code).to eql('SUMMERSALE')
       end
     end
 
@@ -28,10 +28,10 @@ describe NetSuite::Records::PromotionCode do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::PromotionCode, {:external_id => 1}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::PromotionCode, {:external_id => 1}], {}).and_return(response)
+        expect {
           NetSuite::Records::PromotionCode.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::PromotionCode with OPTIONS=(.*) could not be found/)
       end
     end

data/spec/netsuite/records/record_ref_spec.rb

@@ -7,26 +7,26 @@ describe NetSuite::Records::RecordRef do
     context 'when passing in as plain attribute to initialize' do
       it 'correctly sets the internal_id' do
         record_ref = NetSuite::Records::RecordRef.new(:internal_id => '1')
-        record_ref.internal_id.should eql('1')
+        expect(record_ref.internal_id).to eql('1')
       end
     end
 
     context 'when passing in as swirly attributes to initialize' do
       it 'correctly sets the internal_id' do
         record_ref = NetSuite::Records::RecordRef.new(:@internal_id => '2')
-        record_ref.internal_id.should eql('2')
+        expect(record_ref.internal_id).to eql('2')
       end
     end
 
     context 'when not passed in as an attribute to initialize' do
       it 'does not set an internal_id' do
         record_ref = NetSuite::Records::RecordRef.new
-        record_ref.internal_id.should be_nil
+        expect(record_ref.internal_id).to be_nil
       end
     end
 
     it 'has no public internal_id setter' do
-      record_ref.should_not respond_to(:internal_id=)
+      expect(record_ref).not_to respond_to(:internal_id=)
     end
   end
 
@@ -40,8 +40,8 @@ describe NetSuite::Records::RecordRef do
 
     context 'readers' do
       it 'can take on arbitrary attributes into itself on initialization' do
-        record_ref.name.should eql('This is a record_ref')
-        record_ref.banana.should eql('for monkeys')
+        expect(record_ref.name).to eql('This is a record_ref')
+        expect(record_ref.banana).to eql('for monkeys')
       end
     end
   end
@@ -54,7 +54,7 @@ describe NetSuite::Records::RecordRef do
     end
 
     it 'ignores untouchable attributes' do
-      record_ref.instance_variable_get('@attributes').keys.should_not include(:"@xmlns:platform_core")
+      expect(record_ref.instance_variable_get('@attributes').keys).not_to include(:"@xmlns:platform_core")
     end
   end
 
@@ -62,9 +62,9 @@ describe NetSuite::Records::RecordRef do
     it 'initializes a new ref with the proper attributes from the record' do
       record = NetSuite::Records::Classification.new(:is_inactive => false, :name => 'Retail', :internal_id => '9')
       record_ref = NetSuite::Records::RecordRef.new(record)
-      record_ref.should be_kind_of(NetSuite::Records::RecordRef)
-      record_ref.internal_id.should eql('9')
-      record_ref.type.should eql('classification')
+      expect(record_ref).to be_kind_of(NetSuite::Records::RecordRef)
+      expect(record_ref.internal_id).to eql('9')
+      expect(record_ref.type).to eql('classification')
     end
   end
 
@@ -74,13 +74,13 @@ describe NetSuite::Records::RecordRef do
       record = {
         'platformCore:something' => 'blah'
       }
-      record_ref.to_record.should eql(record)
+      expect(record_ref.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string of the SOAP type' do
-      record_ref.record_type.should eql('platformCore:RecordRef')
+      expect(record_ref.record_type).to eql('platformCore:RecordRef')
     end
   end
 

data/spec/netsuite/records/rev_rec_template_spec.rb

@@ -7,7 +7,7 @@ describe NetSuite::Records::RevRecTemplate do
     [
       :name, :is_inactive
     ].each do |field|
-      template.should have_field(field)
+      expect(template).to have_field(field)
     end
   end
 
@@ -16,10 +16,10 @@ describe NetSuite::Records::RevRecTemplate do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :name => 'A template' }) }
 
       it 'returns an RevRecTemplate instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::RevRecTemplate, :external_id => 10], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::RevRecTemplate, :external_id => 10], {}).and_return(response)
         template = NetSuite::Records::RevRecTemplate.get(:external_id => 10)
-        template.should be_kind_of(NetSuite::Records::RevRecTemplate)
-        template.name.should eql('A template')
+        expect(template).to be_kind_of(NetSuite::Records::RevRecTemplate)
+        expect(template.name).to eql('A template')
       end
     end
 
@@ -27,10 +27,10 @@ describe NetSuite::Records::RevRecTemplate do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::RevRecTemplate, :external_id => 10], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::RevRecTemplate, :external_id => 10], {}).and_return(response)
+        expect {
           NetSuite::Records::RevRecTemplate.get(:external_id => 10)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::RevRecTemplate with OPTIONS=(.*) could not be found/)
       end
     end

data/spec/netsuite/records/sales_order_item_list_spec.rb

@@ -4,7 +4,7 @@ describe NetSuite::Records::SalesOrderItemList do
   let(:list) { NetSuite::Records::SalesOrderItemList.new }
 
   it 'has a items attribute' do
-    list.items.should be_kind_of(Array)
+    expect(list.items).to be_kind_of(Array)
   end
 
   describe '#to_record' do
@@ -20,7 +20,7 @@ describe NetSuite::Records::SalesOrderItemList do
           'tranSales:rate' => 10
         }]
       }
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
   end
 end

data/spec/netsuite/records/sales_order_item_spec.rb

@@ -11,7 +11,7 @@ describe NetSuite::Records::SalesOrderItem do
       :tax1_amt, :tax_rate1, :tax_rate2, :vsoe_allocation, :vsoe_amount, :vsoe_deferral, :vsoe_delivered, :vsoe_permit_discount,
       :vsoe_price
     ].each do |field|
-      item.should have_field(field)
+      expect(item).to have_field(field)
     end
   end
 
@@ -19,7 +19,7 @@ describe NetSuite::Records::SalesOrderItem do
     [
       :department, :item, :job, :klass, :location, :price, :rev_rec_schedule, :tax_code, :units
     ].each do |record_ref|
-      item.should have_record_ref(record_ref)
+      expect(item).to have_record_ref(record_ref)
     end
   end
 

data/spec/netsuite/records/sales_order_spec.rb

@@ -19,7 +19,7 @@ describe NetSuite::Records::SalesOrder do
       :total, :total_cost_estimate, :tran_date, :tran_id, :tran_is_vsoe_bundle, :unapplied, :vat_reg_num,
       :vsoe_auto_calc, :cc_approved
     ].each do |field|
-      salesorder.should have_field(field)
+      expect(salesorder).to have_field(field)
     end
   end
 
@@ -30,7 +30,7 @@ describe NetSuite::Records::SalesOrder do
       :opportunity, :partner, :posting_period, :promo_code, :sales_group, :sales_rep,
       :ship_method, :shipping_tax_code, :subsidiary, :tax_item
     ].each do |record_ref|
-      salesorder.should have_record_ref(record_ref)
+      expect(salesorder).to have_record_ref(record_ref)
     end
   end
 
@@ -47,14 +47,14 @@ describe NetSuite::Records::SalesOrder do
         }
       }
       salesorder.item_list = attributes
-      salesorder.item_list.should be_kind_of(NetSuite::Records::SalesOrderItemList)
-      salesorder.item_list.items.length.should eql(1)
+      expect(salesorder.item_list).to be_kind_of(NetSuite::Records::SalesOrderItemList)
+      expect(salesorder.item_list.items.length).to eql(1)
     end
 
     it 'can be set from a SalesOrderItemList object' do
       item_list = NetSuite::Records::SalesOrderItemList.new
       salesorder.item_list = item_list
-      salesorder.item_list.should eql(item_list)
+      expect(salesorder.item_list).to eql(item_list)
     end
   end
 
@@ -93,10 +93,10 @@ describe NetSuite::Records::SalesOrder do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :alt_shipping_cost => 100 }) }
 
       it 'returns a SalesOrder instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::SalesOrder, :external_id => 1], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::SalesOrder, :external_id => 1], {}).and_return(response)
         salesorder = NetSuite::Records::SalesOrder.get(:external_id => 1)
-        salesorder.should be_kind_of(NetSuite::Records::SalesOrder)
-        salesorder.alt_shipping_cost.should eql(100)
+        expect(salesorder).to be_kind_of(NetSuite::Records::SalesOrder)
+        expect(salesorder.alt_shipping_cost).to eql(100)
       end
     end
 
@@ -104,10 +104,10 @@ describe NetSuite::Records::SalesOrder do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::SalesOrder, :external_id => 1], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::SalesOrder, :external_id => 1], {}).and_return(response)
+        expect {
           NetSuite::Records::SalesOrder.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::SalesOrder with OPTIONS=(.*) could not be found/)
       end
     end
@@ -116,9 +116,9 @@ describe NetSuite::Records::SalesOrder do
   describe '.initialize' do
     context 'when the request is successful' do
       it 'returns an initialized sales order from the customer entity' do
-        NetSuite::Actions::Initialize.should_receive(:call).with([NetSuite::Records::SalesOrder, customer], {}).and_return(response)
+        expect(NetSuite::Actions::Initialize).to receive(:call).with([NetSuite::Records::SalesOrder, customer], {}).and_return(response)
         salesorder = NetSuite::Records::SalesOrder.initialize(customer)
-        salesorder.should be_kind_of(NetSuite::Records::SalesOrder)
+        expect(salesorder).to be_kind_of(NetSuite::Records::SalesOrder)
       end
     end
 
@@ -135,10 +135,10 @@ describe NetSuite::Records::SalesOrder do
 
       it 'returns true' do
         salesorder = NetSuite::Records::SalesOrder.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([salesorder], {}).
             and_return(response)
-        salesorder.add.should be_truthy
+        expect(salesorder.add).to be_truthy
       end
     end
 
@@ -147,10 +147,10 @@ describe NetSuite::Records::SalesOrder do
 
       it 'returns false' do
         salesorder = NetSuite::Records::SalesOrder.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([salesorder], {}).
             and_return(response)
-        salesorder.add.should be_falsey
+        expect(salesorder.add).to be_falsey
       end
     end
   end
@@ -163,10 +163,10 @@ describe NetSuite::Records::SalesOrder do
 
       it 'returns true' do
         salesorder = NetSuite::Records::SalesOrder.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([salesorder], {}).
             and_return(response)
-        salesorder.delete.should be_truthy
+        expect(salesorder.delete).to be_truthy
       end
     end
 
@@ -175,10 +175,10 @@ describe NetSuite::Records::SalesOrder do
 
       it 'returns false' do
         salesorder = NetSuite::Records::SalesOrder.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([salesorder], {}).
             and_return(response)
-        salesorder.delete.should be_falsey
+        expect(salesorder.delete).to be_falsey
       end
     end
   end
@@ -193,13 +193,13 @@ describe NetSuite::Records::SalesOrder do
         'tranSales:email'  => 'something@example.com',
         'tranSales:tranId' => '4'
       }
-      salesorder.to_record.should eql(record)
+      expect(salesorder.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string representation of the SOAP type' do
-      salesorder.record_type.should eql('tranSales:SalesOrder')
+      expect(salesorder.record_type).to eql('tranSales:SalesOrder')
     end
   end