netsuite 0.3.0 → 0.3.1

data/spec/netsuite/records/sales_tax_item_spec.rb

@@ -10,7 +10,7 @@ describe NetSuite::Records::SalesTaxItem do
       :exempt, :is_default, :exclude_from_tax_reports, :available, :export,
       :county, :city, :state, :zip
     ].each do |field|
-      sales_tax_item.should have_field(field)
+      expect(sales_tax_item).to have_field(field)
     end
   end
 
@@ -19,7 +19,7 @@ describe NetSuite::Records::SalesTaxItem do
       :tax_type, :tax_agency, :tax_account, :purchase_account, :sale_account,
       :parent, :nexus_country
     ].each do |record_ref|
-      sales_tax_item.should have_record_ref(record_ref)
+      expect(sales_tax_item).to have_record_ref(record_ref)
     end
   end
 

data/spec/netsuite/records/service_sale_item_spec.rb

@@ -16,12 +16,12 @@ describe NetSuite::Records::ServiceSaleItem do
       :store_description, :store_detailed_description, :store_display_name, :translations_list, :upc_code, :url_component,
       :use_marginal_rates, :vsoe_deferral, :vsoe_delivered, :vsoe_permit_discount, :vsoe_price, :vsoe_sop_group
     ].each do |field|
-      item.should have_field(field)
+      expect(item).to have_field(field)
     end
 
     # TODO there is a probably a more robust way to test this
-    item.custom_field_list.class.should == NetSuite::Records::CustomFieldList
-    item.pricing_matrix.class.should == NetSuite::Records::PricingMatrix
+    expect(item.custom_field_list.class).to eq(NetSuite::Records::CustomFieldList)
+    expect(item.pricing_matrix.class).to eq(NetSuite::Records::PricingMatrix)
   end
 
   it 'has the right record_refs' do
@@ -31,7 +31,7 @@ describe NetSuite::Records::ServiceSaleItem do
       :quantity_pricing_schedule, :rev_rec_schedule, :sale_unit, :sales_tax_code, :store_display_image,
       :store_display_thumbnail, :store_item_template, :subsidiary_list, :tax_schedule, :units_type
     ].each do |record_ref|
-      item.should have_record_ref(record_ref)
+      expect(item).to have_record_ref(record_ref)
     end
   end
 
@@ -40,10 +40,10 @@ describe NetSuite::Records::ServiceSaleItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :item_id => 'penguins' }) }
 
       it 'returns a ServiceSaleItem instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::ServiceSaleItem, :external_id => 20], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::ServiceSaleItem, :external_id => 20], {}).and_return(response)
         customer = NetSuite::Records::ServiceSaleItem.get(:external_id => 20)
-        customer.should be_kind_of(NetSuite::Records::ServiceSaleItem)
-        customer.item_id.should eql('penguins')
+        expect(customer).to be_kind_of(NetSuite::Records::ServiceSaleItem)
+        expect(customer.item_id).to eql('penguins')
       end
     end
 
@@ -51,10 +51,10 @@ describe NetSuite::Records::ServiceSaleItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::ServiceSaleItem, :external_id => 20], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::ServiceSaleItem, :external_id => 20], {}).and_return(response)
+        expect {
           NetSuite::Records::ServiceSaleItem.get(:external_id => 20)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::ServiceSaleItem with OPTIONS=(.*) could not be found/)
       end
     end
@@ -67,10 +67,10 @@ describe NetSuite::Records::ServiceSaleItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.add.should be_truthy
+        expect(item.add).to be_truthy
       end
     end
 
@@ -78,10 +78,10 @@ describe NetSuite::Records::ServiceSaleItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.add.should be_falsey
+        expect(item.add).to be_falsey
       end
     end
   end
@@ -91,10 +91,10 @@ describe NetSuite::Records::ServiceSaleItem do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.delete.should be_truthy
+        expect(item.delete).to be_truthy
       end
     end
 
@@ -102,10 +102,10 @@ describe NetSuite::Records::ServiceSaleItem do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([item], {}).
             and_return(response)
-        item.delete.should be_falsey
+        expect(item.delete).to be_falsey
       end
     end
   end
@@ -121,13 +121,13 @@ describe NetSuite::Records::ServiceSaleItem do
         'listAcct:itemId' => 'penguins',
         'listAcct:isOnline'     => true
       }
-      item.to_record.should eql(record)
+      expect(item.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string of the SOAP type' do
-      item.record_type.should eql('listAcct:ServiceSaleItem')
+      expect(item.record_type).to eql('listAcct:ServiceSaleItem')
     end
   end
 

data/spec/netsuite/records/ship_address_spec.rb

@@ -8,7 +8,7 @@ describe NetSuite::Records::ShipAddress do
       :ship_attention, :ship_addressee, :ship_phone, :ship_addr1, :ship_addr2, :ship_addr3,
       :ship_city, :ship_state, :ship_zip, :ship_country, :ship_is_residential
     ].each do |field|
-      ship_address.should have_field(field)
+      expect(ship_address).to have_field(field)
     end
   end
 
@@ -23,13 +23,13 @@ describe NetSuite::Records::ShipAddress do
         'platformCommon:shipAttention' => 'Mr. Smith',
         'platformCommon:shipZip'       => '90007'
       }
-      ship_address.to_record.should eql(record)
+      expect(ship_address.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string of the SOAP record type' do
-      ship_address.record_type.should eql('platformCommon:ShipAddress')
+      expect(ship_address.record_type).to eql('platformCommon:ShipAddress')
     end
   end
 

data/spec/netsuite/records/site_category_spec.rb

@@ -10,7 +10,7 @@ describe NetSuite::Records::SiteCategory do
       :search_keywords, :sitemap_priority, :store_detailed_description,
       :translations_list, :url_component
     ].each do |field|
-      site_category.should have_field(field)
+      expect(site_category).to have_field(field)
     end
   end
 
@@ -19,7 +19,7 @@ describe NetSuite::Records::SiteCategory do
       :category_list_layout, :correlated_items_list_layout, :item_list_layout, :parent_category,
       :related_items_list_layout, :store_display_image, :store_display_thumbnail, :website
     ].each do |record_ref|
-      site_category.should have_record_ref(record_ref)
+      expect(site_category).to have_record_ref(record_ref)
     end
   end
 
@@ -28,10 +28,10 @@ describe NetSuite::Records::SiteCategory do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :url_component => 'some url' }) }
 
       it 'returns a SiteCategory instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::SiteCategory, :external_id => 1], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::SiteCategory, :external_id => 1], {}).and_return(response)
         site_category = NetSuite::Records::SiteCategory.get(:external_id => 1)
-        site_category.should be_kind_of(NetSuite::Records::SiteCategory)
-        site_category.url_component.should == 'some url'
+        expect(site_category).to be_kind_of(NetSuite::Records::SiteCategory)
+        expect(site_category.url_component).to eq('some url')
       end
     end
 
@@ -39,10 +39,10 @@ describe NetSuite::Records::SiteCategory do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::SiteCategory, :external_id => 1], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::SiteCategory, :external_id => 1], {}).and_return(response)
+        expect {
           NetSuite::Records::SiteCategory.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::SiteCategory with OPTIONS=(.*) could not be found/)
       end
     end

data/spec/netsuite/records/subsidiary_spec.rb

@@ -12,14 +12,14 @@ describe NetSuite::Records::Subsidiary do
       :federal_id_number, :addr_language, :non_consol, :consol, :ship_address1,
       :ship_address2, :ship_city, :ship_state, :ship_country, :ship_zip,
       :state1_tax_number, :ssn_or_tin, :inbound_email ].each do |field|
-      subsidiary.should have_field(field)
+      expect(subsidiary).to have_field(field)
     end
   end
 
   it 'has all the right record refs' do
     [ :check_layout, :inter_co_account, :parent, :logo, :page_logo,
       :fiscal_calendar, :tax_fiscal_calendar, :currency ].each do |record_ref|
-      subsidiary.should have_record_ref(record_ref)
+      expect(subsidiary).to have_record_ref(record_ref)
     end
   end
 end

data/spec/netsuite/records/support_case_spec.rb

@@ -9,7 +9,7 @@ describe NetSuite::Records::SupportCase do
       :internal_only, :title, :case_number, :start_date, :email, :phone, :inbound_email,
       :is_inactive, :help_desk
     ].each do |field|
-      support_case.should have_field(field)
+      expect(support_case).to have_field(field)
     end
   end
 
@@ -17,7 +17,7 @@ describe NetSuite::Records::SupportCase do
     [
       :custom_form, :company, :contact, :issue, :status, :priority, :origin, :category, :assigned
     ].each do |record_ref|
-      support_case.should have_record_ref(record_ref)
+      expect(support_case).to have_record_ref(record_ref)
     end
   end
 
@@ -30,14 +30,14 @@ describe NetSuite::Records::SupportCase do
         }
       }
       support_case.custom_field_list = attributes
-      support_case.custom_field_list.should be_kind_of(NetSuite::Records::CustomFieldList)
-      support_case.custom_field_list.custom_fields.length.should eql(1)
+      expect(support_case.custom_field_list).to be_kind_of(NetSuite::Records::CustomFieldList)
+      expect(support_case.custom_field_list.custom_fields.length).to eql(1)
     end
 
     it 'can be set from a CustomFieldList object' do
       custom_field_list = NetSuite::Records::CustomFieldList.new
       support_case.custom_field_list = custom_field_list
-      support_case.custom_field_list.should eql(custom_field_list)
+      expect(support_case.custom_field_list).to eql(custom_field_list)
     end
   end
 
@@ -46,10 +46,10 @@ describe NetSuite::Records::SupportCase do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :title => 'Case title' }) }
 
       it 'returns a SupportCase instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::SupportCase, :external_id => 1], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::SupportCase, :external_id => 1], {}).and_return(response)
         support_case = NetSuite::Records::SupportCase.get(:external_id => 1)
-        support_case.should be_kind_of(NetSuite::Records::SupportCase)
-        support_case.title.should == 'Case title'
+        expect(support_case).to be_kind_of(NetSuite::Records::SupportCase)
+        expect(support_case.title).to eq('Case title')
       end
     end
 
@@ -57,10 +57,10 @@ describe NetSuite::Records::SupportCase do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::SupportCase, :external_id => 1], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::SupportCase, :external_id => 1], {}).and_return(response)
+        expect {
           NetSuite::Records::SupportCase.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::SupportCase with OPTIONS=(.*) could not be found/)
       end
     end
@@ -73,10 +73,10 @@ describe NetSuite::Records::SupportCase do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([support_case], {}).
             and_return(response)
-        support_case.add.should be_truthy
+        expect(support_case.add).to be_truthy
       end
     end
 
@@ -84,10 +84,10 @@ describe NetSuite::Records::SupportCase do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([support_case], {}).
             and_return(response)
-        support_case.add.should be_falsey
+        expect(support_case.add).to be_falsey
       end
     end
   end
@@ -97,10 +97,10 @@ describe NetSuite::Records::SupportCase do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :internal_id => '1' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([support_case], {}).
             and_return(response)
-        support_case.delete.should be_truthy
+        expect(support_case.delete).to be_truthy
       end
     end
 
@@ -108,10 +108,10 @@ describe NetSuite::Records::SupportCase do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'returns false' do
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([support_case], {}).
             and_return(response)
-        support_case.delete.should be_falsey
+        expect(support_case.delete).to be_falsey
       end
     end
   end
@@ -121,9 +121,9 @@ describe NetSuite::Records::SupportCase do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :title => 'Case title' }) }
 
       it 'returns true' do
-        NetSuite::Actions::Update.should_receive(:call).with([NetSuite::Records::SupportCase, :external_id => 1, :title => 'Case title'], {}).and_return(response)
+        expect(NetSuite::Actions::Update).to receive(:call).with([NetSuite::Records::SupportCase, :external_id => 1, :title => 'Case title'], {}).and_return(response)
         support_case = NetSuite::Records::SupportCase.new(:external_id => 1)
-        support_case.update(:title => 'Case title').should be_truthy
+        expect(support_case.update(:title => 'Case title')).to be_truthy
       end
     end
 
@@ -131,9 +131,9 @@ describe NetSuite::Records::SupportCase do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Update.should_receive(:call).with([NetSuite::Records::SupportCase, :internal_id => 1, :title => 'Case title'], {}).and_return(response)
+        expect(NetSuite::Actions::Update).to receive(:call).with([NetSuite::Records::SupportCase, :internal_id => 1, :title => 'Case title'], {}).and_return(response)
         support_case = NetSuite::Records::SupportCase.new(:internal_id => 1)
-        support_case.update(:title => 'Case title').should be_falsey
+        expect(support_case.update(:title => 'Case title')).to be_falsey
       end
     end
   end
@@ -142,7 +142,7 @@ describe NetSuite::Records::SupportCase do
     let(:support_case) { NetSuite::Records::SupportCase.new(:title => 'Case title') }
 
     it 'returns a hash of attributes that can be used in a SOAP request' do
-      support_case.to_record.should eql({
+      expect(support_case.to_record).to eql({
         'listSupport:title' => 'Case title'
       })
     end
@@ -150,7 +150,7 @@ describe NetSuite::Records::SupportCase do
 
   describe '#record_type' do
     it 'returns a string type for the record to be used in a SOAP request' do
-      support_case.record_type.should eql('listSupport:SupportCase')
+      expect(support_case.record_type).to eql('listSupport:SupportCase')
     end
   end
 

data/spec/netsuite/records/tax_type_spec.rb

@@ -5,7 +5,7 @@ describe NetSuite::Records::TaxType do
 
   it 'has all the right fields' do
     [ :description, :name ].each do |field|
-      tax_type.should have_field(field)
+      expect(tax_type).to have_field(field)
     end
   end
 end

data/spec/netsuite/records/term_spec.rb

@@ -8,7 +8,7 @@ describe NetSuite::Records::Term do
       :name, :date_driven, :days_until_next_due, :discount_percent, :days_until_expiry, :day_of_month_net_due,
       :due_next_month_if_within_days, :discount_percent_date_driven, :day_discount_expires, :preferred, :is_inactive
     ].each do |field|
-      term.should have_field(field)
+      expect(term).to have_field(field)
     end
   end
 
@@ -17,10 +17,10 @@ describe NetSuite::Records::Term do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :name => 'Term 1' }) }
 
       it 'returns a Term instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Term, {:external_id => 1}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Term, {:external_id => 1}], {}).and_return(response)
         term = NetSuite::Records::Term.get(:external_id => 1)
-        term.should be_kind_of(NetSuite::Records::Term)
-        term.name.should eql('Term 1')
+        expect(term).to be_kind_of(NetSuite::Records::Term)
+        expect(term.name).to eql('Term 1')
       end
     end
 
@@ -28,10 +28,10 @@ describe NetSuite::Records::Term do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Term, {:external_id => 1}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Term, {:external_id => 1}], {}).and_return(response)
+        expect {
           NetSuite::Records::Term.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::Term with OPTIONS=(.*) could not be found/)
       end
     end
@@ -45,10 +45,10 @@ describe NetSuite::Records::Term do
 
       it 'returns true' do
         term = NetSuite::Records::Term.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([term], {}).
             and_return(response)
-        term.add.should be_truthy
+        expect(term.add).to be_truthy
       end
     end
 
@@ -57,10 +57,10 @@ describe NetSuite::Records::Term do
 
       it 'returns false' do
         term = NetSuite::Records::Term.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([term], {}).
             and_return(response)
-        term.add.should be_falsey
+        expect(term.add).to be_falsey
       end
     end
   end
@@ -73,10 +73,10 @@ describe NetSuite::Records::Term do
 
       it 'returns true' do
         term = NetSuite::Records::Term.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([term], {}).
             and_return(response)
-        term.delete.should be_truthy
+        expect(term.delete).to be_truthy
       end
     end
 
@@ -85,10 +85,10 @@ describe NetSuite::Records::Term do
 
       it 'returns false' do
         term = NetSuite::Records::Term.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([term], {}).
             and_return(response)
-        term.delete.should be_falsey
+        expect(term.delete).to be_falsey
       end
     end
   end