netsuite 0.3.0 → 0.3.1

data/spec/netsuite/records/account_spec.rb

@@ -8,7 +8,7 @@ describe NetSuite::Records::Account do
       :acct_name, :acct_number, :acct_type, :cash_flow_rate, :cur_doc_num, :description, :eliminate, :exchange_rate,
       :general_rate, :include_children, :inventory, :is_inactive, :opening_balance, :revalue, :tran_date
     ].each do |field|
-      account.should have_field(field)
+      expect(account).to have_field(field)
     end
   end
 
@@ -16,7 +16,7 @@ describe NetSuite::Records::Account do
     [
       :billable_expenses_acct, :category1099misc, :currency, :deferral_acct, :department, :klass, :location, :parent
     ].each do |record_ref|
-      account.should have_record_ref(record_ref)
+      expect(account).to have_record_ref(record_ref)
     end
   end
 
@@ -40,10 +40,10 @@ describe NetSuite::Records::Account do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :acct_name => 'Account 1' }) }
 
       it 'returns a Account instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Account, {:external_id => 1}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Account, {:external_id => 1}], {}).and_return(response)
         account = NetSuite::Records::Account.get(:external_id => 1)
-        account.should be_kind_of(NetSuite::Records::Account)
-        account.acct_name.should eql('Account 1')
+        expect(account).to be_kind_of(NetSuite::Records::Account)
+        expect(account.acct_name).to eql('Account 1')
       end
     end
 
@@ -51,10 +51,10 @@ describe NetSuite::Records::Account do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::Account, {:external_id => 1}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::Account, {:external_id => 1}], {}).and_return(response)
+        expect {
           NetSuite::Records::Account.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::Account with OPTIONS=(.*) could not be found/)
       end
     end
@@ -68,10 +68,10 @@ describe NetSuite::Records::Account do
 
       it 'returns true' do
         account = NetSuite::Records::Account.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([account], {}).
             and_return(response)
-        account.add.should be_truthy
+        expect(account.add).to be_truthy
       end
     end
 
@@ -80,10 +80,10 @@ describe NetSuite::Records::Account do
 
       it 'returns false' do
         account = NetSuite::Records::Account.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([account], {}).
             and_return(response)
-        account.add.should be_falsey
+        expect(account.add).to be_falsey
       end
     end
   end
@@ -96,10 +96,10 @@ describe NetSuite::Records::Account do
 
       it 'returns true' do
         account = NetSuite::Records::Account.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([account], {}).
             and_return(response)
-        account.delete.should be_truthy
+        expect(account.delete).to be_truthy
       end
     end
 
@@ -108,10 +108,10 @@ describe NetSuite::Records::Account do
 
       it 'returns false' do
         account = NetSuite::Records::Account.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([account], {}).
             and_return(response)
-        account.delete.should be_falsey
+        expect(account.delete).to be_falsey
       end
     end
   end

data/spec/netsuite/records/accounting_period_spec.rb

@@ -7,7 +7,7 @@ describe NetSuite::Records::AccountingPeriod do
     [
       :allow_non_gl_changes, :end_date, :is_adjust, :is_quarter, :is_year, :period_name, :start_date
     ].each do |field|
-      accounting_period.should have_field(field)
+      expect(accounting_period).to have_field(field)
     end
   end
 
@@ -15,7 +15,7 @@ describe NetSuite::Records::AccountingPeriod do
     [
       :parent
     ].each do |record_ref|
-      accounting_period.should have_record_ref(record_ref)
+      expect(accounting_period).to have_record_ref(record_ref)
     end
   end
 
@@ -24,10 +24,10 @@ describe NetSuite::Records::AccountingPeriod do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :period_name => 'Accounting Period 1' }) }
 
       it 'returns a Account instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::AccountingPeriod, {:external_id => 1}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::AccountingPeriod, {:external_id => 1}], {}).and_return(response)
         accounting_period = NetSuite::Records::AccountingPeriod.get(:external_id => 1)
-        accounting_period.should be_kind_of(NetSuite::Records::AccountingPeriod)
-        accounting_period.period_name.should eql('Accounting Period 1')
+        expect(accounting_period).to be_kind_of(NetSuite::Records::AccountingPeriod)
+        expect(accounting_period.period_name).to eql('Accounting Period 1')
       end
     end
 
@@ -35,10 +35,10 @@ describe NetSuite::Records::AccountingPeriod do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::AccountingPeriod, {:external_id => 1}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::AccountingPeriod, {:external_id => 1}], {}).and_return(response)
+        expect {
           NetSuite::Records::AccountingPeriod.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::AccountingPeriod with OPTIONS=(.*) could not be found/)
       end
     end
@@ -88,10 +88,10 @@ describe NetSuite::Records::AccountingPeriod do
 
       it 'returns true' do
         accounting_period = NetSuite::Records::AccountingPeriod.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([accounting_period], {}).
             and_return(response)
-        accounting_period.add.should be_truthy
+        expect(accounting_period.add).to be_truthy
       end
     end
 
@@ -100,10 +100,10 @@ describe NetSuite::Records::AccountingPeriod do
 
       it 'returns false' do
         accounting_period = NetSuite::Records::AccountingPeriod.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([accounting_period], {}).
             and_return(response)
-        accounting_period.add.should be_falsey
+        expect(accounting_period.add).to be_falsey
       end
     end
   end
@@ -116,10 +116,10 @@ describe NetSuite::Records::AccountingPeriod do
 
       it 'returns true' do
         accounting_period = NetSuite::Records::AccountingPeriod.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([accounting_period], {}).
             and_return(response)
-        accounting_period.delete.should be_truthy
+        expect(accounting_period.delete).to be_truthy
       end
     end
 
@@ -128,10 +128,10 @@ describe NetSuite::Records::AccountingPeriod do
 
       it 'returns false' do
         accounting_period = NetSuite::Records::AccountingPeriod.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([accounting_period], {}).
             and_return(response)
-        accounting_period.delete.should be_falsey
+        expect(accounting_period.delete).to be_falsey
       end
     end
   end

data/spec/netsuite/records/assembly_item_spec.rb

@@ -12,8 +12,8 @@ describe NetSuite::Records::AssemblyItem do
         }]
       }
       item.member_list = attributes
-      item.member_list.should be_kind_of(NetSuite::Records::MemberList)
-      item.member_list.item_member.length.should eql(1)
+      expect(item.member_list).to be_kind_of(NetSuite::Records::MemberList)
+      expect(item.member_list.item_member.length).to eql(1)
 
       expect(item.member_list.item_member.first.item.internal_id).to eq(1)
       expect(item.member_list.item_member.first.quantity).to eq(20)

data/spec/netsuite/records/bill_address_spec.rb

@@ -8,7 +8,7 @@ describe NetSuite::Records::BillAddress do
       :bill_attention, :bill_addressee, :bill_phone, :bill_addr1, :bill_addr2,
       :bill_addr3, :bill_city, :bill_state, :bill_zip, :bill_country
     ].each do |field|
-      bill_address.should have_field(field)
+      expect(bill_address).to have_field(field)
     end
   end
 
@@ -39,13 +39,13 @@ describe NetSuite::Records::BillAddress do
         'platformCommon:billZip'       => '90007',
         'platformCommon:billCountry'   => '_unitedStates'
       }
-      bill_address.to_record.should eql(record)
+      expect(bill_address.to_record).to eql(record)
     end
   end
 
   describe 'record_namespace' do
     it 'belongs to the platformCommon namespace' do
-      bill_address.record_namespace.should eql('platformCommon')
+      expect(bill_address.record_namespace).to eql('platformCommon')
     end
   end
 

data/spec/netsuite/records/billing_schedule_milestone_list_spec.rb

@@ -7,9 +7,9 @@ describe NetSuite::Records::BillingScheduleMilestoneList do
   it 'can have milestones be added to it' do
     list.milestones << milestone
     milestone_list = list.milestones
-    milestone_list.should be_kind_of(Array)
-    milestone_list.length.should eql(1)
-    milestone_list.each { |i| i.should be_kind_of(NetSuite::Records::BillingScheduleMilestone) }
+    expect(milestone_list).to be_kind_of(Array)
+    expect(milestone_list.length).to eql(1)
+    milestone_list.each { |i| expect(i).to be_kind_of(NetSuite::Records::BillingScheduleMilestone) }
   end
 
   describe '#to_record' do
@@ -17,7 +17,7 @@ describe NetSuite::Records::BillingScheduleMilestoneList do
       record = {
         'listAcct:billingScheduleMilestone' => []
       }
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
   end
 

data/spec/netsuite/records/billing_schedule_milestone_spec.rb

@@ -8,7 +8,7 @@ describe NetSuite::Records::BillingScheduleMilestone do
       :comments, :milestone_actual_completion_date, :milestone_amount, 
       :milestone_completed, :milestone_date, :milestone_id
     ].each do |field|
-      milestone.should have_field(field)
+      expect(milestone).to have_field(field)
     end
   end
 
@@ -16,15 +16,15 @@ describe NetSuite::Records::BillingScheduleMilestone do
     [
       :milestone_term, :project_task
     ].each do |record_ref|
-      milestone.should have_record_ref(record_ref)
+      expect(milestone).to have_record_ref(record_ref)
     end
   end
 
   it 'can initialize from a record' do
     record = NetSuite::Records::BillingScheduleMilestone.new(:comments => "foo")
     milestone = NetSuite::Records::BillingScheduleMilestone.new(record)
-    milestone.should be_kind_of(NetSuite::Records::BillingScheduleMilestone)
-    milestone.comments.should eql("foo")
+    expect(milestone).to be_kind_of(NetSuite::Records::BillingScheduleMilestone)
+    expect(milestone.comments).to eql("foo")
   end
 
   describe '#to_record' do
@@ -38,13 +38,13 @@ describe NetSuite::Records::BillingScheduleMilestone do
         'listAcct:comments'        => 'comment',
         'listAcct:milestoneAmount' => 1
       }
-      milestone.to_record.should eql(record)
+      expect(milestone.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string of the SOAP record type' do
-      milestone.record_type.should eql('listAcct:BillingScheduleMilestone')
+      expect(milestone.record_type).to eql('listAcct:BillingScheduleMilestone')
     end
   end
 

data/spec/netsuite/records/billing_schedule_recurrence_list_spec.rb

@@ -7,9 +7,9 @@ describe NetSuite::Records::BillingScheduleRecurrenceList do
   it 'can have recurrences be added to it' do
     list.recurrences << recurrence
     recurrence_list = list.recurrences
-    recurrence_list.should be_kind_of(Array)
-    recurrence_list.length.should eql(1)
-    recurrence_list.each { |i| i.should be_kind_of(NetSuite::Records::BillingScheduleRecurrence) }
+    expect(recurrence_list).to be_kind_of(Array)
+    expect(recurrence_list.length).to eql(1)
+    recurrence_list.each { |i| expect(i).to be_kind_of(NetSuite::Records::BillingScheduleRecurrence) }
   end
 
   describe '#to_record' do
@@ -17,7 +17,7 @@ describe NetSuite::Records::BillingScheduleRecurrenceList do
       record = {
         'listAcct:billingScheduleRecurrence' => []
       }
-      list.to_record.should eql(record)
+      expect(list.to_record).to eql(record)
     end
   end
 

data/spec/netsuite/records/billing_schedule_recurrence_spec.rb

@@ -8,7 +8,7 @@ describe NetSuite::Records::BillingScheduleRecurrence do
       :amount, :count, :recurrence_date, :recurrence_id,
       :relative_to_previous, :units
     ].each do |field|
-      recurrence.should have_field(field)
+      expect(recurrence).to have_field(field)
     end
   end
 
@@ -16,15 +16,15 @@ describe NetSuite::Records::BillingScheduleRecurrence do
     [
       :payment_terms
     ].each do |record_ref|
-      recurrence.should have_record_ref(record_ref)
+      expect(recurrence).to have_record_ref(record_ref)
     end
   end
 
   it 'can initialize from a record' do
     record = NetSuite::Records::BillingScheduleRecurrence.new(:amount => 10)
     recurrence = NetSuite::Records::BillingScheduleRecurrence.new(record)
-    recurrence.should be_kind_of(NetSuite::Records::BillingScheduleRecurrence)
-    recurrence.amount.should eql(10)
+    expect(recurrence).to be_kind_of(NetSuite::Records::BillingScheduleRecurrence)
+    expect(recurrence.amount).to eql(10)
   end
 
   describe '#to_record' do
@@ -36,13 +36,13 @@ describe NetSuite::Records::BillingScheduleRecurrence do
       record = {
         'listAcct:amount' => 10
       }
-      recurrence.to_record.should eql(record)
+      expect(recurrence.to_record).to eql(record)
     end
   end
 
   describe '#record_type' do
     it 'returns a string of the SOAP record type' do
-      recurrence.record_type.should eql('listAcct:BillingScheduleRecurrence')
+      expect(recurrence.record_type).to eql('listAcct:BillingScheduleRecurrence')
     end
   end
 

data/spec/netsuite/records/billing_schedule_spec.rb

@@ -11,7 +11,7 @@ describe NetSuite::Records::BillingSchedule do
       :schedule_type, :series_start_date, :year_dom, :year_dow,
       :year_dowim, :year_dowim_month, :year_mode, :year_month
     ].each do |field|
-      billing_schedule.should have_field(field)
+      expect(billing_schedule).to have_field(field)
     end
   end
 
@@ -19,7 +19,7 @@ describe NetSuite::Records::BillingSchedule do
     [
       :initial_terms, :project, :recurrence_terms, :transaction
     ].each do |record_ref|
-      billing_schedule.should have_record_ref(record_ref)
+      expect(billing_schedule).to have_record_ref(record_ref)
     end
   end
 
@@ -29,8 +29,8 @@ describe NetSuite::Records::BillingSchedule do
         :comments => "comment"
       }
       billing_schedule.milestone_list.milestone = attributes
-      billing_schedule.milestone_list.should be_kind_of(NetSuite::Records::BillingScheduleMilestoneList)
-      billing_schedule.milestone_list.milestones.length.should eql(1)
+      expect(billing_schedule.milestone_list).to be_kind_of(NetSuite::Records::BillingScheduleMilestoneList)
+      expect(billing_schedule.milestone_list.milestones.length).to eql(1)
     end
   end
   
@@ -40,8 +40,8 @@ describe NetSuite::Records::BillingSchedule do
         :amount => 10
       }
       billing_schedule.recurrence_list.recurrence = attributes
-      billing_schedule.recurrence_list.should be_kind_of(NetSuite::Records::BillingScheduleRecurrenceList)
-      billing_schedule.recurrence_list.recurrences.length.should eql(1)
+      expect(billing_schedule.recurrence_list).to be_kind_of(NetSuite::Records::BillingScheduleRecurrenceList)
+      expect(billing_schedule.recurrence_list.recurrences.length).to eql(1)
     end
   end
 
@@ -50,10 +50,10 @@ describe NetSuite::Records::BillingSchedule do
       let(:response) { NetSuite::Response.new(:success => true, :body => { :name => 'Billing Scheduleing 1' }) }
 
       it 'returns a Billing Schedule instance populated with the data from the response object' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::BillingSchedule, {:external_id => 1}], {}).and_return(response)
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::BillingSchedule, {:external_id => 1}], {}).and_return(response)
         billing_schedule = NetSuite::Records::BillingSchedule.get(:external_id => 1)
-        billing_schedule.should be_kind_of(NetSuite::Records::BillingSchedule)
-        billing_schedule.name.should eql('Billing Scheduleing 1')
+        expect(billing_schedule).to be_kind_of(NetSuite::Records::BillingSchedule)
+        expect(billing_schedule.name).to eql('Billing Scheduleing 1')
       end
     end
 
@@ -61,10 +61,10 @@ describe NetSuite::Records::BillingSchedule do
       let(:response) { NetSuite::Response.new(:success => false, :body => {}) }
 
       it 'raises a RecordNotFound exception' do
-        NetSuite::Actions::Get.should_receive(:call).with([NetSuite::Records::BillingSchedule, {:external_id => 1}], {}).and_return(response)
-        lambda {
+        expect(NetSuite::Actions::Get).to receive(:call).with([NetSuite::Records::BillingSchedule, {:external_id => 1}], {}).and_return(response)
+        expect {
           NetSuite::Records::BillingSchedule.get(:external_id => 1)
-        }.should raise_error(NetSuite::RecordNotFound,
+        }.to raise_error(NetSuite::RecordNotFound,
           /NetSuite::Records::BillingSchedule with OPTIONS=(.*) could not be found/)
       end
     end
@@ -114,10 +114,10 @@ describe NetSuite::Records::BillingSchedule do
 
       it 'returns true' do
         billing_schedule = NetSuite::Records::BillingSchedule.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([billing_schedule], {}).
             and_return(response)
-        billing_schedule.add.should be_truthy
+        expect(billing_schedule.add).to be_truthy
       end
     end
 
@@ -126,10 +126,10 @@ describe NetSuite::Records::BillingSchedule do
 
       it 'returns false' do
         billing_schedule = NetSuite::Records::BillingSchedule.new(test_data)
-        NetSuite::Actions::Add.should_receive(:call).
+        expect(NetSuite::Actions::Add).to receive(:call).
             with([billing_schedule], {}).
             and_return(response)
-        billing_schedule.add.should be_falsey
+        expect(billing_schedule.add).to be_falsey
       end
     end
   end
@@ -142,10 +142,10 @@ describe NetSuite::Records::BillingSchedule do
 
       it 'returns true' do
         billing_schedule = NetSuite::Records::BillingSchedule.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([billing_schedule], {}).
             and_return(response)
-        billing_schedule.delete.should be_truthy
+        expect(billing_schedule.delete).to be_truthy
       end
     end
 
@@ -154,10 +154,10 @@ describe NetSuite::Records::BillingSchedule do
 
       it 'returns false' do
         billing_schedule = NetSuite::Records::BillingSchedule.new(test_data)
-        NetSuite::Actions::Delete.should_receive(:call).
+        expect(NetSuite::Actions::Delete).to receive(:call).
             with([billing_schedule], {}).
             and_return(response)
-        billing_schedule.delete.should be_falsey
+        expect(billing_schedule.delete).to be_falsey
       end
     end
   end