mongoid 9.0.12 → 9.1.0

data/spec/mongoid/attributes/nested_spec_models.rb

@@ -1,11 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class NestedAuthor
   include Mongoid::Document
 
   field :name, type: String
-  has_one :post, class_name: "NestedPost"
+  has_one :post, class_name: 'NestedPost'
   accepts_nested_attributes_for :post
 end
 
@@ -13,23 +12,23 @@ class NestedComment
   include Mongoid::Document
 
   field :body, type: String
-  belongs_to :post, class_name: "NestedPost"
+  belongs_to :post, class_name: 'NestedPost'
 end
 
 class NestedPost
   include Mongoid::Document
 
   field :title, type: String
-  belongs_to :author, class_name: "NestedAuthor"
-  has_many :comments, class_name: "NestedComment"
+  belongs_to :author, class_name: 'NestedAuthor'
+  has_many :comments, class_name: 'NestedComment'
   accepts_nested_attributes_for :comments
 end
 
 class NestedBook
   include Mongoid::Document
 
-  embeds_one :cover, class_name: "NestedCover"
-  embeds_many :pages, class_name: "NestedPage"
+  embeds_one :cover, class_name: 'NestedCover'
+  embeds_many :pages, class_name: 'NestedPage'
 
   accepts_nested_attributes_for :cover, :pages
 end
@@ -38,12 +37,12 @@ class NestedCover
   include Mongoid::Document
 
   field :title, type: String
-  embedded_in :book, class_name: "NestedBook"
+  embedded_in :book, class_name: 'NestedBook'
 end
 
 class NestedPage
   include Mongoid::Document
 
   field :number, type: Integer
-  embedded_in :book, class_name: "NestedBook"
+  embedded_in :book, class_name: 'NestedBook'
 end

data/spec/mongoid/attributes/projector_spec.rb

@@ -1,7 +1,6 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Attributes::Projector do
   Dir[File.join(File.dirname(__FILE__), 'projector_data', '*.yml')].sort.each do |path|
@@ -10,10 +9,7 @@ describe Mongoid::Attributes::Projector do
 
       specs.each do |spec|
         context spec['name'] do
-
-          if spec['pending']
-            pending spec['pending'].to_s
-          end
+          pending spec['pending'].to_s if spec['pending']
 
           let(:projection) do
             spec['projection']

data/spec/mongoid/attributes/readonly_spec.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Attributes::Readonly do
-
   before do
     Person.attr_readonly(*attributes)
   end
@@ -16,106 +14,97 @@ describe Mongoid::Attributes::Readonly do
     end
   end
 
-  describe ".attr_readonly" do
-
-    context "when providing a single field" do
-
+  describe '.attr_readonly' do
+    context 'when providing a single field' do
       let(:attributes) do
         :title
       end
 
-      it "adds the field to readonly attributes" do
-        expect(Person.readonly_attributes.to_a).to include("title")
+      it 'adds the field to readonly attributes' do
+        expect(Person.readonly_attributes.to_a).to include('title')
       end
     end
 
-    context "when providing a field alias" do
-
+    context 'when providing a field alias' do
       let(:attributes) do
         :aliased_timestamp
       end
 
-      it "adds the database field name to readonly attributes" do
-        expect(Person.readonly_attributes.to_a).to include("at")
+      it 'adds the database field name to readonly attributes' do
+        expect(Person.readonly_attributes.to_a).to include('at')
       end
     end
 
-    context "when providing multiple fields" do
-
+    context 'when providing multiple fields' do
       let(:attributes) do
-        [ :title, :terms ]
+        %i[title terms]
       end
 
-      it "adds the fields to readonly attributes" do
-        expect(Person.readonly_attributes.to_a).to include("title", "terms")
+      it 'adds the fields to readonly attributes' do
+        expect(Person.readonly_attributes.to_a).to include('title', 'terms')
       end
     end
 
-    context "when creating a new document with a readonly field" do
-
+    context 'when creating a new document with a readonly field' do
       let(:attributes) do
-        [ :title, :terms, :aliased_timestamp ]
+        %i[title terms aliased_timestamp]
       end
 
       let(:person) do
-        Person.create!(title: "sir", terms: true, aliased_timestamp: Time.at(42))
+        Person.create!(title: 'sir', terms: true, aliased_timestamp: Time.at(42))
       end
 
-      it "sets the first readonly value" do
-        expect(person.title).to eq("sir")
+      it 'sets the first readonly value' do
+        expect(person.title).to eq('sir')
       end
 
-      it "sets the second readonly value" do
+      it 'sets the second readonly value' do
         expect(person.terms).to be true
       end
 
-      it "sets the third readonly value" do
+      it 'sets the third readonly value' do
         expect(person.aliased_timestamp).to eq(Time.at(42))
       end
 
-      it "persists the first readonly value" do
-        expect(person.reload.title).to eq("sir")
+      it 'persists the first readonly value' do
+        expect(person.reload.title).to eq('sir')
       end
 
-      it "persists the second readonly value" do
+      it 'persists the second readonly value' do
         expect(person.reload.terms).to be true
       end
 
-      it "persists the third readonly value" do
+      it 'persists the third readonly value' do
         expect(person.reload.aliased_timestamp).to eq(Time.at(42))
       end
     end
 
-    context "when updating an existing readonly field" do
-
+    context 'when updating an existing readonly field' do
       let(:attributes) do
-        [ :title, :terms, :score, :aliased_timestamp ]
+        %i[title terms score aliased_timestamp]
       end
 
       let(:person) do
-        Person.create!(title: "sir", terms: true, score: 1, aliased_timestamp: Time.at(42))
+        Person.create!(title: 'sir', terms: true, score: 1, aliased_timestamp: Time.at(42))
       end
 
-      context "when updating via the setter" do
-
-        it "does not update the first field" do
+      context 'when updating via the setter' do
+        it 'does not update the first field' do
           person.title = 'mr'
           person.save!
-          expect(person.reload.title).to eq("sir")
+          expect(person.reload.title).to eq('sir')
         end
 
-        it "does not update the second field" do
+        it 'does not update the second field' do
           person.aliased_timestamp = Time.at(43)
           person.save!
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
 
-      context "when updating via inc" do
-
+      context 'when updating via inc' do
         context 'with single field operation' do
-
-          it "updates the field" do
+          it 'updates the field' do
             person.inc(score: 1)
             person.save!
             expect(person.reload.score).to eq(2)
@@ -123,8 +112,7 @@ describe Mongoid::Attributes::Readonly do
         end
 
         context 'with multiple fields operation' do
-
-          it "updates the fields" do
+          it 'updates the fields' do
             person.inc(score: 1, age: 1)
             person.save!
             expect(person.reload.score).to eq(2)
@@ -133,11 +121,9 @@ describe Mongoid::Attributes::Readonly do
         end
       end
 
-      context "when updating via bit" do
-
+      context 'when updating via bit' do
         context 'with single field operation' do
-
-          it "does the update" do
+          it 'does the update' do
             person.bit(score: { or: 13 })
             person.save!
             expect(person.reload.score).to eq(13)
@@ -145,9 +131,8 @@ describe Mongoid::Attributes::Readonly do
         end
 
         context 'with multiple fields operation' do
-
-          it "updates the attribute" do
-            person.bit(age: {and: 13}, score: {or: 13})
+          it 'updates the attribute' do
+            person.bit(age: { and: 13 }, score: { or: 13 })
             person.save!
             expect(person.reload.score).to eq(13)
             expect(person.reload.age).to eq(4)
@@ -155,93 +140,85 @@ describe Mongoid::Attributes::Readonly do
         end
       end
 
-      context "when updating via []=" do
-
-        it "does not update the first field" do
-          person[:title] = "mr"
+      context 'when updating via []=' do
+        it 'does not update the first field' do
+          person[:title] = 'mr'
           person.save!
-          expect(person.reload.title).to eq("sir")
+          expect(person.reload.title).to eq('sir')
         end
 
-        it "does not update the second field" do
+        it 'does not update the second field' do
           person[:aliased_timestamp] = Time.at(43)
           person.save!
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
 
-      context "when updating via write_attribute" do
-
-        it "does not update the first field" do
-          person.write_attribute(:title, "mr")
+      context 'when updating via write_attribute' do
+        it 'does not update the first field' do
+          person.write_attribute(:title, 'mr')
           person.save!
-          expect(person.reload.title).to eq("sir")
+          expect(person.reload.title).to eq('sir')
         end
 
-        it "does not update the second field" do
+        it 'does not update the second field' do
           person.write_attribute(:aliased_timestamp, Time.at(43))
           person.save!
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
 
-      context "when updating via update_attributes" do
-
-        it "does not update the first field" do
-          person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
+      context 'when updating via update_attributes' do
+        it 'does not update the first field' do
+          person.update_attributes!(title: 'mr', aliased_timestamp: Time.at(43))
           person.save!
-          expect(person.reload.title).to eq("sir")
+          expect(person.reload.title).to eq('sir')
         end
 
-        it "does not update the second field" do
-          person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
+        it 'does not update the second field' do
+          person.update_attributes!(title: 'mr', aliased_timestamp: Time.at(43))
           person.save!
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
 
-      context "when updating via update_attributes!" do
-
-        it "does not update the first field" do
-          person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
+      context 'when updating via update_attributes!' do
+        it 'does not update the first field' do
+          person.update_attributes!(title: 'mr', aliased_timestamp: Time.at(43))
           person.save!
-          expect(person.reload.title).to eq("sir")
+          expect(person.reload.title).to eq('sir')
         end
 
-        it "does not update the second field" do
-          person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
+        it 'does not update the second field' do
+          person.update_attributes!(title: 'mr', aliased_timestamp: Time.at(43))
           person.save!
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
 
-      context "when updating via update_attribute" do
-
-        it "raises an error" do
-          expect {
-            person.update_attribute(:title, "mr")
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+      context 'when updating via update_attribute' do
+        it 'raises an error' do
+          expect do
+            person.update_attribute(:title, 'mr')
+          end.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
         end
       end
 
-      context "when updating via remove_attribute" do
-
-        it "raises an error" do
-          expect {
+      context 'when updating via remove_attribute' do
+        it 'raises an error' do
+          expect do
             person.remove_attribute(:title)
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+          end.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
         end
       end
     end
 
     context 'when a foreign_key is defined as readonly' do
-
       let(:attributes) do
         :mother_id
       end
 
       context 'when the relation exists' do
-
         let(:mother) do
           Person.create!
         end
@@ -257,7 +234,6 @@ describe Mongoid::Attributes::Readonly do
       end
 
       context 'when the relation does not exist' do
-
         let(:child) do
           Person.create!
         end
@@ -268,9 +244,9 @@ describe Mongoid::Attributes::Readonly do
       end
     end
 
-    context "when a subclass inherits readonly fields" do
+    context 'when a subclass inherits readonly fields' do
       let(:attributes) do
-        [:title, :terms]
+        %i[title terms]
       end
 
       before do
@@ -279,12 +255,12 @@ describe Mongoid::Attributes::Readonly do
         end
       end
 
-      it "ensures subclass inherits the readonly attributes from parent" do
-        expect(OldPerson.readonly_attributes.to_a).to include("title","terms")
+      it 'ensures subclass inherits the readonly attributes from parent' do
+        expect(OldPerson.readonly_attributes.to_a).to include('title', 'terms')
       end
 
       it "ensures subclass does not modify parent's readonly attributes" do
-        expect(Person.readonly_attributes.to_a).not_to include("age")
+        expect(Person.readonly_attributes.to_a).not_to include('age')
       end
     end
   end