mongoid 9.0.12 → 9.1.0

data/spec/mongoid/persistable/poppable_spec.rb

@@ -1,90 +1,81 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Persistable::Poppable do
-
-  describe "#pop" do
-
-    context "when the document is the root document" do
-
-      shared_examples_for "a poppable root document" do
-
-        it "pops for positive values" do
+  describe '#pop' do
+    context 'when the document is the root document' do
+      shared_examples_for 'a poppable root document' do
+        it 'pops for positive values' do
           expect(person.array).to eq([ 1, 2, 3 ])
         end
 
-        it "shifts for negative values" do
-          expect(person.aliases).to eq([ "b" ])
+        it 'shifts for negative values' do
+          expect(person.aliases).to eq([ 'b' ])
         end
 
-        it "returns the self object" do
+        it 'returns the self object' do
           expect(pop).to eq(person)
         end
 
-        it "persists pops" do
+        it 'persists pops' do
           expect(person.reload.array).to eq([ 1, 2, 3 ])
         end
 
-        it "persists shifts" do
-          expect(person.reload.aliases).to eq([ "b" ])
+        it 'persists shifts' do
+          expect(person.reload.aliases).to eq([ 'b' ])
         end
 
-        it "clears out dirty changes" do
-          expect(person).to_not be_changed
+        it 'clears out dirty changes' do
+          expect(person).not_to be_changed
         end
       end
 
       let(:person) do
-        Person.create!(array: [ 1, 2, 3, 4 ], aliases: [ "a", "b" ])
+        Person.create!(array: [ 1, 2, 3, 4 ], aliases: %w[a b])
       end
 
-      context "when provided string fields" do
-
+      context 'when provided string fields' do
         let!(:pop) do
-          person.pop("array" => 1, "aliases" => -1)
+          person.pop('array' => 1, 'aliases' => -1)
         end
 
-        it_behaves_like "a poppable root document"
+        it_behaves_like 'a poppable root document'
       end
 
-      context "when provided symbol fields" do
-
+      context 'when provided symbol fields' do
         let!(:pop) do
           person.pop(array: 1, aliases: -1)
         end
 
-        it_behaves_like "a poppable root document"
+        it_behaves_like 'a poppable root document'
       end
     end
 
-    context "when the document is embedded" do
-
-      shared_examples_for "a poppable embedded document" do
-
-        it "pops for positive values" do
+    context 'when the document is embedded' do
+      shared_examples_for 'a poppable embedded document' do
+        it 'pops for positive values' do
           expect(address.services).to eq([ 1, 2, 3 ])
         end
 
-        it "shifts for negative values" do
-          expect(address.aliases).to eq([ "b" ])
+        it 'shifts for negative values' do
+          expect(address.aliases).to eq([ 'b' ])
         end
 
-        it "returns self object" do
+        it 'returns self object' do
           expect(pop).to eq(address)
         end
 
-        it "persists pops" do
+        it 'persists pops' do
           expect(address.reload.services).to eq([ 1, 2, 3 ])
         end
 
-        it "persists shifts" do
-          expect(address.reload.aliases).to eq([ "b" ])
+        it 'persists shifts' do
+          expect(address.reload.aliases).to eq([ 'b' ])
         end
 
-        it "clears out dirty changes" do
-          expect(address).to_not be_changed
+        it 'clears out dirty changes' do
+          expect(address).not_to be_changed
         end
       end
 
@@ -93,70 +84,66 @@ describe Mongoid::Persistable::Poppable do
       end
 
       let(:address) do
-        person.addresses.create!(street: "test", services: [ 1, 2, 3, 4 ], aliases: [ "a", "b" ])
+        person.addresses.create!(street: 'test', services: [ 1, 2, 3, 4 ], aliases: %w[a b])
       end
 
-      context "when provided string fields" do
-
+      context 'when provided string fields' do
         let!(:pop) do
-          address.pop("services" => 1, "aliases" => -1)
+          address.pop('services' => 1, 'aliases' => -1)
         end
 
-        it_behaves_like "a poppable embedded document"
+        it_behaves_like 'a poppable embedded document'
       end
 
-      context "when provided symbol fields" do
-
+      context 'when provided symbol fields' do
         let!(:pop) do
           address.pop(services: 1, aliases: -1)
         end
 
-        it_behaves_like "a poppable embedded document"
+        it_behaves_like 'a poppable embedded document'
       end
     end
 
-    context "when executing atomically" do
-
+    context 'when executing atomically' do
       let(:person) do
-        Person.create!(test_array: [1, 2, 3])
+        Person.create!(test_array: [ 1, 2, 3 ])
       end
 
-      it "marks a dirty change for the popped fields" do
+      it 'marks a dirty change for the popped fields' do
         person.atomically do
           person.pop test_array: 1
-          expect(person.changes).to eq({"test_array" => [[1, 2, 3], [1, 2]]})
+          expect(person.changes).to eq({ 'test_array' => [ [ 1, 2, 3 ], [ 1, 2 ] ] })
         end
       end
     end
 
-    context "when executing on a readonly document" do
-
+    context 'when executing on a readonly document' do
       let(:person) do
-        Person.create!(test_array: [1, 2, 3])
+        Person.create!(test_array: [ 1, 2, 3 ])
       end
 
-      context "when legacy_readonly is true" do
+      context 'when legacy_readonly is true' do
         config_override :legacy_readonly, true
 
         before do
-          person.__selected_fields = { "test_array" => 1 }
+          person.__selected_fields = { 'test_array' => 1 }
         end
 
-        it "persists the changes" do
+        it 'persists the changes' do
           expect(person).to be_readonly
           person.pop(test_array: 1)
           expect(person.test_array).to eq([ 1, 2 ])
         end
       end
 
-      context "when legacy_readonly is false" do
+      context 'when legacy_readonly is false' do
         config_override :legacy_readonly, false
 
         before do
           person.readonly!
         end
 
-        it "raises a ReadonlyDocument error" do
+        it 'raises a ReadonlyDocument error' do
           expect(person).to be_readonly
           expect do
             person.pop(test_array: 1)

data/spec/mongoid/persistable/pullable_spec.rb

@@ -1,37 +1,32 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Persistable::Pullable do
-
-  describe "#pull" do
-
-    context "when the document is a root document" do
-
-      shared_examples_for "a pullable root document" do
-
-        it "pulls the first value" do
+  describe '#pull' do
+    context 'when the document is a root document' do
+      shared_examples_for 'a pullable root document' do
+        it 'pulls the first value' do
           expect(person.aliases).to eq([ 2, 3 ])
         end
 
-        it "pulls the last value" do
+        it 'pulls the last value' do
           expect(person.array).to eq([ 4, 6 ])
         end
 
-        it "returns self object" do
+        it 'returns self object' do
           expect(pull).to eq(person)
         end
 
-        it "resets dirty changes" do
-          expect(person).to_not be_changed
+        it 'resets dirty changes' do
+          expect(person).not_to be_changed
         end
 
-        it "persists the first pull" do
+        it 'persists the first pull' do
           expect(person.reload.aliases).to eq([ 2, 3 ])
         end
 
-        it "persists the last pull" do
+        it 'persists the last pull' do
           expect(person.reload.array).to eq([ 4, 6 ])
         end
       end
@@ -40,50 +35,46 @@ describe Mongoid::Persistable::Pullable do
         Person.create!(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
       end
 
-      context "when providing string keys" do
-
+      context 'when providing string keys' do
         let!(:pull) do
-          person.pull("aliases" => 1, "array" => 5, "test_array" => 2)
+          person.pull('aliases' => 1, 'array' => 5, 'test_array' => 2)
         end
 
-        it_behaves_like "a pullable root document"
+        it_behaves_like 'a pullable root document'
       end
 
-      context "when providing symbol keys" do
-
+      context 'when providing symbol keys' do
         let!(:pull) do
           person.pull(aliases: 1, array: 5)
         end
 
-        it_behaves_like "a pullable root document"
+        it_behaves_like 'a pullable root document'
       end
     end
 
-    context "when the document is embedded" do
-
-      shared_examples_for "a pullable embedded document" do
-
-        it "pulls the first value" do
+    context 'when the document is embedded' do
+      shared_examples_for 'a pullable embedded document' do
+        it 'pulls the first value' do
           expect(address.services).to eq([ 2, 3 ])
         end
 
-        it "pulls the last value" do
+        it 'pulls the last value' do
           expect(address.a).to eq([ 4, 6 ])
         end
 
-        it "returns self object" do
+        it 'returns self object' do
           expect(pull).to eq(address)
         end
 
-        it "resets dirty changes" do
-          expect(address).to_not be_changed
+        it 'resets dirty changes' do
+          expect(address).not_to be_changed
         end
 
-        it "persists the first pull" do
+        it 'persists the first pull' do
           expect(address.reload.services).to eq([ 2, 3 ])
         end
 
-        it "persists the last pull" do
+        it 'persists the last pull' do
           expect(address.reload.a).to eq([ 4, 6 ])
         end
       end
@@ -93,70 +84,66 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:address) do
-        person.addresses.create!(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
+        person.addresses.create!(street: 't', services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
       end
 
-      context "when providing string keys" do
-
+      context 'when providing string keys' do
         let!(:pull) do
-          address.pull("services" => 1, "a" => 5)
+          address.pull('services' => 1, 'a' => 5)
         end
 
-        it_behaves_like "a pullable embedded document"
+        it_behaves_like 'a pullable embedded document'
       end
 
-      context "when providing symbol keys" do
-
+      context 'when providing symbol keys' do
         let!(:pull) do
           address.pull(services: 1, a: 5)
         end
 
-        it_behaves_like "a pullable embedded document"
+        it_behaves_like 'a pullable embedded document'
       end
     end
 
-    context "when executing atomically" do
-
+    context 'when executing atomically' do
       let(:person) do
         Person.create!(test_array: [ 1, 1, 2, 3 ])
       end
 
-      it "marks a dirty change for the pulled fields" do
+      it 'marks a dirty change for the pulled fields' do
         person.atomically do
           person.pull test_array: 1
-          expect(person.changes).to eq({"test_array" => [[ 1, 1, 2, 3 ], [ 2, 3 ]]})
+          expect(person.changes).to eq({ 'test_array' => [ [ 1, 1, 2, 3 ], [ 2, 3 ] ] })
         end
       end
     end
 
-    context "when executing on a readonly document" do
-
+    context 'when executing on a readonly document' do
       let(:person) do
         Person.create!(test_array: [ 1, 1, 2, 3 ])
       end
 
-      context "when legacy_readonly is true" do
+      context 'when legacy_readonly is true' do
         config_override :legacy_readonly, true
 
         before do
-          person.__selected_fields = { "test_array" => 1 }
+          person.__selected_fields = { 'test_array' => 1 }
         end
 
-        it "persists the changes" do
+        it 'persists the changes' do
           expect(person).to be_readonly
           person.pull(test_array: 1)
           expect(person.test_array).to eq([ 2, 3 ])
         end
       end
 
-      context "when legacy_readonly is false" do
+      context 'when legacy_readonly is false' do
         config_override :legacy_readonly, false
 
         before do
           person.readonly!
         end
 
-        it "raises a ReadonlyDocument error" do
+        it 'raises a ReadonlyDocument error' do
           expect(person).to be_readonly
           expect do
             person.pull(test_array: 1)
@@ -166,33 +153,30 @@ describe Mongoid::Persistable::Pullable do
     end
   end
 
-  describe "#pull_all" do
-
-    context "when the document is the root document" do
-
-      shared_examples_for "a multi-pullable root document" do
-
-        it "pulls the first value" do
+  describe '#pull_all' do
+    context 'when the document is the root document' do
+      shared_examples_for 'a multi-pullable root document' do
+        it 'pulls the first value' do
           expect(person.aliases).to eq([ 3 ])
         end
 
-        it "pulls the last value" do
+        it 'pulls the last value' do
           expect(person.array).to eq([ 4 ])
         end
 
-        it "returns self object" do
+        it 'returns self object' do
           expect(pull_all).to eq(person)
         end
 
-        it "resets dirty changes" do
-          expect(person).to_not be_changed
+        it 'resets dirty changes' do
+          expect(person).not_to be_changed
         end
 
-        it "persists the first pull" do
+        it 'persists the first pull' do
           expect(person.reload.aliases).to eq([ 3 ])
         end
 
-        it "persists the last pull" do
+        it 'persists the last pull' do
           expect(person.reload.array).to eq([ 4 ])
         end
       end
@@ -201,52 +185,48 @@ describe Mongoid::Persistable::Pullable do
         Person.create!(aliases: [ 1, 1, 2, 3 ], array: [ 4, 5, 6 ])
       end
 
-      context "when providing string keys" do
-
+      context 'when providing string keys' do
         let!(:pull_all) do
           person.pull_all(
-            "aliases" => [ 1, 2 ], "array" => [ 5, 6 ], "test_array" => [ 1 ]
+            'aliases' => [ 1, 2 ], 'array' => [ 5, 6 ], 'test_array' => [ 1 ]
           )
         end
 
-        it_behaves_like "a multi-pullable root document"
+        it_behaves_like 'a multi-pullable root document'
       end
 
-      context "when providing symbol keys" do
-
+      context 'when providing symbol keys' do
         let!(:pull_all) do
           person.pull_all(aliases: [ 1, 2 ], array: [ 5, 6 ])
         end
 
-        it_behaves_like "a multi-pullable root document"
+        it_behaves_like 'a multi-pullable root document'
       end
     end
 
-    context "when the document is embedded" do
-
-      shared_examples_for "a multi-pullable embedded document" do
-
-        it "pulls the first value" do
+    context 'when the document is embedded' do
+      shared_examples_for 'a multi-pullable embedded document' do
+        it 'pulls the first value' do
           expect(address.services).to eq([ 3 ])
         end
 
-        it "pulls the last value" do
+        it 'pulls the last value' do
           expect(address.a).to eq([ 4 ])
         end
 
-        it "returns self object" do
+        it 'returns self object' do
           expect(pull_all).to eq(address)
         end
 
-        it "resets dirty changes" do
-          expect(address).to_not be_changed
+        it 'resets dirty changes' do
+          expect(address).not_to be_changed
         end
 
-        it "persists the first pull" do
+        it 'persists the first pull' do
           expect(address.reload.services).to eq([ 3 ])
         end
 
-        it "persists the last pull" do
+        it 'persists the last pull' do
           expect(address.reload.a).to eq([ 4 ])
         end
       end
@@ -256,70 +236,66 @@ describe Mongoid::Persistable::Pullable do
       end
 
       let(:address) do
-        person.addresses.create!(street: "t", services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
+        person.addresses.create!(street: 't', services: [ 1, 2, 3 ], a: [ 4, 5, 6 ])
       end
 
-      context "when providing string keys" do
-
+      context 'when providing string keys' do
         let!(:pull_all) do
-          address.pull_all("services" => [ 1, 2 ], "a" => [ 5, 6 ])
+          address.pull_all('services' => [ 1, 2 ], 'a' => [ 5, 6 ])
         end
 
-        it_behaves_like "a multi-pullable embedded document"
+        it_behaves_like 'a multi-pullable embedded document'
       end
 
-      context "when providing symbol keys" do
-
+      context 'when providing symbol keys' do
         let!(:pull_all) do
           address.pull_all(services: [ 1, 2 ], a: [ 5, 6 ])
         end
 
-        it_behaves_like "a multi-pullable embedded document"
+        it_behaves_like 'a multi-pullable embedded document'
       end
     end
 
-    context "when executing atomically" do
-
+    context 'when executing atomically' do
       let(:person) do
         Person.create!(test_array: [ 1, 1, 2, 3, 4 ])
       end
 
-      it "marks a dirty change for the pulled fields" do
+      it 'marks a dirty change for the pulled fields' do
         person.atomically do
           person.pull_all test_array: [ 1, 2 ]
-          expect(person.changes).to eq({"test_array" => [[ 1, 1, 2, 3, 4 ], [ 3, 4 ]]})
+          expect(person.changes).to eq({ 'test_array' => [ [ 1, 1, 2, 3, 4 ], [ 3, 4 ] ] })
         end
       end
     end
 
-    context "when executing on a readonly document" do
-
+    context 'when executing on a readonly document' do
       let(:person) do
         Person.create!(test_array: [ 1, 1, 2, 3, 4 ])
       end
 
-      context "when legacy_readonly is true" do
+      context 'when legacy_readonly is true' do
         config_override :legacy_readonly, true
 
         before do
-          person.__selected_fields = { "test_array" => 1 }
+          person.__selected_fields = { 'test_array' => 1 }
         end
 
-        it "persists the changes" do
+        it 'persists the changes' do
           expect(person).to be_readonly
           person.pull_all(test_array: [ 1, 2 ])
           expect(person.test_array).to eq([ 3, 4 ])
         end
       end
 
-      context "when legacy_readonly is false" do
+      context 'when legacy_readonly is false' do
         config_override :legacy_readonly, false
 
         before do
           person.readonly!
         end
 
-        it "raises a ReadonlyDocument error" do
+        it 'raises a ReadonlyDocument error' do
           expect(person).to be_readonly
           expect do
             person.pull_all(test_array: [ 1, 2 ])