mongoid 9.0.12 → 9.1.0

data/spec/mongoid/document_fields_spec.rb

@@ -1,14 +1,12 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Document do
-
   describe 'BSON::Binary field' do
     context 'when assigned a BSON::Binary instance' do
       let(:data) do
-        BSON::Binary.new("hello world")
+        BSON::Binary.new('hello world')
       end
 
       let(:registry) do
@@ -25,7 +23,7 @@ describe Mongoid::Document do
         registry.save!
 
         _registry = Registry.find(registry.id)
-        _registry.data.should == data
+        _registry.data.should eq data
       end
     end
 
@@ -33,7 +31,7 @@ describe Mongoid::Document do
       let(:data) do
         # Frozen string literals do not allow setting encoding on a string
         # literal - work around by composing the string at runtime
-        ([0, 253, 254] * 2).map(&:chr).join.force_encoding('BINARY')
+        ([ 0, 253, 254 ] * 2).map(&:chr).join.force_encoding('BINARY')
       end
 
       let(:registry) do
@@ -48,7 +46,7 @@ describe Mongoid::Document do
         registry.save!
 
         _registry = Registry.find(registry.id)
-        _registry.data.should == BSON::Binary.new(data)
+        _registry.data.should eq BSON::Binary.new(data)
       end
     end
 
@@ -62,14 +60,14 @@ describe Mongoid::Document do
       end
 
       it 'assigns nil' do
-        registry.data.should be nil
+        registry.data.should be_nil
       end
 
       it 'persists' do
         registry.save!
 
         _registry = Registry.find(registry.id)
-        _registry.data.should be nil
+        _registry.data.should be_nil
       end
     end
 
@@ -83,14 +81,14 @@ describe Mongoid::Document do
       end
 
       it 'assigns nil' do
-        registry.data.should be nil
+        registry.data.should be_nil
       end
 
       it 'persists' do
         registry.save!
 
         _registry = Registry.find(registry.id)
-        _registry.data.should be nil
+        _registry.data.should be_nil
       end
     end
   end
@@ -115,7 +113,7 @@ describe Mongoid::Document do
         registry.save!
 
         _registry = Registry.find(registry.id)
-        _registry.obj_id.should == obj_id
+        _registry.obj_id.should eq obj_id
       end
     end
 
@@ -136,7 +134,7 @@ describe Mongoid::Document do
         registry.save!
 
         _registry = Registry.find(registry.id)
-        _registry.obj_id.should == BSON::ObjectId.from_string(obj_id)
+        _registry.obj_id.should eq BSON::ObjectId.from_string(obj_id)
       end
     end
 
@@ -150,20 +148,20 @@ describe Mongoid::Document do
       end
 
       it 'assigns nil' do
-        registry.obj_id.should be nil
+        registry.obj_id.should be_nil
       end
 
       it 'persists' do
         registry.save!
 
         _registry = Registry.find(registry.id)
-        _registry.obj_id.should be nil
+        _registry.obj_id.should be_nil
       end
     end
 
     context 'when assigned an invalid string' do
       let(:obj_id) do
-        "hello"
+        'hello'
       end
 
       let(:registry) do
@@ -171,14 +169,14 @@ describe Mongoid::Document do
       end
 
       it 'assigns nil' do
-        registry.obj_id.should == "hello"
+        registry.obj_id.should eq 'hello'
       end
 
       it 'persists' do
         registry.save!
 
         _registry = Registry.find(registry.id)
-        _registry.obj_id.should == "hello"
+        _registry.obj_id.should eq 'hello'
       end
     end
 
@@ -192,14 +190,14 @@ describe Mongoid::Document do
       end
 
       it 'assigns nil' do
-        registry.obj_id.should == :sym
+        registry.obj_id.should eq :sym
       end
 
       it 'persists' do
         registry.save!
 
         _registry = Registry.find(registry.id)
-        _registry.obj_id.should == :sym
+        _registry.obj_id.should eq :sym
       end
     end
   end
@@ -207,7 +205,7 @@ describe Mongoid::Document do
   describe 'Hash field' do
     context 'with symbol key and value' do
       let(:church) do
-        Church.create!(location: {state: :ny})
+        Church.create!(location: { state: :ny })
       end
 
       let(:found_church) do
@@ -215,11 +213,11 @@ describe Mongoid::Document do
       end
 
       it 'round-trips the value' do
-        found_church.location[:state].should == :ny
+        found_church.location[:state].should eq :ny
       end
 
       it 'stringifies the key' do
-        found_church.location.keys.should == %w(state)
+        found_church.location.keys.should eq %w[state]
       end
 
       it 'retrieves value as symbol via driver' do
@@ -228,7 +226,7 @@ describe Mongoid::Document do
         church
 
         v = Church.collection.find.first
-        v['location'].should == {'state' => :ny}
+        v['location'].should eq({ 'state' => :ny })
       end
     end
   end
@@ -240,10 +238,10 @@ describe Mongoid::Document do
       expect(Mop.find(mop.id).regexp_field).to be_a Regexp
       expect(
         Mop.collection.find(
-          "_id" => mop.id,
-          "regexp_field" => { "$type" => 'regex' }
+          '_id' => mop.id,
+          'regexp_field' => { '$type' => 'regex' }
         ).count
-      ).to be == 1
+      ).to eq 1
     end
   end
 
@@ -254,10 +252,10 @@ describe Mongoid::Document do
       expect(Mop.find(mop.id).bson_regexp_field).to be_a BSON::Regexp::Raw
       expect(
         Mop.collection.find(
-          "_id" => mop.id,
-          "bson_regexp_field" => { "$type" => 'regex' }
+          '_id' => mop.id,
+          'bson_regexp_field' => { '$type' => 'regex' }
         ).count
-      ).to be == 1
+      ).to eq 1
     end
   end
 end

data/spec/mongoid/document_persistence_context_spec.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Document do
-
   let(:klass) do
     Person
   end
@@ -15,19 +13,19 @@ describe Mongoid::Document do
 
   describe '.client_name' do
     it 'returns client name' do
-      Person.client_name.should == :default
+      Person.client_name.should eq :default
     end
   end
 
   describe '.database_name' do
     it 'returns database name' do
-      Person.database_name.should == 'mongoid_test'
+      Person.database_name.should eq 'mongoid_test'
     end
   end
 
   describe '.collection_name' do
     it 'returns collection name' do
-      Person.collection_name.should == :people
+      Person.collection_name.should eq :people
     end
   end
 
@@ -40,28 +38,28 @@ describe Mongoid::Document do
       config_override :legacy_persistence_context_behavior, false
 
       it 'remembers its persistence context when created' do
-        expect(person.collection_name).to be == :extra_people
+        expect(person.collection_name).to eq :extra_people
       end
 
       it 'remembers its context when queried specifically' do
         person_by_id = Person.with(options) { Person.find(_id: person._id) }
-        expect(person_by_id.collection_name).to be == :extra_people
+        expect(person_by_id.collection_name).to eq :extra_people
       end
 
       it 'remembers its context when queried generally' do
         person # force the person to be created
         person_generally = Person.with(options) { Person.all[0] }
-        expect(person_generally.collection_name).to be == :extra_people
+        expect(person_generally.collection_name).to eq :extra_people
       end
 
       it 'can be reloaded without specifying the context' do
         expect { person.reload }.not_to raise_error
-        expect(person.collection_name).to be == :extra_people
+        expect(person.collection_name).to eq :extra_people
       end
 
       it 'can be updated without specifying the context' do
         person.update username: 'zyg15'
-        expect(Person.with(options) { Person.first.username }).to be == 'zyg15'
+        expect(Person.with(options) { Person.first.username }).to eq 'zyg15'
       end
 
       it 'an explicit context takes precedence over a remembered context when persisting' do
@@ -82,18 +80,18 @@ describe Mongoid::Document do
       config_override :legacy_persistence_context_behavior, true
 
       it 'does not remember its persistence context when created' do
-        expect(person.collection_name).to be == :people
+        expect(person.collection_name).to eq :people
       end
 
       it 'does not remember its context when queried specifically' do
         person_by_id = Person.with(options) { Person.find(_id: person._id) }
-        expect(person_by_id.collection_name).to be == :people
+        expect(person_by_id.collection_name).to eq :people
       end
 
       it 'does not remember its context when queried generally' do
         person # force the person to be created
         person_generally = Person.with(options) { Person.all[0] }
-        expect(person_generally.collection_name).to be == :people
+        expect(person_generally.collection_name).to eq :people
       end
 
       it 'cannot be reloaded without specifying the context' do
@@ -102,7 +100,7 @@ describe Mongoid::Document do
 
       it 'cannot be updated without specifying the context' do
         person.update username: 'zyg15'
-        expect(Person.with(options) { Person.first.username }).to be == 'zyg14'
+        expect(Person.with(options) { Person.first.username }).to eq 'zyg14'
       end
     end
   end

data/spec/mongoid/document_query_spec.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Document do
-
   context 'when projecting with #only' do
     before do
       Person.create!(username: 'Dev', title: 'CEO')
@@ -15,12 +13,14 @@ describe Mongoid::Document do
     it 'populates specified fields only' do
       expect do
         person.title
-      end.to raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'title' on Person which was not loaded/)
+      end.to raise_error(Mongoid::Errors::AttributeNotLoaded,
+                         /Attempted to access attribute 'title' on Person which was not loaded/)
       # has a default value specified in the model
       expect do
         person.age
-      end.to raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'age' on Person which was not loaded/)
-      expect(person.attributes.keys).to eq(['_id', 'username'])
+      end.to raise_error(Mongoid::Errors::AttributeNotLoaded,
+                         /Attempted to access attribute 'age' on Person which was not loaded/)
+      expect(person.attributes.keys).to eq(%w[_id username])
     end
 
     it 'allows writing omitted fields' do
@@ -45,12 +45,11 @@ describe Mongoid::Document do
 
     let(:person) { Person.where(username: 'Dev').without(:title).first }
 
-      it 'allows access to attribute of embedded document' do
+    it 'allows access to attribute of embedded document' do
       expect(person.pet.name).to eq 'Duck'
     end
 
     context 'when exclusion starts with association name but is not the association' do
-
       let(:person) { Person.where(username: 'Dev').without(:pet_).first }
 
       it 'allows access to attribute of embedded document' do
@@ -59,7 +58,6 @@ describe Mongoid::Document do
     end
 
     context 'when exclusion starts with prefix of association name' do
-
       let(:person) { Person.where(username: 'Dev').without(:pe).first }
 
       it 'allows access to attribute of embedded document' do
@@ -68,7 +66,6 @@ describe Mongoid::Document do
     end
 
     context 'when another attribute of the association is excluded' do
-
       let(:person) { Person.where(username: 'Dev').without('pet.weight').first }
 
       it 'allows access to non-excluded attribute of embedded document' do
@@ -77,13 +74,13 @@ describe Mongoid::Document do
     end
 
     context 'when the excluded attribute of the association is retrieved' do
-
       let(:person) { Person.where(username: 'Dev').without('pet.name').first }
 
       it 'prohibits the retrieval' do
         lambda do
           person.pet.name
-        end.should raise_error(Mongoid::Errors::AttributeNotLoaded, /Attempted to access attribute 'name' on Animal which was not loaded/)
+        end.should raise_error(Mongoid::Errors::AttributeNotLoaded,
+                               /Attempted to access attribute 'name' on Animal which was not loaded/)
       end
     end
   end