mongoid 9.0.12 → 9.1.0

data/spec/mongoid/association/referenced/has_one/binding_spec.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Association::Referenced::HasOne::Binding do
-
   let(:person) do
     Person.new
   end
@@ -14,86 +12,78 @@ describe Mongoid::Association::Referenced::HasOne::Binding do
   end
 
   let(:association) do
-    Person.relations["game"]
+    Person.relations['game']
   end
 
-  describe "#bind_one" do
-
+  describe '#bind_one' do
     let(:binding) do
       described_class.new(person, game, association)
     end
 
-    context "when the document is bindable" do
-
+    context 'when the document is bindable' do
       before do
-        expect(person).to receive(:save).never
-        expect(game).to receive(:save).never
+        expect(person).not_to receive(:save)
+        expect(game).not_to receive(:save)
         binding.bind_one
       end
 
-      it "sets the inverse relation" do
+      it 'sets the inverse relation' do
         expect(game.person).to eq(person)
       end
 
-      it "sets the foreign key" do
+      it 'sets the foreign key' do
         expect(game.person_id).to eq(person.id)
       end
     end
 
-    context "when the document is not bindable" do
-
+    context 'when the document is not bindable' do
       before do
         game.person = person
       end
 
-      it "does nothing" do
-        expect(person).to receive(:game=).never
+      it 'does nothing' do
+        expect(person).not_to receive(:game=)
         binding.bind_one
       end
     end
   end
 
-  describe "#unbind_one" do
-
+  describe '#unbind_one' do
     let(:binding) do
       described_class.new(person, game, association)
     end
 
-    context "when the document is unbindable" do
-
+    context 'when the document is unbindable' do
       before do
         binding.bind_one
-        expect(person).to receive(:delete).never
-        expect(game).to receive(:delete).never
+        expect(person).not_to receive(:delete)
+        expect(game).not_to receive(:delete)
         binding.unbind_one
       end
 
-      it "removes the inverse relation" do
+      it 'removes the inverse relation' do
         expect(game.person).to be_nil
       end
 
-      it "removed the foreign key" do
+      it 'removed the foreign key' do
         expect(game.person_id).to be_nil
       end
     end
 
-    context "when the document is not unbindable" do
-
-      it "does nothing" do
-        expect(person).to receive(:game=).never
+    context 'when the document is not unbindable' do
+      it 'does nothing' do
+        expect(person).not_to receive(:game=)
         binding.unbind_one
       end
     end
   end
 
-  context "when binding frozen documents" do
-
+  context 'when binding frozen documents' do
     let(:person) do
       Person.new
     end
 
-    context "when the child is frozen" do
-
+    context 'when the child is frozen' do
       let(:game) do
         Game.new.freeze
       end
@@ -102,20 +92,18 @@ describe Mongoid::Association::Referenced::HasOne::Binding do
         person.game = game
       end
 
-      it "does not set the foreign key" do
+      it 'does not set the foreign key' do
         expect(game.person_id).to be_nil
       end
     end
   end
 
-  context "when unbinding frozen documents" do
-
+  context 'when unbinding frozen documents' do
     let(:person) do
       Person.new
     end
 
-    context "when the child is frozen" do
-
+    context 'when the child is frozen' do
       let(:game) do
         Game.new
       end
@@ -126,7 +114,7 @@ describe Mongoid::Association::Referenced::HasOne::Binding do
         person.game = nil
       end
 
-      it "does not unset the foreign key" do
+      it 'does not unset the foreign key' do
         expect(game.person_id).to eq(person.id)
       end
     end

data/spec/mongoid/association/referenced/has_one/buildable_spec.rb

@@ -1,16 +1,13 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Association::Referenced::HasOne::Buildable do
-
   let(:base) do
     double(new_record?: false)
   end
 
-  describe "#build" do
-
+  describe '#build' do
     let(:document) do
       association.build(base, object)
     end
@@ -23,8 +20,7 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
       Mongoid::Association::Referenced::HasOne.new(Person, :account, options)
     end
 
-    context "when provided an id" do
-
+    context 'when provided an id' do
       let!(:account) do
         Account.create!(person_id: object, name: 'banking', balance: 200)
       end
@@ -37,13 +33,12 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
         expect_any_instance_of(Mongoid::Criteria).to receive(:where).with(association.foreign_key => object).and_call_original
       end
 
-      it "sets the document" do
+      it 'sets the document' do
         expect(document).to eq(account)
       end
     end
 
-    context "when scope is specified" do
-
+    context 'when scope is specified' do
       let!(:account) do
         Account.create!(person_id: object, name: 'banking', balance: 200)
       end
@@ -54,7 +49,7 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
 
       let(:options) do
         {
-            scope: -> { gt(balance: 100) }
+          scope: -> { gt(balance: 100) }
         }
       end
 
@@ -63,37 +58,44 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
         expect_any_instance_of(Mongoid::Criteria).to receive(:gt).with(balance: 100).and_call_original
       end
 
-      context "when document satisfies scope" do
-
-        it "sets the document" do
+      context 'when document satisfies scope' do
+        it 'sets the document' do
           expect(document).to eq(account)
         end
       end
 
-      context "when document does not satisfy scope" do
-
+      context 'when document does not satisfy scope' do
         let!(:account) do
           Account.create!(person_id: object, name: 'banking', balance: 50)
         end
 
-        it "returns nil" do
+        it 'returns nil' do
           expect(document).to eq(nil)
         end
       end
     end
 
-    context "when provided a object" do
+    context 'when provided an array of hashes' do
+      let(:object) do
+        [ { '_id' => BSON::ObjectId.new, 'name' => 'Savings', 'balance' => 500 } ]
+      end
 
+      it 'returns the document' do
+        expect(document.name).to eq('Savings')
+        expect(document.balance).to eq(500)
+      end
+    end
+
+    context 'when provided a object' do
       let(:object) do
         Account.new
       end
 
-      it "returns the object" do
+      it 'returns the object' do
         expect(document).to eq(object)
       end
 
       context 'when the object is already associated with another object' do
-
         let(:original_person) do
           Person.new
         end
@@ -116,19 +118,17 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
       end
     end
 
-    context "when the document is not found" do
-
+    context 'when the document is not found' do
       let(:object) do
         BSON::ObjectId.new
       end
 
-      it "returns nil" do
+      it 'returns nil' do
         expect(document).to be_nil
       end
     end
 
-    context "when the document is persisted" do
-
+    context 'when the document is persisted' do
       let(:person) do
         Person.create!
       end
@@ -137,13 +137,12 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
         Game.create!(person: person)
       end
 
-      it "returns the document" do
+      it 'returns the document' do
         expect(person.game).to eq(game)
       end
     end
 
-    context "when the document have a non standard pk" do
-
+    context 'when the document have a non standard pk' do
       let(:person) do
         Person.create!
       end
@@ -152,7 +151,7 @@ describe Mongoid::Association::Referenced::HasOne::Buildable do
         Cat.create!(person: person)
       end
 
-      it "returns the document" do
+      it 'returns the document' do
         expect(person.cat).to eq(cat)
       end
     end

data/spec/mongoid/association/referenced/has_one/eager_spec.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 require_relative '../has_one_models'
 
 describe Mongoid::Association::Referenced::HasOne::Eager do
-
-  describe ".grouped_doc" do
-
+  describe '.grouped_doc' do
     let(:person) do
       Person.create!
     end
@@ -21,7 +18,7 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
     end
 
     let(:eager) do
-      described_class.new([association], docs).tap do |b|
+      described_class.new([ association ], docs).tap do |b|
         b.send(:shift_association)
       end
     end
@@ -30,13 +27,12 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
       Cat.create!(person: person)
     end
 
-    it "aggregates by the relation primary key" do
-      expect(eager.send(:grouped_docs).keys).to eq([person.username])
+    it 'aggregates by the relation primary key' do
+      expect(eager.send(:grouped_docs).keys).to eq([ person.username ])
     end
   end
 
-  describe ".set_on_parent" do
-
+  describe '.set_on_parent' do
     let(:person) do
       Person.create!
     end
@@ -50,7 +46,7 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
     end
 
     let(:eager) do
-      described_class.new([association], docs).tap do |b|
+      described_class.new([ association ], docs).tap do |b|
         b.send(:shift_association)
       end
     end
@@ -60,10 +56,8 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
       eager
     end
 
-    it "sets the relation into the parent" do
-      docs.each do |doc|
-        expect(doc).to receive(:set_relation).once.with(:cat, :foo)
-      end
+    it 'sets the relation into the parent' do
+      expect(docs).to all(receive(:set_relation).once.with(:cat, :foo))
       eager.send(:set_on_parent, person.username, :foo)
     end
 
@@ -72,7 +66,7 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
       # same connection object.
       require_no_multi_shard
 
-      it "doesnt call an extra query" do
+      it 'doesnt call an extra query' do
         expect_query(0) do
           eager.send(:set_on_parent, person.username, :foo)
         end
@@ -80,8 +74,7 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
     end
   end
 
-  describe ".includes" do
-
+  describe '.includes' do
     let(:person) do
       Person.create!
     end
@@ -91,70 +84,64 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
       Cat.create!(person: Person.create!)
     end
 
-    context "when including the has_one relation" do
+    context 'when including the has_one relation' do
       # Query count assertions require that all queries are sent using the
       # same connection object.
       require_no_multi_shard
 
-      it "queries twice" do
-
+      it 'queries twice' do
         expect_query(2) do
-
           Person.all.includes(:cat).each do |person|
-            expect(person.cat).to_not be_nil
+            expect(person.cat).not_to be_nil
           end
         end
       end
     end
 
-    context "when including more than one has_one relation" do
+    context 'when including more than one has_one relation' do
       # Query count assertions require that all queries are sent using the
       # same connection object.
       require_no_multi_shard
 
-      it "queries 3 times" do
-
+      it 'queries 3 times' do
         expect_query(3) do
-
           Person.all.includes(:cat, :account).each do |person|
-            expect(person.cat).to_not be_nil
+            expect(person.cat).not_to be_nil
           end
         end
       end
     end
 
-    context "when the relation is not polymorphic" do
-
+    context 'when the relation is not polymorphic' do
       let!(:game) do
-        person.create_game(name: "Tron")
+        person.create_game(name: 'Tron')
       end
 
       let!(:eager) do
         Person.where(_id: person.id).includes(:game).first
       end
 
-      it "puts the documents in the parent document" do
+      it 'puts the documents in the parent document' do
         expect(eager.ivar(:game)).to eq(game)
       end
 
-      it "does not query when touching the association" do
+      it 'does not query when touching the association' do
         expect_query(0) do
           expect(eager.game).to eq(game)
         end
       end
 
-      it "does not query when updating the association" do
+      it 'does not query when updating the association' do
         expect_query(0) do
-          eager.game.name = "Revenge of Racing of Magic"
-          expect(eager.game.name).to eq("Revenge of Racing of Magic")
+          eager.game.name = 'Revenge of Racing of Magic'
+          expect(eager.game.name).to eq('Revenge of Racing of Magic')
         end
       end
     end
 
-    context "when the relation is polymorphic" do
-
+    context 'when the relation is polymorphic' do
       let!(:book) do
-        Book.create!(name: "Game of Thrones")
+        Book.create!(name: 'Game of Thrones')
       end
 
       let!(:rating) do
@@ -165,18 +152,18 @@ describe Mongoid::Association::Referenced::HasOne::Eager do
         Book.all.includes(:rating).first
       end
 
-      it "puts the found documents in the parent document" do
+      it 'puts the found documents in the parent document' do
         expect(eager.ivar(:rating)).to eq(rating)
       end
 
-      it "does not query when touching the association" do
+      it 'does not query when touching the association' do
         expect_query(0) do
           expect(eager.rating).to eq(rating)
         end
       end
     end
 
-    context "when the association has scope" do
+    context 'when the association has scope' do
       let!(:trainer1) { HomTrainer.create!(name: 'Dave') }
       let!(:trainer2) { HomTrainer.create!(name: 'Ash') }
       let!(:animal1) { HomAnimal.create!(taxonomy: 'reptile', trainer: trainer1) }