mongoid 9.0.12 → 9.1.0

data/spec/mongoid/association/embedded/cyclic_spec.rb

@@ -1,66 +1,60 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Association::Embedded::Cyclic do
-
-  describe ".recursively_embeds_many" do
-
-    context "when the name is inflected easily" do
-
+  describe '.recursively_embeds_many' do
+    context 'when the name is inflected easily' do
       let(:document) do
         Role.new
       end
 
-      it "creates the parent relation" do
+      it 'creates the parent relation' do
         expect(document).to respond_to(:parent_role)
       end
 
-      it "creates the child relation" do
+      it 'creates the child relation' do
         expect(document).to respond_to(:child_roles)
       end
 
-      it "sets cyclic to true" do
+      it 'sets cyclic to true' do
         expect(document.cyclic).to be true
       end
 
-      context "when a query is executed" do
-
+      context 'when a query is executed' do
         before do
           document.save!
         end
 
-        it "queries the database, not memory" do
+        it 'queries the database, not memory' do
           expect(Role.first).to be_a(Role)
         end
       end
     end
 
-    context "when the name is not inflected easily" do
-
+    context 'when the name is not inflected easily' do
       let(:document) do
         Entry.new
       end
 
-      it "creates the parent relation" do
+      it 'creates the parent relation' do
         expect(document).to respond_to(:parent_entry)
       end
 
-      it "creates the child relation" do
+      it 'creates the child relation' do
         expect(document).to respond_to(:child_entries)
       end
 
-      it "sets cyclic to true" do
+      it 'sets cyclic to true' do
         expect(document.cyclic).to be true
       end
     end
 
-    context "when the document is namespaced" do
-
+    context 'when the document is namespaced' do
       module Trees
         class Node
           include Mongoid::Document
+
           recursively_embeds_many
 
           field :name, type: String
@@ -75,106 +69,100 @@ describe Mongoid::Association::Embedded::Cyclic do
         Trees::Node.new
       end
 
-      it "creates the parent relation" do
+      it 'creates the parent relation' do
         expect(document).to respond_to(:parent_node)
       end
 
-      it "creates the child relation" do
+      it 'creates the child relation' do
         expect(document).to respond_to(:child_nodes)
       end
 
-      it "sets cyclic to true" do
+      it 'sets cyclic to true' do
         expect(document.cyclic).to be true
       end
     end
 
-    context "when the classes are namespaced" do
-
+    context 'when the classes are namespaced' do
       let(:document) do
         Fruits::Apple.new
       end
 
-      it "creates the parent relation" do
+      it 'creates the parent relation' do
         expect(document).to respond_to(:parent_apple)
       end
 
-      it "creates the child relation" do
+      it 'creates the child relation' do
         expect(document).to respond_to(:child_apples)
       end
 
-      it "sets cyclic to true" do
+      it 'sets cyclic to true' do
         expect(document.cyclic).to be true
       end
     end
 
-    context "when cascading callbacks are enabled" do
-
+    context 'when cascading callbacks are enabled' do
       let(:document) do
         Fruits::Pineapple.new
       end
 
-      it "creates relation with cascading callbacks enabled" do
+      it 'creates relation with cascading callbacks enabled' do
         expect(document.class.relations['child_pineapples']).to be_cascading_callbacks
       end
     end
   end
 
-  describe ".recursively_embeds_one" do
-
+  describe '.recursively_embeds_one' do
     let(:document) do
       Shelf.new
     end
 
-    it "creates the parent relation" do
+    it 'creates the parent relation' do
       expect(document).to respond_to(:parent_shelf)
     end
 
-    it "creates the child relation" do
+    it 'creates the child relation' do
       expect(document).to respond_to(:child_shelf)
     end
 
-    it "sets cyclic to true" do
+    it 'sets cyclic to true' do
       expect(document.cyclic).to be true
     end
 
-    context "when cascading callbacks are enabled" do
-
+    context 'when cascading callbacks are enabled' do
       let(:document) do
         Fruits::Mango.new
       end
 
-      it "creates relation with cascading callbacks enabled" do
+      it 'creates relation with cascading callbacks enabled' do
         expect(document.class.relations['child_mango']).to be_cascading_callbacks
       end
     end
 
-    context "when a query is executed" do
-
+    context 'when a query is executed' do
       before do
         document.save!
       end
 
-      it "queries the database, not memory" do
+      it 'queries the database, not memory' do
         expect(Shelf.first).to be_a(Shelf)
       end
     end
   end
 
-  context "when building a namespaced hierarchy" do
-
+  context 'when building a namespaced hierarchy' do
     let(:root) do
-      Trees::Node.new(name: "root")
+      Trees::Node.new(name: 'root')
     end
 
     let!(:child_one) do
-      root.child_nodes.build(name: "first_child")
+      root.child_nodes.build(name: 'first_child')
     end
 
     let!(:child_two) do
-      root.child_nodes.build(name: "second_child")
+      root.child_nodes.build(name: 'second_child')
     end
 
-    it "sets the parent node" do
+    it 'sets the parent node' do
       expect(child_one.parent_node).to eq(root)
     end
   end

data/spec/mongoid/association/embedded/dirty_spec.rb

@@ -1,40 +1,36 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 require 'spec_helper'
 
-describe "when initialize a model with an embedded model" do
-
+describe 'when initialize a model with an embedded model' do
   let(:person) do
     Person.new(pet: Pet.new)
   end
 
-  it "has changes in the embedded model" do
-    expect(person.pet.changes).to_not be_empty
+  it 'has changes in the embedded model' do
+    expect(person.pet.changes).not_to be_empty
   end
 
-  it "does not have previous_changes in the embedded model" do
+  it 'does not have previous_changes in the embedded model' do
     expect(person.pet.previous_changes).to be_empty
   end
 end
 
-describe "when creating a model with an embedded model" do
-
+describe 'when creating a model with an embedded model' do
   let(:person) do
     Person.create!(pet: Pet.new)
   end
 
-  it "does not have changes in the embedded model" do
+  it 'does not have changes in the embedded model' do
     expect(person.pet.changes).to be_empty
   end
 
-  it "has previous_changes in the embedded model" do
-    expect(person.pet.previous_changes).to_not be_empty
+  it 'has previous_changes in the embedded model' do
+    expect(person.pet.previous_changes).not_to be_empty
   end
 end
 
-describe "when embedding a model on an already saved model" do
-
+describe 'when embedding a model on an already saved model' do
   let(:person) do
     Person.create!
   end
@@ -43,25 +39,24 @@ describe "when embedding a model on an already saved model" do
     person.pet = Pet.new
   end
 
-  it "has not changes on the embedded model" do
+  it 'has not changes on the embedded model' do
     expect(person.pet.changes).to be_empty
   end
 
-  it "has previous changes on the embedded model" do
-    expect(person.pet.previous_changes).to_not be_empty
+  it 'has previous changes on the embedded model' do
+    expect(person.pet.previous_changes).not_to be_empty
   end
 
-  describe "and saving the model" do
-
+  describe 'and saving the model' do
     before do
       person.save!
     end
 
-    it "does not have changes on the embedded model" do
+    it 'does not have changes on the embedded model' do
       expect(person.pet.changes).to be_empty
     end
 
-    it "does not have previous changes on the embedded model" do
+    it 'does not have previous changes on the embedded model' do
       expect(person.pet.previous_changes).to be_empty
     end
   end

data/spec/mongoid/association/embedded/embedded_in/binding_spec.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Association::Embedded::EmbeddedIn::Binding do
-
   let(:person) do
     Person.new
   end
@@ -18,155 +16,139 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Binding do
   end
 
   let(:name_association) do
-    Name.relations["namable"]
+    Name.relations['namable']
   end
 
   let(:address_association) do
-    Address.relations["addressable"]
+    Address.relations['addressable']
   end
 
   let(:person_association) do
-    Person.relations["addresses"]
+    Person.relations['addresses']
   end
 
-  describe "#bind_one" do
-
-    context "when the child of an embeds one" do
-
+  describe '#bind_one' do
+    context 'when the child of an embeds one' do
       let(:binding) do
         described_class.new(name, person, name_association)
       end
 
-      context "when the document is bindable" do
-
+      context 'when the document is bindable' do
         before do
           binding.bind_one
         end
 
-        it "parentizes the documents" do
+        it 'parentizes the documents' do
           expect(name._parent).to eq(person)
         end
 
-        it "sets the inverse relation" do
+        it 'sets the inverse relation' do
           expect(person.name).to eq(name)
         end
       end
 
-      context "when the document is not bindable" do
-
+      context 'when the document is not bindable' do
         before do
           person.name = name
         end
 
-        it "does nothing" do
-          expect(name).to receive(:namable=).with(person).never
+        it 'does nothing' do
+          expect(name).not_to receive(:namable=).with(person)
           expect(name).to receive(:namable=).with(nil).once
           binding.bind_one
         end
       end
     end
 
-    context "when the child of an embeds many" do
-
+    context 'when the child of an embeds many' do
       let(:binding) do
         described_class.new(address, person, address_association)
       end
 
-      context "when the document is bindable" do
-
-        context "when the base has no association" do
-
+      context 'when the document is bindable' do
+        context 'when the base has no association' do
           before do
             binding.bind_one
           end
 
-          it "parentizes the documents" do
+          it 'parentizes the documents' do
             expect(address._parent).to eq(person)
           end
 
-          it "sets the inverse relation" do
+          it 'sets the inverse relation' do
             expect(person.addresses).to include(address)
           end
         end
 
-        context "when the base has an association" do
-
+        context 'when the base has an association' do
           before do
             address._association = person_association
           end
 
-          it "does not overwrite the existing association" do
-            expect(address).to receive(:_association=).never
+          it 'does not overwrite the existing association' do
+            expect(address).not_to receive(:_association=)
             binding.bind_one
           end
         end
       end
 
-      context "when the document is not bindable" do
-
+      context 'when the document is not bindable' do
         before do
           person.addresses = [ address ]
         end
 
-        it "does nothing" do
-          expect(address).to receive(:addressable=).never
+        it 'does nothing' do
+          expect(address).not_to receive(:addressable=)
           binding.bind_one
         end
       end
     end
   end
 
-  describe "#unbind_one" do
-
-    context "when the child of an embeds one" do
-
+  describe '#unbind_one' do
+    context 'when the child of an embeds one' do
       let(:binding) do
         described_class.new(name, person, name_association)
       end
 
-      context "when the document is unbindable" do
-
+      context 'when the document is unbindable' do
         before do
           binding.bind_one
           binding.unbind_one
         end
 
-        it "removes the inverse relation" do
+        it 'removes the inverse relation' do
           expect(person.name).to be_nil
         end
       end
 
-      context "when the document is not unbindable" do
-
-        it "does nothing" do
-          expect(name).to receive(:namable=).never
+      context 'when the document is not unbindable' do
+        it 'does nothing' do
+          expect(name).not_to receive(:namable=)
           binding.unbind_one
         end
       end
     end
 
-    context "when the child of an embeds many" do
-
+    context 'when the child of an embeds many' do
       let(:binding) do
         described_class.new(address, person, address_association)
       end
 
-      context "when the document is unbindable" do
-
+      context 'when the document is unbindable' do
         before do
           binding.bind_one
           binding.unbind_one
         end
 
-        it "removes the inverse relation" do
+        it 'removes the inverse relation' do
           expect(person.addresses).to be_empty
         end
       end
 
-      context "when the document is not unbindable" do
-
-        it "does nothing" do
-          expect(address).to receive(:addressable=).never
+      context 'when the document is not unbindable' do
+        it 'does nothing' do
+          expect(address).not_to receive(:addressable=)
           binding.unbind_one
         end
       end

data/spec/mongoid/association/embedded/embedded_in/buildable_spec.rb

@@ -1,26 +1,22 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Association::Embedded::EmbeddedIn::Buildable do
-
-  describe "#build" do
-
+  describe '#build' do
     let(:base) do
       double
     end
 
     let(:options) do
-      { }
+      {}
     end
 
     let(:association) do
       Mongoid::Association::Embedded::EmbeddedIn.new(Person, :addresses, options)
     end
 
-    context "when a document is provided" do
-
+    context 'when a document is provided' do
       let(:object) do
         double
       end
@@ -29,16 +25,14 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Buildable do
         association.build(base, object)
       end
 
-      it "returns the document" do
+      it 'returns the document' do
         expect(document).to eq(object)
       end
     end
   end
 
   context 'when the object is already associated with another object' do
-
-    context "when inverse is embeds_many" do
-
+    context 'when inverse is embeds_many' do
       let(:appointment1) do
         Appointment.new
       end
@@ -59,12 +53,11 @@ describe Mongoid::Association::Embedded::EmbeddedIn::Buildable do
       it 'does not clear the object of its previous association' do
         expect(appointment1.person).to eq(person)
         expect(appointment2.person).to eq(person)
-        expect(person.appointments).to eq([appointment1, appointment2])
+        expect(person.appointments).to eq([ appointment1, appointment2 ])
       end
     end
 
-    context "when inverse is embeds_one" do
-
+    context 'when inverse is embeds_one' do
       let(:scribe1) do
         Scribe.new
       end