mongoid 9.0.11 → 9.1.1

data/lib/mongoid/association/options.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Association
-
     # Options context used for all association types.
     module Options
-
       # Returns the name of the parent to a polymorphic child.
       #
       # @return [ String | Symbol ] The name.
@@ -42,6 +39,23 @@ module Mongoid
         !!@options[:autobuild]
       end
 
+      # Invokes the :fallback Proc and returns the null object that stands in
+      # for the association when its actual value is nil. The Proc is invoked
+      # on every access; identity is the user's responsibility (return a fresh
+      # instance, a shared constant, or whatever the Proc chooses).
+      #
+      # @return [ Object | nil ] The Proc's return value, or nil if not set.
+      def fallback
+        @options[:fallback]&.call
+      end
+
+      # Whether the association has a :fallback (null object) option set.
+      #
+      # @return [ true | false ]
+      def fallback?
+        !@options[:fallback].nil?
+      end
+
       # Is the association cyclic.
       #
       # @return [ true | false ] Whether the association is cyclic.
@@ -71,7 +85,7 @@ module Mongoid
       def autosave
         !!@options[:autosave]
       end
-      alias :autosave? :autosave
+      alias autosave? autosave
 
       # Whether the association is counter-cached.
       #
@@ -83,7 +97,9 @@ module Mongoid
       # Whether this association is polymorphic.
       #
       # @return [ true | false ] Whether the association is polymorphic.
-      def polymorphic?; false; end
+      def polymorphic?
+        false
+      end
 
       # Whether the association has callbacks cascaded down from the parent.
       #
@@ -100,7 +116,9 @@ module Mongoid
       # Whether the association has forced nil inverse (So no foreign keys are saved).
       #
       # @return [ false ] Default is false.
-      def forced_nil_inverse?; false; end
+      def forced_nil_inverse?
+        false
+      end
 
       # The field for saving the associated object's type.
       #
@@ -111,7 +129,7 @@ module Mongoid
       #
       # @return [ nil ] Default is nil.
       def touch_field
-        @touch_field ||= options[:touch] if (options[:touch].is_a?(String) || options[:touch].is_a?(Symbol))
+        @touch_field ||= options[:touch] if options[:touch].is_a?(String) || options[:touch].is_a?(Symbol)
       end
 
       # Whether the association object should be automatically touched

data/lib/mongoid/association/referenced/auto_save.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Association
     module Referenced
-
       # Mixin module included into Mongoid::Document which adds
       # the ability to automatically save opposite-side documents
       # in referenced associations when saving the subject document.

data/lib/mongoid/association/referenced/belongs_to/binding.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Association
     module Referenced
       class BelongsTo
-
         # Binding class for belongs_to associations.
         class Binding
           include Bindable
@@ -30,14 +28,12 @@ module Mongoid
                 bind_polymorphic_inverse_type(_base, key)
               end
 
-              if inverse = _association.inverse(_target)
-                if set_base_association
-                  if _base.referenced_many?
-                    _target.__send__(inverse).push(_base)
-                  else
-                    remove_associated(_target)
-                    _target.set_relation(inverse, _base)
-                  end
+              if (inverse = _association.inverse(_target)) && set_base_association
+                if _base.referenced_many?
+                  _target.__send__(inverse).push(_base)
+                else
+                  remove_associated(_target)
+                  _target.set_relation(inverse, _base)
                 end
               end
             end
@@ -77,11 +73,11 @@ module Mongoid
           # @param [ Document ] doc The document to check.
           def check_polymorphic_inverses!(doc)
             inverses = _association.inverses(doc)
-            if inverses.length > 1 && _base.send(_association.foreign_key).nil?
-              raise Errors::InvalidSetPolymorphicRelation.new(
-                  _association.name, _base.class.name, _target.class.name
-              )
-            end
+            return unless inverses.length > 1 && _base.send(_association.foreign_key).nil?
+
+            raise Errors::InvalidSetPolymorphicRelation.new(
+              _association.name, _base.class.name, _target.class.name
+            )
           end
         end
       end

data/lib/mongoid/association/referenced/belongs_to/buildable.rb

@@ -1,14 +1,11 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Association
     module Referenced
       class BelongsTo
-
         # The Builder behavior for belongs_to associations.
         module Buildable
-
           # This method either takes an _id or an object and queries for the
           # inverse side using the id or sets the object.
           #
@@ -21,8 +18,25 @@ module Mongoid
           # @param [ nil ] selected_fields Must be nil.
           #
           # @return [ Document ] A single document.
-          def build(base, object, type = nil, selected_fields = nil)
+          def build(_base, object, type = nil, selected_fields = nil)
             return object unless query?(object)
+
+            # Handle array from $lookup aggregation (returns array even for belongs_to)
+            if object.is_a?(Array)
+              first = object.first
+              case first
+              when nil, Mongoid::Document then return first
+              when Hash then return Factory.execute_from_db(klass, first, nil, selected_fields,
+                                                            execute_callbacks: false)
+              else raise ArgumentError, 'Cannot build belongs_to association from array'
+              end
+            end
+
+            # Handle single hash from $lookup with $unwind
+            if object.is_a?(Hash)
+              return Factory.execute_from_db(klass, object, nil, selected_fields, execute_callbacks: false)
+            end
+
             execute_query(object, type)
           end
 
@@ -33,7 +47,11 @@ module Mongoid
           end
 
           def query_criteria(object, type)
-            cls = type ? (type.is_a?(String) ? type.constantize : type) : relation_class
+            cls = if type
+                    type.is_a?(String) ? type.constantize : type
+                  else
+                    relation_class
+                  end
             crit = cls.criteria
             crit = crit.apply_scope(scope)
             crit.where(primary_key => object)

data/lib/mongoid/association/referenced/belongs_to/eager.rb

@@ -1,14 +1,11 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Association
     module Referenced
       class BelongsTo
-
         # Eager class for belongs_to associations.
         class Eager < Association::Eager
-
           private
 
           def preload
@@ -27,10 +24,15 @@ module Mongoid
           # association is not polymorphic, all documents are retrieved in
           # a single query. If the association is polymorphic, one query is
           # issued per association target class.
+          #
+          # The polymorphic *_type field is resolved through the
+          # association's resolver to keep this path consistent with the
+          # non-eager accessor and to avoid loading arbitrary constants
+          # named in user-controlled BSON data.
           def each_loaded_document(&block)
             if @association.polymorphic?
               keys_by_type_from_docs.each do |type, keys|
-                each_loaded_document_of_class(Object.const_get(type), keys, &block)
+                each_loaded_document_of_class(@association.resolver.model_for(type), keys, &block)
               end
             else
               super
@@ -45,6 +47,7 @@ module Mongoid
 
             @docs.each_with_object({}) do |doc, keys_by_type|
               next unless doc.respond_to?(inverse_type_field) && doc.respond_to?(group_by_key)
+
               inverse_type_name = doc.send(inverse_type_field)
               # If a particular document does not have a value for this
               # association, inverse_type_name will be nil.

data/lib/mongoid/association/referenced/belongs_to.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 require 'mongoid/association/referenced/belongs_to/binding'
 require 'mongoid/association/referenced/belongs_to/buildable'
@@ -9,7 +8,6 @@ require 'mongoid/association/referenced/belongs_to/eager'
 module Mongoid
   module Association
     module Referenced
-
       # The BelongsTo type association.
       class BelongsTo
         include Relatable
@@ -19,19 +17,20 @@ module Mongoid
         # common ones.
         #
         # @return [ Array<Symbol> ] The extra valid options.
-        ASSOCIATION_OPTIONS = [
-            :autobuild,
-            :autosave,
-            :counter_cache,
-            :dependent,
-            :foreign_key,
-            :index,
-            :polymorphic,
-            :primary_key,
-            :touch,
-            :optional,
-            :required,
-            :scope,
+        ASSOCIATION_OPTIONS = %i[
+          autobuild
+          autosave
+          counter_cache
+          dependent
+          fallback
+          foreign_key
+          index
+          polymorphic
+          primary_key
+          touch
+          optional
+          required
+          scope
         ].freeze
 
         # The complete list of valid options for this association, including
@@ -48,7 +47,7 @@ module Mongoid
         # The default foreign key suffix.
         #
         # @return [ String ] '_id'
-        FOREIGN_KEY_SUFFIX = '_id'.freeze
+        FOREIGN_KEY_SUFFIX = '_id'
 
         # The list of association complements.
         #
@@ -69,24 +68,33 @@ module Mongoid
         # Does this association type store the foreign key?
         #
         # @return [ true ] Always true.
-        def stores_foreign_key?; true; end
+        def stores_foreign_key?
+          true
+        end
 
         # Is this association type embedded?
         #
         # @return [ false ] Always false.
-        def embedded?; false; end
+        def embedded?
+          false
+        end
 
         # The default for validation the association object.
         #
         # @return [ false ] Always false.
-        def validation_default; false; end
+        def validation_default
+          false
+        end
 
         # Get the foreign key field for saving the association reference.
         #
         # @return [ String ] The foreign key field for saving the association reference.
         def foreign_key
-          @foreign_key ||= @options[:foreign_key] ? @options[:foreign_key].to_s :
+          @foreign_key ||= if @options[:foreign_key]
+                             @options[:foreign_key].to_s
+                           else
                              default_foreign_key_field
+                           end
         end
 
         # Get the association proxy class for this association type.
@@ -107,7 +115,7 @@ module Mongoid
         # class objects, and vice versa. This is obtained via the `:polymorphic` option
         # that was given when the association was defined.
         #
-        # See Mongoid::ModelResolver.resolver for how the `:polymorphic` option is 
+        # See Mongoid::ModelResolver.resolver for how the `:polymorphic` option is
         # interpreted here.
         #
         # @raise KeyError if no such resolver has been registered under the given
@@ -190,32 +198,30 @@ module Mongoid
         end
 
         def polymorph!
-          if polymorphic?
-            @owner_class.polymorphic = true
-            @owner_class.field(inverse_type, type: String)
-          end
+          return unless polymorphic?
+
+          @owner_class.polymorphic = true
+          @owner_class.field(inverse_type, type: String)
         end
 
         def polymorphic_inverses(other = nil)
-          if other
-            matches = other.relations.values.select do |rel|
-              relation_complements.include?(rel.class) &&
-                  rel.as == name &&
-                  rel.relation_class_name == inverse_class_name
-            end
-            matches.collect { |m| m.name }
+          return unless other
+
+          matches = other.relations.values.select do |rel|
+            relation_complements.include?(rel.class) &&
+              rel.as == name &&
+              rel.relation_class_name == inverse_class_name
           end
+          matches.collect { |m| m.name }
         end
 
         def determine_inverses(other)
           matches = (other || relation_class).relations.values.select do |rel|
             relation_complements.include?(rel.class) &&
-                rel.relation_class_name == inverse_class_name
-
-          end
-          if matches.size > 1
-            raise Errors::AmbiguousRelationship.new(relation_class, @owner_class, name, matches)
+              rel.relation_class_name == inverse_class_name
           end
+          raise Errors::AmbiguousRelationship.new(relation_class, @owner_class, name, matches) if matches.size > 1
+
           matches.collect { |m| m.name }
         end
 
@@ -228,12 +234,12 @@ module Mongoid
 
         def create_foreign_key_field!
           @owner_class.field(
-              foreign_key,
-              type: FOREIGN_KEY_FIELD_TYPE,
-              identity: true,
-              overwrite: true,
-              association: self,
-              default: nil
+            foreign_key,
+            type: FOREIGN_KEY_FIELD_TYPE,
+            identity: true,
+            overwrite: true,
+            association: self,
+            default: nil
           )
         end
       end

data/lib/mongoid/association/referenced/counter_cache.rb

@@ -1,10 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Association
     module Referenced
-
       # Mixin module included into Mongoid::Document which adds
       # the ability to cache the count of opposite-side documents
       # in referenced n-to-many associations.
@@ -26,7 +24,6 @@ module Mongoid
         end
 
         module ClassMethods
-
           # Reset the given counter using the .count() query from the
           # db. This method is useful in case that a counter got
           # corrupted, or a new counter was added to the collection.
@@ -56,7 +53,7 @@ module Mongoid
           # @param [ String ] id The id of the object to update.
           # @param [ Hash ] counters
           def update_counters(id, counters)
-            where(:_id => id).inc(counters)
+            where(_id: id).inc(counters)
           end
 
           # Increment the counter name from the entries that match the
@@ -113,19 +110,17 @@ module Mongoid
                   end
                 end
 
-                if record = __send__(name)
-                  unless current.nil?
-                    record[cache_column] = (record[cache_column] || 0) + 1
-                    record.class.with(record.persistence_context) do |_class|
-                      _class.increment_counter(cache_column, current) if record.persisted?
-                    end
+                if (record = without_autobuild { __send__(name) }) && !current.nil?
+                  record[cache_column] = (record[cache_column] || 0) + 1
+                  record.class.with(record.persistence_context) do |_class|
+                    _class.increment_counter(cache_column, current) if record.persisted?
                   end
                 end
               end
             end
 
             klass.after_create do
-              if record = __send__(name)
+              if record = without_autobuild { __send__(name) }
                 record[cache_column] = (record[cache_column] || 0) + 1
 
                 if record.persisted?
@@ -138,7 +133,7 @@ module Mongoid
             end
 
             klass.before_destroy do
-              if record = __send__(name)
+              if record = without_autobuild { __send__(name) }
                 record[cache_column] = (record[cache_column] || 0) - 1 unless record.frozen?
 
                 if record.persisted?

data/lib/mongoid/association/referenced/has_and_belongs_to_many/binding.rb

@@ -1,11 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Association
     module Referenced
       class HasAndBelongsToMany
-
         # Binding class for all has_and_belongs_to_many associations.
         class Binding
           include Bindable

data/lib/mongoid/association/referenced/has_and_belongs_to_many/buildable.rb

@@ -1,14 +1,11 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Association
     module Referenced
       class HasAndBelongsToMany
-
         # The Builder behavior for has_and_belongs_to_many associations.
         module Buildable
-
           # This builder either takes a hash and queries for the
           # object or an array of documents, where it will just return them.
           #
@@ -21,8 +18,15 @@ module Mongoid
           # @param [ nil ] selected_fields Must be nil.
           #
           # @return [ Array<Document> ] The documents.
-          def build(base, object, type = nil, selected_fields = nil)
+          def build(_base, object, _type = nil, selected_fields = nil)
             if query?(object)
+              # Handle array of hashes from $lookup aggregation
+              if object.is_a?(Array) && object.all? { |o| o.is_a?(Hash) }
+                return object.map do |attrs|
+                  Factory.execute_from_db(klass, attrs, nil, selected_fields, execute_callbacks: false)
+                end
+              end
+
               query_criteria(object)
             else
               object.try(:dup)

data/lib/mongoid/association/referenced/has_and_belongs_to_many/eager.rb

@@ -1,14 +1,11 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Association
     module Referenced
       class HasAndBelongsToMany
-
         # Eager class for has_and_belongs_to_many associations.
         class Eager < Association::Eager
-
           private
 
           def preload