mongoid 9.0.11 → 9.1.1

data/spec/support/immutable_ids.rb

@@ -1,19 +1,18 @@
-# rubocop:todo all
 module Mongoid
   module ImmutableIds
     def immutable_id_examples_as(name)
       shared_examples_for name do
         shared_examples 'a persisted document' do
-          it 'should disallow _id to be updated' do
+          it 'disallows _id to be updated' do
             expect { invoke_operation! }
               .to raise_error(Mongoid::Errors::ImmutableAttribute)
           end
-    
+
           context 'when immutable_ids is false' do
             before { Mongoid::Config.immutable_ids = false }
             after { Mongoid::Config.immutable_ids = true }
 
-            it 'should ignore the change and issue a warning' do
+            it 'ignores the change and issue a warning' do
               expect(Mongoid::Warnings).to receive(:warn_mutable_ids)
               expect { invoke_operation! }.not_to raise_error
               expect(id_is_unchanged).not_to be legacy_behavior_expects_id_to_change
@@ -23,7 +22,7 @@ module Mongoid
           context 'when id is set to the existing value' do
             let(:new_id_value) { object._id }
 
-            it 'should allow the update to proceed' do
+            it 'allows the update to proceed' do
               expect { invoke_operation! }
                 .not_to raise_error
             end
@@ -33,47 +32,47 @@ module Mongoid
         context 'when the field is _id' do
           let(:new_id_value) { 1234 }
 
-          context 'when the document is top-level' do    
+          context 'when the document is top-level' do
             let(:legacy_behavior_expects_id_to_change) { false }
 
             context 'when the document is new' do
               let(:object) { Person.new }
-    
-              it 'should allow _id to be updated' do
+
+              it 'allows _id to be updated' do
                 invoke_operation!
                 expect(object.new_record?).to be false
-                expect(object.reload._id).to be == new_id_value
+                expect(object.reload._id).to eq new_id_value
               end
             end
-    
+
             context 'when the document has been persisted' do
               let(:object) { Person.create }
               let!(:original_id) { object._id }
               let(:id_is_unchanged) { Person.exists?(original_id) }
-    
+
               it_behaves_like 'a persisted document'
             end
           end
-    
+
           context 'when the document is embedded' do
             let(:parent) { Person.create }
             let(:legacy_behavior_expects_id_to_change) { true }
 
             context 'when the document is new' do
               let(:object) { parent.favorites.new }
-    
-              it 'should allow _id to be updated' do
+
+              it 'allows _id to be updated' do
                 invoke_operation!
                 expect(object.new_record?).to be false
-                expect(parent.reload.favorites.first._id).to be == new_id_value
+                expect(parent.reload.favorites.first._id).to eq new_id_value
               end
             end
-    
+
             context 'when the document has been persisted' do
               let(:object) { parent.favorites.create }
               let!(:original_id) { object._id }
               let(:id_is_unchanged) { parent.favorites.where(_id: original_id).exists? }
-      
+
               it_behaves_like 'a persisted document'
 
               context 'updating embeds_one via parent' do
@@ -81,7 +80,7 @@ module Mongoid
                   before { Mongoid::Config.immutable_ids = false }
                   after { Mongoid::Config.immutable_ids = true }
 
-                  it 'should ignore the change' do
+                  it 'ignores the change' do
                     expect(Mongoid::Warnings).to receive(:warn_mutable_ids)
 
                     parent.pet = pet = Pet.new
@@ -91,18 +90,18 @@ module Mongoid
                     new_id = BSON::ObjectId.new
 
                     expect { parent.update(pet: { _id: new_id }) }.not_to raise_error
-                    expect(parent.reload.pet._id.to_s).to be == original_id.to_s
+                    expect(parent.reload.pet._id.to_s).to eq original_id.to_s
                   end
                 end
 
                 context 'when immutable_ids is true' do
                   before { expect(Mongoid::Config.immutable_ids).to be true }
 
-                  it 'should raise an exception' do
+                  it 'raises an exception' do
                     parent.pet = pet = Pet.new
                     parent.save
 
-                    original_id = pet._id
+                    pet._id
                     new_id = BSON::ObjectId.new
 
                     expect { parent.update(pet: { _id: new_id }) }

data/spec/support/macros.rb

@@ -1,12 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Macros
-
     def use_spec_mongoid_config
       around do |example|
-        config_path = File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
+        config_path = File.join(File.dirname(__FILE__), '..', 'config', 'mongoid.yml')
 
         Mongoid::Clients.clear
         Mongoid.load!(config_path, :test)

data/spec/support/models/account.rb

@@ -1,21 +1,20 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Account
   include Mongoid::Document
 
-  field :_id, type: String, overwrite: true, default: ->{ name.try(:parameterize) }
+  field :_id, type: String, overwrite: true, default: -> { name.try(:parameterize) }
 
   field :number, type: String
   field :balance, type: Integer
   field :nickname, type: String
   field :name, type: String
-  field :balanced, type: Mongoid::Boolean, default: ->{ balance? ? true : false }
+  field :balanced, type: Mongoid::Boolean, default: -> { balance? || false }
 
   field :overridden, type: String
 
   embeds_many :memberships
-  belongs_to :creator, class_name: "User", foreign_key: :creator_id
+  belongs_to :creator, class_name: 'User', foreign_key: :creator_id
   belongs_to :person
   has_many :alerts, autosave: false
   has_and_belongs_to_many :agents
@@ -26,7 +25,7 @@ class Account
   validates_length_of :name, maximum: 10, on: :create
 
   def overridden
-    self[:overridden] = "not recommended"
+    self[:overridden] = 'not recommended'
   end
 
   # MONGOID-3365

data/spec/support/models/acolyte.rb

@@ -1,20 +1,20 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Acolyte
   include Mongoid::Document
   include Mongoid::Attributes::Dynamic
+
   field :status
   field :name
 
   embeds_many :versions, as: :memorable
   belongs_to :church
 
-  default_scope ->{ asc(:name) }
-  scope :active, ->{ where(status: "active") }
-  scope :named, ->{ where(:name.exists => true) }
+  default_scope -> { asc(:name) }
+  scope :active, -> { where(status: 'active') }
+  scope :named, -> { where(:name.exists => true) }
 
   def callback_test?
-    name == "callback-test"
+    name == 'callback-test'
   end
 end

data/spec/support/models/actor.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Actor
   include Mongoid::Document
+
   field :name
   field :after_custom_count, type: Integer, default: 0
   has_and_belongs_to_many :tags
@@ -13,9 +13,9 @@ class Actor
 
   def do_something
     run_callbacks(:custom) do
-      self.name = "custom"
+      self.name = 'custom'
     end
   end
 end
 
-require "support/models/actress"
+require 'support/models/actress'

data/spec/support/models/actress.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Actress < Actor
 end

data/spec/support/models/address.rb

@@ -1,10 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Address
   include Mongoid::Document
 
-  field :_id, type: String, overwrite: true, default: ->{ street.try(:parameterize) }
+  field :_id, type: String, overwrite: true, default: -> { street.try(:parameterize) }
 
   attr_accessor :mode
 
@@ -35,10 +34,11 @@ class Address
 
   embedded_in :addressable, polymorphic: true do
     def extension
-      "Testing"
+      'Testing'
     end
+
     def doctor?
-      title == "Dr"
+      title == 'Dr'
     end
   end
 
@@ -48,12 +48,12 @@ class Address
   belongs_to :account
   belongs_to :band
 
-  scope :without_postcode, ->{ where(postcode: nil) }
-  scope :ordered, ->{ order_by(state: 1) }
-  scope :without_postcode_ordered, ->{ without_postcode.ordered }
-  scope :rodeo, ->{ where(street: "Rodeo Dr") } do
+  scope :without_postcode, -> { where(postcode: nil) }
+  scope :ordered, -> { order_by(state: 1) }
+  scope :without_postcode_ordered, -> { without_postcode.ordered }
+  scope :rodeo, -> { where(street: 'Rodeo Dr') } do
     def mansion?
-      all? { |address| address.street == "Rodeo Dr" }
+      all? { |address| address.street == 'Rodeo Dr' }
     end
   end
 
@@ -70,11 +70,11 @@ class Address
 
   class << self
     def california
-      where(state: "CA")
+      where(state: 'CA')
     end
 
     def homes
-      where(address_type: "Home")
+      where(address_type: 'Home')
     end
 
     def streets

data/spec/support/models/address_component.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class AddressComponent
   include Mongoid::Document
+
   field :street, type: String
   embedded_in :person
 end

data/spec/support/models/address_number.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class AddressNumber
   include Mongoid::Document
+
   field :country_code, type: Integer, default: 1
   field :number
   embedded_in :slave

data/spec/support/models/agency.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Agency
   include Mongoid::Document
   include Mongoid::Timestamps::Updated
+
   has_many :agents, validate: false
 end

data/spec/support/models/agent.rb

@@ -1,9 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Agent
   include Mongoid::Document
   include Mongoid::Timestamps::Updated
+
   field :title, type: String
   field :number, type: String
   field :dob, type: Time

data/spec/support/models/album.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Album
   include Mongoid::Document
@@ -12,7 +11,7 @@ class Album
   private
 
   def set_parent_name
-    artist.name = "destroyed" if artist
+    artist.name = 'destroyed' if artist
   end
 
   def set_parent_name_fail

data/spec/support/models/alert.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Alert
   include Mongoid::Document
+
   field :message, type: String
   belongs_to :account
   has_many :items

data/spec/support/models/animal.rb

@@ -1,10 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Animal
   include Mongoid::Document
 
-  field :_id, type: String, overwrite: true, default: ->{ name.try(:parameterize) }
+  field :_id, type: String, overwrite: true, default: -> { name.try(:parameterize) }
 
   field :name
   field :height, type: Integer
@@ -13,17 +12,17 @@ class Animal
 
   embedded_in :person
   embedded_in :circus, class_name: 'Circus' # class_name is necessary because ActiveRecord think the singular of Circus
-                                            # is Circu
+  # is Circu
 
   validates_format_of :name, without: /\$\$\$/
 
   accepts_nested_attributes_for :person
 
   def tag_list
-    tags.join(", ")
+    tags.join(', ')
   end
 
   def tag_list=(_tag_list)
-    self.tags = _tag_list.split(",").map(&:strip)
+    self.tags = _tag_list.split(',').map(&:strip)
   end
 end

data/spec/support/models/answer.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Answer
   include Mongoid::Document
+
   embedded_in :question
 
   field :position, type: Integer

data/spec/support/models/appointment.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Appointment
   include Mongoid::Document
+
   field :active, type: Mongoid::Boolean, default: true
   field :timed, type: Mongoid::Boolean, default: true
   embedded_in :person
-  default_scope ->{ where(active: true) }
+  default_scope -> { where(active: true) }
 end

data/spec/support/models/armrest.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Armrest
   include Mongoid::Document

data/spec/support/models/array_field.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class ArrayField
   include Mongoid::Document

data/spec/support/models/article.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Article
   include Mongoid::Document

data/spec/support/models/artist.rb

@@ -1,16 +1,20 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Artist
   include Mongoid::Document
 
-  attr_accessor :before_add_called, :after_add_called, :before_add_referenced_called, :after_add_referenced_called, :before_remove_embedded_called, :after_remove_embedded_called, :before_remove_referenced_called, :after_remove_referenced_called
+  attr_accessor :before_add_called, :after_add_called, :before_add_referenced_called, :after_add_referenced_called,
+                :before_remove_embedded_called, :after_remove_embedded_called, :before_remove_referenced_called, :after_remove_referenced_called
 
   field :name, type: String
 
-  embeds_many :songs, before_add: [ :before_add_song, Proc.new { |artist, song| song.before_add_called = true } ], before_remove: :before_remove_song
+  embeds_many :songs, before_add: [ :before_add_song, proc { |_artist, song|
+    song.before_add_called = true
+  } ], before_remove: :before_remove_song
   embeds_many :labels, after_add: :after_add_label, after_remove: :after_remove_label
-  has_many :albums, dependent: :destroy, before_add: [:before_add_album, Proc.new { |artist, album| album.before_add_called = true} ], after_add: :after_add_album, before_remove: :before_remove_album, after_remove: :after_remove_album
+  has_many :albums, dependent: :destroy, before_add: [ :before_add_album, proc { |_artist, album|
+    album.before_add_called = true
+  } ], after_add: :after_add_album, before_remove: :before_remove_album, after_remove: :after_remove_album
   belongs_to :band
 
   before_create :before_create_stub
@@ -57,35 +61,35 @@ class Artist
     2.times { |n| songs.create!(title: "#{n}") }
   end
 
-  def before_add_song(song)
+  def before_add_song(_song)
     @before_add_called = true
   end
 
-  def after_add_label(label)
+  def after_add_label(_label)
     @after_add_called = true
   end
 
-  def before_add_album(album)
+  def before_add_album(_album)
     @before_add_referenced_called = true
   end
 
-  def after_add_album(album)
+  def after_add_album(_album)
     @after_add_referenced_called = true
   end
 
-  def before_remove_song(song)
+  def before_remove_song(_song)
     @before_remove_embedded_called = true
   end
 
-  def after_remove_label(label)
+  def after_remove_label(_label)
     @after_remove_embedded_called = true
   end
 
-  def before_remove_album(album)
+  def before_remove_album(_album)
     @before_remove_referenced_called = true
   end
 
-  def after_remove_album(album)
+  def after_remove_album(_album)
     @after_remove_referenced_called = true
   end
 end

data/spec/support/models/artwork.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Artwork
   include Mongoid::Document
+
   has_and_belongs_to_many :exhibitors
 end

data/spec/support/models/audible_sound.rb

@@ -1,4 +1,3 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class AudibleSound < Sound; end

data/spec/support/models/audio.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Audio
   include Mongoid::Document
+
   field :likes, type: Integer
-  default_scope ->{ self.or({:likes => nil}, {:likes.gt => 100}) }
+  default_scope -> { self.or({ likes: nil }, { :likes.gt => 100 }) }
 end

data/spec/support/models/augmentation.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Augmentation
   include Mongoid::Document
@@ -14,7 +13,7 @@ class Augmentation
 
   field :after_find_player
   field :after_initialize_player
-  field :after_default_player, default: ->{ self.player&._id }
+  field :after_default_player, default: -> { player&._id }
 
   after_find do |doc|
     doc.after_find_player = player&._id

data/spec/support/models/author.rb

@@ -1,8 +1,8 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Author
   include Mongoid::Document
+
   field :id, type: Integer
   field :author, type: Mongoid::Boolean
   field :name, type: String

data/spec/support/models/baby.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Baby
   include Mongoid::Document
+
   embedded_in :kangaroo
 end

data/spec/support/models/band.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Band
   include Mongoid::Document

data/spec/support/models/bar.rb

@@ -1,13 +1,13 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Bar
   include Mongoid::Document
   include Mongoid::Attributes::Dynamic
+
   field :name, type: String
   field :location, type: Array
   field :lat_lng, type: LatLng
 
   has_one :rating, as: :ratable
-  index location: "2d"
+  index location: '2d'
 end

data/spec/support/models/basic.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Basic
   include Mongoid::Document

data/spec/support/models/bed.rb

@@ -1,4 +1,3 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Bed; end

data/spec/support/models/big_palette.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class BigPalette < Palette
 end

data/spec/support/models/birthday.rb

@@ -1,16 +1,14 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Birthday
   include Mongoid::Document
+
   field :title
   field :date, type: Date
   embedded_in :owner, inverse_of: :birthdays
 
-  def self.each_day(start_date, end_date)
+  def self.each_day(start_date, end_date, &block)
     groups = only(:date).asc(:date).where(:date.gte => start_date, :date.lte => end_date).group
-    groups.each do |date, group|
-      yield(date, group)
-    end
+    groups.each(&block)
   end
 end

data/spec/support/models/bolt.rb

@@ -1,5 +1,4 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Bolt
   include Mongoid::Document

data/spec/support/models/bomb.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Bomb
   include Mongoid::Document
+
   has_one :explosion, dependent: :delete_all, autobuild: true
 end

data/spec/support/models/book.rb

@@ -1,10 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 class Book
   include Mongoid::Document
   include Mongoid::Attributes::Dynamic
   include Mongoid::Timestamps
+
   field :title, type: String
   field :chapters, type: Integer
   belongs_to :series