mongoid 9.0.11 → 9.1.1

data/lib/mongoid/errors/invalid_field_operator.rb

@@ -1,17 +1,14 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Raised when invalid field-level operator is passed to an
     # embedded matcher.
     class InvalidFieldOperator < InvalidQuery
-
       # @api private
-      VALID_OPERATORS = %w(
+      VALID_OPERATORS = %w[
         all elemMatch eq exists gt gte in lt lte ne nin not regex size
-      ).freeze
+      ].freeze
 
       # Creates the exception.
       #
@@ -20,10 +17,9 @@ module Mongoid
       # @api private
       def initialize(operator)
         @operator = operator
-        super(compose_message("invalid_field_operator",
-          operator: operator,
-          valid_operators: VALID_OPERATORS.map { |op| "'$#{op}'" }.join(', '),
-        ))
+        super(compose_message('invalid_field_operator',
+                              operator: operator,
+                              valid_operators: VALID_OPERATORS.map { |op| "'$#{op}'" }.join(', ')))
       end
 
       # @return [ String ] The operator that was used.

data/lib/mongoid/errors/invalid_field_option.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when trying to create a field that has an invalid
     # option.
     class InvalidFieldOption < MongoidError
-
       # Create the new error.
       #
       # @example Create the error.
@@ -20,12 +17,12 @@ module Mongoid
       def initialize(klass, name, option, valid)
         super(
           compose_message(
-            "invalid_field_option",
+            'invalid_field_option',
             {
               name: name,
               klass: klass,
               option: option,
-              valid: valid.join(", ")
+              valid: valid.join(', ')
             }
           )
         )

data/lib/mongoid/errors/invalid_field_type.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when trying to define a field using a :type option value
     # that is not present in the field type mapping.
     class InvalidFieldType < MongoidError
-
       # Create the new error.
       #
       # @example Instantiate the error.
@@ -19,7 +16,7 @@ module Mongoid
       def initialize(klass, field, type)
         super(
           compose_message('invalid_field_type',
-            klass: klass, field: field, type_inspection: type.inspect)
+                          klass: klass, field: field, type_inspection: type.inspect)
         )
       end
     end

data/lib/mongoid/errors/invalid_find.rb

@@ -1,18 +1,15 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Raised when invalid arguments are passed to #find.
     class InvalidFind < MongoidError
-
       # Create the new invalid find error.
       #
       # @example Create the error.
       #   InvalidFind.new
       def initialize
-        super(compose_message("calling_document_find_with_nil_is_invalid", {}))
+        super(compose_message('calling_document_find_with_nil_is_invalid', {}))
       end
     end
   end

data/lib/mongoid/errors/invalid_global_executor_concurrency.rb

@@ -1,20 +1,17 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when a bad global executor concurrency option is attempted
     # to be set.
     class InvalidGlobalExecutorConcurrency < MongoidError
-
       # Create the new error.
       #
       # @api private
       def initialize
         super(
           compose_message(
-            "invalid_global_executor_concurrency"
+            'invalid_global_executor_concurrency'
           )
         )
       end

data/lib/mongoid/errors/invalid_includes.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when an invalid value is passed to an eager
     # loading query.
     class InvalidIncludes < MongoidError
-
       # Initialize the error.
       #
       # @example Initialize the error.
@@ -18,11 +15,11 @@ module Mongoid
       def initialize(klass, args)
         super(
           compose_message(
-            "invalid_includes",
+            'invalid_includes',
             {
               klass: klass.name,
-              args: args.map(&:inspect).join(", "),
-              relations: klass.relations.keys.map(&:inspect).join(", ")
+              args: args.map(&:inspect).join(', '),
+              relations: klass.relations.keys.map(&:inspect).join(', ')
             }
           )
         )

data/lib/mongoid/errors/invalid_index.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Raised when an invalid index is defined.
     class InvalidIndex < MongoidError
-
       # Create the new error.
       #
       # @example Create the error.
@@ -18,7 +15,7 @@ module Mongoid
       def initialize(klass, spec, options)
         super(
           compose_message(
-            "invalid_index",
+            'invalid_index',
             { klass: klass.name, spec: spec, options: options }
           )
         )

data/lib/mongoid/errors/invalid_options.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Raised when invalid options are passed to an association macro.
     class InvalidOptions < MongoidError
-
       # Instantiate the options error.
       #
       # @example Create the error.
@@ -18,7 +15,7 @@ module Mongoid
       def initialize(name, invalid, valid)
         super(
           compose_message(
-            "invalid_options",
+            'invalid_options',
             { name: name, invalid: invalid, valid: valid.join(', ') }
           )
         )

data/lib/mongoid/errors/invalid_path.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Used when attempting to get embedded paths with incorrect root path set.
     class InvalidPath < MongoidError
-
       # Create the new error.
       #
       # @example Create the error.
@@ -14,7 +11,7 @@ module Mongoid
       #
       # @param [ Class ] klass The document class.
       def initialize(klass)
-        super(compose_message("invalid_path", { klass: klass }))
+        super(compose_message('invalid_path', { klass: klass }))
       end
     end
   end

data/lib/mongoid/errors/invalid_persistence_option.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Raised when invalid options are used to create a persistence context.
     class InvalidPersistenceOption < MongoidError
-
       # Instantiate the persistence context option error.
       #
       # @example Create the error.
@@ -16,10 +13,10 @@ module Mongoid
       # @param [ Array<Symbol> ] valid The allowed options.
       def initialize(invalid, valid)
         super(
-            compose_message(
-                "invalid_persistence_option",
-                { invalid: invalid, valid: valid }
-            )
+          compose_message(
+            'invalid_persistence_option',
+            { invalid: invalid, valid: valid }
+          )
         )
       end
     end

data/lib/mongoid/errors/invalid_query.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Raised when invalid query is passed to an embedded matcher, or an
     # invalid query fragment is passed to the query builder (Criteria object).
     class InvalidQuery < MongoidError
-
       # Create the new invalid query error.
       #
       # @api private
@@ -22,16 +19,14 @@ module Mongoid
       #
       # @api private
       def self.truncate_expr(expr)
-        unless expr.is_a?(String)
-          expr = expr.inspect
-        end
+        expr = expr.inspect unless expr.is_a?(String)
 
         if expr.length > 103
-          expr = if expr =~ /\A<#((?:.|\n)*)>\z/
-            "<##{expr.slice(0, 97)}...>"
-          else
-            expr.slice(0, 100) + '...'
-          end
+          expr = if /\A<#((?:.|\n)*)>\z/.match?(expr)
+                   "<##{expr.slice(0, 97)}...>"
+                 else
+                   expr.slice(0, 100) + '...'
+                 end
         end
 
         expr

data/lib/mongoid/errors/invalid_relation.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when trying to create an association that conflicts with
     # an already defined method.
     class InvalidRelation < MongoidError
-
       # Create the new error.
       #
       # @example Create the error.
@@ -17,15 +14,15 @@ module Mongoid
       # @param [ Symbol ] name The method name.
       def initialize(klass, name)
         super(
-            compose_message(
-                "invalid_relation",
-                {
-                    name: name,
-                    origin: origin(klass, name),
-                    file: location(klass, name)[0],
-                    line: location(klass, name)[1]
-                }
-            )
+          compose_message(
+            'invalid_relation',
+            {
+              name: name,
+              origin: origin(klass, name),
+              file: location(klass, name)[0],
+              line: location(klass, name)[1]
+            }
+          )
         )
       end
 
@@ -55,7 +52,7 @@ module Mongoid
       # @return [ Array<String, Integer> ] The location of the method.
       def location(klass, name)
         @location ||=
-            (klass.instance_method(name).source_location || [ "Unknown", 0 ])
+          klass.instance_method(name).source_location || [ 'Unknown', 0 ]
       end
     end
   end

data/lib/mongoid/errors/invalid_relation_option.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Raised when an option provided for an association is invalid.
     class InvalidRelationOption < MongoidError
-
       # Create the new error.
       #
       # @example Create the new error.
@@ -18,10 +15,10 @@ module Mongoid
       # @param [ Array<Symbol> ] valid_options The valid option.
       def initialize(klass, name, option, valid_options)
         super(
-            compose_message(
-                "invalid_relation_option",
-                { klass: klass, name: name, option: option, valid_options: valid_options }
-            )
+          compose_message(
+            'invalid_relation_option',
+            { klass: klass, name: name, option: option, valid_options: valid_options }
+          )
         )
       end
     end

data/lib/mongoid/errors/invalid_scope.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when defining a scope of an invalid type.
     class InvalidScope < MongoidError
-
       # Create the error.
       #
       # @example Create the error.
@@ -16,7 +13,7 @@ module Mongoid
       # @param [ Object ] value The attempted scope value.
       def initialize(klass, value)
         super(
-          compose_message("invalid_scope", { klass: klass, value: value })
+          compose_message('invalid_scope', { klass: klass, value: value })
         )
       end
     end

data/lib/mongoid/errors/invalid_session_nesting.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when a session is attempted to be used with a model whose client already
     # has an opened session.
     class InvalidSessionNesting < MongoidError
-
       # Create the error.
       def initialize
         super(compose_message('invalid_session_nesting'))

data/lib/mongoid/errors/invalid_set_polymorphic_relation.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Raised when trying to set a polymorphic "references in" association to a
     # model with multiple "references many/one" associations pointing to that
     # first model.
@@ -26,13 +24,13 @@ module Mongoid
     #   face = Face.new
     #   eye.eyeable = face # Raises error
     class InvalidSetPolymorphicRelation < MongoidError
-
       # Create the new invalid set polymorphic association error.
       #
       # @example Create the error.
       #   InvalidSetPolymorphicRelation.new
       def initialize(name, klass, other_klass)
-        super(compose_message("invalid_set_polymorphic_relation", { name: name, klass: klass, other_klass: other_klass }))
+        super(compose_message('invalid_set_polymorphic_relation',
+                              { name: name, klass: klass, other_klass: other_klass }))
       end
     end
   end

data/lib/mongoid/errors/invalid_storage_options.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Raised when options provided to :store_in are invalid.
     class InvalidStorageOptions < MongoidError
-
       # Create the new error.
       #
       # @example Create the new error.
@@ -17,7 +14,7 @@ module Mongoid
       def initialize(klass, options)
         super(
           compose_message(
-            "invalid_storage_options",
+            'invalid_storage_options',
             { klass: klass, options: options }
           )
         )

data/lib/mongoid/errors/invalid_time.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This exception is raised when a bad value is attempted to be converted to
     # a date or time.
     class InvalidTime < MongoidError
-
       # Create the new invalid date error.
       #
       # @example Create the new invalid date error.
@@ -15,7 +12,7 @@ module Mongoid
       #
       # @param [ Object ] value The value that was attempted.
       def initialize(value)
-        super(compose_message("invalid_time", { value: value }))
+        super(compose_message('invalid_time', { value: value }))
       end
     end
   end

data/lib/mongoid/errors/invalid_transaction_nesting.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when a transaction is attempted to be used with a model whose client already
     # has an opened transaction.
     class InvalidTransactionNesting < MongoidError
-
       # Create the error.
       def initialize
         super(compose_message('invalid_transaction_nesting'))

data/lib/mongoid/errors/inverse_not_found.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Raised when no inverse_of definition can be found when needed.
     class InverseNotFound < MongoidError
-
       # Create then new error.
       #
       # @example Create the new error.
@@ -19,7 +16,7 @@ module Mongoid
       def initialize(base, name, klass, inverse)
         super(
           compose_message(
-            "inverse_not_found",
+            'inverse_not_found',
             { base: base, name: name, klass: klass, inverse: inverse }
           )
         )

data/lib/mongoid/errors/mixed_client_configuration.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when a client configuration contains both a uri and
     # other standard options.
     class MixedClientConfiguration < MongoidError
-
       # Initialize the error.
       #
       # @example Initialize the error.
@@ -18,8 +15,8 @@ module Mongoid
       def initialize(name, config)
         super(
           compose_message(
-            "mixed_client_configuration",
-            { name: name, config: config }
+            'mixed_client_configuration',
+            { name: name, config: ConfigRedactor.redact(config) }
           )
         )
       end

data/lib/mongoid/errors/mixed_relations.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when trying to reference an embedded document from
     # a document in another collection that is not its parent.
     #
@@ -22,7 +20,7 @@ module Mongoid
       def initialize(root_klass, embedded_klass)
         super(
           compose_message(
-            "mixed_relations",
+            'mixed_relations',
             { root: root_klass, embedded: embedded_klass }
           )
         )

data/lib/mongoid/errors/mongoid_error.rb

@@ -1,17 +1,14 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # Default parent Mongoid error for all custom errors. This handles the base
     # key for the translations and provides the convenience method for
     # translating the messages.
     class MongoidError < StandardError
-
       attr_reader :problem, :summary, :resolution
 
-      BASE_KEY = "mongoid.errors.messages"
+      BASE_KEY = 'mongoid.errors.messages'
 
       # Compose the message.
       #
@@ -23,14 +20,13 @@ module Mongoid
         @problem = translate_problem(key, attributes)
         @summary = translate_summary(key, attributes)
         @resolution = translate_resolution(key, attributes)
-        @problem_title = translate("message_title", {})
-        @summary_title = translate("summary_title", {})
-        @resolution_title = translate("resolution_title", {})
-
+        @problem_title = translate('message_title', {})
+        @summary_title = translate('summary_title', {})
+        @resolution_title = translate('resolution_title', {})
 
-        "\n#{@problem_title}:\n  #{@problem&.strip}"+
-        "\n#{@summary_title}:\n  #{@summary&.strip}"+
-        "\n#{@resolution_title}:\n  #{@resolution&.strip}"
+        "\n#{@problem_title}:\n  #{@problem&.strip}" +
+          "\n#{@summary_title}:\n  #{@summary&.strip}" +
+          "\n#{@resolution_title}:\n  #{@resolution&.strip}"
       end
 
       private

data/lib/mongoid/errors/nested_attributes_metadata_not_found.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when metadata could not be found when defining
     # nested attributes, or the name was incorrect.
     class NestedAttributesMetadataNotFound < MongoidError
-
       # Create the new metadata error.
       #
       # @example Create the new metadata error.
@@ -18,7 +15,7 @@ module Mongoid
       def initialize(klass, name)
         super(
           compose_message(
-            "nested_attributes_metadata_not_found",
+            'nested_attributes_metadata_not_found',
             { klass: klass, name: name }
           )
         )

data/lib/mongoid/errors/no_client_config.rb

@@ -1,13 +1,10 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when attempting to create a new client that does
     # not have a named configuration.
     class NoClientConfig < MongoidError
-
       # Create the new error.
       #
       # @example Create the error.
@@ -15,7 +12,7 @@ module Mongoid
       #
       # @param [ String | Symbol ] name The name of the client.
       def initialize(name)
-        super(compose_message("no_client_config", { name: name }))
+        super(compose_message('no_client_config', { name: name }))
       end
     end
   end

data/lib/mongoid/errors/no_client_database.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Errors
-
     # This error is raised when a client is configured without a database.
     class NoClientDatabase < MongoidError
-
       # Create the new error.
       #
       # @example Create the new error.
@@ -17,8 +14,8 @@ module Mongoid
       def initialize(name, config)
         super(
           compose_message(
-            "no_client_database",
-            { name: name, config: config }
+            'no_client_database',
+            { name: name, config: ConfigRedactor.redact(config) }
           )
         )
       end