mongoid 9.0.11 → 9.1.1

data/spec/mongoid/errors/validations_spec.rb

@@ -1,14 +1,11 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Errors::Validations do
-
-  describe "#message" do
-
+  describe '#message' do
     let(:errors) do
-      double(full_messages: [ "Error 1", "Error 2" ], empty?: false)
+      double(full_messages: [ 'Error 1', 'Error 2' ], empty?: false)
     end
 
     let(:document) do
@@ -19,29 +16,29 @@ describe Mongoid::Errors::Validations do
       described_class.new(document)
     end
 
-    it "contains the problem in the message" do
+    it 'contains the problem in the message' do
       expect(error.message).to include(
-        "Validation of Person failed"
+        'Validation of Person failed'
       )
     end
 
-    it "contains the summary in the message" do
+    it 'contains the summary in the message' do
       expect(error.message).to include(
-        "The following errors were found: Error 1, Error 2"
+        'The following errors were found: Error 1, Error 2'
       )
     end
 
-    it "contains the resolution in the message" do
+    it 'contains the resolution in the message' do
       expect(error.message).to include(
-        "Try persisting the document with valid data"
+        'Try persisting the document with valid data'
       )
     end
 
-    it "sets the document in the error" do
+    it 'sets the document in the error' do
       expect(error.document).to eq(document)
     end
 
-    it "aliases record to document" do
+    it 'aliases record to document' do
       expect(error.record).to eq(document)
     end
   end

data/spec/mongoid/extensions/array_spec.rb

@@ -1,20 +1,16 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "spec_helper"
+require 'spec_helper'
 
 describe Mongoid::Extensions::Array do
-
-  describe "#__evolve_object_id__" do
-
-    context "when provided an array of strings" do
-
+  describe '#__evolve_object_id__' do
+    context 'when provided an array of strings' do
       let(:object_id) do
         BSON::ObjectId.new
       end
 
       let(:other) do
-        "blah"
+        'blah'
       end
 
       let(:array) do
@@ -25,17 +21,16 @@ describe Mongoid::Extensions::Array do
         array.__evolve_object_id__
       end
 
-      it "converts the convertible ones to object ids" do
+      it 'converts the convertible ones to object ids' do
         expect(evolved).to eq([ object_id, other ])
       end
 
-      it "returns the same instance" do
+      it 'returns the same instance' do
         expect(evolved).to equal(array)
       end
     end
 
-    context "when provided an array of object ids" do
-
+    context 'when provided an array of object ids' do
       let(:object_id) do
         BSON::ObjectId.new
       end
@@ -48,17 +43,16 @@ describe Mongoid::Extensions::Array do
         array.__evolve_object_id__
       end
 
-      it "returns the array" do
+      it 'returns the array' do
         expect(evolved).to eq(array)
       end
 
-      it "returns the same instance" do
+      it 'returns the same instance' do
         expect(evolved).to equal(array)
       end
     end
 
-    context "when some values are nil" do
-
+    context 'when some values are nil' do
       let(:object_id) do
         BSON::ObjectId.new
       end
@@ -71,49 +65,46 @@ describe Mongoid::Extensions::Array do
         array.__evolve_object_id__
       end
 
-      it "returns the array with the nils" do
+      it 'returns the array with the nils' do
         expect(evolved).to eq([ object_id, nil ])
       end
 
-      it "returns the same instance" do
+      it 'returns the same instance' do
         expect(evolved).to equal(array)
       end
     end
 
-    context "when some values are empty strings" do
-
+    context 'when some values are empty strings' do
       let(:object_id) do
         BSON::ObjectId.new
       end
 
       let(:array) do
-        [ object_id, "" ]
+        [ object_id, '' ]
       end
 
       let(:evolved) do
         array.__evolve_object_id__
       end
 
-      it "returns the array with the empty strings" do
-        expect(evolved).to eq([ object_id, "" ])
+      it 'returns the array with the empty strings' do
+        expect(evolved).to eq([ object_id, '' ])
       end
 
-      it "returns the same instance" do
+      it 'returns the same instance' do
         expect(evolved).to equal(array)
       end
     end
   end
 
-  describe "#__mongoize_object_id__" do
-
-    context "when provided an array of strings" do
-
+  describe '#__mongoize_object_id__' do
+    context 'when provided an array of strings' do
       let(:object_id) do
         BSON::ObjectId.new
       end
 
       let(:other) do
-        "blah"
+        'blah'
       end
 
       let(:array) do
@@ -124,17 +115,16 @@ describe Mongoid::Extensions::Array do
         array.__mongoize_object_id__
       end
 
-      it "converts the convertible ones to object ids" do
+      it 'converts the convertible ones to object ids' do
         expect(mongoized).to eq([ object_id, other ])
       end
 
-      it "returns the same instance" do
+      it 'returns the same instance' do
         expect(mongoized).to equal(array)
       end
     end
 
-    context "when provided an array of object ids" do
-
+    context 'when provided an array of object ids' do
       let(:object_id) do
         BSON::ObjectId.new
       end
@@ -147,17 +137,16 @@ describe Mongoid::Extensions::Array do
         array.__mongoize_object_id__
       end
 
-      it "returns the array" do
+      it 'returns the array' do
         expect(mongoized).to eq(array)
       end
 
-      it "returns the same instance" do
+      it 'returns the same instance' do
         expect(mongoized).to equal(array)
       end
     end
 
-    context "when some values are nil" do
-
+    context 'when some values are nil' do
       let(:object_id) do
         BSON::ObjectId.new
       end
@@ -170,57 +159,55 @@ describe Mongoid::Extensions::Array do
         array.__mongoize_object_id__
       end
 
-      it "returns the array without the nils" do
+      it 'returns the array without the nils' do
         expect(mongoized).to eq([ object_id ])
       end
 
-      it "returns the same instance" do
+      it 'returns the same instance' do
         expect(mongoized).to equal(array)
       end
     end
 
-    context "when some values are empty strings" do
-
+    context 'when some values are empty strings' do
       let(:object_id) do
         BSON::ObjectId.new
       end
 
       let(:array) do
-        [ object_id, "" ]
+        [ object_id, '' ]
       end
 
       let(:mongoized) do
         array.__mongoize_object_id__
       end
 
-      it "returns the array without the empty strings" do
+      it 'returns the array without the empty strings' do
         expect(mongoized).to eq([ object_id ])
       end
 
-      it "returns the same instance" do
+      it 'returns the same instance' do
         expect(mongoized).to equal(array)
       end
     end
   end
 
-  describe "#__mongoize_time__" do
-
+  describe '#__mongoize_time__' do
     let(:array) do
-      [ 2010, 11, 19, 00, 24, 49.123457 ]
+      [ 2010, 11, 19, 0o0, 24, 49.123457 ]
     end
 
     let(:mongoized) do
       array.__mongoize_time__
     end
 
-    context "when setting ActiveSupport time zone" do
+    context 'when setting ActiveSupport time zone' do
       include_context 'setting ActiveSupport time zone'
 
       # In AS time zone (could be different from Ruby time zone)
-      let(:expected_time) { ::Time.zone.local(*array).in_time_zone }
+      let(:expected_time) { Time.zone.local(*array).in_time_zone }
 
-      it "converts to the as time zone" do
-        expect(mongoized.zone).to eq("JST")
+      it 'converts to the as time zone' do
+        expect(mongoized.zone).to eq('JST')
       end
 
       it_behaves_like 'mongoizes to AS::TimeWithZone'
@@ -228,75 +215,69 @@ describe Mongoid::Extensions::Array do
     end
   end
 
-  describe "#delete_one" do
-
+  describe '#delete_one' do
     context "when the object doesn't exist" do
-
       let(:array) do
         []
       end
 
       let!(:deleted) do
-        array.delete_one("1")
+        array.delete_one('1')
       end
 
-      it "returns nil" do
+      it 'returns nil' do
         expect(deleted).to be_nil
       end
     end
 
-    context "when the object exists once" do
-
+    context 'when the object exists once' do
       let(:array) do
-        [ "1", "2" ]
+        %w[1 2]
       end
 
       let!(:deleted) do
-        array.delete_one("1")
+        array.delete_one('1')
       end
 
-      it "deletes the object" do
-        expect(array).to eq([ "2" ])
+      it 'deletes the object' do
+        expect(array).to eq([ '2' ])
       end
 
-      it "returns the object" do
-        expect(deleted).to eq("1")
+      it 'returns the object' do
+        expect(deleted).to eq('1')
       end
     end
 
-    context "when the object exists more than once" do
-
+    context 'when the object exists more than once' do
       let(:array) do
-        [ "1", "2", "1" ]
+        %w[1 2 1]
       end
 
       let!(:deleted) do
-        array.delete_one("1")
+        array.delete_one('1')
       end
 
-      it "deletes the first object" do
-        expect(array).to eq([ "2", "1" ])
+      it 'deletes the first object' do
+        expect(array).to eq(%w[2 1])
       end
 
-      it "returns the object" do
-        expect(deleted).to eq("1")
+      it 'returns the object' do
+        expect(deleted).to eq('1')
       end
     end
   end
 
-  describe ".demongoize" do
-
+  describe '.demongoize' do
     let(:array) do
       [ 1, 2, 3 ]
     end
 
-    it "returns the array" do
+    it 'returns the array' do
       expect(Array.demongoize(array)).to eq(array)
     end
   end
 
-  describe ".mongoize" do
-
+  describe '.mongoize' do
     let(:date) do
       Date.new(2012, 1, 1)
     end
@@ -309,31 +290,30 @@ describe Mongoid::Extensions::Array do
       Array.mongoize(input)
     end
 
-    it "mongoizes each element in the array" do
+    it 'mongoizes each element in the array' do
       expect(mongoized.first).to be_a(Time)
     end
 
-    it "converts the elements properly" do
+    it 'converts the elements properly' do
       expect(mongoized.first).to eq(Time.utc(2012, 1, 1, 0, 0, 0))
     end
 
-    context "when passing in a set" do
+    context 'when passing in a set' do
       let(:input) do
         [ date ].to_set
       end
 
-      it "mongoizes to an array" do
+      it 'mongoizes to an array' do
         expect(mongoized).to be_a(Array)
       end
 
-      it "converts the elements properly" do
+      it 'converts the elements properly' do
         expect(mongoized.first).to eq(Time.utc(2012, 1, 1, 0, 0, 0))
       end
     end
   end
 
-  describe "#mongoize" do
-
+  describe '#mongoize' do
     let(:date) do
       Date.new(2012, 1, 1)
     end
@@ -346,25 +326,23 @@ describe Mongoid::Extensions::Array do
       array.mongoize
     end
 
-    it "mongoizes each element in the array" do
+    it 'mongoizes each element in the array' do
       expect(mongoized.first).to be_a(Time)
     end
 
-    it "converts the elements properly" do
+    it 'converts the elements properly' do
       expect(mongoized.first).to eq(Time.utc(2012, 1, 1, 0, 0, 0))
     end
   end
 
-  describe ".resizable?" do
-
-    it "returns true" do
+  describe '.resizable?' do
+    it 'returns true' do
       expect(Array).to be_resizable
     end
   end
 
-  describe "#resiable?" do
-
-    it "returns true" do
+  describe '#resiable?' do
+    it 'returns true' do
       expect([]).to be_resizable
     end
   end