mongoid 9.0.11 → 9.1.1

data/lib/mongoid/contextual/memory.rb

@@ -1,12 +1,11 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "mongoid/contextual/aggregable/memory"
-require "mongoid/association/eager_loadable"
+require 'mongoid/contextual/aggregable/memory'
+require 'mongoid/association/eager_loadable'
+require 'mongoid/field_readable'
 
 module Mongoid
   module Contextual
-
     # Context object used for performing bulk query and persistence
     # operations on documents which have been loaded into application
     # memory. The method interface of this class is consistent with
@@ -17,6 +16,7 @@ module Mongoid
       include Association::EagerLoadable
       include Queryable
       include Positional
+      include FieldReadable
 
       # @attribute [r] root The root document.
       # @attribute [r] path The atomic path.
@@ -34,6 +34,7 @@ module Mongoid
       # @return [ true | false ] If the objects are equal.
       def ==(other)
         return false unless other.respond_to?(:entries)
+
         entries == other.entries
       end
 
@@ -51,13 +52,13 @@ module Mongoid
         end
         unless removed.empty?
           collection.find(selector).update_one(
-            positionally(selector, "$pullAll" => { path => removed }),
+            positionally(selector, '$pullAll' => { path => removed }),
             session: _session
           )
         end
         deleted
       end
-      alias :delete_all :delete
+      alias delete_all delete
 
       # Destroy all documents in the database that match the selector.
       #
@@ -73,7 +74,7 @@ module Mongoid
         end
         deleted
       end
-      alias :destroy_all :destroy
+      alias destroy_all destroy
 
       # Get the distinct values in the db for the provided field.
       #
@@ -96,11 +97,9 @@ module Mongoid
       #   end
       #
       # @return [ Enumerator ] The enumerator.
-      def each
+      def each(&block)
         if block_given?
-          documents_for_iteration.each do |doc|
-            yield(doc)
-          end
+          documents_for_iteration.each(&block)
           self
         else
           to_enum
@@ -141,14 +140,19 @@ module Mongoid
       #
       # @return [ Document ] The first document.
       def first(limit = nil)
-        if limit
-          eager_load(documents.first(limit))
+        use_first = limit.nil?
+        limit ||= 1
+        if criteria.use_lookup?
+          @criteria = criteria.limit(limit)
+          result = eager_load_with_lookup
         else
-          eager_load([documents.first]).first
+          result = eager_load(documents.first(limit))
         end
+
+        use_first ? result.first : result
       end
-      alias :one :first
-      alias :find_first :first
+      alias one first
+      alias find_first first
 
       # Get the first document in the database for the criteria's selector or
       # raise an error if none is found.
@@ -172,10 +176,20 @@ module Mongoid
       # @param [ Criteria ] criteria The criteria.
       def initialize(criteria)
         @criteria, @klass = criteria, criteria.klass
-        @documents = criteria.documents.select do |doc|
-          @root ||= doc._root
-          @collection ||= root.collection
-          doc._matches?(criteria.selector)
+
+        # Resolving the collection can build a Mongo::Client the first time it
+        # runs, so it happens before the budget opens. Where the budget is
+        # enforced with Timeout the exception is asynchronous, and landing in
+        # the middle of that would leave a half-built client behind.
+        if (first = criteria.documents.first)
+          @root = first._root
+          @collection = @root.collection
+        end
+
+        # One regexp budget covers the whole scan, so that the limit bounds the
+        # query rather than each document individually.
+        @documents = Matcher::RegexpBudget.open(criteria.selector) do
+          criteria.documents.select { |doc| doc._matches?(criteria.selector) }
         end
         apply_sorting
         apply_options
@@ -207,7 +221,7 @@ module Mongoid
         if limit
           eager_load(documents.last(limit))
         else
-          eager_load([documents.last]).first
+          eager_load([ documents.last ]).first
         end
       end
 
@@ -234,7 +248,7 @@ module Mongoid
       def length
         documents.length
       end
-      alias :size :length
+      alias size length
 
       # Limits the number of documents that are returned.
       #
@@ -272,9 +286,9 @@ module Mongoid
       #
       # @return [ Object | Array<Object> ] The picked values.
       def pick(*fields)
-        if doc = documents.first
-          pluck_from_doc(doc, *fields)
-        end
+        return unless doc = documents.first
+
+        pluck_from_doc(doc, *fields)
       end
 
       # Tally the field values in memory.
@@ -286,7 +300,7 @@ module Mongoid
       #
       # @return [ Hash ] The hash of counts.
       def tally(field)
-        return documents.each_with_object({}) do |d, acc|
+        documents.each_with_object({}) do |d, acc|
           v = retrieve_value_at_path(d, field)
           acc[v] ||= 0
           acc[v] += 1
@@ -305,7 +319,7 @@ module Mongoid
         if limit
           eager_load(documents.take(limit))
         else
-          eager_load([documents.first]).first
+          eager_load([ documents.first ]).first
         end
       end
 
@@ -380,7 +394,7 @@ module Mongoid
       #
       # @return [ Document ] The second document.
       def second
-        eager_load([documents.second]).first
+        eager_load([ documents.second ]).first
       end
 
       # Get the second document in the database for the criteria's selector or
@@ -404,7 +418,7 @@ module Mongoid
       #
       # @return [ Document ] The third document.
       def third
-        eager_load([documents.third]).first
+        eager_load([ documents.third ]).first
       end
 
       # Get the third document in the database for the criteria's selector or
@@ -428,7 +442,7 @@ module Mongoid
       #
       # @return [ Document ] The fourth document.
       def fourth
-        eager_load([documents.fourth]).first
+        eager_load([ documents.fourth ]).first
       end
 
       # Get the fourth document in the database for the criteria's selector or
@@ -452,7 +466,7 @@ module Mongoid
       #
       # @return [ Document ] The fifth document.
       def fifth
-        eager_load([documents.fifth]).first
+        eager_load([ documents.fifth ]).first
       end
 
       # Get the fifth document in the database for the criteria's selector or
@@ -476,7 +490,7 @@ module Mongoid
       #
       # @return [ Document ] The second to last document.
       def second_to_last
-        eager_load([documents.second_to_last]).first
+        eager_load([ documents.second_to_last ]).first
       end
 
       # Get the second to last document in the database for the criteria's selector or
@@ -500,7 +514,7 @@ module Mongoid
       #
       # @return [ Document ] The third to last document.
       def third_to_last
-        eager_load([documents.third_to_last]).first
+        eager_load([ documents.third_to_last ]).first
       end
 
       # Get the third to last document in the database for the criteria's selector or
@@ -519,6 +533,14 @@ module Mongoid
 
       private
 
+      # Returns materialized documents for use in the cross-cluster $lookup
+      # fallback. In the memory context, documents are already instantiated.
+      #
+      # @api private
+      def docs_for_lookup_fallback
+        documents
+      end
+
       # Get the documents the context should iterate. This follows 3 rules:
       #
       # @api private
@@ -530,7 +552,7 @@ module Mongoid
       def documents_for_iteration
         docs = documents[skipping || 0, limiting || documents.length] || []
         if eager_loadable?
-          eager_load(docs)
+          criteria.use_lookup? ? eager_load_with_lookup : eager_load(docs)
         end
         docs
       end
@@ -546,14 +568,15 @@ module Mongoid
       # @param [ Array<Document> ] docs The docs to update.
       def update_documents(attributes, docs)
         return false if !attributes || docs.empty?
-        updates = { "$set" => {}}
+
+        updates = { '$set' => {} }
         docs.each do |doc|
           @selector ||= root.atomic_selector
           doc.write_attributes(attributes)
-          updates["$set"].merge!(doc.atomic_updates["$set"] || {})
+          updates['$set'].merge!(doc.atomic_updates['$set'] || {})
           doc.move_changes
         end
-        collection.find(selector).update_one(updates, session: _session) unless updates["$set"].empty?
+        collection.find(selector).update_one(updates, session: _session) unless updates['$set'].empty?
       end
 
       # Get the limiting value.
@@ -576,9 +599,7 @@ module Mongoid
       # @param [ Integer ] value The limit.
       #
       # @return [ Integer ] The limit.
-      def limiting=(value)
-        @limiting = value
-      end
+      attr_writer :limiting
 
       # Get the skipping value.
       #
@@ -600,9 +621,7 @@ module Mongoid
       # @param [ Integer ] value The skip.
       #
       # @return [ Integer ] The skip.
-      def skipping=(value)
-        @skipping = value
-      end
+      attr_writer :skipping
 
       # Apply criteria options.
       #
@@ -614,6 +633,7 @@ module Mongoid
       # @return [ Memory ] self.
       def apply_options
         raise Errors::InMemoryCollationNotSupported.new if criteria.options[:collation]
+
         skip(criteria.options[:skip]).limit(criteria.options[:limit])
       end
 
@@ -622,9 +642,9 @@ module Mongoid
       # @example Apply the sorting params.
       #   context.apply_sorting
       def apply_sorting
-        if spec = criteria.options[:sort]
-          in_place_sort(spec)
-        end
+        return unless spec = criteria.options[:sort]
+
+        in_place_sort(spec)
       end
 
       # Compare two values, handling the cases when
@@ -677,8 +697,6 @@ module Mongoid
         doc.destroyed = true
       end
 
-      private
-
       def _session
         @criteria.send(:_session)
       end
@@ -722,30 +740,30 @@ module Mongoid
       #   doesn't exist.
       def retrieve_value_at_path(document, field_path)
         return if field_path.blank? || !document
+
         segment, remaining = field_path.to_s.split('.', 2)
 
         curr = if document.is_a?(Document)
-          # Retrieves field for segment to check localization. Only does one
-          # iteration since there's no dots
-          res = if remaining
-            field = document.class.traverse_association_tree(segment)
-            # If this is a localized field, and there are remaining, get the
-            # _translations hash so that we can get the specified translation in
-            # the remaining
-            if field&.localized?
-              document.send("#{segment}_translations")
-            end
-          end
-          meth = klass.aliased_associations[segment] || segment
-          res.nil? ? document.try(meth) : res
-        elsif document.is_a?(Hash)
-          # TODO: Remove the indifferent access when implementing MONGOID-5410.
-          document.key?(segment.to_s) ?
-            document[segment.to_s] :
-            document[segment.to_sym]
-        else
-          nil
-        end
+                 # Retrieves field for segment to check localization. Only does one
+                 # iteration since there's no dots
+                 res = if remaining
+                         field = document.class.traverse_association_tree(segment)
+                         # If this is a localized field, and there are remaining, get the
+                         # _translations hash so that we can get the specified translation in
+                         # the remaining
+                         document.public_send("#{segment}_translations") if field&.localized?
+                       end
+                 res.nil? ? read_field_value(document, segment) : res
+               elsif document.is_a?(Hash)
+                 # TODO: Remove the indifferent access when implementing MONGOID-5410.
+                 if document.key?(segment.to_s)
+                   document[segment.to_s]
+                 else
+                   document[segment.to_sym]
+                 end
+               else
+                 nil
+               end
 
         return curr unless remaining
 

data/lib/mongoid/contextual/mongo/documents_loader.rb

@@ -1,5 +1,4 @@
-# rubocop:todo all
-require "mongoid/association/eager_loadable"
+require 'mongoid/association/eager_loadable'
 
 module Mongoid
   module Contextual
@@ -30,7 +29,7 @@ module Mongoid
         # @return [ Concurrent::ThreadPoolExecutor ] The executor
         #   to be used to execute document loading tasks.
         def self.global_thread_pool_async_query_executor
-          create_pool = Proc.new do |concurrency|
+          create_pool = proc do |concurrency|
             Concurrent::ThreadPoolExecutor.new(
               min_threads: 0,
               max_threads: concurrency,