mongoid 9.0.11 → 9.1.1

data/lib/mongoid/contextual/aggregable/mongo.rb

@@ -1,14 +1,12 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "mongoid/contextual/aggregable"
+require 'mongoid/contextual/aggregable'
 
 module Mongoid
   module Contextual
     module Aggregable
       # Contains behavior for aggregating values in Mongo.
       module Mongo
-
         # Get all the aggregate values for the provided field.
         #
         # @example Get all the aggregate values.
@@ -28,10 +26,10 @@ module Mongoid
         #   count, sum of 0 and max, min, avg of nil.
         def aggregates(field)
           result = collection.aggregate(
-                    pipeline(field),
-                    session: _session,
-                    hint: view.hint
-                  ).to_a
+            pipeline(field),
+            session: _session,
+            hint: view.hint
+          ).to_a
 
           if result.empty?
             Aggregable::EMPTY_RESULT.dup
@@ -49,7 +47,7 @@ module Mongoid
         #
         # @return [ Float ] The average.
         def avg(field)
-          aggregates(field)["avg"]
+          aggregates(field)['avg']
         end
 
         # Get the max value of the provided field. If provided a block, will
@@ -69,7 +67,7 @@ module Mongoid
         # @return [ Float | Document ] The max value or document with the max
         #   value.
         def max(field = nil)
-          block_given? ? super() : aggregates(field)["max"]
+          block_given? ? super() : aggregates(field)['max']
         end
 
         # Get the min value of the provided field. If provided a block, will
@@ -89,7 +87,7 @@ module Mongoid
         # @return [ Float | Document ] The min value or document with the min
         #   value.
         def min(field = nil)
-          block_given? ? super() : aggregates(field)["min"]
+          block_given? ? super() : aggregates(field)['min']
         end
 
         # Get the sum value of the provided field. If provided a block, will
@@ -108,7 +106,7 @@ module Mongoid
         def sum(field = nil)
           return super(field || 0) if block_given?
 
-          aggregates(field)["sum"] || 0
+          aggregates(field)['sum'] || 0
         end
 
         private
@@ -128,18 +126,18 @@ module Mongoid
           sort, skip, limit = criteria.options.values_at(:sort, :skip, :limit)
 
           pipeline = []
-          pipeline << { "$match" =>  criteria.exists(field => true).selector }
-          pipeline << { "$sort" => sort } if sort && (skip || limit)
-          pipeline << { "$skip" => skip } if skip
-          pipeline << { "$limit" => limit } if limit
+          pipeline << { '$match' => criteria.exists(field => true).selector }
+          pipeline << { '$sort' => sort } if sort && (skip || limit)
+          pipeline << { '$skip' => skip } if skip
+          pipeline << { '$limit' => limit } if limit
           pipeline << {
-            "$group"  => {
-              "_id"   => field.to_s,
-              "count" => { "$sum" => 1 },
-              "max"   => { "$max" => db_field },
-              "min"   => { "$min" => db_field },
-              "sum"   => { "$sum" => db_field },
-              "avg"   => { "$avg" => db_field }
+            '$group' => {
+              '_id' => field.to_s,
+              'count' => { '$sum' => 1 },
+              'max' => { '$max' => db_field },
+              'min' => { '$min' => db_field },
+              'sum' => { '$sum' => db_field },
+              'avg' => { '$avg' => db_field }
             }
           }
         end

data/lib/mongoid/contextual/aggregable/none.rb

@@ -1,14 +1,12 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
-require "mongoid/contextual/aggregable"
+require 'mongoid/contextual/aggregable'
 
 module Mongoid
   module Contextual
     module Aggregable
       # Contains behavior for aggregating values in null context.
       module None
-
         # Get all the aggregate values for the provided field in null context.
         # Provided for interface consistency with Aggregable::Mongo.
         #
@@ -59,7 +57,7 @@ module Mongoid
         # @param [ Symbol ] _field The field to max.
         #
         # @return [ nil ] Always nil.
-        alias :max :min
+        alias max min
       end
     end
   end

data/lib/mongoid/contextual/aggregable.rb

@@ -1,17 +1,15 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Contextual
     module Aggregable
-
       # @api private
       EMPTY_RESULT = {
-        "count" => 0,
-        "sum" => 0,
-        "avg" => nil,
-        "min" => nil,
-        "max" => nil,
+        'count' => 0,
+        'sum' => 0,
+        'avg' => nil,
+        'min' => nil,
+        'max' => nil
       }.freeze
     end
   end

data/lib/mongoid/contextual/atomic.rb

@@ -1,16 +1,13 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Contextual
-
     # Mixin module included in Mongoid::Criteria which provides a
     # direct method interface to MongoDB's Update Operators ($set,
     # $pull, $inc, etc.) These operators can be applied to update
     # all documents in the database within the criteria scope,
     # without loading each document into Mongoid's memory.
     module Atomic
-
       # Execute an atomic $addToSet on the matching documents.
       #
       # @example Add the value to the set.
@@ -20,7 +17,7 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def add_to_set(adds)
-        view.update_many("$addToSet" => collect_operations(adds))
+        view.update_many('$addToSet' => collect_operations(adds))
       end
 
       # Perform an atomic $addToSet/$each on the matching documents.
@@ -32,7 +29,7 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def add_each_to_set(adds)
-        view.update_many("$addToSet" => collect_each_operations(adds))
+        view.update_many('$addToSet' => collect_each_operations(adds))
       end
 
       # Perform an atomic $bit operation on the matching documents.
@@ -44,7 +41,7 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def bit(bits)
-        view.update_many("$bit" => collect_operations(bits))
+        view.update_many('$bit' => collect_operations(bits))
       end
 
       # Perform an atomic $inc operation on the matching documents.
@@ -56,7 +53,7 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def inc(incs)
-        view.update_many("$inc" => collect_operations(incs))
+        view.update_many('$inc' => collect_operations(incs))
       end
 
       # Perform an atomic $mul operation on the matching documents.
@@ -68,7 +65,7 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def mul(factors)
-        view.update_many("$mul" => collect_operations(factors))
+        view.update_many('$mul' => collect_operations(factors))
       end
 
       # Perform an atomic $pop operation on the matching documents.
@@ -83,7 +80,7 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def pop(pops)
-        view.update_many("$pop" => collect_operations(pops))
+        view.update_many('$pop' => collect_operations(pops))
       end
 
       # Perform an atomic $pull operation on the matching documents.
@@ -97,7 +94,7 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def pull(pulls)
-        view.update_many("$pull" => collect_operations(pulls))
+        view.update_many('$pull' => collect_operations(pulls))
       end
 
       # Perform an atomic $pullAll operation on the matching documents.
@@ -109,7 +106,7 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def pull_all(pulls)
-        view.update_many("$pullAll" => collect_operations(pulls))
+        view.update_many('$pullAll' => collect_operations(pulls))
       end
 
       # Perform an atomic $push operation on the matching documents.
@@ -121,7 +118,7 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def push(pushes)
-        view.update_many("$push" => collect_operations(pushes))
+        view.update_many('$push' => collect_operations(pushes))
       end
 
       # Perform an atomic $push/$each operation on the matching documents.
@@ -133,7 +130,7 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def push_all(pushes)
-        view.update_many("$push" => collect_each_operations(pushes))
+        view.update_many('$push' => collect_each_operations(pushes))
       end
 
       # Perform an atomic $rename of fields on the matching documents.
@@ -145,11 +142,10 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def rename(renames)
-        operations = renames.inject({}) do |ops, (old_name, new_name)|
+        operations = renames.each_with_object({}) do |(old_name, new_name), ops|
           ops[old_name] = new_name.to_s
-          ops
         end
-        view.update_many("$rename" => collect_operations(operations))
+        view.update_many('$rename' => collect_operations(operations))
       end
 
       # Perform an atomic $set of fields on the matching documents.
@@ -161,7 +157,7 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def set(sets)
-        view.update_many("$set" => collect_operations(sets))
+        view.update_many('$set' => collect_operations(sets))
       end
 
       # Perform an atomic $unset of a field on the matching documents.
@@ -198,9 +194,9 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def set_min(fields)
-        view.update_many("$min" => collect_operations(fields))
+        view.update_many('$min' => collect_operations(fields))
       end
-      alias :clamp_upper_bound :set_min
+      alias clamp_upper_bound set_min
 
       # Performs an atomic $max update operation on the given field or fields.
       # Each field will be set to the maximum of [current_value, given value].
@@ -221,9 +217,9 @@ module Mongoid
       #
       # @return [ nil ] Nil.
       def set_max(fields)
-        view.update_many("$max" => collect_operations(fields))
+        view.update_many('$max' => collect_operations(fields))
       end
-      alias :clamp_lower_bound :set_max
+      alias clamp_lower_bound set_max
 
       private
 
@@ -231,7 +227,7 @@ module Mongoid
       #
       # @param [ Array | Hash ] ops The operations to collect.
       # @param [ Hash ] aggregator The hash to use to aggregate the operations.
-      # 
+      #
       # @return [ Hash ] The aggregated operations, by field.
       def collect_operations(ops, aggregator = {})
         ops.each_with_object(aggregator) do |(field, value), operations|
@@ -241,7 +237,7 @@ module Mongoid
 
       def collect_each_operations(ops)
         ops.each_with_object({}) do |(field, value), operations|
-          operations[database_field_name(field)] = { "$each" => Array.wrap(value).mongoize }
+          operations[database_field_name(field)] = { '$each' => Array.wrap(value).mongoize }
         end
       end
 
@@ -261,7 +257,7 @@ module Mongoid
       # @return [ Hash ] The selector for the atomic $unset operation.
       def collect_unset_operations(ops)
         ops.map { |op| op.is_a?(Hash) ? op.keys : op }.flatten
-           .map { |field| [database_field_name(field), true] }.to_h
+           .map { |field| [ database_field_name(field), true ] }.to_h
       end
     end
   end

data/lib/mongoid/contextual/command.rb

@@ -1,12 +1,9 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Contextual
-
     # Mixin module included in objects which represent database commands.
     module Command
-
       # @attribute [r] collection The collection to query against.
       # @attribute [r] criteria The criteria for the context.
       attr_reader :collection, :criteria

data/lib/mongoid/contextual/map_reduce.rb

@@ -1,9 +1,7 @@
 # frozen_string_literal: true
-# rubocop:todo all
 
 module Mongoid
   module Contextual
-
     # Represents a mapReduce database command instruction.
     class MapReduce
       extend Forwardable
@@ -20,7 +18,7 @@ module Mongoid
       #
       # @return [ Hash ] The counts.
       def counts
-        results["counts"]
+        results['counts']
       end
 
       # Iterates over each of the documents in the map/reduce, excluding the
@@ -32,12 +30,10 @@ module Mongoid
       #   end
       #
       # @return [ Enumerator ] The enumerator.
-      def each
+      def each(&block)
         validate_out!
         if block_given?
-          @map_reduce.each do |doc|
-            yield doc
-          end
+          @map_reduce.each(&block)
         else
           @map_reduce.to_enum
         end
@@ -50,7 +46,7 @@ module Mongoid
       #
       # @return [ Integer ] The number of emitted documents.
       def emitted
-        counts["emit"]
+        counts['emit']
       end
 
       # Provide a finalize js function for the map/reduce.
@@ -87,7 +83,7 @@ module Mongoid
       #
       # @return [ Integer ] The number of input documents.
       def input
-        counts["input"]
+        counts['input']
       end
 
       # Sets the map/reduce to use jsMode.
@@ -138,7 +134,7 @@ module Mongoid
       #
       # @return [ Integer ] The number of output documents.
       def output
-        counts["output"]
+        counts['output']
       end
 
       # Get the raw output from the map/reduce operation.
@@ -153,7 +149,7 @@ module Mongoid
         opts = { read: criteria.options.fetch(:read) } if criteria.options[:read]
         @map_reduce.database.command(cmd, (opts || {}).merge(session: _session)).first
       end
-      alias :results :raw
+      alias results raw
 
       # Execute the map/reduce, returning the raw output.
       # Useful when you don't care about map/reduce's output.
@@ -162,7 +158,7 @@ module Mongoid
       #   map_reduce.execute
       #
       # @return [ Hash ] The raw output
-      alias :execute :raw
+      alias execute raw
 
       # Get the number of documents reduced by the map/reduce.
       #
@@ -171,7 +167,7 @@ module Mongoid
       #
       # @return [ Integer ] The number of reduced documents.
       def reduced
-        counts["reduce"]
+        counts['reduce']
       end
 
       # Adds a javascript object to the global scope of the map/reduce.
@@ -194,7 +190,7 @@ module Mongoid
       #
       # @return [ Float ] The time in milliseconds.
       def time
-        results["timeMillis"]
+        results['timeMillis']
       end
 
       # Get a pretty string representation of the map/reduce, including the
@@ -205,14 +201,14 @@ module Mongoid
       #
       # @return [ String ] The inspection string.
       def inspect
-%Q{#<Mongoid::Contextual::MapReduce
+        %(#<Mongoid::Contextual::MapReduce
   selector: #{criteria.selector.inspect}
   class:    #{criteria.klass}
   map:      #{command[:map]}
   reduce:   #{command[:reduce]}
   finalize: #{command[:finalize]}
   out:      #{command[:out].inspect}>
-}
+)
       end
 
       # Returns the selector of the command spec.