mongoid 6.4.8 → 7.0.13

data/spec/mongoid/matchable/eq_spec.rb

@@ -0,0 +1,48 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+
+describe Mongoid::Matchable::Eq do
+
+  let(:matcher) do
+    described_class.new("first")
+  end
+
+  describe "#_matches?" do
+
+    context "when the values are equal" do
+
+      it "returns true" do
+        expect(matcher._matches?("$eq" => "first")).to be true
+      end
+    end
+
+    context "when the values are not equal" do
+
+      it "returns false" do
+        expect(matcher._matches?("$eq" => "second")).to be false
+      end
+    end
+
+    context "when the value is an array" do
+
+      let(:array_matcher) do
+        described_class.new([ "first" ])
+      end
+
+      context "when the value is in the array" do
+
+        it "returns true" do
+          expect(array_matcher._matches?("$eq" => "first")).to be true
+        end
+      end
+
+      context "when the value is not in the array" do
+
+        it "returns false" do
+          expect(array_matcher._matches?("$eq" => "second")).to be false
+        end
+      end
+    end
+  end
+end

data/spec/mongoid/matchable/regexp_spec.rb

@@ -15,7 +15,7 @@ describe Mongoid::Matchable::Regexp do
     context 'when a BSON::Regexp::Raw object is passed' do
 
       let(:regexp) do
-        BSON::Regexp::Raw.new('^Em')
+        BSON::Regexp::Raw.new("\\AEm")
       end
 
       it 'compiles the regexp object to a native regexp for the matching' do
@@ -37,7 +37,7 @@ describe Mongoid::Matchable::Regexp do
     context 'when a native Regexp object is passed' do
 
       let(:regexp) do
-        /^Em/
+        /\AEm/
       end
 
       it 'calls super with the native regexp' do

data/spec/mongoid/matchable_spec.rb

@@ -293,7 +293,7 @@ describe Mongoid::Matchable do
       context 'when a BSON::Regexp::Raw object is used' do
 
         let(:selector) do
-          { street: BSON::Regexp::Raw.new("^Clarkenwell") }
+          { street: BSON::Regexp::Raw.new("\\AClarkenwell") }
         end
 
         it "returns true" do
@@ -304,7 +304,7 @@ describe Mongoid::Matchable do
       context 'when a native Regexp object is used' do
 
         let(:selector) do
-          { street: /^Clarkenwell/ }
+          { street: /\AClarkenwell/ }
         end
 
         it "returns true" do

data/spec/mongoid/persistable/pushable_spec.rb

@@ -4,7 +4,7 @@ describe Mongoid::Persistable::Pushable do
 
   describe "#add_to_set" do
 
-    context "when the document is a root document" do
+    context "when the document is a top level document" do
 
       shared_examples_for "a unique pushable root document" do
 
@@ -62,6 +62,60 @@ describe Mongoid::Persistable::Pushable do
 
         it_behaves_like "a unique pushable root document"
       end
+
+      context 'when the host model is not saved' do
+        context 'when attribute exists' do
+          let(:person) do
+            Person.new(aliases: [2])
+          end
+
+          it 'records the change' do
+            person.add_to_set({aliases: 1})
+
+            expect(person.aliases).to eq([2, 1])
+          end
+        end
+
+        context 'when attribute does not exist' do
+          let(:person) do
+            Person.new
+          end
+
+          it 'records the change' do
+            person.add_to_set({aliases: 1})
+
+            expect(person.aliases).to eq([1])
+          end
+        end
+      end
+
+      context 'when the host model is loaded from database' do
+        context 'when attribute exists' do
+          let(:person) do
+            Person.create!(aliases: [2])
+            person = Person.last
+          end
+
+          it 'records the change' do
+            person.add_to_set({aliases: 1})
+
+            expect(person.aliases).to eq([2, 1])
+          end
+        end
+
+        context 'when attribute does not exist' do
+          let(:person) do
+            Person.create!
+            person = Person.last
+          end
+
+          it 'records the change' do
+            person.add_to_set({aliases: 1})
+
+            expect(person.aliases).to eq([1])
+          end
+        end
+      end
     end
 
     context "when the document is embedded" do

data/spec/mongoid/persistable/savable_spec.rb

@@ -166,8 +166,8 @@ describe Mongoid::Persistable::Savable do
           Person.create(title: "Blah")
         end
 
-        let!(:address) do
-          person.addresses.build(street: "Bond St")
+        let!(:symptom) do
+          person.symptoms.build(name: "Headache")
         end
 
         let!(:name) do
@@ -190,7 +190,7 @@ describe Mongoid::Persistable::Savable do
               "name.first_name" => "Ryan"
             },
             "$push"=> {
-              "addresses" =>  { '$each' => [ { "_id" => address.id, "street" => "Bond St" } ] }
+              "symptoms" => { '$each' => [ { "_id" => symptom.id, "name" => "Headache" } ] }
             }
           })
         end
@@ -202,7 +202,7 @@ describe Mongoid::Persistable::Savable do
           end
 
           it "saves embedded many relations" do
-            expect(person.addresses.first.street).to eq("Bond St")
+            expect(person.symptoms.first.name).to eq("Headache")
           end
 
           it "saves embedded one relations" do
@@ -309,7 +309,7 @@ describe Mongoid::Persistable::Savable do
         expect {
           person.username = 'unloaded-attribute'
           person.save
-        }.to raise_error(Mongoid::Errors::ReadonlyAttribute)
+        }.to raise_error(ActiveModel::MissingAttributeError)
       end
 
       context 'when the changed attribute is aliased' do

data/spec/mongoid/persistable/settable_spec.rb

@@ -211,7 +211,7 @@ describe Mongoid::Persistable::Settable do
       Church.new.tap do |a|
         a.location = { 'city' => 'Berlin' }
         a.name = 'Church1'
-        a.save
+        a.save!
       end
     end
 
@@ -280,7 +280,7 @@ describe Mongoid::Persistable::Settable do
 
     context 'when the field is a nested hash' do
 
-      context 'when the field is reset to an empty hash' do
+      context 'when the field is set to an empty hash' do
 
         before do
           church.set('location' => {})
@@ -301,7 +301,7 @@ describe Mongoid::Persistable::Settable do
           Church.new.tap do |a|
             a.location = {'address' => {'city' => 'Berlin', 'street' => 'Yorckstr'}}
             a.name = 'Church1'
-            a.save
+            a.save!
           end
         end
 
@@ -321,7 +321,7 @@ describe Mongoid::Persistable::Settable do
           Church.new.tap do |a|
             a.location = {'address' => {'city' => 'Berlin', 'street' => 'Yorckstr'}}
             a.name = 'Church1'
-            a.save
+            a.save!
           end
         end
 
@@ -341,20 +341,105 @@ describe Mongoid::Persistable::Settable do
           Church.new.tap do |a|
             a.location = {'address' => {'state' => {'address' => {'city' => 'Berlin', 'street' => 'Yorckstr'}}}}
             a.name = 'Church1'
-            a.save
+            a.save!
           end
         end
 
-        before do
-          church.set('location.address.state.address.city' => 'Munich')
+        context 'setting value to a string' do
+          it 'keeps peer attributes of the nested hash' do
+            church.set('location.address.state.address.city' => 'Munich')
+
+            expect(church.name).to eq('Church1')
+            expect(church.location).to eql({'address' => {'state' => {'address' => {'city' => 'Munich', 'street' => 'Yorckstr'}}}})
+          end
+
+          it 'removes lower level attributes of the nested hash' do
+            church.set('location.address.state.address' => 'hello')
+
+            expect(church.name).to eq('Church1')
+            expect(church.location).to eql({'address' => {'state' => {'address' => 'hello'}}})
+          end
         end
 
-        it 'does not reset the nested hash' do
-          expect(church.name).to eq('Church1')
-          expect(church.location).to eql({'address' => {'state' => {'address' => {'city' => 'Munich', 'street' => 'Yorckstr'}}}})
+        context 'setting value to a hash' do
+          it 'keeps peer attributes of the nested hash' do
+            church.set('location.address.state.address.city' => {'hello' => 'world'})
+
+            expect(church.name).to eq('Church1')
+            expect(church.location).to eql({'address' => {'state' => {'address' => {'city' => {'hello' => 'world'}, 'street' => 'Yorckstr'}}}})
+          end
+
+          it 'removes lower level attributes of the nested hash' do
+            church.set('location.address.state.address' => {'hello' => 'world'})
+
+            expect(church.name).to eq('Church1')
+            expect(church.location).to eql({'address' => {'state' => {'address' => {'hello' => 'world'}}}})
+          end
         end
       end
     end
+
+    context 'when nested field is an array' do
+      let(:church) do
+        Church.create!(
+          location: {'address' => ['one', 'two']}
+        )
+      end
+
+      context 'setting to a different array' do
+        it 'sets values to new array discarding old values' do
+          church.set('location.address' => ['three'])
+
+          expect(church.location).to eq('address' => ['three'])
+          church.reload
+          expect(church.location).to eq('address' => ['three'])
+        end
+      end
+
+      context 'changing from an array to a number' do
+        it 'sets value to the number' do
+          church.set('location.address' => 5)
+
+          expect(church.location).to eq('address' => 5)
+          church.reload
+          expect(church.location).to eq('address' => 5)
+        end
+      end
+    end
+
+    context 'when nested field is not an array' do
+      let(:church) do
+        Church.create!(
+          location: {'address' => 5}
+        )
+      end
+
+      context 'setting to an array' do
+        it 'sets values to the array' do
+          church.set('location.address' => ['three'])
+
+          expect(church.location).to eq('address' => ['three'])
+          church.reload
+          expect(church.location).to eq('address' => ['three'])
+        end
+      end
+    end
+
+    context 'when nesting into a field that is not a hash' do
+      let(:church) do
+        Church.create!(
+          location: {'address' => 5}
+        )
+      end
+
+      it 'sets field to new hash value discarding original value' do
+        church.set('location.address.a' => 'test')
+
+        expect(church.location).to eq('address' => {'a' => 'test'})
+        church.reload
+        expect(church.location).to eq('address' => {'a' => 'test'})
+      end
+    end
   end
 
   context 'when the field is not already set locally' do
@@ -410,4 +495,34 @@ describe Mongoid::Persistable::Settable do
       end
     end
   end
+
+  context "when the field being set was projected out" do
+    let(:full_agent) do
+      Agent.create!(title: "Double-Oh Eight")
+    end
+
+    let(:agent) do
+      Agent.where(_id: full_agent.id).only(:dob).first
+    end
+
+    context 'field exists in database' do
+      it "raises MissingAttributeError" do
+        lambda do
+          agent.set(title: '008')
+        end.should raise_error(ActiveModel::MissingAttributeError)
+
+        expect(agent.reload.title).to eq 'Double-Oh Eight'
+      end
+    end
+
+    context 'field does not exist in database' do
+      it "raises MissingAttributeError" do
+        lambda do
+          agent.set(number: '008')
+        end.should raise_error(ActiveModel::MissingAttributeError)
+
+        expect(agent.reload.read_attribute(:number)).to be nil
+      end
+    end
+  end
 end

data/spec/mongoid/persistable_spec.rb

@@ -57,7 +57,7 @@ describe Mongoid::Persistable do
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
             "$unset" => { "origin" => true }},
-           { session: nil }]
+            { :session => nil } ]
         end
 
         before do
@@ -83,8 +83,8 @@ describe Mongoid::Persistable do
             "$inc" => { "member_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
-            "$unset" => { "origin" => true }},
-           { :session => nil } ]
+            "$unset" => { "origin" => true } },
+            { :session => nil } ]
         end
 
         before do
@@ -107,12 +107,12 @@ describe Mongoid::Persistable do
       context "when given multiple operations of the same type" do
 
         let(:operations) do
-          [{
+         [{
             "$inc" => { "member_count" => 10, "other_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
             "$unset" => { "origin" => true }},
-            { session: nil }]
+            { :session => nil } ]
         end
 
         before do
@@ -149,7 +149,7 @@ describe Mongoid::Persistable do
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
             "$unset" => { "origin" => true }},
-            { session: nil }]
+            { :session => nil } ]
         end
 
         before do
@@ -200,6 +200,21 @@ describe Mongoid::Persistable do
         expect(document.atomically).to be true
       end
     end
+
+    context "when the block has no operations" do
+        before do
+          expect_any_instance_of(Mongo::Collection::View).to_not receive(:update_one)
+        end
+
+        let!(:update) do
+          document.atomically do
+          end
+        end
+
+        it "doesn't update the document" do
+          expect(document.reload.origin).to eq("London")
+        end
+    end
   end
 
   describe "#fail_due_to_valiation!" do

data/spec/mongoid/persistence_context_spec.rb

@@ -536,7 +536,7 @@ describe Mongoid::PersistenceContext do
     end
 
     before do
-      Mongoid.clients[:alternative] = { database: :mongoid_test, hosts: [ "#{HOST}:#{PORT}" ] }
+      Mongoid.clients[:alternative] = { database: :mongoid_test, hosts: SpecConfig.instance.addresses }
     end
 
     after do

data/spec/mongoid/query_cache_spec.rb

@@ -45,32 +45,16 @@ describe Mongoid::QueryCache do
         :posts
       end
 
-      context 'when query cache is disabled' do
+      context 'does not query for the relation and instead sets the base' do
 
         before do
           Mongoid::QueryCache.enabled = false
         end
 
         it 'queries for each access to the base' do
-          expect_query(relations.size) do
-            relations.each do |object|
-              object.person
-            end
-          end
-        end
-      end
-
-      context 'when query cache is enabled' do
-
-        before do
-          Mongoid::QueryCache.enabled = true
-        end
-
-        it 'queries only once for the base' do
-          expect_query(1) do
-            relations.each do |object|
-              object.person
-            end
+          expect(server).to receive(:with_connection).exactly(0).times.and_call_original
+          relations.each do |object|
+            object.person
           end
         end
       end
@@ -153,6 +137,36 @@ describe Mongoid::QueryCache do
     end
   end
 
+  context 'querying all documents after a single document' do
+    before do
+      3.times do
+        Person.create
+      end
+    end
+
+    it 'returns all documents' do
+      expect(Person.all.to_a.count).to eq(3)
+      Person.first
+      expect(Person.all.to_a.count).to eq(3)
+    end
+
+    context 'with conditions specified' do
+      it 'returns all documents' do
+        expect(Person.gt(age: 0).to_a.count).to eq(3)
+        Person.gt(age: 0).first
+        expect(Person.gt(age: 0).to_a.count).to eq(3)
+      end
+    end
+
+    context 'with order specified' do
+      it 'returns all documents' do
+        expect(Person.order_by(name: 1).to_a.count).to eq(3)
+        Person.order_by(name: 1).first
+        expect(Person.order_by(name: 1).to_a.count).to eq(3)
+      end
+    end
+  end
+
   context "when querying in the same collection" do
 
     before do
@@ -180,7 +194,8 @@ describe Mongoid::QueryCache do
         end
       end
 
-      context 'when the first query has a collation', if: collation_supported? do
+      context 'when the first query has a collation' do
+        min_server_version '3.4'
 
         before do
           Band.where(name: 'DEPECHE MODE').collation(locale: 'en_US', strength: 2).to_a
@@ -494,18 +509,18 @@ describe Mongoid::QueryCache do
     end
   end
 
-  context "when querying a very large collection" do
+  context "when querying collection smaller than the batch size" do
 
     before do
-      100.times { Band.create! }
+      99.times { Band.create! }
     end
 
     it "returns the right number of records" do
-      expect(Band.all.to_a.length).to eq(100)
+      expect(Band.all.to_a.length).to eq(99)
     end
 
     it "#pluck returns the same count of objects" do
-      expect(Band.pluck(:name).length).to eq(100)
+      expect(Band.pluck(:name).length).to eq(99)
     end
 
     context "when loading all the documents" do
@@ -516,12 +531,12 @@ describe Mongoid::QueryCache do
 
       it "caches the complete result of the query" do
         expect_no_queries do
-          expect(Band.all.to_a.length).to eq(100)
+          expect(Band.all.to_a.length).to eq(99)
         end
       end
 
       it "returns the same count of objects when using #pluck" do
-        expect(Band.pluck(:name).length).to eq(100)
+        expect(Band.pluck(:name).length).to eq(99)
       end
     end
   end
@@ -533,6 +548,29 @@ describe Mongoid::QueryCache do
       Band.collection.indexes.create_one(name: 1)
     end
   end
+
+  context 'when the initial query does not exhaust the results' do
+    before do
+      Mongoid::QueryCache.enabled = true
+      10.times { Band.create! }
+
+      Band.batch_size(4).all.to_a
+    end
+
+    it 'does not cache the result' do
+      expect(Band.all.map(&:id).size).to eq(10)
+    end
+
+    context 'when a batch size smaller than the result set is specified' do
+      let(:batch_size) do
+        4
+      end
+
+      it 'does not cache the result' do
+        expect(Band.batch_size(batch_size).all.map(&:id).size).to eq(10)
+      end
+    end
+  end
 end
 
 describe Mongoid::QueryCache::Middleware do