mongoid 6.4.8 → 7.0.13

data/spec/mongoid/criteria/modifiable_spec.rb

@@ -49,6 +49,29 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.create
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   describe "#create!" do
@@ -65,6 +88,29 @@ describe Mongoid::Criteria::Modifiable do
         }.to raise_error(Mongoid::Errors::Validations)
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.create!
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   [ :delete, :delete_all, :destroy, :destroy_all ].each do |method|
@@ -295,6 +341,25 @@ describe Mongoid::Criteria::Modifiable do
           expect(person.pets).to be true
         end
       end
+
+      context 'when the object is polymorphic' do
+
+        let(:movie) do
+          Movie.new
+        end
+
+        let(:document) do
+          Rating.find_or_create_by(ratable: movie)
+        end
+
+        it 'sets the polymorphic id' do
+          expect(document.ratable_id).to eq(movie.id)
+        end
+
+        it 'sets the type field' do
+          expect(document.ratable_type).to eq('Movie')
+        end
+      end
     end
   end
 
@@ -447,6 +512,25 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:document) do
+        Rating.find_or_create_by!(ratable: movie)
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   describe ".find_or_initialize_by" do
@@ -500,6 +584,25 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:document) do
+        Rating.find_or_initialize_by(ratable: movie)
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   describe "first_or_create" do
@@ -649,7 +752,7 @@ describe Mongoid::Criteria::Modifiable do
             band = Band.create
             Mongoid::Criteria.new(Record) do |criteria|
               criteria.embedded = true
-              criteria.metadata = Band.reflect_on_association(:records)
+              criteria.association = Band.reflect_on_association(:records)
               criteria.parent_document = band
               criteria.selector = { "records" => { "producers"=>{"$in"=>["nonexistent"] } } }
             end
@@ -703,6 +806,29 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
 
+      context 'when the object is polymorphic' do
+
+        let(:movie) do
+          Movie.new
+        end
+
+        let(:criteria) do
+          Rating.where(ratable: movie)
+        end
+
+        let(:document) do
+          criteria.first_or_create
+        end
+
+        it 'sets the polymorphic id' do
+          expect(document.ratable_id).to eq(movie.id)
+        end
+
+        it 'sets the type field' do
+          expect(document.ratable_type).to eq('Movie')
+        end
+      end
+
       context "when a block is provided" do
 
         let(:document) do
@@ -919,6 +1045,29 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.first_or_create!
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   describe "first_or_initialize" do
@@ -938,6 +1087,29 @@ describe Mongoid::Criteria::Modifiable do
       end
     end
 
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.first_or_initialize
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
+
     context "when the document is not found" do
 
       context "when attributes are provided" do

data/spec/mongoid/criteria/queryable/extensions/numeric_spec.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+
+describe Mongoid::Criteria::Queryable::Extensions::Numeric::ClassMethods do
+
+  let(:host) do
+    Class.new do
+      include Mongoid::Criteria::Queryable::Extensions::Numeric::ClassMethods
+    end.new
+  end
+
+  describe "#__numeric__" do
+
+    let(:actual) { host.__numeric__(str) }
+
+    context "when the string is a whole number" do
+
+      let(:str) { '123' }
+
+      it "returns the value as integer" do
+        expect(actual).to eq(123)
+      end
+    end
+
+    context "when the string is a floating point number" do
+
+      let(:str) { '123.45' }
+
+      it "returns the value as a float" do
+        expect(actual).to eq(123.45)
+      end
+    end
+
+    context "when the string is a dot only" do
+
+      let(:str) { '.' }
+
+      it "returns zero" do
+        expect(actual).to eq(0)
+      end
+    end
+
+    context "when the string is a number with fractional part consisting of zeros" do
+
+      let(:str) { '12.000' }
+
+      it "returns the value as integer" do
+        expect(actual).to eq(12)
+      end
+    end
+  end
+end

data/spec/mongoid/criteria/queryable/extensions/regexp_spec.rb

@@ -8,7 +8,7 @@ describe Mongoid::Criteria::Queryable::Extensions::Regexp do
     context "when provided a regexp" do
 
       let(:regexp) do
-        /^[123]/
+        /\A[123]/
       end
 
       let(:evolved) do
@@ -23,7 +23,7 @@ describe Mongoid::Criteria::Queryable::Extensions::Regexp do
     context "when provided a string" do
 
       let(:regexp) do
-        "^[123]"
+        "\\A[123]"
       end
 
       let(:evolved) do
@@ -31,7 +31,7 @@ describe Mongoid::Criteria::Queryable::Extensions::Regexp do
       end
 
       it "returns the converted regexp" do
-        expect(evolved).to eq(/^[123]/)
+        expect(evolved).to eq(/\A[123]/)
       end
     end
 
@@ -40,7 +40,7 @@ describe Mongoid::Criteria::Queryable::Extensions::Regexp do
       context "when the elements are regexps" do
 
         let(:regexp) do
-          /^[123]/
+          /\A[123]/
         end
 
         let(:array) do
@@ -63,7 +63,7 @@ describe Mongoid::Criteria::Queryable::Extensions::Regexp do
       context "when the elements are strings" do
 
         let(:regexp) do
-          "^[123]"
+          "\\A[123]"
         end
 
         let(:evolved) do
@@ -71,7 +71,7 @@ describe Mongoid::Criteria::Queryable::Extensions::Regexp do
         end
 
         it "returns the regexps" do
-          expect(evolved).to eq([ /^[123]/ ])
+          expect(evolved).to eq([ /\A[123]/ ])
         end
       end
     end
@@ -80,7 +80,7 @@ describe Mongoid::Criteria::Queryable::Extensions::Regexp do
   describe "#regexp?" do
 
     let(:regexp) do
-      /^[123]/
+      /\A[123]/
     end
 
     it "returns true" do

data/spec/mongoid/criteria/queryable/extensions/string_spec.rb

@@ -66,6 +66,49 @@ describe String do
         expect(evolved).to eq(Time.new(2010, 1, 1, 11, 0, 0, 0).utc)
       end
     end
+
+    context "when the string without timezone" do
+
+      context "when using active support's time zone" do
+
+        before do
+          Mongoid.use_activesupport_time_zone = true
+          ::Time.zone = "Tokyo"
+        end
+
+        let(:date) do
+          "2010-01-01 5:00:00"
+        end
+
+        let(:evolved) do
+          date.__evolve_time__
+        end
+
+        it "parses string using active support's time zone" do
+          expect(evolved).to eq(Time.zone.parse(date).utc)
+        end
+      end
+
+      context "when not using active support's time zone" do
+
+        before do
+          Mongoid.use_activesupport_time_zone = false
+          ::Time.zone = nil
+        end
+
+        let(:date) do
+          "2010-01-01 5:00:00"
+        end
+
+        let(:evolved) do
+          date.__evolve_time__
+        end
+
+        it "parses string using system time zone" do
+          expect(evolved).to eq(Time.parse(date).utc)
+        end
+      end
+    end
   end
 
   describe "#__sort_option__" do
@@ -272,7 +315,7 @@ describe String do
     context "when provided a regex" do
 
       let(:regex) do
-        /^[123]/
+        /\A[123]/.freeze
       end
 
       let(:evolved) do

data/spec/mongoid/criteria/queryable/extensions/time_spec.rb

@@ -346,23 +346,35 @@ describe Time do
 
   describe "#__evolve_date__" do
 
-    let(:time) do
-      Time.new(2010, 1, 1, 12, 0, 0)
-    end
-
     let(:evolved) do
       time.__evolve_date__
     end
 
-    it "returns midnight utc" do
-      expect(evolved).to eq(Time.utc(2010, 1, 1, 0, 0, 0))
+    context 'beginning of day' do
+      let(:time) do
+        Time.new(2010, 1, 1, 0, 0, 1).freeze
+      end
+
+      it "returns midnight utc" do
+        expect(evolved).to eq(Time.utc(2010, 1, 1, 0, 0, 0))
+      end
+    end
+
+    context 'end of day' do
+      let(:time) do
+        Time.new(2010, 1, 1, 23, 59, 59).freeze
+      end
+
+      it "returns midnight utc" do
+        expect(evolved).to eq(Time.utc(2010, 1, 1, 0, 0, 0))
+      end
     end
   end
 
   describe "#__evolve_time__" do
 
     let(:time) do
-      Time.new(2010, 1, 1, 12, 0, 0)
+      Time.new(2010, 1, 1, 12, 0, 0).freeze
     end
 
     let(:evolved) do

data/spec/mongoid/criteria/queryable/extensions/time_with_zone_spec.rb

@@ -322,10 +322,37 @@ describe ActiveSupport::TimeWithZone do
     end
   end
 
+  describe "#__evolve_date__" do
+
+    let(:evolved) do
+      time.__evolve_date__
+    end
+
+    context 'beginning of day' do
+      let(:time) do
+        time_zone.local(2010, 1, 1, 0, 0, 1).freeze
+      end
+
+      it "returns midnight utc" do
+        expect(evolved).to eq(Time.utc(2010, 1, 1, 0, 0, 0))
+      end
+    end
+
+    context 'end of day' do
+      let(:time) do
+        time_zone.local(2010, 1, 1, 23, 59, 59).freeze
+      end
+
+      it "returns midnight utc" do
+        expect(evolved).to eq(Time.utc(2010, 1, 1, 0, 0, 0))
+      end
+    end
+  end
+
   describe "#__evolve_time__" do
 
     let(:date) do
-      time_zone.local(2010, 1, 1, 12, 0, 0)
+      time_zone.local(2010, 1, 1, 12, 0, 0).freeze
     end
 
     let(:evolved) do

data/spec/mongoid/criteria/queryable/key_spec.rb

@@ -23,16 +23,58 @@ describe Mongoid::Criteria::Queryable::Key do
 
   describe "#__expr_part__" do
 
-    let(:key) do
-      described_class.new("field", :__union__, "$all")
+    context 'operator only' do
+      let(:key) do
+        described_class.new("field", :__union__, "$all")
+      end
+
+      let(:specified) do
+        key.__expr_part__([ 1, 2 ])
+      end
+
+      it "returns the name plus operator and value" do
+        expect(specified).to eq({ "field" => { "$all" => [ 1, 2 ] }})
+      end
     end
 
-    let(:specified) do
-      key.__expr_part__([ 1, 2 ])
+    context 'operator and expanded only' do
+      let(:key) do
+        described_class.new("field", :__override__, "$geoIntersects", '$geometry')
+      end
+
+      let(:specified) do
+        key.__expr_part__([ 1, 10 ])
+      end
+
+      it "returns the query expression" do
+        expect(specified).to eq({ "field" => {
+          '$geoIntersects' => {
+            '$geometry' => [1, 10],
+          },
+        }})
+      end
     end
 
-    it "returns the name plus operator and value" do
-      expect(specified).to eq({ "field" => { "$all" => [ 1, 2 ] }})
+    context 'operator, expanded and block' do
+      let(:key) do
+        described_class.new("field", :__override__, "$geoIntersects", '$geometry') do |value|
+          { "type" => 'Point', "coordinates" => value }
+        end
+      end
+
+      let(:specified) do
+        key.__expr_part__([ 1, 10 ])
+      end
+
+      it "returns the query expression" do
+        expect(specified).to eq({ "field" => {
+          '$geoIntersects' => {
+            '$geometry' => {
+              'type' => 'Point', 'coordinates' => [1, 10],
+            },
+          },
+        }})
+      end
     end
   end
 

data/spec/mongoid/criteria/queryable/pipeline_spec.rb

@@ -196,5 +196,17 @@ describe Mongoid::Criteria::Queryable::Pipeline do
         end
       end
     end
+
+    context "when provided a hash" do
+      before do
+        pipeline.unwind(path: "$author", "includeArrayIndex" => "author_index", preserveNullAndEmptyArrays: true)
+      end
+
+      it "sets the hash" do
+        expect(pipeline).to eq([
+          { "$unwind" => { path: "$author", "includeArrayIndex" => "author_index", preserveNullAndEmptyArrays: true } }
+        ])
+      end
+    end
   end
 end