mongoid 6.4.8 → 7.0.13

data/spec/lite_spec_helper.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+$LOAD_PATH.unshift(File.dirname(__FILE__))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "..", "lib"))
+$LOAD_PATH.unshift(File.join(File.dirname(__FILE__), "shared", "lib"))
+
+require "mongoid"
+
+# MRI 2.5 and JRuby 9.2 change visibility of Object#pp when 'pp' is required,
+# which happens when RSpec reports anything. This creates an issue for tests
+# that verify method forwarding. Work around by proactively loading 'pp'.
+# https://github.com/jruby/jruby/issues/5599
+require 'pp'
+
+require 'support/spec_config'
+require 'mrss/lite_constraints'
+require "support/session_registry"
+
+unless SpecConfig.instance.ci?
+  begin
+    require 'byebug'
+  rescue LoadError
+    # jruby - try pry
+    begin
+      require 'pry'
+    # jruby likes to raise random error classes, in this case
+    # NameError in addition to LoadError
+    rescue Exception
+    end
+  end
+end
+
+if SpecConfig.instance.mri?
+  require 'timeout_interrupt'
+else
+  require 'timeout'
+  TimeoutInterrupt = Timeout
+end
+
+RSpec.configure do |config|
+  config.expect_with(:rspec) do |c|
+    c.syntax = [:should, :expect]
+  end
+
+  if SpecConfig.instance.ci?
+    config.add_formatter(RSpec::Core::Formatters::JsonFormatter, File.join(File.dirname(__FILE__), '../tmp/rspec.json'))
+  end
+
+  if SpecConfig.instance.ci? && !%w(1 true yes).include?(ENV['INTERACTIVE']&.downcase)
+    timeout = if SpecConfig.instance.app_tests?
+      # Allow 5 minutes per test for the app tests, since they install
+      # gems for Rails applications which can take a long time.
+      300
+    else
+      # Allow a max of 30 seconds per test.
+      # Tests should take under 10 seconds ideally but it seems
+      # we have some that run for more than 10 seconds in CI.
+      30
+    end
+    config.around(:each) do |example|
+      TimeoutInterrupt.timeout(timeout) do
+        example.run
+      end
+    end
+  end
+
+  config.extend(Mrss::LiteConstraints)
+end
+
+# require all shared examples
+Dir['./spec/support/shared/*.rb'].sort.each { |file| require file }

data/spec/mongoid/{relations → association}/accessors_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Accessors do
+describe Mongoid::Association::Accessors do
 
   describe "\#{getter}?" do
 
@@ -687,6 +687,45 @@ describe Mongoid::Relations::Accessors do
     end
   end
 
+  context 'when setting associations to nil values' do
+    context 'when the document embeds one' do
+      let(:definitions) do
+        class AccessorEmbedding
+          include Mongoid::Document
+
+          embeds_one :accessor_embedded
+        end
+
+        class AccessorEmbedded
+          include Mongoid::Document
+
+          embedded_in :accessor_embedding
+        end
+
+        define_embedded
+      end
+
+      let(:embedding) do
+        AccessorEmbedding.create!
+      end
+
+      let(:define_embedded) do
+        AccessorEmbedded.create!(accessor_embedding: embedding)
+      end
+
+      it 'successfully removes the embedded document' do
+        definitions
+
+        expect(embedding.accessor_embedded).not_to be_nil
+
+        embedding.accessor_embedded = nil
+        embedding.save!
+
+        expect(embedding.reload.accessor_embedded).to be_nil
+      end
+    end
+  end
+
   context "when setting association foreign keys" do
 
     let(:game) do

data/spec/mongoid/{relations → association}/auto_save_spec.rb

@@ -1,11 +1,12 @@
 require "spec_helper"
 
-describe Mongoid::Relations::AutoSave do
+describe Mongoid::Association::Referenced::AutoSave do
 
   describe ".auto_save" do
 
     before(:all) do
-      Person.autosave(Person.relations["account"].merge!(autosave: true))
+      Person.has_many :drugs, validate: false, autosave: true
+      Person.has_one :account, validate: false, autosave: true
     end
 
     after(:all) do
@@ -42,13 +43,8 @@ describe Mongoid::Relations::AutoSave do
 
       context "when the relation has already had the autosave callback added" do
 
-        let(:metadata) do
-          Person.relations["drugs"].merge!(autosave: true)
-        end
-
         before do
-          Person.autosave(metadata)
-          Person.autosave(metadata)
+          Person.has_many :drugs, validate: false, autosave: true
         end
 
         let(:drug) do
@@ -71,6 +67,11 @@ describe Mongoid::Relations::AutoSave do
         context "when saving a new parent document" do
 
           context 'when persistence options are not set on the parent' do
+
+            before do
+              Person.has_many :drugs, validate: false, autosave: true
+            end
+
             before do
               person.drugs << drug
               person.save
@@ -254,10 +255,6 @@ describe Mongoid::Relations::AutoSave do
 
       context "when it has two relations with autosaves" do
 
-        before do
-          Person.autosave(Person.relations["drugs"].merge!(autosave: true))
-        end
-
         let!(:person) do
           Person.create(drugs: [percocet], account: account)
         end
@@ -309,6 +306,57 @@ describe Mongoid::Relations::AutoSave do
           end
         end
       end
+
+      context 'when the autosave should be cascaded' do
+
+        before do
+          class King
+            include Mongoid::Document
+            has_one :peasant, autosave: true
+          end
+
+          class Peasant
+            include Mongoid::Document
+            belongs_to :king
+            has_one :harvest, autosave: true
+          end
+
+          class Harvest
+            include Mongoid::Document
+            field :season, type: String
+            belongs_to :peasant
+          end
+        end
+
+        after do
+          Object.send(:remove_const, :King)
+          Object.send(:remove_const, :Peasant)
+          Object.send(:remove_const, :Harvest)
+        end
+
+        let(:king) do
+          King.create
+        end
+
+        let(:peasant) do
+          Peasant.create
+        end
+
+        let(:harvest) do
+          Harvest.create(season: 'Summer')
+        end
+
+        before do
+          peasant.harvest = harvest
+          king.peasant = peasant
+          harvest.season = 'Fall'
+          king.save
+        end
+
+        it 'cascades the save' do
+          expect(harvest.reload.season).to eq('Fall')
+        end
+      end
     end
   end
 end

data/spec/mongoid/{relations → association}/builders_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Builders do
+describe Mongoid::Association::Builders do
 
   describe "#build_#\{name}" do
 

data/spec/mongoid/association/constrainable_spec.rb

@@ -0,0 +1,115 @@
+require "spec_helper"
+
+describe Mongoid::Association::Constrainable do
+
+  describe "#convert_to_foreign_key" do
+
+    context "when the id's class stores object ids" do
+
+      before(:all) do
+        Person.field(
+          :_id,
+          type: BSON::ObjectId,
+          pre_processed: true,
+          default: ->{ BSON::ObjectId.new },
+          overwrite: true
+        )
+      end
+
+      let(:constrainable) do
+        Post.belongs_to :person
+      end
+
+      context "when provided an object id" do
+
+        let(:object) do
+          BSON::ObjectId.new
+        end
+
+        it "returns the object id" do
+          expect(constrainable.convert_to_foreign_key(object)).to eq(object)
+        end
+      end
+
+      context "when provided a string" do
+
+        let(:object) do
+          BSON::ObjectId.new
+        end
+
+        it "returns an object id from the string" do
+          expect(constrainable.convert_to_foreign_key(object.to_s)).to eq(object)
+        end
+      end
+    end
+
+    context "when the id's class does not store object ids" do
+
+      let(:constrainable) do
+        Alert.belongs_to :account
+      end
+
+      it "returns the object" do
+        expect(constrainable.convert_to_foreign_key("testing")).to eq("testing")
+      end
+    end
+
+    context 'when the association is polymorphic' do
+
+      let(:constrainable) do
+        Post.relations['posteable']
+      end
+
+      let(:result) do
+        constrainable.convert_to_foreign_key(object)
+      end
+
+      context 'when a BSON::ObjectId is passed' do
+
+        let(:object) do
+          BSON::ObjectId.new
+        end
+
+        it 'returns the object id' do
+          expect(result).to eq(object)
+        end
+      end
+
+      context 'when a string is passed' do
+
+        context 'when the string represents an ObjectId' do
+
+          let(:object) do
+            BSON::ObjectId.new.to_s
+          end
+
+          it 'returns the object id' do
+            expect(result).to eq(BSON::ObjectId.from_string(object))
+          end
+        end
+
+        context 'when the string does not represent an ObjectId' do
+
+          let(:object) do
+            'some-other-string'
+          end
+
+          it 'returns the object' do
+            expect(result).to eq(object)
+          end
+        end
+      end
+
+      context 'when a model object is passed' do
+
+        let(:object) do
+          Post.new
+        end
+
+        it 'returns the id' do
+          expect(result).to eq(object.id)
+        end
+      end
+    end
+  end
+end

data/spec/mongoid/{relations → association}/counter_cache_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::CounterCache do
+describe Mongoid::Association::Referenced::CounterCache do
 
   describe "#reset_counters" do