mongoid 6.4.8 → 7.0.13

data/spec/mongoid/{relations → association}/reflections_spec.rb

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Reflections do
+describe Mongoid::Association::Reflections do
 
   class TestClass
     include Mongoid::Document
@@ -20,17 +20,6 @@ describe Mongoid::Relations::Reflections do
       klass.embeds_many(:addresses)
     end
 
-    context "when the name exists" do
-
-      let(:relation) do
-        klass.reflect_on_association(:addresses)
-      end
-
-      it "returns the association metadata" do
-        expect(relation.macro).to eq(:embeds_many)
-      end
-    end
-
     context "when the name does not exist" do
 
       let(:relation) do

data/spec/mongoid/{relations/synchronization_spec.rb → association/syncable_spec.rb}

@@ -1,10 +1,12 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Synchronization do
+describe "Syncable Association" do
 
   before(:all) do
     Mongoid.raise_not_found_error = true
     Person._synced(Person.relations["preferences"])
+    Person.has_and_belongs_to_many :preferences
+    Preference.has_and_belongs_to_many :people
   end
 
   after(:all) do
@@ -27,7 +29,7 @@ describe Mongoid::Relations::Synchronization do
         field :_synced?
       end
     end
-    
+
     let(:model_syncable?) do
       class TestModel
         include Mongoid::Document

data/spec/mongoid/{relations_spec.rb → association_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations do
+describe Mongoid::Association do
 
   before(:all) do
     Person.field(

data/spec/mongoid/atomic/modifiers_spec.rb

@@ -212,7 +212,7 @@ describe Mongoid::Atomic::Modifiers do
         it "adds the push all modifiers" do
           expect(modifiers).to eq(
             { "$push" =>
-                { "addresses" => { '$each' => [
+              { "addresses" => { '$each' => [
                   { "street" => "Oxford St" }
                 ] }
               }
@@ -303,7 +303,7 @@ describe Mongoid::Atomic::Modifiers do
               conflicts: { "$push" =>
                 { "addresses" => { '$each' => [
                     { "street" => "Oxford St" }
-                  ] }
+                  ]}
                 }
               }
             }

data/spec/mongoid/atomic/paths_spec.rb

@@ -265,5 +265,46 @@ describe Mongoid::Atomic::Paths do
         end
       end
     end
+
+    context "when the same class is embedded in multiple associations" do
+
+      let(:customer) do
+        Customer.new
+      end
+
+      context "assignment after saving" do
+
+        it "correctly sets the association for the embedded class" do
+          pending 'MONGOID-5039'
+
+          customer.home_address = CustomerAddress.new
+          customer.work_address = CustomerAddress.new
+
+          expect(customer.home_address.atomic_path).to eq("home_address")
+          expect(customer.work_address.atomic_path).to eq("work_address")
+
+          customer.save!
+
+          customer.home_address = CustomerAddress.new
+          customer.work_address = CustomerAddress.new
+
+          expect(customer.home_address.atomic_path).to eq("home_address")
+          expect(customer.work_address.atomic_path).to eq("work_address")
+        end
+      end
+
+      context "inverse assignment" do
+
+        it "correctly returns the path for each embedded class" do
+          pending 'MONGOID-5039'
+
+          customer.work_address = CustomerAddress.new
+          customer.work_address.addressable = customer
+
+          expect(customer.home_address.atomic_path).to eq("home_address")
+          expect(customer.work_address.atomic_path).to eq("work_address")
+        end
+      end
+    end
   end
 end

data/spec/mongoid/atomic_spec.rb

@@ -76,13 +76,13 @@ describe Mongoid::Atomic do
             person.addresses.build(street: "Oxford St")
           end
 
-          it "returns a $set and $push for modifications" do
+          it "returns a $set and $push with $each for modifications" do
             expect(person.atomic_updates).to eq(
               {
                 "$set" => { "title" => "Sir" },
-                "$push" => { "addresses" => { '$each' => [
+                "$push" => { "addresses" => { "$each" => [
                     { "_id" => "oxford-st", "street" => "Oxford St" }
-                  ]} }
+                  ] } }
               }
             )
           end
@@ -271,7 +271,7 @@ describe Mongoid::Atomic do
                             "_id" => location.id,
                             "name" => "Home"
                           ]
-                        }] }
+                        }]}
                       }
                     }
                   }

data/spec/mongoid/attributes/dynamic_spec.rb

@@ -0,0 +1,153 @@
+# frozen_string_literal: true
+# encoding: utf-8
+
+require "spec_helper"
+
+describe Mongoid::Attributes::Dynamic do
+  shared_examples_for 'dynamic field' do
+    let(:raw_attributes) do
+      {attr_name => 'foo bar'}
+    end
+
+    context 'when reading attributes' do
+      context 'an unsaved model' do
+        it 'can be read' do
+          bar = Bar.new(raw_attributes)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+
+      context 'saved model' do
+        it 'can be read' do
+          bar = Bar.new(raw_attributes)
+          bar.save!
+
+          bar = Bar.find(bar.id)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+
+      context 'when attribute is not set' do
+        it 'cannot be read' do
+          bar = Bar.new
+          expect do
+            bar.send(attr_name)
+          end.to raise_error(NoMethodError)
+        end
+
+        context 'reading via read_attribute' do
+          it 'returns nil' do
+            bar = Bar.new
+            expect(bar.read_attribute(:foo)).to be nil
+          end
+        end
+
+        context 'reading via []' do
+          it 'returns nil' do
+            bar = Bar.new
+            expect(bar[:foo]).to be nil
+          end
+        end
+      end
+    end
+
+    context 'when writing attributes via constructor' do
+      it 'can be written' do
+        bar = Bar.new(raw_attributes)
+        bar.save!
+
+        bar = Bar.find(bar.id)
+        expect(bar.send(attr_name)).to eq('foo bar')
+      end
+    end
+
+    context 'when writing attributes via attributes=' do
+      it 'can be written' do
+        bar = Bar.new
+        bar.attributes = raw_attributes
+        bar.save!
+
+        bar = Bar.find(bar.id)
+        expect(bar.send(attr_name)).to eq('foo bar')
+      end
+    end
+
+    context 'when writing attributes via write_attribute' do
+      it 'can be written' do
+        bar = Bar.new
+        bar.write_attribute(attr_name, 'foo bar')
+        bar.save!
+
+        bar = Bar.find(bar.id)
+        expect(bar.send(attr_name)).to eq('foo bar')
+      end
+    end
+
+    context 'when writing attributes via []=' do
+      context 'string key' do
+        it 'can be written' do
+          bar = Bar.new
+          bar[attr_name.to_s] = 'foo bar'
+          bar.save!
+
+          bar = Bar.find(bar.id)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+
+      context 'symbol key' do
+        it 'can be written' do
+          bar = Bar.new
+          bar[attr_name.to_sym] = 'foo bar'
+          bar.save!
+
+          bar = Bar.find(bar.id)
+          expect(bar.send(attr_name)).to eq('foo bar')
+        end
+      end
+    end
+
+    context 'when writing attributes via #{attribute}=' do
+      context 'when attribute is not already set' do
+        let(:bar) { Bar.new }
+
+        it 'cannot be written' do
+          expect do
+            bar.send("#{attr_name}=", 'foo bar')
+            bar.save!
+          end.to raise_error(NoMethodError)
+        end
+      end
+
+      context 'when attribute is already set' do
+        let(:bar) { Bar.new(attr_name => 'foo bar') }
+
+        it 'can be written' do
+          bar.send("#{attr_name}=", 'new foo bar')
+          bar.save!
+
+          _bar = Bar.find(bar.id)
+          expect(_bar.send(attr_name)).to eq('new foo bar')
+        end
+      end
+    end
+  end
+
+  context 'when attribute name is alphanumeric' do
+    let(:attr_name) { 'foo' }
+
+    it_behaves_like 'dynamic field'
+  end
+
+  context 'when attribute name contains spaces' do
+    let(:attr_name) { 'hello world' }
+
+    it_behaves_like 'dynamic field'
+  end
+
+  context 'when attribute name contains special characters' do
+    let(:attr_name) { 'hello%world' }
+
+    it_behaves_like 'dynamic field'
+  end
+end

data/spec/mongoid/attributes/nested_spec.rb

@@ -12,10 +12,12 @@ describe Mongoid::Attributes::Nested do
 
       before do
         Person.accepts_nested_attributes_for :favorites
+        Person.accepts_nested_attributes_for :children
       end
 
       after do
         Person.send(:undef_method, :favorites_attributes=)
+        Person.send(:undef_method, :children_attributes=)
         Person.nested_attributes.clear
       end
 
@@ -23,9 +25,18 @@ describe Mongoid::Attributes::Nested do
         expect(person).to respond_to(:favorites_attributes=)
       end
 
+      it "does not autosave if the association is embedded" do
+        expect(person).not_to respond_to(:autosave_documents_for_favorites)
+      end
+
+      it "autosaves if the association is not embedded" do
+        expect(person).to respond_to(:autosave_documents_for_children)
+      end
+
       it "adds the method name to the nested attributes list" do
         expect(Person.nested_attributes).to eq({
-          "favorites_attributes" => "favorites_attributes="
+          "favorites_attributes" => "favorites_attributes=",
+          "children_attributes" => "children_attributes="
         })
       end
     end
@@ -41,12 +52,12 @@ describe Mongoid::Attributes::Nested do
         Account.nested_attributes.clear
       end
 
-      let(:metadata) do
+      let(:association) do
         Account.reflect_on_association(:alerts)
       end
 
       it "keeps autosave set to false" do
-        expect(metadata).to_not be_autosave
+        expect(association).to_not be_autosave
       end
     end
   end
@@ -202,11 +213,12 @@ describe Mongoid::Attributes::Nested do
     context "when the relation is a referenced in" do
 
       before do
-        Post.accepts_nested_attributes_for :person
+        Post.accepts_nested_attributes_for :person, autosave: false
       end
 
       after do
-        Post.reset_callbacks(:save)
+        Post.send(:undef_method, :person_attributes=)
+        Post.nested_attributes.clear
       end
 
       let(:post) do
@@ -4381,12 +4393,11 @@ describe Mongoid::Attributes::Nested do
 
     context "when nesting multiple levels and parent is timestamped" do
 
-      before do
-        class Address
-          after_save do
-            addressable.touch
-          end
-        end
+      around do |example|
+        original_relations = Location.relations
+        Location.embedded_in :address, touch: true
+        example.run
+        Location.relations = original_relations
       end
 
       after do
@@ -4766,6 +4777,13 @@ describe Mongoid::Attributes::Nested do
           user.update_attributes(params)
         end
 
+        around do |example|
+          original_relations = User.relations
+          User.has_many :posts, foreign_key: :author_id, validate: false, autosave: true
+          example.run
+          user.relations = original_relations
+        end
+
         let(:post) do
           user.posts.first
         end

data/spec/mongoid/attributes/readonly_spec.rb

@@ -96,30 +96,14 @@ describe Mongoid::Attributes::Readonly do
       context "when updating via the setter" do
 
         it "does not update the first field" do
-          expect {
-            person.title = 'mr'
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
-          expect(person.title).to eq("sir")
-        end
-
-        it "does not update the second field" do
-          expect {
-            person.aliased_timestamp = Time.at(43)
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
-          expect(person.aliased_timestamp).to eq(Time.at(42))
-        end
-
-        it "does not persist the first field" do
-          expect {
-            person.title = 'mr'
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+          person.title = 'mr'
+          person.save
           expect(person.reload.title).to eq("sir")
         end
 
-        it "does not persist the second field" do
-          expect {
-            person.aliased_timestamp = Time.at(43)
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        it "does not update the second field" do
+          person.aliased_timestamp = Time.at(43)
+          person.save
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
@@ -128,19 +112,20 @@ describe Mongoid::Attributes::Readonly do
 
         context 'with single field operation' do
 
-          it "raises an error " do
-            expect {
-              person.inc(score: 1)
-            }.to raise_error(Mongoid::Errors::ReadonlyAttribute)
+          it "updates the field" do
+            person.inc(score: 1)
+            person.save
+            expect(person.reload.score).to eq(2)
           end
         end
 
         context 'with multiple fields operation' do
 
-          it "raises an error " do
-            expect {
-              person.inc(score: 1, age: 1)
-            }.to raise_error(Mongoid::Errors::ReadonlyAttribute)
+          it "updates the fields" do
+            person.inc(score: 1, age: 1)
+            person.save
+            expect(person.reload.score).to eq(2)
+            expect(person.reload.age).to eq(101)
           end
         end
       end
@@ -149,21 +134,20 @@ describe Mongoid::Attributes::Readonly do
 
         context 'with single field operation' do
 
-          it "raises an error " do
-            expect {
-              person.bit(score: { or: 13 })
-            }.to raise_error(Mongoid::Errors::ReadonlyAttribute)
+          it "does the update" do
+            person.bit(score: { or: 13 })
+            person.save
+            expect(person.reload.score).to eq(13)
           end
         end
 
         context 'with multiple fields operation' do
 
-          it "raises an error " do
-            expect {
-              person.bit(
-                age: { and: 13 }, score: { or: 13 }, inte: { and: 13, or: 10 }
-              )
-            }.to raise_error(Mongoid::Errors::ReadonlyAttribute)
+          it "udpates the attribute" do
+            person.bit(age: {and: 13}, score: {or: 13})
+            person.save
+            expect(person.reload.score).to eq(13)
+            expect(person.reload.age).to eq(4)
           end
         end
       end
@@ -171,30 +155,14 @@ describe Mongoid::Attributes::Readonly do
       context "when updating via []=" do
 
         it "does not update the first field" do
-          expect {
-            person[:title] = "mr"
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
-          expect(person.title).to eq("sir")
-        end
-
-        it "does not update the second field" do
-          expect {
-            person[:aliased_timestamp] = Time.at(43)
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
-          expect(person.aliased_timestamp).to eq(Time.at(42))
-        end
-
-        it "does not persist the first field" do
-          expect {
-            person[:title] = "mr"
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+          person[:title] = "mr"
+          person.save
           expect(person.reload.title).to eq("sir")
         end
 
-        it "does not persist the second field" do
-          expect {
-            person[:aliased_timestamp] = Time.at(43)
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        it "does not update the second field" do
+          person[:aliased_timestamp] = Time.at(43)
+          person.save
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
@@ -202,30 +170,14 @@ describe Mongoid::Attributes::Readonly do
       context "when updating via write_attribute" do
 
         it "does not update the first field" do
-          expect {
-            person.write_attribute(:title, "mr")
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
-          expect(person.title).to eq("sir")
-        end
-
-        it "does not update the second field" do
-          expect {
-            person.write_attribute(:aliased_timestamp, Time.at(43))
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
-          expect(person.aliased_timestamp).to eq(Time.at(42))
-        end
-
-        it "does not persist the first field" do
-          expect {
-            person.write_attribute(:title, "mr")
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+          person.write_attribute(:title, "mr")
+          person.save
           expect(person.reload.title).to eq("sir")
         end
 
-        it "does not persist the second field" do
-          expect {
-            person.write_attribute(:aliased_timestamp, Time.at(43))
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        it "does not update the second field" do
+          person.write_attribute(:aliased_timestamp, Time.at(43))
+          person.save
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
@@ -233,30 +185,14 @@ describe Mongoid::Attributes::Readonly do
       context "when updating via update_attributes" do
 
         it "does not update the first field" do
-          expect {
-            person.update_attributes(title: "mr", aliased_timestamp: Time.at(43))
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
-          expect(person.title).to eq("sir")
-        end
-
-        it "does not update the second field" do
-          expect {
-            person.update_attributes(title: "mr", aliased_timestamp: Time.at(43))
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
-          expect(person.aliased_timestamp).to eq(Time.at(42))
-        end
-
-        it "does not persist the first field" do
-          expect {
-            person.update_attributes(title: "mr", aliased_timestamp: Time.at(43))
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+          person.update_attributes(title: "mr", aliased_timestamp: Time.at(43))
+          person.save
           expect(person.reload.title).to eq("sir")
         end
 
-        it "does not persist the second field" do
-          expect {
-            person.update_attributes(title: "mr", aliased_timestamp: Time.at(43))
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        it "does not update the second field" do
+          person.update_attributes(title: "mr", aliased_timestamp: Time.at(43))
+          person.save
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
@@ -264,30 +200,14 @@ describe Mongoid::Attributes::Readonly do
       context "when updating via update_attributes!" do
 
         it "does not update the first field" do
-          expect {
-            person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
-          expect(person.title).to eq("sir")
-        end
-
-        it "does not update the second field" do
-          expect {
-            person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
-          expect(person.aliased_timestamp).to eq(Time.at(42))
-        end
-
-        it "does not persist the first field" do
-          expect {
-            person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+          person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
+          person.save
           expect(person.reload.title).to eq("sir")
         end
 
-        it "does not persist the second field" do
-          expect {
-            person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
-          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        it "does not update the second field" do
+          person.update_attributes!(title: "mr", aliased_timestamp: Time.at(43))
+          person.save
           expect(person.reload.aliased_timestamp).to eq(Time.at(42))
         end
       end
@@ -297,7 +217,7 @@ describe Mongoid::Attributes::Readonly do
         it "raises an error" do
           expect {
             person.update_attribute(:title, "mr")
-          }.to raise_error(Mongoid::Errors::ReadonlyAttribute)
+          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
         end
       end
 
@@ -306,9 +226,44 @@ describe Mongoid::Attributes::Readonly do
         it "raises an error" do
           expect {
             person.remove_attribute(:title)
-          }.to raise_error(Mongoid::Errors::ReadonlyAttribute)
+          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
         end
       end
     end
+
+    context 'when a foreign_key is defined as readonly' do
+
+      let(:attributes) do
+        :mother_id
+      end
+
+      context 'when the relation exists' do
+
+        let(:mother) do
+          Person.create
+        end
+
+        let(:child) do
+          Person.create(mother: mother)
+          Person.find_by(mother: mother)
+        end
+
+        it 'the relation can still be accessed' do
+          expect(child.mother).to eq(mother)
+        end
+      end
+
+      context 'when the relation does not exist' do
+
+        let(:child) do
+          Person.create
+        end
+
+        it 'the relation is nil' do
+          expect(child.mother).to be_nil
+        end
+      end
+
+    end
   end
 end