mongoid 6.4.8 → 7.0.13

data/spec/mongoid/extensions/array_spec.rb

@@ -204,14 +204,10 @@ describe Mongoid::Extensions::Array do
 
     context "when the related model uses object ids" do
 
-      let(:metadata) do
+      let(:association) do
         Person.relations["preferences"]
       end
 
-      let(:constraint) do
-        metadata.constraint
-      end
-
       context "when provided an object id" do
 
         let(:object_id) do
@@ -219,7 +215,7 @@ describe Mongoid::Extensions::Array do
         end
 
         let(:fk) do
-          Array.__mongoize_fk__(constraint, object_id)
+          Array.__mongoize_fk__(association, object_id)
         end
 
         it "returns the object id as an array" do
@@ -234,7 +230,7 @@ describe Mongoid::Extensions::Array do
         end
 
         let(:fk) do
-          Array.__mongoize_fk__(constraint, [ object_id ])
+          Array.__mongoize_fk__(association, [ object_id ])
         end
 
         it "returns the object ids" do
@@ -251,7 +247,7 @@ describe Mongoid::Extensions::Array do
           end
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, object_id.to_s)
+            Array.__mongoize_fk__(association, object_id.to_s)
           end
 
           it "returns the object id in an array" do
@@ -266,7 +262,7 @@ describe Mongoid::Extensions::Array do
           end
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, string)
+            Array.__mongoize_fk__(association, string)
           end
 
           it "returns the string in an array" do
@@ -277,7 +273,7 @@ describe Mongoid::Extensions::Array do
         context "when the string is blank" do
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, "")
+            Array.__mongoize_fk__(association, "")
           end
 
           it "returns an empty array" do
@@ -289,7 +285,7 @@ describe Mongoid::Extensions::Array do
       context "when provided nil" do
 
         let(:fk) do
-          Array.__mongoize_fk__(constraint, nil)
+          Array.__mongoize_fk__(association, nil)
         end
 
         it "returns an empty array" do
@@ -306,7 +302,7 @@ describe Mongoid::Extensions::Array do
           end
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, [ object_id.to_s ])
+            Array.__mongoize_fk__(association, [ object_id.to_s ])
           end
 
           it "returns the object id in an array" do
@@ -321,7 +317,7 @@ describe Mongoid::Extensions::Array do
           end
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, [ string ])
+            Array.__mongoize_fk__(association, [ string ])
           end
 
           it "returns the string in an array" do
@@ -332,7 +328,7 @@ describe Mongoid::Extensions::Array do
         context "when the strings are blank" do
 
           let(:fk) do
-            Array.__mongoize_fk__(constraint, [ "", "" ])
+            Array.__mongoize_fk__(association, [ "", "" ])
           end
 
           it "returns an empty array" do
@@ -344,7 +340,7 @@ describe Mongoid::Extensions::Array do
       context "when provided nils" do
 
         let(:fk) do
-          Array.__mongoize_fk__(constraint, [ nil, nil, nil ])
+          Array.__mongoize_fk__(association, [ nil, nil, nil ])
         end
 
         it "returns an empty array" do

data/spec/mongoid/extensions/hash_spec.rb

@@ -230,10 +230,27 @@ describe Mongoid::Extensions::Hash do
     it "should retrieve a nested value under the provided key" do
       expect(nested).to eq "hundred"
     end
+
+    context 'and the value is falsey' do
+      let(:hash) do
+        { "100" => { "name" => false } }
+      end
+      it "should retrieve the falsey nested value under the provided key" do
+        expect(nested).to eq false
+      end
+    end
+
+    context 'and the value is nil' do
+      let(:hash) do
+        { "100" => { 0 => "Please don't return this value!" } }
+      end
+      it "should retrieve the nil nested value under the provided key" do
+        expect(nested).to eq nil
+      end
+    end
   end
 
   context "when the hash key is an integer" do
-
     let(:hash) do
       { 100 => { "name" => "hundred" } }
     end

data/spec/mongoid/extensions/object_spec.rb

@@ -39,14 +39,10 @@ describe Mongoid::Extensions::Object do
 
     context "when the related model uses object ids" do
 
-      let(:metadata) do
+      let(:association) do
         Game.relations["person"]
       end
 
-      let(:constraint) do
-        metadata.constraint
-      end
-
       context "when provided an object id" do
 
         let(:object_id) do
@@ -54,7 +50,7 @@ describe Mongoid::Extensions::Object do
         end
 
         let(:fk) do
-          Object.__mongoize_fk__(constraint, object_id)
+          Object.__mongoize_fk__(association, object_id)
         end
 
         it "returns the object id" do
@@ -71,7 +67,7 @@ describe Mongoid::Extensions::Object do
           end
 
           let(:fk) do
-            Object.__mongoize_fk__(constraint, object_id.to_s)
+            Object.__mongoize_fk__(association, object_id.to_s)
           end
 
           it "returns the object id" do
@@ -86,7 +82,7 @@ describe Mongoid::Extensions::Object do
           end
 
           let(:fk) do
-            Object.__mongoize_fk__(constraint, string)
+            Object.__mongoize_fk__(association, string)
           end
 
           it "returns the string" do
@@ -97,7 +93,7 @@ describe Mongoid::Extensions::Object do
         context "when the string is blank" do
 
           let(:fk) do
-            Object.__mongoize_fk__(constraint, "")
+            Object.__mongoize_fk__(association, "")
           end
 
           it "returns nil" do
@@ -109,7 +105,7 @@ describe Mongoid::Extensions::Object do
       context "when provided nil" do
 
         let(:fk) do
-          Object.__mongoize_fk__(constraint, nil)
+          Object.__mongoize_fk__(association, nil)
         end
 
         it "returns nil" do
@@ -120,7 +116,7 @@ describe Mongoid::Extensions::Object do
       context "when provided an empty array" do
 
         let(:fk) do
-          Object.__mongoize_fk__(constraint, [])
+          Object.__mongoize_fk__(association, [])
         end
 
         it "returns an empty array" do

data/spec/mongoid/extensions/range_spec.rb

@@ -139,6 +139,13 @@ describe Mongoid::Extensions::Range do
         expect(("a".."z").mongoize).to eq({ "min" => "a", "max" => "z" })
       end
     end
+
+    context 'when the value is a string' do
+
+      it 'returns a string' do
+        expect(Range.mongoize('3')).to eq('3')
+      end
+    end
   end
 
   describe "#resizable?" do

data/spec/mongoid/factory_spec.rb

@@ -92,7 +92,7 @@ describe Mongoid::Factory do
     context "when the type is a symbol" do
 
       let(:person) do
-        described_class.build(Person, {:_type => "Doctor"})
+        described_class.build(Person, { :_type => "Doctor" })
       end
 
       it "instantiates the subclass" do
@@ -106,11 +106,11 @@ describe Mongoid::Factory do
     context "when the attributes are nil" do
 
       let(:document) do
-        described_class.from_db(Address, nil)
+        described_class.from_db(Animal, nil)
       end
 
       it "generates based on the provided class" do
-        expect(document).to be_a(Address)
+        expect(document).to be_a(Animal)
       end
 
       it "sets the attributes to empty" do
@@ -192,5 +192,23 @@ describe Mongoid::Factory do
         expect(document.title).to eq("Sir")
       end
     end
+
+    context 'when type does not correspond to a Class name' do
+
+      let(:attributes) do
+        { "title" => "Sir", "_type" => "invalid_class_name" }
+      end
+
+      let(:person) do
+        described_class.from_db(Person, attributes)
+      end
+
+      it 'raises a exception' do
+        expect {
+          person
+        }.to raise_exception(Mongoid::Errors::UnknownModel)
+      end
+
+    end
   end
 end

data/spec/mongoid/fields/foreign_key_spec.rb

@@ -7,7 +7,7 @@ describe Mongoid::Fields::ForeignKey do
     let(:field) do
       described_class.new(
         :vals,
-        metadata: Person.relations["preferences"],
+        association: Person.relations["preferences"],
         type: Array,
         default: [],
         identity: true
@@ -68,7 +68,7 @@ describe Mongoid::Fields::ForeignKey do
     let(:field) do
       described_class.new(
         :vals,
-        metadata: Person.relations["posts"],
+        association: Person.relations["posts"],
         type: Array,
         default: default,
         identity: true
@@ -89,7 +89,7 @@ describe Mongoid::Fields::ForeignKey do
     let(:field) do
       described_class.new(
         :vals,
-        metadata: Person.relations["posts"],
+        association: Person.relations["posts"],
         type: Array,
         default: [],
         identity: true
@@ -103,14 +103,14 @@ describe Mongoid::Fields::ForeignKey do
 
   describe "#evolve" do
 
-    let(:metadata) do
+    let(:association) do
       Person.reflect_on_association(:preferences)
     end
 
     context "when provided a document" do
 
       let(:field) do
-        described_class.new(:person_id, type: Object, metadata: metadata)
+        described_class.new(:person_id, type: Object, association: association)
       end
 
       let(:game) do
@@ -129,7 +129,7 @@ describe Mongoid::Fields::ForeignKey do
     context "when the type is an array" do
 
       let(:field) do
-        described_class.new(:preference_ids, type: Array, default: [], metadata: metadata)
+        described_class.new(:preference_ids, type: Array, default: [], association: association)
       end
 
       context "when providing a single value" do
@@ -197,12 +197,12 @@ describe Mongoid::Fields::ForeignKey do
 
           context "when the relation stores ids as strings" do
 
-            let!(:metadata) do
+            let!(:association) do
               Agent.reflect_on_association(:accounts)
             end
 
             let!(:field) do
-              described_class.new(:account_ids, type: Array, default: [], metadata: metadata)
+              described_class.new(:account_ids, type: Array, default: [], association: association)
             end
 
             let(:id_one) do
@@ -260,12 +260,12 @@ describe Mongoid::Fields::ForeignKey do
 
     context "when the type is an object" do
 
-      let(:metadata) do
+      let(:association) do
         Game.reflect_on_association(:person)
       end
 
       let(:field) do
-        described_class.new(:person_id, type: Object, metadata: metadata)
+        described_class.new(:person_id, type: Object, association: association)
       end
 
       context "when providing a single value" do
@@ -312,12 +312,12 @@ describe Mongoid::Fields::ForeignKey do
 
         context "when the relation stores string ids" do
 
-          let(:metadata) do
+          let(:association) do
             Comment.reflect_on_association(:account)
           end
 
           let(:field) do
-            described_class.new(:person_id, type: Object, metadata: metadata)
+            described_class.new(:person_id, type: Object, association: association)
           end
 
           context "when the value is an id string" do
@@ -384,12 +384,12 @@ describe Mongoid::Fields::ForeignKey do
 
           context "when the relation stores ids as strings" do
 
-            let(:metadata) do
+            let(:association) do
               Comment.reflect_on_association(:account)
             end
 
             let(:field) do
-              described_class.new(:person_id, type: Object, metadata: metadata)
+              described_class.new(:person_id, type: Object, association: association)
             end
 
             let(:id_one) do
@@ -445,14 +445,14 @@ describe Mongoid::Fields::ForeignKey do
       end
     end
 
-    context "when the metadata is polymoprhic" do
+    context "when the association is polymoprhic" do
 
-      let(:metadata) do
+      let(:association) do
         Agent.reflect_on_association(:names)
       end
 
       let(:field) do
-        described_class.new(:nameable_id, type: Object, metadata: metadata)
+        described_class.new(:nameable_id, type: Object, association: association)
       end
 
       let(:value) do
@@ -464,7 +464,7 @@ describe Mongoid::Fields::ForeignKey do
       end
 
       it "does not change the foreign key" do
-        expect(evolved).to be(value)
+        expect(evolved).to eq(BSON::ObjectId.from_string(value))
       end
     end
   end
@@ -500,12 +500,8 @@ describe Mongoid::Fields::ForeignKey do
 
       context "when the array is object ids" do
 
-        let(:metadata) do
-          Mongoid::Relations::Metadata.new(
-            inverse_class_name: "Game",
-            name: :person,
-            relation: Mongoid::Relations::Referenced::In
-          )
+        let(:association) do
+          Game.relations["person"]
         end
 
         let(:field) do
@@ -514,7 +510,7 @@ describe Mongoid::Fields::ForeignKey do
             type: Array,
             default: [],
             identity: true,
-            metadata: metadata,
+            association: association,
             overwrite: true
           )
         end
@@ -589,12 +585,8 @@ describe Mongoid::Fields::ForeignKey do
 
       context "when the array is object ids" do
 
-        let(:metadata) do
-          Mongoid::Relations::Metadata.new(
-            inverse_class_name: "Game",
-            name: :person,
-            relation: Mongoid::Relations::Referenced::In
-          )
+        let(:association) do
+          Game.relations['person']
         end
 
         let(:field) do
@@ -603,7 +595,7 @@ describe Mongoid::Fields::ForeignKey do
             type: Object,
             default: nil,
             identity: true,
-            metadata: metadata,
+            association: association,
             overwrite: true
           )
         end

data/spec/mongoid/fields_spec.rb

@@ -816,7 +816,7 @@ describe Mongoid::Fields do
 
     context "when the field name conflicts with mongoid's internals" do
 
-      [:__metadata, :invalid].each do |meth|
+      [:_association, :invalid].each do |meth|
         context "when the field is named #{meth}" do
 
           it "raises an error" do

data/spec/mongoid/indexable_spec.rb

@@ -45,7 +45,7 @@ describe Mongoid::Indexable do
       end
     end
 
-    context "when database specific options exist", if: non_legacy_server? do
+    context "when database specific options exist" do
 
       let(:klass) do
         Class.new do
@@ -89,12 +89,13 @@ describe Mongoid::Indexable do
         klass.create_indexes
       end
 
-      it "creates the indexes" do
-        expect(klass.collection.indexes.get(_type: 1)).to_not be_nil
+      it "creates the indexes by using specified background option" do
+        index = klass.collection.indexes.get(_type: 1)
+        expect(index[:background]).to eq(true)
       end
     end
 
-    context "when database options are specified", if: non_legacy_server? do
+    context "when database options are specified" do
 
       let(:klass) do
         Class.new do
@@ -104,12 +105,9 @@ describe Mongoid::Indexable do
         end
       end
 
-      before do
-        klass.create_indexes
-      end
-
       after do
         klass.remove_indexes
+        Mongoid::Config.background_indexing = false
       end
 
       let(:indexes) do
@@ -118,12 +116,25 @@ describe Mongoid::Indexable do
         end
       end
 
-      it "creates the indexes" do
-        expect(indexes.get(_type: 1)).to_not be_nil
+      it "creates the indexes by using default background_indexing option" do
+        klass.create_indexes
+
+        index = indexes.get(_type: 1)
+        expect(index[:background]).to eq(Mongoid::Config.background_indexing)
+      end
+
+      it "creates the indexes by using specified background_indexing option" do
+        Mongoid::Config.background_indexing = true
+
+        klass.create_indexes
+
+        index = indexes.get(_type: 1)
+        expect(index[:background]).to eq(true)
       end
     end
 
-    context "when a collation option is specified", if: collation_supported? do
+    context "when a collation option is specified" do
+      min_server_version '3.4'
 
       let(:klass) do
         Class.new do
@@ -298,7 +309,8 @@ describe Mongoid::Indexable do
       end
     end
 
-    context "when providing a collation option", if: collation_supported? do
+    context "when providing a collation option" do
+      min_server_version '3.4'
 
       before do
         klass.index({ name: 1 }, collation: { locale: 'en_US', strength: 2 })

data/spec/mongoid/interceptable_spec.rb

@@ -526,6 +526,8 @@ describe Mongoid::Interceptable do
           end
 
           after(:all) do
+            # ActiveSupport may raise an error when trying to reset callbacks on all of Band's
+            # descendants, regardless of whether they have a particular callback defined.
             begin; Band.reset_callbacks(:rearrange); rescue; end
           end
 
@@ -597,7 +599,7 @@ describe Mongoid::Interceptable do
       it "raises an error" do
         expect {
           Band.has_and_belongs_to_many :tags, cascade_callbacks: true
-        }.to raise_error(Mongoid::Errors::InvalidOptions)
+        }.to raise_error(Mongoid::Errors::InvalidRelationOption)
       end
     end
 
@@ -1181,6 +1183,25 @@ describe Mongoid::Interceptable do
           end
         end
 
+        context 'when the parent is updated' do
+
+          let(:band) do
+            Band.create(name: "Moderat")
+          end
+
+          before do
+            band.update(records: [ { name: 'Black on Both Sides' }])
+          end
+
+          it 'executes the callback' do
+            expect(band.records.first.before_validation_called).to be true
+          end
+
+          it 'persists the change' do
+            expect(band.reload.records.first.before_validation_called).to be true
+          end
+        end
+
         context "when the child is persisted" do
 
           let(:band) do

data/spec/mongoid/matchable/default_spec.rb

@@ -68,7 +68,7 @@ describe Mongoid::Matchable::Default do
         context "when the value is a regexp" do
 
           it "returns true" do
-            expect(matcher._matches?(/^Test[3-5]$/)).to be true
+            expect(matcher._matches?(/\ATest[3-5]\z/)).to be true
           end
         end
       end
@@ -112,14 +112,21 @@ describe Mongoid::Matchable::Default do
         described_class.new(["Test1", "Test2", "Test3"])
       end
 
-      context "when the attribute contains the value" do
+      context "when the attribute equals the value" do
 
         it "returns true" do
           expect(matcher._matches?(["Test1", "Test2", "Test3"])).to be true
         end
       end
 
-      context "when the attribute does not contain the value" do
+      context "when the value contains same items as attribute but in different order" do
+
+        it "returns false" do
+          expect(matcher._matches?(["Test1", "Test3", "Test2"])).to be false
+        end
+      end
+
+      context "when the value is a subset of attribute" do
 
         it "returns false" do
           expect(matcher._matches?(["Test1", "Test2"])).to be false

data/spec/mongoid/matchable/elem_match_spec.rb

@@ -53,6 +53,19 @@ describe Mongoid::Matchable::ElemMatch do
           expect(matcher._matches?("$elemMatch" => {"a" => {"$in" => [1]}, "b" => {"$gt" => 1}})).to be true
         end
       end
+
+      context "when using a $not operator that matches" do
+
+        it "returns true" do
+          expect(matcher._matches?("$elemMatch" => {"a" => {"$not" => 4}})).to be true
+        end
+      end
+    end
+
+    context "when using symbols and a :$not operator that matches" do
+      it "returns true" do
+        expect(matcher._matches?(:$elemMatch => {"a" => {:$not => 4}})).to be true
+      end
     end
 
     context "when there is not a sub document that matches the criteria" do
@@ -74,6 +87,13 @@ describe Mongoid::Matchable::ElemMatch do
           expect(matcher._matches?("$elemMatch" => {"a" => {"$in" => [1]}, "b" => {"$gt" => 10}})).to be false
         end
       end
+
+      context "when using a $not operator that does not match" do
+
+        it "returns true" do
+          expect(matcher._matches?("$elemMatch" => {"a" => {"$not" => 1}})).to be true
+        end
+      end
     end
 
     context "when using a criteria that matches partially but not a single sub document" do