mongoid 6.4.8 → 7.0.13

data/spec/mongoid/{relations/bindings/referenced/many_to_many_spec.rb → association/referenced/has_and_belongs_to_many/binding_spec.rb}

@@ -1,6 +1,6 @@
 require "spec_helper"
 
-describe Mongoid::Relations::Bindings::Referenced::ManyToMany do
+describe Mongoid::Association::Referenced::HasAndBelongsToMany::Binding do
 
   let(:person) do
     Person.new
@@ -11,17 +11,17 @@ describe Mongoid::Relations::Bindings::Referenced::ManyToMany do
   end
 
   let(:target) do
-    Mongoid::Relations::Targets::Enumerable.new([ preference ])
+    Mongoid::Association::Referenced::HasMany::Targets::Enumerable.new([ preference ])
   end
 
-  let(:metadata) do
+  let(:association) do
     Person.relations["preferences"]
   end
 
   describe "#bind_one" do
 
     let(:binding) do
-      described_class.new(person, target, metadata)
+      described_class.new(person, target, association)
     end
 
     context "when the document is bindable" do
@@ -77,7 +77,7 @@ describe Mongoid::Relations::Bindings::Referenced::ManyToMany do
   describe "#unbind_one" do
 
     let(:binding) do
-      described_class.new(person, target, metadata)
+      described_class.new(person, target, association)
     end
 
     context "when the documents are unbindable" do

data/spec/mongoid/association/referenced/has_and_belongs_to_many/buildable_spec.rb

@@ -0,0 +1,121 @@
+require "spec_helper"
+
+describe Mongoid::Association::Referenced::HasAndBelongsToMany::Buildable do
+
+  let(:base) do
+    double
+  end
+
+  let(:options) do
+    { }
+  end
+
+  describe "#build" do
+
+    let(:documents) do
+      association.build(base, object)
+    end
+
+    let(:association) do
+      Mongoid::Association::Referenced::HasAndBelongsToMany.new(Person, :preferences, options)
+    end
+
+    context "when provided ids" do
+
+      let(:object_id) do
+        BSON::ObjectId.new
+      end
+
+      let(:object) do
+        [ object_id ]
+      end
+
+      let(:criteria) do
+        Preference.all_of("_id" => { "$in" => object })
+      end
+
+      it "returns the criteria" do
+        expect(documents).to eq(criteria)
+      end
+    end
+
+    context "when order specified" do
+
+      let(:object_id) do
+        BSON::ObjectId.new
+      end
+
+      let(:options) do
+        {
+          order: :rating.desc
+        }
+      end
+
+      let(:object) do
+        [ object_id ]
+      end
+
+      let(:criteria) do
+        Preference.all_of("_id" => { "$in" => object }).order_by(options[:order])
+      end
+
+      it "returns the criteria" do
+        expect(documents).to eq(criteria)
+      end
+    end
+
+    context "when provided a object" do
+
+      context "when the object is not nil" do
+
+        let(:object) do
+          [ Post.new ]
+        end
+
+        it "returns the objects" do
+          expect(documents).to eq(object)
+        end
+      end
+
+      context "when the object is nil" do
+
+        let(:object) do
+          nil
+        end
+
+        let(:criteria) do
+          Preference.all_of("_id" => { "$in" => [] })
+        end
+
+        it "a criteria object" do
+          expect(documents).to eq(criteria)
+        end
+      end
+    end
+
+    context "when no documents found in the database" do
+
+      context "when the ids are empty" do
+
+        it "returns an empty array" do
+          expect(Person.new.preferences).to be_empty
+        end
+      end
+
+      context "when the ids are incorrect" do
+
+        let(:person) do
+          Person.create
+        end
+
+        before do
+          person.preference_ids = [ BSON::ObjectId.new ]
+        end
+
+        it "returns an empty array" do
+          expect(person.preferences).to be_empty
+        end
+      end
+    end
+  end
+end

data/spec/mongoid/{relations/eager/has_and_belongs_to_many_spec.rb → association/referenced/has_and_belongs_to_many/eager_spec.rb}

@@ -1,6 +1,7 @@
 require "spec_helper"
+require_relative '../has_and_belongs_to_many_models'
 
-describe Mongoid::Relations::Eager::HasAndBelongsToMany do
+describe Mongoid::Association::Referenced::HasAndBelongsToMany::Eager do
 
   describe ".keys_from_docs" do
 
@@ -16,18 +17,18 @@ describe Mongoid::Relations::Eager::HasAndBelongsToMany do
       House.create!
     end
 
-    let(:metadata) do
+    let(:association) do
       Person.reflect_on_association(:houses)
     end
 
     let(:eager) do
-      described_class.new([metadata], docs).tap do |b|
-        b.shift_metadata
+      described_class.new([association], docs).tap do |b|
+        b.send(:shift_association)
       end
     end
 
     it "aggregates by the foreign key" do
-      expect(eager.keys_from_docs).to eq([house.id])
+      expect(eager.send(:keys_from_docs)).to eq([house.id])
     end
   end
 
@@ -41,7 +42,7 @@ describe Mongoid::Relations::Eager::HasAndBelongsToMany do
       Person.create!(houses: 3.times.map { House.create! })
     end
 
-    context "when including the has_and_belongs_to_many relation" do
+    context "when including the has_and_belongs_to_many association" do
 
       it "queries twice" do
         expect_query(2) do
@@ -60,7 +61,7 @@ describe Mongoid::Relations::Eager::HasAndBelongsToMany do
       end
     end
 
-    context "when the relation is not polymorphic" do
+    context "when the association is not polymorphic" do
 
       let(:eager) do
         Person.asc(:_id).includes(:preferences).last
@@ -129,5 +130,23 @@ describe Mongoid::Relations::Eager::HasAndBelongsToMany do
         end
       end
     end
+
+    context "when all the values for the has_and_belongs_to_many association are empty" do
+
+      before do
+        2.times { |i| HabtmmPerson.create! }
+      end
+
+      it "only queries once for the parent documents" do
+        found_person = false
+        expect_query(1) do
+          HabtmmPerson.all.includes(:tickets).each do |person|
+            expect(person.tickets).to eq []
+            found_person = true
+          end
+        end
+        expect(found_person).to be true
+      end
+    end
   end
 end

data/spec/mongoid/association/referenced/has_and_belongs_to_many/proxy_persistence_spec.rb

@@ -0,0 +1,56 @@
+# frozen_string_literal: true
+
+require "spec_helper"
+require_relative '../has_and_belongs_to_many_models'
+
+describe Mongoid::Association::Referenced::HasAndBelongsToMany::Proxy do
+  context 'with primary_key and foreign_key given' do
+    let(:company) { HabtmmCompany.create!(c_id: 123) }
+    let(:employee) { HabtmmEmployee.create!(e_id: 456) }
+
+    before do
+      company.employees << employee
+    end
+
+    it 'references correct field' do
+      expect(company.e_ids).to eq([456])
+    end
+
+    describe 'nullify' do
+      before do
+        company.employees << repl_employee
+        company.save!
+        expect(company.employees.length).to eq(2)
+        repl_employee.habtmm_company_ids = [company.id]
+        repl_employee.save!
+        repl_employee.reload
+        expect(repl_employee.habtmm_company_ids).to eq([company.id])
+      end
+
+      context 'without replacement' do
+        let(:repl_employee) { HabtmmEmployee.create!(e_id: 444) }
+
+        it 'disassociates child from parent' do
+          company.employees.nullify
+          repl_employee.reload
+          expect(repl_employee.habtmm_company_ids).to eq([])
+        end
+      end
+
+      context 'with replacement' do
+        let(:repl_employee) { HabtmmEmployee.create!(e_id: 444) }
+
+        before do
+          company.employees << repl_employee
+          expect(company.employees.length).to eq(2)
+        end
+
+        it 'keeps replacement associated with the parent' do
+          company.employees.nullify([repl_employee])
+          repl_employee.reload
+          expect(repl_employee.habtmm_company_ids).to eq([company.id])
+        end
+      end
+    end
+  end
+end