mongoid 5.4.1 → 7.4.0

data/spec/mongoid/validatable/uniqueness_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Validatable::UniquenessValidator do
@@ -19,34 +21,41 @@ describe Mongoid::Validatable::UniquenessValidator do
         context "when persisting to another collection" do
 
           before do
-            Dictionary.with(collection: "dicts").create(name: "websters")
+            Dictionary.with(collection: "dicts") do |klass|
+              klass.create!(name: "websters")
+            end
           end
 
           context "when the document is not valid" do
 
             let(:websters) do
-              Dictionary.with(collection: "dicts").new(name: "websters")
+              object = nil
+              valid = Dictionary.with(collection: "dicts") do |klass|
+                object = klass.new(name: "websters")
+                object.valid?
+              end
+              { :valid => valid, :object => object }
             end
 
             it "performs the validation on the correct collection" do
-              expect(websters).to_not be_valid
+              expect(websters[:valid]).to be(false)
             end
 
             it "adds the uniqueness error" do
-              websters.valid?
-              expect(websters.errors[:name]).to_not be_nil
+              expect(websters[:object].errors[:name]).to_not be_nil
             end
 
             it "clears the persistence options in the thread local" do
-              websters.valid?
-              expect(Dictionary.persistence_options).to be_nil
+              expect(Dictionary.persistence_context).to eq(Mongoid::PersistenceContext.new(Dictionary))
             end
           end
 
           context "when the document is valid" do
 
             let(:oxford) do
-              Dictionary.with(collection: "dicts").new(name: "oxford")
+              Dictionary.with(collection: "dicts") do |klass|
+                klass.new(name: "oxford")
+              end
             end
 
             it "performs the validation on the correct collection" do
@@ -71,7 +80,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute id is unique" do
 
             let(:dictionary) do
-              Dictionary.create
+              Dictionary.create!
             end
 
             let(:word) do
@@ -163,7 +172,7 @@ describe Mongoid::Validatable::UniquenessValidator do
                 context "when a document with no value exists in the database" do
 
                   before do
-                    Dictionary.create
+                    Dictionary.create!
                   end
 
                   let(:dictionary) do
@@ -181,7 +190,7 @@ describe Mongoid::Validatable::UniquenessValidator do
                 context "when single localization" do
 
                   before do
-                    Dictionary.create(description: "english")
+                    Dictionary.create!(description: "english")
                   end
 
                   let(:dictionary) do
@@ -217,7 +226,7 @@ describe Mongoid::Validatable::UniquenessValidator do
                   context "when single localization" do
 
                     before do
-                      Dictionary.create(description: "english")
+                      Dictionary.create!(description: "english")
                     end
 
                     let(:dictionary) do
@@ -273,7 +282,7 @@ describe Mongoid::Validatable::UniquenessValidator do
                 context "when there are no special characters" do
 
                   before do
-                    Dictionary.create(description: "english")
+                    Dictionary.create!(description: "english")
                   end
 
                   let(:dictionary) do
@@ -288,7 +297,7 @@ describe Mongoid::Validatable::UniquenessValidator do
                 context "when special characters exist" do
 
                   before do
-                    Dictionary.create(description: "english")
+                    Dictionary.create!(description: "english")
                   end
 
                   let(:dictionary) do
@@ -308,7 +317,7 @@ describe Mongoid::Validatable::UniquenessValidator do
                   context "when signle localization" do
 
                     before do
-                      Dictionary.create(description: "english")
+                      Dictionary.create!(description: "english")
                     end
 
                     let(:dictionary) do
@@ -350,7 +359,7 @@ describe Mongoid::Validatable::UniquenessValidator do
                 context "when the document is the match in the database" do
 
                   let!(:dictionary) do
-                    Dictionary.create(description: "english")
+                    Dictionary.create!(description: "english")
                   end
 
                   it "returns true" do
@@ -410,7 +419,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique" do
 
             let!(:oxford) do
-              Dictionary.create(name: "Oxford")
+              Dictionary.create!(name: "Oxford")
             end
 
             let(:dictionary) do
@@ -438,7 +447,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is not the match" do
 
               before do
-                Dictionary.create(name: "Oxford")
+                Dictionary.create!(name: "Oxford")
               end
 
               let!(:dictionary) do
@@ -460,7 +469,7 @@ describe Mongoid::Validatable::UniquenessValidator do
               context "when the field has changed" do
 
                 let!(:dictionary) do
-                  Dictionary.create(name: "Oxford")
+                  Dictionary.create!(name: "Oxford")
                 end
 
                 it "returns true" do
@@ -512,7 +521,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the attribute is not unique" do
 
               before do
-                Dictionary.create(name: "Oxford")
+                Dictionary.create!(name: "Oxford")
               end
 
               let(:dictionary) do
@@ -539,7 +548,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique" do
 
             before do
-              Dictionary.create(name: "Oxford", language: "English")
+              Dictionary.create!(name: "Oxford", language: "English")
             end
 
             let(:dictionary) do
@@ -554,7 +563,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique in the scope" do
 
             before do
-              Dictionary.create(name: "Oxford", language: "English")
+              Dictionary.create!(name: "Oxford", language: "English")
             end
 
             let(:dictionary) do
@@ -569,7 +578,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is not unique with no scope" do
 
             before do
-              Dictionary.create(name: "Oxford", language: "English")
+              Dictionary.create!(name: "Oxford", language: "English")
             end
 
             let(:dictionary) do
@@ -584,7 +593,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is not unique in another scope" do
 
             before do
-              Dictionary.create(name: "Oxford", language: "English")
+              Dictionary.create!(name: "Oxford", language: "English")
             end
 
             let(:dictionary) do
@@ -601,7 +610,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is not the match" do
 
               before do
-                Dictionary.create(name: "Oxford", language: "English")
+                Dictionary.create!(name: "Oxford", language: "English")
               end
 
               let(:dictionary) do
@@ -621,7 +630,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is the match in the database" do
 
               let!(:dictionary) do
-                Dictionary.create(name: "Oxford", language: "English")
+                Dictionary.create!(name: "Oxford", language: "English")
               end
 
               it "returns true" do
@@ -644,7 +653,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique" do
 
             before do
-              Dictionary.create(name: "Oxford", publisher: "Amazon")
+              Dictionary.create!(name: "Oxford", publisher: "Amazon")
             end
 
             let(:dictionary) do
@@ -659,7 +668,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique in the scope" do
 
             before do
-              Dictionary.create(name: "Oxford", publisher: "Amazon")
+              Dictionary.create!(name: "Oxford", publisher: "Amazon")
             end
 
             let(:dictionary) do
@@ -699,7 +708,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is not unique with no scope" do
 
             before do
-              Dictionary.create(name: "Oxford", publisher: "Amazon")
+              Dictionary.create!(name: "Oxford", publisher: "Amazon")
             end
 
             let(:dictionary) do
@@ -714,7 +723,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is not unique in another scope" do
 
             before do
-              Dictionary.create(name: "Oxford", publisher: "Amazon")
+              Dictionary.create!(name: "Oxford", publisher: "Amazon")
             end
 
             let(:dictionary) do
@@ -731,7 +740,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is not the match" do
 
               before do
-                Dictionary.create(name: "Oxford", publisher: "Amazon")
+                Dictionary.create!(name: "Oxford", publisher: "Amazon")
               end
 
               let(:dictionary) do
@@ -751,7 +760,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is the match in the database" do
 
               let!(:dictionary) do
-                Dictionary.create(name: "Oxford", publisher: "Amazon")
+                Dictionary.create!(name: "Oxford", publisher: "Amazon")
               end
 
               it "returns true" do
@@ -762,7 +771,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when one of the scopes is a time" do
 
               before do
-                Dictionary.create(
+                Dictionary.create!(
                   name: "Oxford",
                   publisher: "Amazon",
                   published: 10.days.ago.to_time
@@ -789,20 +798,47 @@ describe Mongoid::Validatable::UniquenessValidator do
           end
         end
 
-        context "when a range scope is provided" do
+        context "when a range condition is provided" do
 
           before do
-            Dictionary.validates_uniqueness_of(:name, :scope => Dictionary.where(:year.gte => 1900, :year.lt => 2000))
-            Dictionary.create(name: "French-English", year: 1950)
-            Dictionary.create(name: "French-English", year: 1960)
+            Dictionary.validates_uniqueness_of(:name,
+              conditions: -> { Dictionary.where(:year.gte => 1900, :year.lt => 2000) })
           end
 
           after do
             Dictionary.reset_callbacks(:validate)
           end
 
-          it "successfully prevents uniqueness violation" do
-            expect(Dictionary.all.size).to eq(1)
+          context 'when multiple documents would match the condition' do
+            it "prevents creation of new document" do
+              Dictionary.create!(name: "French-English", year: 1950)
+
+              expect do
+                Dictionary.create!(name: "French-English", year: 1960)
+              end.to raise_error(Mongoid::Errors::Validations, /Name is already taken/)
+
+              expect(Dictionary.all.size).to eq(1)
+            end
+          end
+
+          context 'when only new document would match the condition' do
+            it 'creates the new document' do
+              Dictionary.create!(name: "French-English", year: 950)
+              expect do
+                Dictionary.create!(name: "French-English", year: 1950)
+              end.not_to raise_error
+            end
+          end
+
+          context 'when only existing document matches the condition' do
+            it 'creates the new document' do
+              pending 'https://jira.mongodb.org/browse/MONGOID-4815'
+
+              Dictionary.create!(name: "French-English", year: 1950)
+              expect do
+                Dictionary.create!(name: "French-English", year: 950)
+              end.not_to raise_error
+            end
           end
         end
 
@@ -819,7 +855,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique" do
 
             before do
-              Dictionary.create(name: "Oxford", publisher: "Amazon")
+              Dictionary.create!(name: "Oxford", publisher: "Amazon")
             end
 
             let(:dictionary) do
@@ -834,7 +870,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique in the scope" do
 
             before do
-              Dictionary.create(
+              Dictionary.create!(
                 name: "Oxford",
                 publisher: "Amazon",
                 year: 2011
@@ -857,7 +893,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is not unique with no scope" do
 
             before do
-              Dictionary.create(name: "Oxford", publisher: "Amazon")
+              Dictionary.create!(name: "Oxford", publisher: "Amazon")
             end
 
             let(:dictionary) do
@@ -872,7 +908,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is not unique in another scope" do
 
             before do
-              Dictionary.create(
+              Dictionary.create!(
                 name: "Oxford",
                 publisher: "Amazon",
                 year: 1995
@@ -897,7 +933,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is not the match" do
 
               before do
-                Dictionary.create(
+                Dictionary.create!(
                   name: "Oxford",
                   publisher: "Amazon",
                   year: 1960
@@ -925,7 +961,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is the match in the database" do
 
               let!(:dictionary) do
-                Dictionary.create(
+                Dictionary.create!(
                   name: "Oxford",
                   publisher: "Amazon",
                   year: 1960
@@ -952,7 +988,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique" do
 
             before do
-              Dictionary.create(name: "Oxford")
+              Dictionary.create!(name: "Oxford")
             end
 
             let(:dictionary) do
@@ -969,7 +1005,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is not the match" do
 
               before do
-                Dictionary.create(name: "Oxford")
+                Dictionary.create!(name: "Oxford")
               end
 
               let(:dictionary) do
@@ -989,7 +1025,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is the match in the database" do
 
               let!(:dictionary) do
-                Dictionary.create(name: "Oxford")
+                Dictionary.create!(name: "Oxford")
               end
 
               it "returns true" do
@@ -1014,7 +1050,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when there are no special characters" do
 
               before do
-                Dictionary.create(name: "Oxford")
+                Dictionary.create!(name: "Oxford")
               end
 
               let(:dictionary) do
@@ -1029,7 +1065,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when special characters exist" do
 
               before do
-                Dictionary.create(name: "Oxford")
+                Dictionary.create!(name: "Oxford")
               end
 
               let(:dictionary) do
@@ -1047,7 +1083,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is not the match" do
 
               before do
-                Dictionary.create(name: "Oxford")
+                Dictionary.create!(name: "Oxford")
               end
 
               let(:dictionary) do
@@ -1067,7 +1103,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is the match in the database" do
 
               let!(:dictionary) do
-                Dictionary.create(name: "Oxford")
+                Dictionary.create!(name: "Oxford")
               end
 
               it "returns true" do
@@ -1097,7 +1133,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is nil" do
 
             before do
-              Dictionary.create
+              Dictionary.create!
             end
 
             let(:dictionary) do
@@ -1123,7 +1159,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is blank" do
 
             before do
-              Dictionary.create(name: "")
+              Dictionary.create!(name: "")
             end
 
             let(:dictionary) do
@@ -1152,7 +1188,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique" do
 
             before do
-              Login.create(username: "Oxford")
+              Login.create!(username: "Oxford")
             end
 
             let(:login) do
@@ -1169,7 +1205,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is not the match" do
 
               before do
-                Login.create(username: "Oxford")
+                Login.create!(username: "Oxford")
               end
 
               let(:login) do
@@ -1189,7 +1225,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is the match in the database" do
 
               let!(:login) do
-                Login.create(username: "Oxford")
+                Login.create!(username: "Oxford")
               end
 
               it "returns true" do
@@ -1212,7 +1248,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique" do
 
             before do
-              Login.create(username: "Oxford", application_id: 1)
+              Login.create!(username: "Oxford", application_id: 1)
             end
 
             let(:login) do
@@ -1227,7 +1263,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique in the scope" do
 
             before do
-              Login.create(username: "Oxford", application_id: 1)
+              Login.create!(username: "Oxford", application_id: 1)
             end
 
             let(:login) do
@@ -1242,7 +1278,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is not unique with no scope" do
 
             before do
-              Login.create(username: "Oxford", application_id: 1)
+              Login.create!(username: "Oxford", application_id: 1)
             end
 
             let(:login) do
@@ -1257,7 +1293,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is not unique in another scope" do
 
             before do
-              Login.create(username: "Oxford", application_id: 1)
+              Login.create!(username: "Oxford", application_id: 1)
             end
 
             let(:login) do
@@ -1274,7 +1310,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is not the match" do
 
               before do
-                Login.create(username: "Oxford", application_id: 1)
+                Login.create!(username: "Oxford", application_id: 1)
               end
 
               let(:login) do
@@ -1294,7 +1330,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is the match in the database" do
 
               let!(:login) do
-                Login.create(username: "Oxford", application_id: 1)
+                Login.create!(username: "Oxford", application_id: 1)
               end
 
               it "returns true" do
@@ -1317,7 +1353,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is unique" do
 
             before do
-              Login.create(username: "Oxford")
+              Login.create!(username: "Oxford")
             end
 
             let(:login) do
@@ -1334,7 +1370,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is not the match" do
 
               before do
-                Login.create(username: "Oxford")
+                Login.create!(username: "Oxford")
               end
 
               let(:login) do
@@ -1354,7 +1390,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is the match in the database" do
 
               let!(:login) do
-                Login.create(username: "Oxford")
+                Login.create!(username: "Oxford")
               end
 
               it "returns true" do
@@ -1379,7 +1415,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when there are no special characters" do
 
               before do
-                Login.create(username: "Oxford")
+                Login.create!(username: "Oxford")
               end
 
               let(:login) do
@@ -1394,7 +1430,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when special characters exist" do
 
               before do
-                Login.create(username: "Oxford")
+                Login.create!(username: "Oxford")
               end
 
               let(:login) do
@@ -1412,7 +1448,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is not the match" do
 
               before do
-                Login.create(username: "Oxford")
+                Login.create!(username: "Oxford")
               end
 
               let(:login) do
@@ -1432,7 +1468,7 @@ describe Mongoid::Validatable::UniquenessValidator do
             context "when the document is the match in the database" do
 
               let!(:login) do
-                Login.create(username: "Oxford")
+                Login.create!(username: "Oxford")
               end
 
               it "returns true" do
@@ -1455,7 +1491,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is nil" do
 
             before do
-              Login.create
+              Login.create!
             end
 
             let(:login) do
@@ -1481,7 +1517,7 @@ describe Mongoid::Validatable::UniquenessValidator do
           context "when the attribute is blank" do
 
             before do
-              Login.create(username: "")
+              Login.create!(username: "")
             end
 
             let(:login) do
@@ -1508,7 +1544,7 @@ describe Mongoid::Validatable::UniquenessValidator do
         context "when the attribute is unique" do
 
           before do
-            Bar.create(lat_lng: LatLng.new(52.30, 13.25))
+            Bar.create!(lat_lng: LatLng.new(52.30, 13.25))
           end
 
           let(:unique_bar) do
@@ -1524,7 +1560,7 @@ describe Mongoid::Validatable::UniquenessValidator do
         context "when the attribute is not unique" do
 
           before do
-            Bar.create(lat_lng: LatLng.new(52.30, 13.25))
+            Bar.create!(lat_lng: LatLng.new(52.30, 13.25))
           end
 
           let(:non_unique_bar) do
@@ -1551,7 +1587,7 @@ describe Mongoid::Validatable::UniquenessValidator do
         context "when the attribute is unique" do
 
           before do
-            Band.create(name: 'Foo', active: false)
+            Band.create!(name: 'Foo', active: false)
           end
 
           let(:unique_band) do
@@ -1567,7 +1603,7 @@ describe Mongoid::Validatable::UniquenessValidator do
         context "when the attribute is not unique" do
 
           before do
-            Band.create(name: 'Foo')
+            Band.create!(name: 'Foo')
           end
 
           let(:non_unique_band) do
@@ -1585,17 +1621,17 @@ describe Mongoid::Validatable::UniquenessValidator do
   context "when the document is embedded" do
 
     let(:word) do
-      Word.create(name: "Schadenfreude")
+      Word.create!(name: "Schadenfreude")
     end
 
     context "when in an embeds_many" do
 
       let!(:def_one) do
-        word.definitions.create(description: "1")
+        word.definitions.create!(description: "1")
       end
 
       let!(:def_two) do
-        word.definitions.create(description: "2")
+        word.definitions.create!(description: "2")
       end
 
       context "when a document is being destroyed" do
@@ -2417,21 +2453,23 @@ describe Mongoid::Validatable::UniquenessValidator do
 
     before do
       Person.validates_uniqueness_of(:username)
+      Person.index({ ssn: 1 }, { unique: true })
       Person.create_indexes
     end
 
     let!(:person) do
-      Person.create(ssn: "132-11-1111", username: "aaasdaffff")
+      Person.create!(ssn: "132-11-1111", username: "aaasdaffff")
     end
 
     after do
       Person.reset_callbacks(:validate)
+      Person.collection.drop
     end
 
     it "transfers the options to the cloned client" do
       expect {
         Person.create!(ssn: "132-11-1111", username: "asdfsdfA")
-      }.to raise_error
+      }.to raise_error(Mongo::Error::OperationFailure)
     end
   end
 end