mongoid 5.4.1 → 7.4.0

data/spec/mongoid/clients_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Clients do
@@ -6,34 +8,38 @@ describe Mongoid::Clients do
 
     shared_examples_for "an overridden collection at the class level" do
 
-      let(:band) do
-        klass.new
-      end
-
       it "returns the collection for the model" do
-        expect(band.collection).to be_a(Mongo::Collection)
+        expect(instance_collection).to be_a(Mongo::Collection)
       end
 
       it "sets the correct collection name" do
-        expect(band.collection.name).to eq("artists")
+        expect(instance_collection.name).to eq("artists")
       end
 
       context "when accessing from the class level" do
 
         it "returns the collection for the model" do
-          expect(klass.collection).to be_a(Mongo::Collection)
+          expect(class_collection).to be_a(Mongo::Collection)
         end
 
         it "sets the correct collection name" do
-          expect(klass.collection.name).to eq("artists")
+          expect(class_collection.name).to eq("artists")
         end
       end
     end
 
     context "when overriding the persistence options" do
 
-      let(:klass) do
-        Band.with(collection: "artists")
+      let(:instance_collection) do
+        Band.with(collection: "artists") do |klass|
+          klass.new.collection
+        end
+      end
+
+      let(:class_collection) do
+        Band.with(collection: "artists") do |klass|
+          klass.collection
+        end
       end
 
       it_behaves_like "an overridden collection at the class level"
@@ -41,10 +47,6 @@ describe Mongoid::Clients do
 
     context "when overriding store_in and persistence options" do
 
-      let(:klass) do
-        Band.with(collection: "artists")
-      end
-
       before do
         Band.store_in collection: "foo"
       end
@@ -53,6 +55,18 @@ describe Mongoid::Clients do
         Band.reset_storage_options!
       end
 
+      let(:instance_collection) do
+        Band.with(collection: "artists") do |klass|
+          klass.new.collection
+        end
+      end
+
+      let(:class_collection) do
+        Band.with(collection: "artists") do |klass|
+          klass.collection
+        end
+      end
+
       it_behaves_like "an overridden collection at the class level"
     end
 
@@ -77,19 +91,23 @@ describe Mongoid::Clients do
 
       context "when overriding with a proc" do
 
-        let(:klass) { Band }
-
         before do
           Band.store_in(collection: ->{ "artists" })
         end
 
+        let(:instance_collection) do
+          Band.new.collection
+        end
+
+        let(:class_collection) do
+          Band.collection
+        end
+
         it_behaves_like "an overridden collection at the class level"
       end
 
       context "when overriding with a string" do
 
-        let(:klass) { Band }
-
         before do
           Band.store_in(collection: "artists")
         end
@@ -98,19 +116,33 @@ describe Mongoid::Clients do
           Band.reset_storage_options!
         end
 
+        let(:instance_collection) do
+          Band.new.collection
+        end
+
+        let(:class_collection) do
+          Band.collection
+        end
+
         it_behaves_like "an overridden collection at the class level"
       end
 
       context "when overriding with a symbol" do
 
-        let(:klass) { Band }
-
         before do
-          klass.store_in(collection: :artists)
+          Band.store_in(collection: :artists)
         end
 
         after do
-          klass.reset_storage_options!
+          Band.reset_storage_options!
+        end
+
+        let(:instance_collection) do
+          Band.new.collection
+        end
+
+        let(:class_collection) do
+          Band.collection
         end
 
         it_behaves_like "an overridden collection at the class level"
@@ -148,38 +180,116 @@ describe Mongoid::Clients do
 
     shared_examples_for "an overridden collection name at the class level" do
 
-      let(:band) do
-        klass.new
-      end
-
       context "when accessing from the instance" do
 
         it "returns the overridden value" do
-          expect(band.collection_name).to eq(:artists)
+          expect(instance_collection_name).to eq(:artists)
         end
       end
 
       context "when accessing from the class level" do
 
         it "returns the overridden value" do
-          expect(klass.collection_name).to eq(:artists)
+          expect(class_collection_name).to eq(:artists)
         end
       end
     end
 
     context "when overriding the persistence options" do
 
-      let(:klass) do
-        Band.with(collection: "artists")
+      let(:instance_collection_name) do
+        Band.with(collection: "artists") do |klass|
+          klass.new.collection_name
+        end
+      end
+
+      let(:class_collection_name) do
+        Band.with(collection: "artists") do |klass|
+          klass.collection_name
+        end
       end
 
       it_behaves_like "an overridden collection name at the class level"
+
+      context 'when nesting #with calls' do
+        let(:instance_collection_name) do
+          Band.with(collection: "ignore") do |klass|
+            Band.with(collection: "artists") do |klass|
+              klass.new.collection_name
+            end
+          end
+        end
+
+        let(:class_collection_name) do
+          Band.with(collection: "ignore") do |klass|
+            Band.with(collection: "artists") do |klass|
+              klass.collection_name
+            end
+          end
+        end
+
+        it_behaves_like "an overridden collection name at the class level"
+      end
+
+      context 'when outer #with call specifies the collection' do
+        use_spec_mongoid_config
+
+        let(:instance_collection_name) do
+          Band.with(collection: "artists") do |klass|
+            Band.with(client: :reports) do |klass|
+              klass.new.collection_name
+            end
+          end
+        end
+
+        let(:class_collection_name) do
+          Band.with(collection: "artists") do |klass|
+            Band.with(client: :reports) do |klass|
+              klass.collection_name
+            end
+          end
+        end
+
+        it_behaves_like "an overridden collection name at the class level"
+      end
+
+      context 'restores outer context in outer block' do
+        use_spec_mongoid_config
+
+        let(:instance_collection_name) do
+          Band.with(collection: "artists") do |klass|
+            Band.with(collection: "scratch") do |klass|
+              # nothing
+            end
+            klass.new.collection_name
+          end
+        end
+
+        let(:class_collection_name) do
+          Band.with(collection: "artists") do |klass|
+            Band.with(collection: "scratch") do |klass|
+              # nothing
+            end
+            klass.collection_name
+          end
+        end
+
+        it_behaves_like "an overridden collection name at the class level"
+      end
     end
 
     context "when overriding store_in and persistence options" do
 
-      let(:klass) do
-        Band.with(collection: "artists")
+      let(:instance_collection_name) do
+        Band.with(collection: "artists") do |klass|
+          klass.new.collection_name
+        end
+      end
+
+      let(:class_collection_name) do
+        Band.with(collection: "artists") do |klass|
+          klass.collection_name
+        end
       end
 
       before do
@@ -195,7 +305,13 @@ describe Mongoid::Clients do
 
     context "when overriding the default with store_in" do
 
-      let(:klass) { Band }
+      let(:instance_collection_name) do
+        Band.new.collection_name
+      end
+
+      let(:class_collection_name) do
+        Band.collection_name
+      end
 
       after do
         Band.reset_storage_options!
@@ -266,38 +382,51 @@ describe Mongoid::Clients do
     end
   end
 
-  describe "#database_name", if: non_legacy_server? do
+  describe "#database_name" do
 
     shared_examples_for "an overridden database name" do
 
-      let(:band) do
-        klass.new
+      after do
+        class_mongo_client.close
       end
 
       context "when accessing from the instance" do
 
         it "returns the overridden value" do
-          # @todo
-          # expect(band.mongo_client.options[:database].to_s).to eq(database_id_alt)
+          expect(instance_database.name.to_s).to eq(database_id_alt)
         end
       end
 
       context "when accessing from the class level" do
 
         it "returns the overridden value" do
-          expect(klass.database_name.to_s).to eq(database_id_alt)
+          expect(class_database.name.to_s).to eq(database_id_alt)
         end
 
         it "client returns the overridden value" do
-          expect(klass.mongo_client.options[:database].to_s).to eq(database_id_alt)
+          expect(class_mongo_client.database.name).to eq(database_id_alt)
         end
       end
     end
 
     context "when overriding the persistence options" do
 
-      let(:klass) do
-        Band.with(database: database_id_alt)
+      let(:instance_database) do
+        Band.with(database: database_id_alt) do |klass|
+          klass.new.mongo_client.database
+        end
+      end
+
+      let(:class_database) do
+        Band.with(database: database_id_alt) do |klass|
+          klass.mongo_client.database
+        end
+      end
+
+      let(:class_mongo_client) do
+        Band.with(database: database_id_alt) do |klass|
+          klass.new.mongo_client
+        end
       end
 
       it_behaves_like "an overridden database name"
@@ -305,7 +434,17 @@ describe Mongoid::Clients do
 
     context "when overriding with store_in" do
 
-      let(:klass) { Band }
+      let(:instance_database) do
+        Band.new.mongo_client.database
+      end
+
+      let(:class_database) do
+        Band.mongo_client.database
+      end
+
+      let(:class_mongo_client) do
+        Band.mongo_client
+      end
 
       before do
         Band.store_in database: database_id_alt
@@ -313,6 +452,7 @@ describe Mongoid::Clients do
 
       after do
         Band.reset_storage_options!
+        class_mongo_client.close
       end
 
       it_behaves_like "an overridden database name"
@@ -320,8 +460,22 @@ describe Mongoid::Clients do
 
     context "when overriding store_in and persistence options" do
 
-      let(:klass) do
-        Band.with(database: database_id_alt)
+      let(:instance_database) do
+        Band.with(database: database_id_alt) do |klass|
+          klass.new.mongo_client.database
+        end
+      end
+
+      let(:class_database) do
+        Band.with(database: database_id_alt) do |klass|
+          klass.mongo_client.database
+        end
+      end
+
+      let(:class_mongo_client) do
+        Band.with(database: database_id_alt) do |klass|
+          klass.new.mongo_client
+        end
       end
 
       before do
@@ -330,6 +484,7 @@ describe Mongoid::Clients do
 
       after do
         Band.reset_storage_options!
+        class_mongo_client.close
       end
 
       it_behaves_like "an overridden database name"
@@ -340,7 +495,7 @@ describe Mongoid::Clients do
       let(:client_name) { :alternative }
 
       before do
-        Mongoid.clients[client_name] = { database: database_id_alt, hosts: [ "#{HOST}:#{PORT}" ] }
+        Mongoid.clients[client_name] = { database: database_id_alt, hosts: SpecConfig.instance.addresses }
       end
 
       after do
@@ -349,8 +504,22 @@ describe Mongoid::Clients do
 
       context "when overriding the persistence options" do
 
-        let(:klass) do
-          Band.with(client: client_name)
+        let(:instance_database) do
+          Band.with(client: :alternative) do |klass|
+            klass.new.mongo_client.database
+          end
+        end
+
+        let(:class_database) do
+          Band.with(client: :alternative) do |klass|
+            klass.mongo_client.database
+          end
+        end
+
+        let(:class_mongo_client) do
+          Band.with(client: :alternative) do |klass|
+            klass.new.mongo_client
+          end
         end
 
         it_behaves_like "an overridden database name"
@@ -358,7 +527,17 @@ describe Mongoid::Clients do
 
       context "when overriding with store_in" do
 
-        let(:klass) { Band }
+        let(:instance_database) do
+          Band.new.mongo_client.database
+        end
+
+        let(:class_database) do
+          Band.mongo_client.database
+        end
+
+        let(:class_mongo_client) do
+          Band.mongo_client
+        end
 
         before do
           Band.store_in(client: client_name)
@@ -366,6 +545,7 @@ describe Mongoid::Clients do
 
         after do
           Band.reset_storage_options!
+          class_mongo_client.close
         end
 
         it_behaves_like "an overridden database name"
@@ -373,7 +553,7 @@ describe Mongoid::Clients do
     end
   end
 
-  describe "#mongo_client", if: non_legacy_server? do
+  describe "#mongo_client" do
 
     let(:file) do
       File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
@@ -397,6 +577,10 @@ describe Mongoid::Clients do
         Mongoid.clients[:default][:database] = database_id
       end
 
+      after do
+        mongo_client.close
+      end
+
       let!(:band) do
         Band.new
       end
@@ -424,10 +608,6 @@ describe Mongoid::Clients do
         Band.store_in(client: :nonexistent)
       end
 
-      after do
-        Band.reset_storage_options!
-      end
-
       let(:band) do
         Band.new
       end
@@ -439,29 +619,19 @@ describe Mongoid::Clients do
       end
     end
 
-    context "when getting a client by name", if: testing_locally? do
-
-      let(:file) do
-        File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
-      end
+    context "when getting a client by name" do
+      use_spec_mongoid_config
 
       before do
-        described_class.clear
-        Mongoid.load!(file, :test)
         Band.store_in(client: :reports)
       end
 
       after do
         mongo_client.close
-        Mongoid::Config.reset
         Band.reset_storage_options!
       end
 
-      let!(:band) do
-        Band.store_in(client: :reports)
-      end
-
-      let!(:mongo_client) do
+      let(:mongo_client) do
         Band.new.mongo_client
       end
 
@@ -497,7 +667,7 @@ describe Mongoid::Clients do
     end
   end
 
-  describe ".mongo_client", if: non_legacy_server? do
+  describe ".mongo_client" do
 
     let(:file) do
       File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
@@ -526,7 +696,7 @@ describe Mongoid::Clients do
         Mongoid.clients[:default][:database] = database_id
       end
 
-      let(:mongo_client) do
+      let!(:mongo_client) do
         Band.mongo_client
       end
 
@@ -557,7 +727,7 @@ describe Mongoid::Clients do
     end
   end
 
-  describe ".store_in", if: non_legacy_server? do
+  describe ".store_in" do
 
     context "when provided a non hash" do
 
@@ -568,7 +738,7 @@ describe Mongoid::Clients do
       end
     end
 
-    context "when provided a class that extend another document" do
+    context "when provided a class that extends another document" do
 
       let(:klass) do
         Class.new(Band)
@@ -594,12 +764,14 @@ describe Mongoid::Clients do
     end
   end
 
-  describe ".with", if: non_legacy_server? do
+  describe ".with" do
 
     context "when changing write concern options" do
 
       let(:client_one) do
-        Band.with(write: { w: 2 }).mongo_client
+        Band.with(write: { w: 2 }) do |klass|
+          klass.mongo_client
+        end
       end
 
       let(:client_two) do
@@ -614,13 +786,17 @@ describe Mongoid::Clients do
     context "when sending operations to a different database" do
 
       after do
-        Band.with(database: database_id_alt).delete_all
+        Band.with(database: database_id_alt) do |klass|
+          klass.delete_all
+        end
       end
 
-      describe ".create" do
+      describe ".create!" do
 
         let!(:band) do
-          Band.with(database: database_id_alt).create
+          Band.with(database: database_id_alt) do |klass|
+            klass.create!
+          end
         end
 
         it "does not persist to the default database" do
@@ -630,25 +806,35 @@ describe Mongoid::Clients do
         end
 
         let(:from_db) do
-          Band.with(database: database_id_alt).find(band.id)
+          Band.with(database: database_id_alt) do |klass|
+            klass.find(band.id)
+          end
         end
 
         it "persists to the specified database" do
           expect(from_db).to eq(band)
         end
 
+        let(:count) do
+          Band.with(database: database_id_alt) do |klass|
+            klass.count
+          end
+        end
+
         it "persists the correct number of documents" do
-          expect(Band.with(database: database_id_alt).count).to eq(1)
+          expect(count).to eq(1)
         end
       end
     end
 
     context "when sending operations to a different collection" do
 
-      describe ".create" do
+      describe ".create!" do
 
         let!(:band) do
-          Band.with(collection: "artists").create
+          Band.with(collection: "artists") do |klass|
+            klass.create!
+          end
         end
 
         it "does not persist to the default database" do
@@ -658,15 +844,23 @@ describe Mongoid::Clients do
         end
 
         let(:from_db) do
-          Band.with(collection: "artists").find(band.id)
+          Band.with(collection: "artists") do |klass|
+            klass.find(band.id)
+          end
         end
 
         it "persists to the specified database" do
           expect(from_db).to eq(band)
         end
 
+        let(:count) do
+          Band.with(collection: "artists") do |klass|
+            klass.count
+          end
+        end
+
         it "persists the correct number of documents" do
-          expect(Band.with(collection: "artists").count).to eq(1)
+          expect(count).to eq(1)
         end
       end
     end
@@ -676,10 +870,15 @@ describe Mongoid::Clients do
       describe ".create" do
 
         before do
+          Person.index({ ssn: 1 }, { unique: true })
           Person.create_indexes
           Person.create(ssn: "432-97-1111")
         end
 
+        after do
+          Person.collection.drop
+        end
+
         context "when no error occurs" do
 
           it "inserts the document" do
@@ -703,6 +902,10 @@ describe Mongoid::Clients do
           Person.create!(ssn: "432-97-1112")
         end
 
+        after do
+          Person.collection.drop
+        end
+
         context "when no error occurs" do
 
           it "inserts the document" do
@@ -713,9 +916,14 @@ describe Mongoid::Clients do
         context "when a mongodb error occurs" do
 
           before do
+            Person.index({ ssn: 1 }, { unique: true })
             Person.create_indexes
           end
 
+          after do
+            Person.collection.drop
+          end
+
           it "bubbles up to the caller" do
             expect {
               Person.create!(ssn: "432-97-1112")
@@ -736,7 +944,7 @@ describe Mongoid::Clients do
       describe ".save" do
 
         before do
-          Person.create(ssn: "432-97-1113")
+          Person.create!(ssn: "432-97-1113")
         end
 
         context "when a mongodb error occurs" do
@@ -746,9 +954,14 @@ describe Mongoid::Clients do
           end
 
           before do
+            Person.index({ ssn: 1 }, { unique: true })
             Person.create_indexes
           end
 
+          after do
+            Person.collection.drop
+          end
+
           it "bubbles up to the caller" do
             expect {
               person.save
@@ -770,9 +983,14 @@ describe Mongoid::Clients do
           end
 
           before do
+            Person.index({ ssn: 1 }, { unique: true })
             Person.create_indexes
           end
 
+          after do
+            Person.collection.drop
+          end
+
           it "bubbles up to the caller" do
             expect {
               person.save!
@@ -796,7 +1014,7 @@ describe Mongoid::Clients do
     end
   end
 
-  context "when overriding the default database", if: non_legacy_server? do
+  context "when overriding the default database" do
 
     let(:file) do
       File.join(File.dirname(__FILE__), "..", "config", "mongoid.yml")
@@ -808,42 +1026,28 @@ describe Mongoid::Clients do
 
     context "when the override is global" do
 
-      shared_examples_for "a global database override" do
-
-        before do
-          Mongoid.override_database(:mongoid_optional)
-        end
-
-        after do
-          Band.delete_all
-          Mongoid.override_database(nil)
-        end
-
-        let!(:band) do
-          klass.create(name: "Tool")
-        end
-
-        it "persists to the overridden database" do
-          mongo_client = Band.mongo_client.with(database: :mongoid_optional)
-          expect(mongo_client[:bands].count(name: "Tool")).to eq(1)
-        end
-
-        it 'uses that database for the model mongo_client' do
-          expect(Band.mongo_client.database.name).to eq('mongoid_optional')
-        end
+      before do
+        Mongoid.override_database(:mongoid_optional)
       end
 
-      context "when normal usage" do
-        let(:klass) { Band }
-
-        it_behaves_like "a global database override"
+      after do
+        Band.delete_all
+        Band.mongo_client.close
+        Mongoid.override_database(nil)
       end
 
-      context "when overriding the persistence options" do
+      let!(:band) do
+        Band.create!(name: "Tool")
+      end
 
-        let(:klass) { Band.with(connect_timeout: 10) }
+      it "persists to the overridden database" do
+        Band.mongo_client.with(database: :mongoid_optional) do |sess|
+          expect(sess[:bands].find(name: "Tool")).to_not be_nil
+        end
+      end
 
-        it_behaves_like "a global database override"
+      it 'uses that database for the model mongo_client' do
+        expect(Band.mongo_client.database.name).to eq('mongoid_optional')
       end
     end
   end