mongoid 5.4.1 → 7.4.0

data/spec/mongoid/attributes/nested_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Attributes::Nested do
@@ -12,10 +14,12 @@ describe Mongoid::Attributes::Nested do
 
       before do
         Person.accepts_nested_attributes_for :favorites
+        Person.accepts_nested_attributes_for :children
       end
 
       after do
         Person.send(:undef_method, :favorites_attributes=)
+        Person.send(:undef_method, :children_attributes=)
         Person.nested_attributes.clear
       end
 
@@ -23,9 +27,18 @@ describe Mongoid::Attributes::Nested do
         expect(person).to respond_to(:favorites_attributes=)
       end
 
+      it "does not autosave if the association is embedded" do
+        expect(person).not_to respond_to(:autosave_documents_for_favorites)
+      end
+
+      it "autosaves if the association is not embedded" do
+        expect(person).to respond_to(:autosave_documents_for_children)
+      end
+
       it "adds the method name to the nested attributes list" do
         expect(Person.nested_attributes).to eq({
-          "favorites_attributes" => "favorites_attributes="
+          "favorites_attributes" => "favorites_attributes=",
+          "children_attributes" => "children_attributes="
         })
       end
     end
@@ -41,12 +54,12 @@ describe Mongoid::Attributes::Nested do
         Account.nested_attributes.clear
       end
 
-      let(:metadata) do
+      let(:association) do
         Account.reflect_on_association(:alerts)
       end
 
       it "keeps autosave set to false" do
-        expect(metadata).to_not be_autosave
+        expect(association).to_not be_autosave
       end
     end
   end
@@ -178,7 +191,7 @@ describe Mongoid::Attributes::Nested do
       end
 
       context "when adding existing document to a relation" do
-        let(:preference) { Preference.create(name: 'sample preference') }
+        let(:preference) { Preference.create!(name: 'sample preference') }
         let(:person) do
           Person.new(
             preferences_attributes: { 0 => { id: preference.id, name: preference.name } }
@@ -202,7 +215,12 @@ describe Mongoid::Attributes::Nested do
     context "when the relation is a referenced in" do
 
       before do
-        Post.accepts_nested_attributes_for :person
+        Post.accepts_nested_attributes_for :person, autosave: false
+      end
+
+      after do
+        Post.send(:undef_method, :person_attributes=)
+        Post.nested_attributes.clear
       end
 
       let(:post) do
@@ -215,7 +233,7 @@ describe Mongoid::Attributes::Nested do
     end
   end
 
-  describe "##{name}_attributes=" do
+  describe "*_attributes=" do
 
     context "when the parent document is new" do
 
@@ -224,7 +242,7 @@ describe Mongoid::Attributes::Nested do
         context "when the parent document is persisted" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -254,7 +272,7 @@ describe Mongoid::Attributes::Nested do
             context "when saving the parent" do
 
               before do
-                person.save
+                person.save!
                 person.reload
               end
 
@@ -356,7 +374,7 @@ describe Mongoid::Attributes::Nested do
             context "when all attributes are empty" do
 
               let(:product) do
-                Product.create(name: "testing")
+                Product.create!(name: "testing")
               end
 
               it "does not add the document" do
@@ -589,7 +607,7 @@ describe Mongoid::Attributes::Nested do
                       end
 
                       let(:owner) do
-                        PetOwner.create
+                        PetOwner.create!
                       end
 
                       let!(:pet) do
@@ -598,7 +616,7 @@ describe Mongoid::Attributes::Nested do
 
                       before do
                         owner.pet_attributes = { id: pet.id, _destroy: truth }
-                        owner.save
+                        owner.save!
                       end
 
                       it "destroys the existing document" do
@@ -1016,7 +1034,7 @@ describe Mongoid::Attributes::Nested do
         context "when the parent document is persisted" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -1050,7 +1068,7 @@ describe Mongoid::Attributes::Nested do
             context "when saving the parent" do
 
               before do
-                person.save
+                person.save!
                 person.reload
               end
 
@@ -1166,7 +1184,7 @@ describe Mongoid::Attributes::Nested do
             context "when the parent is saved" do
 
               before do
-                band.save
+                band.save!
               end
 
               it "runs the first child create callbacks" do
@@ -1335,7 +1353,7 @@ describe Mongoid::Attributes::Nested do
                 expect {
                   person.addresses_attributes =
                     { "foo" => { "id" => "test", "street" => "Test" } }
-                }.to raise_error
+                }.to raise_error(Mongoid::Errors::DocumentNotFound)
               end
             end
           end
@@ -1358,7 +1376,7 @@ describe Mongoid::Attributes::Nested do
                   end
 
                   let!(:record) do
-                    band.records.create
+                    band.records.create!
                   end
 
                   let(:attributes) do
@@ -1396,17 +1414,17 @@ describe Mongoid::Attributes::Nested do
                   end
 
                   let!(:band) do
-                    Band.create
+                    Band.create!
                   end
 
                   let!(:record) do
-                    band.records.create
+                    band.records.create!
                   end
 
                   before do
                     band.records_attributes =
                       { "foo" => { "id" => record.id, "_destroy" => true }}
-                    band.save
+                    band.save!
                   end
 
                   it "deletes the child document" do
@@ -1431,19 +1449,19 @@ describe Mongoid::Attributes::Nested do
                   context "when the parent is persisted" do
 
                     let!(:persisted) do
-                      Person.create(age: 42)
+                      Person.create!(age: 42)
                     end
 
-                    context "when the child returns false in a before callback" do
+                    context "when the child halts the callback chain in a before callback" do
 
                       context "when the child is not paranoid" do
 
                         let(:actor) do
-                          Actor.create
+                          Actor.create!
                         end
 
                         let!(:thing) do
-                          actor.things.create
+                          actor.things.create!
                         end
 
                         before do
@@ -1461,11 +1479,11 @@ describe Mongoid::Attributes::Nested do
                     context "when only 1 child has the default persisted" do
 
                       let!(:app_one) do
-                        persisted.appointments.create
+                        persisted.appointments.create!
                       end
 
                       let!(:app_two) do
-                        persisted.appointments.create.tap do |app|
+                        persisted.appointments.create!.tap do |app|
                           app.unset(:timed)
                         end
                       end
@@ -1482,7 +1500,7 @@ describe Mongoid::Attributes::Nested do
                               "bar" => { "id" => app_one.id, "_destroy" => true },
                               "foo" => { "id" => app_two.id, "_destroy" => true }
                             }
-                          from_db.save
+                          from_db.save!
                         end
 
                         it "destroys both children" do
@@ -1557,7 +1575,7 @@ describe Mongoid::Attributes::Nested do
                       context "when the parent is persisted" do
 
                         let!(:persisted) do
-                          Person.create do |p|
+                          Person.create! do |p|
                             p.addresses << [ address_one, address_two ]
                           end
                         end
@@ -1604,7 +1622,7 @@ describe Mongoid::Attributes::Nested do
                           context "when saving the parent" do
 
                             before do
-                              persisted.save
+                              persisted.save!
                             end
 
                             it "deletes the marked document from the relation" do
@@ -1660,7 +1678,7 @@ describe Mongoid::Attributes::Nested do
                           context "when saving the parent" do
 
                             before do
-                              persisted.save
+                              persisted.save!
                             end
 
                             it "deletes the marked document from the relation" do
@@ -1970,7 +1988,7 @@ describe Mongoid::Attributes::Nested do
                       }
                   end
 
-                  it "ignores the the marked document" do
+                  it "ignores the marked document" do
                     expect(person.addresses.size).to eq(1)
                   end
 
@@ -2031,7 +2049,7 @@ describe Mongoid::Attributes::Nested do
                       }
                   end
 
-                  it "adds the the marked document" do
+                  it "adds the marked document" do
                     expect(person.addresses.first.street).to eq("Maybachufer")
                   end
 
@@ -2091,7 +2109,7 @@ describe Mongoid::Attributes::Nested do
                       }
                   end
 
-                  it "adds the the marked document" do
+                  it "adds the marked document" do
                     expect(person.addresses.first.street).to eq("Maybachufer")
                   end
 
@@ -2372,8 +2390,8 @@ describe Mongoid::Attributes::Nested do
               end
 
               before do
-                pizza.topping = Topping.create(name: "cheese")
-                pizza.update_attributes(topping_attributes: { name: "onions" })
+                pizza.topping = Topping.create!(name: "cheese")
+                pizza.update_attributes!(topping_attributes: { name: "onions" })
               end
 
               it "persists the attribute changes" do
@@ -2948,7 +2966,7 @@ describe Mongoid::Attributes::Nested do
         context "when ids are passed" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -3013,7 +3031,7 @@ describe Mongoid::Attributes::Nested do
                       "0" => { "id" => post_one.id, "title" => "testing again" },
                       "1" => { "id" => post_two.id, "title" => "$$$" }
                     }
-                  person.save
+                  person.save!
                 end
 
                 it "does not perist the invalid value" do
@@ -3028,7 +3046,7 @@ describe Mongoid::Attributes::Nested do
                 expect {
                   person.posts_attributes =
                     { "foo" => { "id" => "test", "title" => "Test" } }
-                }.to raise_error
+                }.to raise_error(Mongoid::Errors::DocumentNotFound)
               end
             end
           end
@@ -3289,7 +3307,7 @@ describe Mongoid::Attributes::Nested do
               context "when the parent is saved" do
 
                 before do
-                  person.save
+                  person.save!
                   person.posts_attributes =
                     [
                       { "title" => "Third" },
@@ -3431,7 +3449,7 @@ describe Mongoid::Attributes::Nested do
                       }
                   end
 
-                  it "ignores the the marked document" do
+                  it "ignores the marked document" do
                     expect(person.posts.size).to eq(1)
                   end
 
@@ -3492,7 +3510,7 @@ describe Mongoid::Attributes::Nested do
                       }
                   end
 
-                  it "adds the the marked document" do
+                  it "adds the marked document" do
                     expect(person.posts.first.title).to eq("New Blog")
                   end
 
@@ -3552,7 +3570,7 @@ describe Mongoid::Attributes::Nested do
                       }
                   end
 
-                  it "adds the the marked document" do
+                  it "adds the marked document" do
                     expect(person.posts.first.title).to eq("New Blog")
                   end
 
@@ -3704,7 +3722,7 @@ describe Mongoid::Attributes::Nested do
         context "when ids are passed" do
 
           let(:person) do
-            Person.create
+            Person.create!
           end
 
           before do
@@ -3745,7 +3763,7 @@ describe Mongoid::Attributes::Nested do
                 expect {
                   person.preferences_attributes =
                     { "foo" => { "id" => "test", "name" => "Test" } }
-                }.to raise_error
+                }.to raise_error(Mongoid::Errors::DocumentNotFound)
               end
             end
           end
@@ -4097,7 +4115,7 @@ describe Mongoid::Attributes::Nested do
                       }
                   end
 
-                  it "ignores the the marked document" do
+                  it "ignores the marked document" do
                     expect(person.preferences.size).to eq(1)
                   end
 
@@ -4158,7 +4176,7 @@ describe Mongoid::Attributes::Nested do
                       }
                   end
 
-                  it "adds the the marked document" do
+                  it "adds the marked document" do
                     expect(person.preferences.first.name).to eq("New Blog")
                   end
 
@@ -4218,7 +4236,7 @@ describe Mongoid::Attributes::Nested do
                       }
                   end
 
-                  it "adds the the marked document" do
+                  it "adds the marked document" do
                     expect(person.preferences.first.name).to eq("New Blog")
                   end
 
@@ -4286,7 +4304,7 @@ describe Mongoid::Attributes::Nested do
     end
   end
 
-  describe "#update_attributes" do
+  describe "#update_attributes!" do
 
     before do
       Person.send(:undef_method, :addresses_attributes=)
@@ -4296,11 +4314,11 @@ describe Mongoid::Attributes::Nested do
     context "when embedding one level behind a has many" do
 
       let(:node) do
-        Node.create
+        Node.create!
       end
 
       let!(:server) do
-        node.servers.create(name: "prod")
+        node.servers.create!(name: "prod")
       end
 
       context "when adding a new embedded document" do
@@ -4319,7 +4337,7 @@ describe Mongoid::Attributes::Nested do
         end
 
         before do
-          node.update_attributes(attributes)
+          node.update_attributes!(attributes)
         end
 
         it "adds the new embedded document" do
@@ -4335,11 +4353,11 @@ describe Mongoid::Attributes::Nested do
     context "when deleting the child document" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:service) do
-        person.services.create(sid: "123")
+        person.services.create!(sid: "123")
       end
 
       let(:attributes) do
@@ -4351,7 +4369,7 @@ describe Mongoid::Attributes::Nested do
       end
 
       before do
-        person.update_attributes(attributes)
+        person.update_attributes!(attributes)
       end
 
       it "removes the document from the parent" do
@@ -4377,12 +4395,11 @@ describe Mongoid::Attributes::Nested do
 
     context "when nesting multiple levels and parent is timestamped" do
 
-      before do
-        class Address
-          after_save do
-            addressable.touch
-          end
-        end
+      around do |example|
+        original_relations = Location.relations
+        Location.embedded_in :address, touch: true
+        example.run
+        Location.relations = original_relations
       end
 
       after do
@@ -4390,15 +4407,15 @@ describe Mongoid::Attributes::Nested do
       end
 
       let(:dokument) do
-        Dokument.create
+        Dokument.create!
       end
 
       let!(:address) do
-        dokument.addresses.create(street: "hobrecht")
+        dokument.addresses.create!(street: "hobrecht")
       end
 
       let!(:location) do
-        address.locations.create(name: "work")
+        address.locations.create!(name: "work")
       end
 
       let(:attributes) do
@@ -4410,7 +4427,7 @@ describe Mongoid::Attributes::Nested do
       end
 
       before do
-        address.update_attributes(attributes)
+        address.update_attributes!(attributes)
         address.reload
       end
 
@@ -4422,21 +4439,21 @@ describe Mongoid::Attributes::Nested do
     context "when nesting multiple levels" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when second level is a one to many" do
 
         let(:person_one) do
-          Person.create
+          Person.create!
         end
 
         let!(:address_one) do
-          person_one.addresses.create(street: "hobrecht")
+          person_one.addresses.create!(street: "hobrecht")
         end
 
         let!(:location_one) do
-          address_one.locations.create(name: "home")
+          address_one.locations.create!(name: "home")
         end
 
         context "when destroying a second level document" do
@@ -4453,7 +4470,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            person_one.update_attributes(attributes)
+            person_one.update_attributes!(attributes)
           end
 
           it "deletes the document from the relation" do
@@ -4468,15 +4485,15 @@ describe Mongoid::Attributes::Nested do
         context "when destroying a second level document with callbacks" do
 
           let(:band) do
-            Band.create(name: "Tool")
+            Band.create!(name: "Tool")
           end
 
           let(:record) do
-            band.records.create(name: "Undertow")
+            band.records.create!(name: "Undertow")
           end
 
           let!(:track) do
-            record.tracks.create(name: "Sober")
+            record.tracks.create!(name: "Sober")
           end
 
           context "when cascading callbacks" do
@@ -4503,7 +4520,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              band.update_attributes(attributes)
+              band.update_attributes!(attributes)
             end
 
             it "removes the child from the relation" do
@@ -4536,7 +4553,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              person.update_attributes(attributes)
+              person.update_attributes!(attributes)
             end
 
             let(:address) do
@@ -4559,11 +4576,11 @@ describe Mongoid::Attributes::Nested do
           context "when adding to an existing document in the first level" do
 
             let!(:address) do
-              person.addresses.create(street: "hobrecht")
+              person.addresses.create!(street: "hobrecht")
             end
 
             let!(:location) do
-              address.locations.create(name: "work")
+              address.locations.create!(name: "work")
             end
 
             let(:attributes) do
@@ -4576,7 +4593,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              person.update_attributes(attributes)
+              person.update_attributes!(attributes)
               person.reload
             end
 
@@ -4607,7 +4624,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            person.update_attributes(attributes)
+            person.update_attributes!(attributes)
           end
 
           let(:address) do
@@ -4633,7 +4650,7 @@ describe Mongoid::Attributes::Nested do
         context "when the nested document is not polymorphic" do
 
           let!(:address) do
-            person.addresses.create(street: "Alexanderstr", number: 1)
+            person.addresses.create!(street: "Alexanderstr", number: 1)
           end
 
           let!(:code) do
@@ -4656,7 +4673,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            person.update_attributes(attributes)
+            person.update_attributes!(attributes)
           end
 
           it "updates the first level embedded document" do
@@ -4673,7 +4690,7 @@ describe Mongoid::Attributes::Nested do
           context "when the first level is an embeds many" do
 
             let!(:address) do
-              person.addresses.create(street: "Alexanderstr", number: 1)
+              person.addresses.create!(street: "Alexanderstr", number: 1)
             end
 
             let!(:target) do
@@ -4696,7 +4713,7 @@ describe Mongoid::Attributes::Nested do
             end
 
             before do
-              person.update_attributes(attributes)
+              person.update_attributes!(attributes)
             end
 
             it "updates the first level embedded document" do
@@ -4732,7 +4749,7 @@ describe Mongoid::Attributes::Nested do
               end
 
               before do
-                person.update_attributes(attributes)
+                person.update_attributes!(attributes)
               end
 
               it "updates the nested embedded document" do
@@ -4749,7 +4766,7 @@ describe Mongoid::Attributes::Nested do
       context "when updating with valid attributes" do
 
         let(:user) do
-          User.create
+          User.create!
         end
 
         let(:params) do
@@ -4759,7 +4776,14 @@ describe Mongoid::Attributes::Nested do
         end
 
         before do
-          user.update_attributes(params)
+          user.update_attributes!(params)
+        end
+
+        around do |example|
+          original_relations = User.relations
+          User.has_many :posts, foreign_key: :author_id, validate: false, autosave: true
+          example.run
+          user.relations = original_relations
         end
 
         let(:post) do
@@ -4778,11 +4802,11 @@ describe Mongoid::Attributes::Nested do
       context "when the document is freshly loaded from the db" do
 
         let!(:node) do
-          Node.create
+          Node.create!
         end
 
         let!(:server) do
-          node.servers.create(name: "test")
+          node.servers.create!(name: "test")
         end
 
         before do
@@ -4815,11 +4839,11 @@ describe Mongoid::Attributes::Nested do
     context "when the relation is an embeds many" do
 
       let(:league) do
-        League.create
+        League.create!
       end
 
       let!(:division) do
-        league.divisions.create(name: "Old Name")
+        league.divisions.create!(name: "Old Name")
       end
 
       context "when additional validation is set" do
@@ -4852,7 +4876,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           it "the update raises an error" do
-            expect{ error_raising_update }.to raise_error
+            expect{ error_raising_update }.to raise_error(Mongoid::Errors::Validations)
           end
 
           it "the update does not occur" do
@@ -4874,7 +4898,7 @@ describe Mongoid::Attributes::Nested do
         end
 
         before do
-          league.update_attributes(params)
+          league.update_attributes!(params)
         end
 
         it "sets the nested attributes" do
@@ -4894,7 +4918,7 @@ describe Mongoid::Attributes::Nested do
           end
 
           before do
-            league.update_attributes(new_params)
+            league.update_attributes!(new_params)
           end
 
           it "sets the nested attributes" do