mongoid 5.4.1 → 7.4.0

data/spec/mongoid/persistable/updatable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Persistable::Updatable do
@@ -7,7 +9,7 @@ describe Mongoid::Persistable::Updatable do
     context "when the field is aliased" do
 
       let(:person) do
-        Person.create
+        Person.create!
       end
 
       context "when the setter is overridden" do
@@ -67,7 +69,7 @@ describe Mongoid::Persistable::Updatable do
     context "when setting an array field" do
 
       let(:person) do
-        Person.create(aliases: [])
+        Person.create!(aliases: [])
       end
 
       before do
@@ -112,6 +114,24 @@ describe Mongoid::Persistable::Updatable do
       end
     end
 
+    context "when dynamic attributes are not enabled" do
+
+      it "raises exception for an unknown attribute " do
+        account = Account.create!(name: 'Foobar')
+
+        expect {
+          account.update_attribute(:somethingnew, "somethingnew")
+        }.to raise_error(Mongoid::Errors::UnknownAttribute)
+      end
+
+      it "will update value of aliased field" do
+        person = Person.create!
+        person.update_attribute(:t, "test_value")
+        expect(person.reload.t).to eq "test_value"
+        expect(person.test).to eq "test_value"
+      end
+    end
+
     context "when provided a symbol attribute name" do
 
       let(:post) do
@@ -168,7 +188,7 @@ describe Mongoid::Persistable::Updatable do
         it "raises an error" do
           expect {
             post.update_attribute(:title, "something")
-          }.to raise_error
+          }.to raise_error(RuntimeError)
         end
       end
     end
@@ -213,7 +233,7 @@ describe Mongoid::Persistable::Updatable do
     context "when persisting a localized field" do
 
       let!(:product) do
-        Product.create(description: "The bomb")
+        Product.create!(description: "The bomb")
       end
 
       before do
@@ -242,15 +262,15 @@ describe Mongoid::Persistable::Updatable do
     context "when updating a deeply embedded document" do
 
       let!(:person) do
-        Person.create
+        Person.create!
       end
 
       let!(:address) do
-        person.addresses.create(street: "Winterfeldtstr")
+        person.addresses.create!(street: "Winterfeldtstr")
       end
 
       let!(:location) do
-        address.locations.create(name: "work")
+        address.locations.create!(name: "work")
       end
 
       let(:from_db) do
@@ -269,6 +289,167 @@ describe Mongoid::Persistable::Updatable do
         expect(from_db.reload.name).to eq("home")
       end
     end
+
+    context 'when the field is read-only' do
+
+      before do
+        Person.attr_readonly :species
+      end
+
+      after do
+        Person.readonly_attributes.reject! { |a| a.to_s == 'species' }
+      end
+
+      let(:person) do
+        Person.create!(species: :human)
+      end
+
+      it 'raises an error when trying to set the attribute' do
+        expect {
+          person.update_attribute(:species, :reptile)
+        }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+      end
+
+      context 'when referring to the attribute with a string' do
+
+        it 'raises an error when trying to set the attribute' do
+          expect {
+            person.update_attribute('species', :reptile)
+          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        end
+      end
+
+      context 'when the field is aliased' do
+
+        before do
+          Person.attr_readonly :at
+        end
+
+        after do
+          Person.readonly_attributes.reject! { |a| a.to_s == 'at' }
+        end
+
+        it 'raises an error when trying to set the attribute using the db name' do
+          expect {
+            person.update_attribute(:at, Time.now)
+          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        end
+
+        it 'raises an error when trying to set the attribute using the aliased name' do
+          expect {
+            person.update_attribute(:aliased_timestamp, Time.now)
+          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        end
+      end
+    end
+
+    context 'when the field is loaded explicitly' do
+
+      before do
+        Person.create!(title: 'Captain')
+      end
+
+      context 'when the loaded attribute is updated' do
+
+        let(:person) do
+          Person.only(:title).first.tap do |_person|
+            _person.update_attribute(:title, 'Esteemed')
+          end
+        end
+
+        it 'allows the field to be updated' do
+          expect(person.title).to eq('Esteemed')
+        end
+
+        it 'persists the updated field' do
+          expect(person.reload.title).to eq('Esteemed')
+        end
+      end
+
+      context 'when the an attribute other than the loaded one is updated' do
+
+        let(:person) do
+          Person.only(:title).first
+        end
+
+        it 'does not allow the field to be updated' do
+          expect {
+            person.update_attribute(:age, 20)
+          }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+        end
+
+        it 'does not persist the change' do
+          expect(person.reload.age).to eq(100)
+        end
+
+        context 'when referring to the attribute with a string' do
+
+          it 'does not allow the field to be updated' do
+            expect {
+              person.update_attribute('age', 20)
+            }.to raise_exception(Mongoid::Errors::ReadonlyAttribute)
+          end
+
+          it 'does not persist the change' do
+            expect(person.reload.age).to eq(100)
+          end
+        end
+      end
+    end
+
+    context 'when fields are explicitly not loaded' do
+
+      before do
+        Person.create!(title: 'Captain')
+      end
+
+      context 'when the loaded attribute is updated' do
+
+        let(:person) do
+          Person.without(:age).first.tap do |_person|
+            _person.update_attribute(:title, 'Esteemed')
+          end
+        end
+
+        it 'allows the field to be updated' do
+          expect(person.title).to eq('Esteemed')
+        end
+
+        it 'persists the updated field' do
+          expect(person.reload.title).to eq('Esteemed')
+        end
+      end
+
+      context 'when the non-loaded attribute is updated' do
+
+        let(:person) do
+          Person.without(:title).first
+        end
+
+        it 'does not allow the field to be updated' do
+          expect {
+            person.update_attribute(:title, 'Esteemed')
+          }.to raise_exception(ActiveModel::MissingAttributeError)
+        end
+
+        it 'does not persist the change' do
+          expect(person.reload.title).to eq('Captain')
+        end
+
+        context 'when referring to the attribute with a string' do
+
+          it 'does not allow the field to be updated' do
+            expect {
+              person.update_attribute('title', 'Esteemed')
+            }.to raise_exception(ActiveModel::MissingAttributeError)
+          end
+
+          it 'does not persist the change' do
+            expect(person.reload.title).to eq('Captain')
+          end
+        end
+      end
+    end
   end
 
   [:update_attributes, :update].each do |method|
@@ -276,14 +457,15 @@ describe Mongoid::Persistable::Updatable do
     describe "##{method}" do
 
       context "when saving with a hash field with invalid keys" do
+        max_server_version '4.9'
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         it "raises an error" do
           expect {
-            person.update_attributes(map: { "$bad.key" => "value" })
+            person.update_attributes!(map: { "$bad.key" => "value" })
           }.to raise_error(Mongo::Error::OperationFailure)
         end
       end
@@ -291,11 +473,11 @@ describe Mongoid::Persistable::Updatable do
       context "when validation passes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:saved) do
-          person.update_attributes(pets: false)
+          person.update_attributes!(pets: false)
         end
 
         let(:from_db) do
@@ -312,9 +494,10 @@ describe Mongoid::Persistable::Updatable do
       end
 
       context "when the document has been destroyed" do
+        max_server_version '4.9'
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         it "raises an error" do
@@ -327,7 +510,7 @@ describe Mongoid::Persistable::Updatable do
       context "when validation passes" do
 
         let(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:saved) do
@@ -350,7 +533,7 @@ describe Mongoid::Persistable::Updatable do
       context "when the document has been destroyed" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         before do
@@ -360,7 +543,7 @@ describe Mongoid::Persistable::Updatable do
         it "raises an error" do
           expect {
             person.send(method, title: "something")
-          }.to raise_error
+          }.to raise_error(RuntimeError)
         end
       end
 
@@ -371,7 +554,7 @@ describe Mongoid::Persistable::Updatable do
         end
 
         let(:game) do
-          Game.create(person: person)
+          Game.create!(person: person)
         end
 
         before do
@@ -408,7 +591,7 @@ describe Mongoid::Persistable::Updatable do
         context "when providing an embedded child" do
 
           let!(:person) do
-            Person.create
+            Person.create!
           end
 
           let!(:name) do
@@ -435,11 +618,11 @@ describe Mongoid::Persistable::Updatable do
         context "when providing a parent to a referenced in" do
 
           let!(:person) do
-            Person.create
+            Person.create!
           end
 
           let!(:post) do
-            Post.create(title: "Testing")
+            Post.create!(title: "Testing")
           end
 
           context "when the relation has not yet been touched" do
@@ -500,7 +683,7 @@ describe Mongoid::Persistable::Updatable do
         before do
           phone_number.country_code = country_code
           person.phone_numbers << phone_number
-          person.save
+          person.save!
         end
 
         it "sets the first level document" do
@@ -543,7 +726,7 @@ describe Mongoid::Persistable::Updatable do
 
   describe "#update!" do
 
-    context "when a callback returns false" do
+    context "when a callback aborts the callback chain" do
 
       let(:oscar) do
         Oscar.new
@@ -556,4 +739,22 @@ describe Mongoid::Persistable::Updatable do
       end
     end
   end
+
+  describe "#update_attributes!" do
+
+    let(:person) do
+      Person.create!
+    end
+
+    let(:attributes) do
+      { security_code: 'secret' }
+    end
+
+    it 'calls update_attributes' do
+      person.should receive(:update_attributes).with(attributes).and_call_original
+      lambda do
+        person.update_attributes!(attributes)
+      end.should_not raise_error
+    end
+  end
 end

data/spec/mongoid/persistable/upsertable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Persistable::Upsertable do
@@ -29,7 +31,7 @@ describe Mongoid::Persistable::Upsertable do
     context "when the document is new" do
 
       let!(:existing) do
-        Band.create(name: "Photek")
+        Band.create!(name: "Photek")
       end
 
       context "when a matching document exists in the db" do
@@ -80,7 +82,7 @@ describe Mongoid::Persistable::Upsertable do
     context "when the document is not new" do
 
       let!(:existing) do
-        Band.create(name: "Photek")
+        Band.create!(name: "Photek")
       end
 
       context "when updating fields outside of the id" do

data/spec/mongoid/persistable_spec.rb

@@ -1,11 +1,15 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Persistable do
 
+  class PersistableSpecTestException < StandardError; end
+
   describe "#atomically" do
 
     let(:document) do
-      Band.create(member_count: 0, likes: 60, origin: "London")
+      Band.create!(member_count: 0, likes: 60, origin: "London")
     end
 
     context "when providing a block" do
@@ -52,16 +56,16 @@ describe Mongoid::Persistable do
       context "when not chaining the operations" do
 
         let(:operations) do
-          {
+          [{
             "$inc" => { "member_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
-            "$unset" => { "origin" => true }
-          }
+            "$unset" => { "origin" => true }},
+            { :session => nil } ]
         end
 
         before do
-          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(*operations).and_call_original
         end
 
         let!(:update) do
@@ -79,16 +83,16 @@ describe Mongoid::Persistable do
       context "when chaining the operations" do
 
         let(:operations) do
-          {
+          [{
             "$inc" => { "member_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
-            "$unset" => { "origin" => true }
-          }
+            "$unset" => { "origin" => true } },
+            { :session => nil } ]
         end
 
         before do
-          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(*operations).and_call_original
         end
 
         let!(:update) do
@@ -107,16 +111,16 @@ describe Mongoid::Persistable do
       context "when given multiple operations of the same type" do
 
         let(:operations) do
-          {
+         [{
             "$inc" => { "member_count" => 10, "other_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
-            "$unset" => { "origin" => true }
-          }
+            "$unset" => { "origin" => true }},
+            { :session => nil } ]
         end
 
         before do
-          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(*operations).and_call_original
         end
 
         let!(:update) do
@@ -144,16 +148,16 @@ describe Mongoid::Persistable do
       context "when expecting the document to be yielded" do
 
         let(:operations) do
-          {
+          [{
             "$inc" => { "member_count" => 10 },
             "$bit" => { "likes" => { :and => 13 }},
             "$set" => { "name" => "Placebo" },
-            "$unset" => { "origin" => true }
-          }
+            "$unset" => { "origin" => true }},
+            { :session => nil } ]
         end
 
         before do
-          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(operations).and_call_original
+          expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).with(*operations).and_call_original
         end
 
         let!(:update) do
@@ -173,8 +177,8 @@ describe Mongoid::Persistable do
 
         before do
           class Band
-            def my_updates
-              atomically do |d|
+            def my_updates(**args)
+              atomically(**args) do |d|
                 d.set(name: "Placebo")
                 d.unset(:origin)
               end
@@ -182,15 +186,87 @@ describe Mongoid::Persistable do
           end
         end
 
-        let!(:update) do
-          document.atomically do |doc|
-            doc.inc(member_count: 10)
-            doc.bit(likes: { and: 13 })
-            doc.my_updates
+        context "when given join_context: false" do
+
+          let(:run_update) do
+            document.atomically do |doc|
+              doc.set origin: "Paris"
+              doc.atomically(join_context: false) do |doc2|
+                doc2.inc(member_count: 10)
+              end
+              doc.inc likes: 1
+              raise PersistableSpecTestException, "oops"
+            end
+          end
+
+          it_behaves_like "an atomically updatable root document" do
+            let!(:update) do
+              document.atomically do |doc|
+                doc.inc(member_count: 10)
+                doc.my_updates join_context: false
+                doc.bit(likes: { and: 13 })
+              end
+            end
+          end
+
+          it "independently persists the non-joining block's operations" do
+            begin run_update; rescue PersistableSpecTestException; end
+
+            document.reload
+
+            expect(document.origin).to eq "London"
+            expect(document.likes).to eq 60
+            expect(document.member_count).to eq 10
+          end
+
+          it "resets in-memory changes that did not successfully persist" do
+            begin run_update; rescue PersistableSpecTestException; end
+
+            expect(document.origin).to eq "London"
+            expect(document.likes).to eq 60
+            expect(document.member_count).to eq 10
           end
         end
 
-        it_behaves_like "an atomically updatable root document"
+        context "when given join_context: true" do
+
+          let(:run_update) do
+            document.atomically do |doc|
+              doc.inc(member_count: 10)
+              doc.my_updates join_context: true
+              doc.bit(likes: { and: 13 })
+            end
+          end
+
+          it_behaves_like "an atomically updatable root document" do
+            let!(:update) { run_update }
+          end
+
+          it "performs an update_one exactly once" do
+            expect_any_instance_of(Mongo::Collection::View).to receive(:update_one).exactly(:once).and_call_original
+            run_update
+          end
+
+          it "resets in-memory changes that did not successfully persist" do
+            begin
+              document.atomically do |doc|
+                doc.set origin: "Paris"
+                doc.atomically(join_context: true) do |doc2|
+                  doc2.inc(member_count: 10)
+                end
+                doc.atomically(join_context: true) do |doc3|
+                  doc.inc likes: 1
+                end
+                raise PersistableSpecTestException, "oops"
+              end
+            rescue PersistableSpecTestException
+            end
+
+            expect(document.origin).to eq "London"
+            expect(document.likes).to eq 60
+            expect(document.member_count).to eq 0
+          end
+        end
       end
     end
 
@@ -200,6 +276,21 @@ describe Mongoid::Persistable do
         expect(document.atomically).to be true
       end
     end
+
+    context "when the block has no operations" do
+        before do
+          expect_any_instance_of(Mongo::Collection::View).to_not receive(:update_one)
+        end
+
+        let!(:update) do
+          document.atomically do
+          end
+        end
+
+        it "doesn't update the document" do
+          expect(document.reload.origin).to eq("London")
+        end
+    end
   end
 
   describe "#fail_due_to_valiation!" do