mongoid 5.4.1 → 7.4.0

data/spec/mongoid/criteria/modifiable_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require "spec_helper"
 
 describe Mongoid::Criteria::Modifiable do
@@ -10,7 +12,7 @@ describe Mongoid::Criteria::Modifiable do
 
     context "when provided valid attributes" do
       let(:band) do
-        criteria.create(genres: [ "electro" ])
+        criteria.create!(genres: [ "electro" ])
       end
 
       it "returns the created document" do
@@ -31,7 +33,7 @@ describe Mongoid::Criteria::Modifiable do
       context "when provided valid attributes & using block" do
 
         let(:band) do
-          criteria.create do |c|
+          criteria.create! do |c|
             c.genres = [ "electro" ]
           end
         end
@@ -49,6 +51,29 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.create!
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   describe "#create!" do
@@ -65,6 +90,29 @@ describe Mongoid::Criteria::Modifiable do
         }.to raise_error(Mongoid::Errors::Validations)
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.create!
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   [ :delete, :delete_all, :destroy, :destroy_all ].each do |method|
@@ -84,9 +132,9 @@ describe Mongoid::Criteria::Modifiable do
       end
 
       before do
-        Person.create(title: "Madam")
+        Person.create!(title: "Madam")
         2.times do |n|
-          Person.create(
+          Person.create!(
             title: "Sir",
             name: name,
             addresses: [ address_one, address_two ]
@@ -171,7 +219,7 @@ describe Mongoid::Criteria::Modifiable do
       context "when providing an attribute" do
 
         let!(:person) do
-          Person.create(title: "Senior")
+          Person.create!(title: "Senior")
         end
 
         it "returns the document" do
@@ -184,11 +232,11 @@ describe Mongoid::Criteria::Modifiable do
         context "with an owner with a BSON identity type" do
 
           let!(:person) do
-            Person.create
+            Person.create!
           end
 
           let!(:game) do
-            Game.create(person: person)
+            Game.create!(person: person)
           end
 
           context "when providing the object directly" do
@@ -217,11 +265,11 @@ describe Mongoid::Criteria::Modifiable do
         context "with an owner with an Integer identity type" do
 
           let!(:jar) do
-            Jar.create
+            Jar.create!
           end
 
           let!(:cookie) do
-            Cookie.create(jar: jar)
+            Cookie.create!(jar: jar)
           end
 
           let(:from_db) do
@@ -240,11 +288,11 @@ describe Mongoid::Criteria::Modifiable do
       context "when providing a document" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:game) do
-          Game.create
+          Game.create!
         end
 
         let(:from_db) do
@@ -295,6 +343,25 @@ describe Mongoid::Criteria::Modifiable do
           expect(person.pets).to be true
         end
       end
+
+      context 'when the object is polymorphic' do
+
+        let(:movie) do
+          Movie.new
+        end
+
+        let(:document) do
+          Rating.find_or_create_by(ratable: movie)
+        end
+
+        it 'sets the polymorphic id' do
+          expect(document.ratable_id).to eq(movie.id)
+        end
+
+        it 'sets the type field' do
+          expect(document.ratable_type).to eq('Movie')
+        end
+      end
     end
   end
 
@@ -305,7 +372,7 @@ describe Mongoid::Criteria::Modifiable do
       context "when providing an attribute" do
 
         let!(:person) do
-          Person.create(title: "Senior")
+          Person.create!(title: "Senior")
         end
 
         it "returns the document" do
@@ -318,11 +385,11 @@ describe Mongoid::Criteria::Modifiable do
         context "with an owner with a BSON identity type" do
 
           let!(:person) do
-            Person.create
+            Person.create!
           end
 
           let!(:game) do
-            Game.create(person: person)
+            Game.create!(person: person)
           end
 
           context "when providing the object directly" do
@@ -351,11 +418,11 @@ describe Mongoid::Criteria::Modifiable do
         context "with an owner with an Integer identity type" do
 
           let!(:jar) do
-            Jar.create
+            Jar.create!
           end
 
           let!(:cookie) do
-            Cookie.create(jar: jar)
+            Cookie.create!(jar: jar)
           end
 
           let(:from_db) do
@@ -374,11 +441,11 @@ describe Mongoid::Criteria::Modifiable do
       context "when providing a document" do
 
         let!(:person) do
-          Person.create
+          Person.create!
         end
 
         let!(:game) do
-          Game.create
+          Game.create!
         end
 
         let(:from_db) do
@@ -447,6 +514,25 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:document) do
+        Rating.find_or_create_by!(ratable: movie)
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   describe ".find_or_initialize_by" do
@@ -454,7 +540,7 @@ describe Mongoid::Criteria::Modifiable do
     context "when the document is found" do
 
       let!(:person) do
-        Person.create(title: "Senior")
+        Person.create!(title: "Senior")
       end
 
       it "returns the document" do
@@ -500,12 +586,31 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
     end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:document) do
+        Rating.find_or_initialize_by(ratable: movie)
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
   end
 
   describe "first_or_create" do
 
     let!(:band) do
-      Band.create(name: "Depeche Mode")
+      Band.create!(name: "Depeche Mode")
     end
 
     context "when the document is found" do
@@ -538,6 +643,135 @@ describe Mongoid::Criteria::Modifiable do
         it "sets the additional attributes" do
           expect(document.origin).to eq("Essex")
         end
+
+        context 'when attributes contain keys also in the criteria selector' do
+
+          context 'when the selector has symbol keys' do
+
+            context 'when the attributes use symbol keys' do
+
+              let(:document) do
+                Band.where(name: 'Tool').first_or_create(name: 'Essex')
+              end
+
+              it 'uses the values from the attributes' do
+                expect(document.name).to eq('Essex')
+              end
+            end
+
+            context 'when the attributes use string keys' do
+
+              let(:document) do
+                Band.where(name: 'Tool').first_or_create('name' => 'Essex')
+              end
+
+              it 'uses the values from the attributes' do
+                expect(document.name).to eq('Essex')
+              end
+            end
+          end
+
+          context 'when the selector has string keys' do
+
+            context 'when the attributes use symbol keys' do
+
+              let(:document) do
+                Band.where('name' => 'Tool').first_or_create(name: 'Essex')
+              end
+
+              it 'uses the values from the attributes' do
+                expect(document.name).to eq('Essex')
+              end
+            end
+
+            context 'when the attributes use string keys' do
+
+              let(:document) do
+                Band.where('name' => 'Tool').first_or_create('name' => 'Essex')
+              end
+
+              it 'uses the values from the attributes' do
+                expect(document.name).to eq('Essex')
+              end
+            end
+          end
+        end
+
+        context 'when the query criteria is on a hash attribute' do
+
+          let(:document) do
+            Person.where(map: { foo: :bar }).first_or_create
+          end
+
+          it 'uses the values from the attributes' do
+            expect(document.map).to eq('foo' => :bar )
+          end
+        end
+
+        context 'when the criteria has a selector with query operators' do
+
+          let(:document) do
+            Band.in(genres: ['Hiphop', 'Soul']).first_or_create(name: 'Smooth')
+          end
+
+          it 'does not create a document with the query operators' do
+            expect(document.attributes.keys).not_to include('genres')
+          end
+        end
+
+        context 'when the criteria has a nested selector with query operators' do
+
+          let(:band) do
+            record = Record.new(producers: ['testing'])
+            band = Band.create!(records: [record])
+          end
+
+          let(:document) do
+            band.records.in(producers: ['nonexistent']).first_or_create(name: 'new-embedded-doc')
+            band.reload
+          end
+
+          it 'creates a new embedded document' do
+            expect(document.records.size).to eq(2)
+          end
+
+          it 'does not alter the existing embedded document' do
+            expect(document.records[0].producers).to eq(['testing'])
+          end
+
+          it 'does not create a document with the query operators as attributes' do
+            expect(document.records[1].producers).to be_nil
+          end
+
+          it 'applies the attribute to the new embedded document' do
+            expect(document.records[1].name).to eq('new-embedded-doc')
+          end
+        end
+
+        context 'when the criteria has a deeply-nested selector with query operators' do
+
+          let(:criteria) do
+            band = Band.create!
+            Mongoid::Criteria.new(Record) do |criteria|
+              criteria.embedded = true
+              criteria.association = Band.reflect_on_association(:records)
+              criteria.parent_document = band
+              criteria.selector = { "records" => { "producers"=>{"$in"=>["nonexistent"] } } }
+            end
+          end
+
+          let(:document) do
+            criteria.first_or_create(name: 'new-record')
+          end
+
+          it 'does not create a document with the query operators' do
+            expect(document.attributes.keys).not_to include('producers')
+          end
+
+          it 'applies the attribute to the new embedded document' do
+            expect(document.name).to eq('new-record')
+          end
+        end
       end
 
       context "when attributes are not provided" do
@@ -558,7 +792,7 @@ describe Mongoid::Criteria::Modifiable do
       context "when the criteria is on an embedded relation" do
 
         let!(:band) do
-          Band.create(name: "Placebo")
+          Band.create!(name: "Placebo")
         end
 
         let(:document) do
@@ -574,6 +808,29 @@ describe Mongoid::Criteria::Modifiable do
         end
       end
 
+      context 'when the object is polymorphic' do
+
+        let(:movie) do
+          Movie.new
+        end
+
+        let(:criteria) do
+          Rating.where(ratable: movie)
+        end
+
+        let(:document) do
+          criteria.first_or_create
+        end
+
+        it 'sets the polymorphic id' do
+          expect(document.ratable_id).to eq(movie.id)
+        end
+
+        it 'sets the type field' do
+          expect(document.ratable_type).to eq('Movie')
+        end
+      end
+
       context "when a block is provided" do
 
         let(:document) do
@@ -736,13 +993,89 @@ describe Mongoid::Criteria::Modifiable do
           end
         end
       end
+
+      context 'when attributes contain keys also in the criteria selector' do
+
+        context 'when the selector has symbol keys' do
+
+          context 'when the attributes use symbol keys' do
+
+            let(:document) do
+              Band.where(name: 'Tool').first_or_create!(name: 'Essex')
+            end
+
+            it 'uses the values from the attributes' do
+              expect(document.name).to eq('Essex')
+            end
+          end
+
+          context 'when the attributes use string keys' do
+
+            let(:document) do
+              Band.where(name: 'Tool').first_or_create!('name' => 'Essex')
+            end
+
+            it 'uses the values from the attributes' do
+              expect(document.name).to eq('Essex')
+            end
+          end
+        end
+
+        context 'when the selector has string keys' do
+
+          context 'when the attributes use symbol keys' do
+
+            let(:document) do
+              Band.where('name' => 'Tool').first_or_create!(name: 'Essex')
+            end
+
+            it 'uses the values from the attributes' do
+              expect(document.name).to eq('Essex')
+            end
+          end
+
+          context 'when the attributes use string keys' do
+
+            let(:document) do
+              Band.where('name' => 'Tool').first_or_create!('name' => 'Essex')
+            end
+
+            it 'uses the values from the attributes' do
+              expect(document.name).to eq('Essex')
+            end
+          end
+        end
+      end
+    end
+
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.first_or_create!
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
     end
   end
 
   describe "first_or_initialize" do
 
     let!(:band) do
-      Band.create(name: "Depeche Mode")
+      Band.create!(name: "Depeche Mode")
     end
 
     context "when the document is found" do
@@ -756,6 +1089,29 @@ describe Mongoid::Criteria::Modifiable do
       end
     end
 
+    context 'when the object is polymorphic' do
+
+      let(:movie) do
+        Movie.new
+      end
+
+      let(:criteria) do
+        Rating.where(ratable: movie)
+      end
+
+      let(:document) do
+        criteria.first_or_initialize
+      end
+
+      it 'sets the polymorphic id' do
+        expect(document.ratable_id).to eq(movie.id)
+      end
+
+      it 'sets the type field' do
+        expect(document.ratable_type).to eq('Movie')
+      end
+    end
+
     context "when the document is not found" do
 
       context "when attributes are provided" do
@@ -830,6 +1186,59 @@ describe Mongoid::Criteria::Modifiable do
           end
         end
       end
+
+      context 'when attributes contain keys also in the criteria selector' do
+
+        context 'when the selector has symbol keys' do
+
+          context 'when the attributes use symbol keys' do
+
+            let(:document) do
+              Band.where(name: 'Tool').first_or_initialize(name: 'Essex')
+            end
+
+            it 'uses the values from the attributes' do
+              expect(document.name).to eq('Essex')
+            end
+          end
+
+          context 'when the attributes use string keys' do
+
+            let(:document) do
+              Band.where(name: 'Tool').first_or_initialize('name' => 'Essex')
+            end
+
+            it 'uses the values from the attributes' do
+              expect(document.name).to eq('Essex')
+            end
+          end
+        end
+
+        context 'when the selector has string keys' do
+
+          context 'when the attributes use symbol keys' do
+
+            let(:document) do
+              Band.where('name' => 'Tool').first_or_initialize(name: 'Essex')
+            end
+
+            it 'uses the values from the attributes' do
+              expect(document.name).to eq('Essex')
+            end
+          end
+
+          context 'when the attributes use string keys' do
+
+            let(:document) do
+              Band.where('name' => 'Tool').first_or_initialize('name' => 'Essex')
+            end
+
+            it 'uses the values from the attributes' do
+              expect(document.name).to eq('Essex')
+            end
+          end
+        end
+      end
     end
   end
 
@@ -840,11 +1249,11 @@ describe Mongoid::Criteria::Modifiable do
     end
 
     let!(:address_one) do
-      person.addresses.create(street: "Oranienstr")
+      person.addresses.create!(street: "Oranienstr")
     end
 
     let!(:address_two) do
-      person.addresses.create(street: "Wienerstr")
+      person.addresses.create!(street: "Wienerstr")
     end
 
     context "when updating the root document" do
@@ -985,11 +1394,11 @@ describe Mongoid::Criteria::Modifiable do
         end
 
         let!(:preference_one) do
-          person.preferences.create(name: "First")
+          person.preferences.create!(name: "First")
         end
 
         let!(:preference_two) do
-          person.preferences.create(name: "Second")
+          person.preferences.create!(name: "Second")
         end
 
         context "when updating the relation directly" do
@@ -1028,15 +1437,15 @@ describe Mongoid::Criteria::Modifiable do
   describe "#update_all" do
 
     let!(:person) do
-      Person.create(title: "Sir")
+      Person.create!(title: "Sir")
     end
 
     let!(:address_one) do
-      person.addresses.create(street: "Oranienstr")
+      person.addresses.create!(street: "Oranienstr")
     end
 
     let!(:address_two) do
-      person.addresses.create(street: "Wienerstr")
+      person.addresses.create!(street: "Wienerstr")
     end
 
     context "when updating the root document" do
@@ -1135,11 +1544,11 @@ describe Mongoid::Criteria::Modifiable do
       context "when the relation is a references many" do
 
         let!(:post_one) do
-          person.posts.create(title: "First")
+          person.posts.create!(title: "First")
         end
 
         let!(:post_two) do
-          person.posts.create(title: "Second")
+          person.posts.create!(title: "Second")
         end
 
         context "when updating the relation directly" do
@@ -1188,11 +1597,11 @@ describe Mongoid::Criteria::Modifiable do
         end
 
         let!(:preference_one) do
-          person.preferences.create(name: "First")
+          person.preferences.create!(name: "First")
         end
 
         let!(:preference_two) do
-          person.preferences.create(name: "Second")
+          person.preferences.create!(name: "Second")
         end
 
         context "when updating the relation directly" do
@@ -1236,11 +1645,15 @@ describe Mongoid::Criteria::Modifiable do
         { 'username' => 'Turnip' }
       end
 
-      it 'returns a criteria with the defined attributes' do
-        expect(Person.create_with(attrs).selector).to eq(attrs)
+      it 'does not modify the selector' do
+        expect(Person.create_with(attrs).selector[:username]).to be_nil
       end
 
-      context 'when a method is chained' do
+      it 'create_attrs is modified' do
+        expect(Person.create_with(attrs).create_attrs).to eq(attrs)
+      end
+
+      context 'when a create is chained' do
 
         context 'when a write method is chained' do
 
@@ -1264,6 +1677,25 @@ describe Mongoid::Criteria::Modifiable do
             expect(new_person.age).to eq(50)
           end
 
+          context 'when a matching document is already in the collection' do
+            let(:query) do
+              { 'username' => 'foo', 'age' => 12 }
+            end
+
+            let(:person) do
+              Person.create!(query)
+            end
+
+            let(:found_person) do
+              Person.create_with(attrs).find_or_create_by(query)
+            end
+
+            it 'finds the matching document' do
+              person
+              expect(found_person.id).to eq(person.id)
+            end
+          end
+
           context 'when the attributes are shared with the write method args' do
 
             let(:query) do
@@ -1274,9 +1706,8 @@ describe Mongoid::Criteria::Modifiable do
               Person.create_with(attrs).find_or_create_by(query)
             end
 
-            it 'gives the write method args precedence' do
-              #  @todo: uncomment when MONGOID-4193 is closed
-              #expect(new_person.username).to eq('Beet')
+            it 'gives the find method args precedence' do
+              expect(new_person.username).to eq('Beet')
               expect(new_person.age).to eq(50)
             end
           end
@@ -1302,8 +1733,12 @@ describe Mongoid::Criteria::Modifiable do
             { 'username' => 'Beet', 'age' => 50 }
           end
 
+          it 'does not modify the selector' do
+            expect(criteria.create_with(attrs).selector).to eq(criteria_selector)
+          end
+
           it 'overwrites all the original attributes' do
-            expect(criteria.create_with(attrs).selector).to eq(attrs)
+            expect(criteria.create_with(attrs).create_attrs).to eq(attrs)
           end
         end
       end
@@ -1314,8 +1749,12 @@ describe Mongoid::Criteria::Modifiable do
           { 'username' => 'Beet' }
         end
 
+        it 'does not modify the selector' do
+          expect(criteria.create_with(attrs).selector).to eq(criteria_selector)
+        end
+
         it 'only overwrites the shared attributes' do
-          expect(criteria.create_with(attrs).selector).to eq(criteria_selector.merge!(attrs))
+          expect(criteria.create_with(attrs).create_attrs).to eq(attrs)
         end
       end
 
@@ -1324,30 +1763,47 @@ describe Mongoid::Criteria::Modifiable do
         let(:attrs) do
           { 'username' => 'Turnip' }
         end
-
         let(:query) do
           { 'username' => 'Beet', 'age' => 50 }
         end
 
-        context 'when a write method is chained' do
+        context 'when a create method is chained' do
 
           it 'executes the method' do
-            #  @todo: uncomment when MONGOID-4193 is closed
-            #expect(criteria.create_with(attrs).new.username).to eq('Beet')
+            expect(criteria.create_with(attrs).new.username).to eq('Turnip')
             expect(criteria.create_with(attrs).new.age).to eq(25)
           end
         end
 
-        context 'when a write method is chained' do
+        context 'when a write method is chained producing conflicting criteria' do
 
           let(:new_person) do
             criteria.create_with(attrs).find_or_create_by(query)
           end
 
-          it 'executes the query' do
-            #  @todo: uncomment when MONGOID-4193 is closed
-            #expect(new_person.username).to eq('Beet')
-            #expect(new_person.age).to eq(50)
+          it 'gives the find method arg precedence' do
+            expect(new_person.username).to eq('Beet')
+            expect(new_person.age).to be(50)
+          end
+
+          context 'when a matching document is already in the collection' do
+            let(:query) do
+              { 'username' => 'foo', 'age' => 12 }
+            end
+
+            let(:person) do
+              Person.create!(query)
+            end
+
+            let(:found_person) do
+              criteria.create_with(attrs).find_or_create_by(query)
+            end
+
+            it 'creates a new document' do
+              person
+              expect(found_person.id).not_to eq(person.id)
+              expect(found_person.id > person.id).to be true
+            end
           end
         end
       end