hyrax 2.9.6 → 3.0.0.pre.beta1

data/spec/views/hyrax/dashboard/collections/_form_share_table.html.erb_spec.rb

@@ -0,0 +1,108 @@
+RSpec.describe 'hyrax/dashboard/collections/_form_share_table.html.erb', type: :view do
+  let(:template) { stub_model(Hyrax::PermissionTemplate) }
+  let(:user) { create(:user) }
+  let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
+  let(:collection) { stub_model(Collection, share_applies_to_new_works?: false) }
+  let(:pt_form) do
+    instance_double(Hyrax::Forms::PermissionTemplateForm,
+                    model_name: template.model_name,
+                    to_key: template.to_key,
+                    access_grants: [access_grant])
+  end
+
+  before do
+    assign(:collection, collection)
+    @form = instance_double(Hyrax::Forms::CollectionForm,
+                            to_model: stub_model(Collection),
+                            permission_template: pt_form)
+    # Ignore the delete button link
+    allow(view).to receive(:admin_permission_template_access_path).and_return("/admin/permission_template_accesses/123")
+  end
+
+  describe "Manager shares table" do
+    before do
+      render 'form_share_table', access: "managers", filter: :manage?
+    end
+
+    context "managers exist" do
+      let(:access_grant) do
+        stub_model(Hyrax::PermissionTemplateAccess,
+                   agent_type: 'user',
+                   agent_id: user.user_key,
+                   access: 'manage')
+      end
+
+      it "lists the managers in the table" do
+        expect(rendered).to have_selector("h3", text: "Managers")
+        expect(rendered).to have_selector("table tbody", text: user.user_key)
+      end
+    end
+    context "no managers exist" do
+      let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
+
+      it "displays a message and no table" do
+        expect(rendered).to have_selector("h3", text: "Managers")
+        expect(rendered).not_to have_selector("table")
+        expect(rendered).to have_content("No managers have been added to this collection.")
+      end
+    end
+  end
+
+  describe "Viewer shares table" do
+    before do
+      render 'form_share_table', access: "viewers", filter: :view?
+    end
+
+    context "viewers exist" do
+      let(:access_grant) do
+        stub_model(Hyrax::PermissionTemplateAccess,
+                   agent_type: 'user',
+                   agent_id: user.user_key,
+                   access: 'view')
+      end
+
+      it "lists the viewers in the table" do
+        expect(rendered).to have_selector("h3", text: "Viewers")
+        expect(rendered).to have_selector("table tbody", text: user.user_key)
+      end
+    end
+    context "no viewers exist" do
+      let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
+
+      it "displays a message and no table" do
+        expect(rendered).to have_selector("h3", text: "Viewers")
+        expect(rendered).not_to have_selector("table")
+        expect(rendered).to have_content("No viewers have been added to this collection.")
+      end
+    end
+  end
+
+  describe "Depositor shares table" do
+    before do
+      render 'form_share_table', access: "depositors", filter: :deposit?
+    end
+
+    context "depositors exist" do
+      let(:access_grant) do
+        stub_model(Hyrax::PermissionTemplateAccess,
+                   agent_type: 'user',
+                   agent_id: user.user_key,
+                   access: 'deposit')
+      end
+
+      it "lists the depositors in the table" do
+        expect(rendered).to have_selector("h3", text: "Depositors")
+        expect(rendered).to have_selector("table tbody", text: user.user_key)
+      end
+    end
+    context "no depositors exist" do
+      let(:access_grant) { stub_model(Hyrax::PermissionTemplateAccess) }
+
+      it "displays a message and no table" do
+        expect(rendered).to have_selector("h3", text: "Depositors")
+        expect(rendered).not_to have_selector("table")
+        expect(rendered).to have_content("No depositors have been added to this collection.")
+      end
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_list_collections.html.erb_spec.rb

@@ -0,0 +1,51 @@
+RSpec.describe 'hyrax/dashboard/collections/_list_collections.html.erb', type: :view do
+  let(:ability) { double }
+  let(:solr_document) { SolrDocument.new(collection_doc) }
+  let(:presenter) { Hyrax::CollectionPresenter.new(solr_document, ability) }
+
+  let(:collection_doc) do
+    {
+      id: '999',
+      'has_model_ssim' => ['Collection'],
+      'title_tesim' => ['Title 1'],
+      'date_created_tesim' => '2000-01-01'
+    }
+  end
+
+  before do
+    allow(view).to receive(:is_admin_set).and_return(false)
+    allow(view).to receive(:current_ability).and_return(ability)
+    allow(presenter).to receive(:available_parent_collections).and_return([])
+    allow(presenter).to receive(:collection_type_badge).and_return('A Collection Type')
+    allow(presenter).to receive(:total_viewable_items).and_return(3)
+    allow(ability).to receive(:can?).with(:edit, solr_document).and_return(false)
+
+    stub_template 'hyrax/my/_collection_action_menu.html.erb' => 'actions'
+  end
+
+  context 'Managed Collections' do
+    before do
+      allow(ability).to receive(:admin?).and_return(false)
+      allow(presenter).to receive(:managed_access).and_return('Manage Access')
+      render('list_collections.html.erb', collection_presenter: presenter)
+    end
+
+    # NOTE: Real labels are Manage, Deposit, or View, but UI shows whatever label gets returned,
+    # so no need to test all conditions.
+    it 'shows access label as returned by presenter' do
+      expect(rendered).to have_text('Manage Access')
+    end
+  end
+
+  context 'All Collections' do
+    before do
+      allow(ability).to receive(:admin?).and_return(true)
+      allow(presenter).to receive(:managed_access).and_return('Manage')
+      render('list_collections.html.erb', collection_presenter: presenter)
+    end
+
+    it "doesn't show access" do
+      expect(rendered).not_to have_text('Manage')
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_show_actions.html.erb_spec.rb

@@ -0,0 +1,77 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_actions.html.erb', type: :view do
+  let(:presenter) { double('Hyrax::CollectionPresenter', collection_type_is_nestable?: false, solr_document: solr_document, id: '123') }
+  let(:solr_document) { double('Solr Document') }
+  let(:can_destroy) { true }
+  let(:can_edit) { true }
+
+  before do
+    allow(view).to receive(:presenter).and_return(presenter)
+    # Must stub non-hyrax routes as engines don't have access to these routes
+    allow(view).to receive_message_chain(:hyrax, :edit_dashboard_collection_path).with(presenter).and_return('/path/to/edit') # rubocop:disable RSpec/MessageChain
+    allow(view).to receive_message_chain(:hyrax, :dashboard_collection_path).with(presenter).and_return('/path/to/destroy') # rubocop:disable RSpec/MessageChain
+
+    allow(view).to receive(:can?).with(:edit, solr_document).and_return(can_edit)
+    allow(view).to receive(:can?).with(:destroy, solr_document).and_return(can_destroy)
+  end
+
+  describe 'when user can edit the document' do
+    let(:can_edit) { true }
+
+    it 'renders edit collection link' do
+      render
+      expect(rendered).to have_link('Edit this collection', href: '/path/to/edit')
+    end
+  end
+  describe 'when user cannot edit the document' do
+    let(:can_edit) { false }
+
+    it 'does not render edit collection link' do
+      render
+      expect(rendered).not_to have_link('Edit this collection', href: '/path/to/edit')
+    end
+  end
+
+  describe 'nesting the collection within another collection' do
+    context 'with nestable collection' do
+      it 'renders add parent collection link' do
+        allow(presenter).to receive(:collection_type_is_nestable?).and_return true
+        allow(presenter).to receive(:user_can_nest_collection?).and_return true
+
+        render
+        expect(rendered).to have_button('Add existing collections to this collection')
+      end
+    end
+
+    context 'with nestable collection but without permissions' do
+      it 'does not render add parent collection link' do
+        allow(presenter).to receive(:collection_type_is_nestable?).and_return true
+        allow(presenter).to receive(:user_can_nest_collection?).and_return false
+
+        render
+        expect(rendered).not_to have_button('Add existing collections to this collection')
+      end
+    end
+
+    context 'with non-nestable collection' do
+      it 'does not render add parent collection link' do
+        render
+        expect(rendered).not_to have_button('Nest this collection')
+      end
+    end
+  end
+
+  describe 'when user can destroy the document' do
+    it 'renders a link to destroy the document' do
+      render
+      expect(rendered).to have_link('Delete this collection', href: '/path/to/destroy')
+    end
+  end
+  describe 'when user cannot destroy the document' do
+    let(:can_destroy) { false }
+
+    it 'does not render a link to destroy the document' do
+      render
+      expect(rendered).not_to have_link('Delete this collection', href: '/path/to/destroy')
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_show_add_items_actions.html.erb_spec.rb

@@ -0,0 +1,46 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_add_items_actions.html.erb', type: :view do
+  let(:presenter) { double('Hyrax::CollectionPresenter', solr_document: solr_document, id: '123', title: 'Collection 1') }
+  let(:solr_document) { double('Solr Document') }
+  let(:can_deposit) { true }
+
+  before do
+    allow(view).to receive(:presenter).and_return(presenter)
+    allow(presenter).to receive(:create_many_work_types?).and_return(true)
+    assign(:presenter, presenter)
+    allow(view).to receive(:can?).with(:deposit, solr_document).and_return(can_deposit)
+  end
+  describe 'when user can edit the document' do
+    let(:can_deposit) { true }
+
+    it 'renders add_existing_works_to_collection link' do
+      render
+      expect(rendered).to have_css(".btn[href='#{hyrax.my_works_path(add_works_to_collection: presenter.id,
+                                                                     add_works_to_collection_label: presenter.title)}']")
+    end
+    it 'renders add_new_work_to_collection link' do
+      render
+      expect(rendered).to have_link("Deposit new work through this collection")
+    end
+  end
+  describe 'when user cannot edit the document' do
+    let(:can_deposit) { false }
+
+    it 'does not render add_works_to_collection link' do
+      render
+      expect(rendered).not_to have_css(".actions-controls-collections .btn[href='#{hyrax.my_works_path(add_works_to_collection: presenter.id,
+                                                                                                       add_works_to_collection_label: presenter.title)}']")
+    end
+  end
+
+  describe 'when there is only one work type' do
+    let(:can_deposit) { true }
+
+    it 'renders add_new_work_to_collection link' do
+      allow(presenter).to receive(:create_many_work_types?).and_return(false)
+      allow(presenter).to receive(:first_work_type).and_return(GenericWork)
+
+      render
+      expect(rendered).to have_link("Deposit new work through this collection")
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_show_descriptions.html.erb_spec.rb

@@ -0,0 +1,32 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_descriptions.html.erb', type: :view do
+  context 'displaying a custom collection' do
+    let(:collection_size) { 123_456_678 }
+    let(:collection) do
+      {
+        id: '999',
+        "has_model_ssim" => ["Collection"],
+        "title_tesim" => ["Title 1"],
+        'date_created_tesim' => '2000-01-01'
+      }
+    end
+    let(:ability) { double }
+    let(:solr_document) { SolrDocument.new(collection) }
+    let(:presenter) { Hyrax::CollectionPresenter.new(solr_document, ability) }
+
+    before do
+      allow(presenter).to receive(:total_items).and_return(2)
+      allow(presenter).to receive(:size).and_return("118 MB")
+      assign(:presenter, presenter)
+    end
+
+    it "draws the metadata fields for collection" do
+      render
+      expect(rendered).to have_content 'Date Created'
+      expect(rendered).to include('itemprop="dateCreated"')
+      expect(rendered).to have_content 'Total items'
+      expect(rendered).to have_content '2'
+      expect(rendered).to have_content 'Size'
+      expect(rendered).to have_content '118 MB'
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_show_document_list.html.erb_spec.rb

@@ -0,0 +1,24 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_document_list.html.erb', type: :view do
+  let(:documents) { ["Hello", "World"] }
+
+  before do
+    stub_template('hyrax/dashboard/collections/_show_document_list_row.html.erb' => "<%= document %>")
+  end
+  context 'when not logged in' do
+    it "renders the documents without an Action section" do
+      allow(view).to receive(:current_user).and_return(nil)
+      render('show_document_list.html.erb', documents: documents)
+      expect(rendered).to have_css('tbody', text: documents.join)
+      expect(rendered).not_to have_css('th', text: 'Action')
+    end
+  end
+
+  context 'when logged in' do
+    it "renders the documents with an Action section" do
+      allow(view).to receive(:current_user).and_return(true)
+      render('show_document_list.html.erb', documents: documents)
+      expect(rendered).to have_css('tbody', text: documents.join)
+      expect(rendered).to have_css('th', text: 'Action')
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_show_document_list_menu.html.erb_spec.rb

@@ -0,0 +1,31 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_document_list_menu.html.erb', type: :view do
+  context 'when user is viewing a collection' do
+    let(:user) { create :user }
+    let(:ability) { instance_double("Ability") }
+    let(:document) { SolrDocument.new(id: '1234') }
+
+    before do
+      view.extend Hyrax::TrophyHelper
+      allow(document).to receive(:to_model).and_return(stub_model(GenericWork))
+      allow(controller).to receive(:current_ability).and_return(ability)
+    end
+
+    it "displays the action list in a drop down for an individual work the user can edit" do
+      allow(ability).to receive(:can?).with(:edit, document).and_return(true)
+      render('show_document_list_menu', document: document, current_user: user)
+      expect(rendered).to have_content 'Select'
+      expect(rendered).to have_content 'Edit'
+      expect(rendered).not_to have_content 'Download File'
+      expect(rendered).to have_content 'Highlight Work on Profile'
+    end
+
+    it "displays the action list in a drop down for an individual work the user cannot edit" do
+      allow(ability).to receive(:can?).with(:edit, document).and_return(false)
+      render('show_document_list_menu', document: document, current_user: user)
+      expect(rendered).to have_content 'Select'
+      expect(rendered).not_to have_content 'Edit'
+      expect(rendered).not_to have_content 'Download File'
+      expect(rendered).to have_content 'Highlight Work on Profile'
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_show_document_list_row.html.erb_spec.rb

@@ -0,0 +1,35 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_document_list_row.html.erb', type: :view do
+  let(:user) { create(:user) }
+
+  let(:work) do
+    mock_model(GenericWork, label: 'One Hundred Years of Solitude', date_uploaded: '1999',
+                            collection?: true, visibility: 'open',
+                            title: ['One Hundred Years of Solitude'],
+                            depositor: user,
+                            edit_groups: [],
+                            creator: ["ggm"])
+  end
+
+  let(:collection) { mock_model(Collection, title: 'My awesome collection', members: [work]) }
+
+  context 'when not logged in' do
+    before do
+      view.blacklight_config = Blacklight::Configuration.new
+      allow(view).to receive(:current_user).and_return(nil)
+      allow(work).to receive(:title_or_label).and_return("One Hundred Years of Solitude")
+      allow(work).to receive(:edit_people).and_return([])
+      allow(view).to receive(:render_collection_links).and_return("collections: #{collection.title}")
+    end
+
+    it "renders collections links" do
+      render('show_document_list_row', document: work)
+      expect(rendered).to have_content 'My awesome collection'
+    end
+
+    it "renders works" do
+      render('show_document_list_row', document: work)
+      expect(rendered).to have_content 'One Hundred Years of Solitude'
+      expect(rendered).to have_content('Edit Access:')
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_show_parent_collection_row.html.erb_spec.rb

@@ -0,0 +1,61 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_parent_collection_row.html.erb', type: :view do
+  let(:child_collection) { double('Collection', id: '123') }
+  let(:parent_collection_doc) do
+    { id: '999',
+      "has_model_ssim" => ["Collection"],
+      "title_tesim" => ["Title 1"],
+      'date_created_tesim' => '2000-01-01' }
+  end
+  let(:document) { SolrDocument.new(parent_collection_doc) }
+  let(:subject) { render('show_parent_collection_row.html.erb', id: child_collection.id, document: document) }
+
+  context 'when user cannot edit the child collection' do
+    before do
+      allow(view).to receive(:can?).with(:edit, child_collection.id).and_return(false)
+      allow(view).to receive(:can?).with(:edit, document.id).and_return(true)
+    end
+
+    it 'does shows link to collection title but not the remove button' do
+      subject
+      expect(rendered).to have_link(document.title.first)
+      expect(rendered).not_to have_button("Remove")
+      expect(rendered).not_to have_link("Remove")
+    end
+  end
+
+  context 'when user can edit the child collection' do
+    before do
+      allow(view).to receive(:can?).with(:edit, child_collection.id).and_return(true)
+    end
+
+    context 'and user can edit the parent collection' do
+      before do
+        allow(view).to receive(:can?).with(:edit, document.id).and_return(true)
+      end
+
+      it 'shows link to collection title and active remove button' do
+        subject
+        expect(rendered).to have_link(document.title.first)
+        expect(rendered).to have_button("Remove")
+      end
+
+      it "renders the proper data attributes on list element" do
+        expect(subject).to have_selector(:css, 'li[data-post-url="/dashboard/collections/123/remove_parent/999"]')
+        expect(subject).to have_selector(:css, 'li[data-id="123"]')
+        expect(subject).to have_selector(:css, 'li[data-parent-id="999"]')
+      end
+    end
+
+    context 'and user cannot edit the parent collection' do
+      before do
+        allow(view).to receive(:can?).with(:edit, document.id).and_return(false)
+      end
+
+      it 'shows link to collection title and active remove link' do
+        subject
+        expect(rendered).to have_link(document.title.first)
+        expect(rendered).to have_link("Remove")
+      end
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_show_parent_collections.html.erb_spec.rb

@@ -0,0 +1,82 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_parent_collections.html.erb', type: :view do
+  let(:collection_doc) do
+    {
+      id: '999',
+      "has_model_ssim" => ["Collection"],
+      "title_tesim" => ["Title 1"],
+      'date_created_tesim' => '2000-01-01'
+    }
+  end
+  let(:subject) { render('show_parent_collections.html.erb', presenter: presenter) }
+  let(:ability) { double }
+  let(:solr_document) { SolrDocument.new(collection_doc) }
+  let(:presenter) { Hyrax::CollectionPresenter.new(solr_document, ability) }
+  let(:collection1) { double('Collection') }
+  let(:collection2) { double('Collection') }
+  let(:collection3) { double('Collection') }
+  let(:collection4) { double('Collection') }
+  let(:collection5) { double('Collection') }
+  let(:parent_collections) { double(Object, documents: parent_docs, response: { "numFound" => parent_docs.size }, total_pages: 1) }
+
+  before do
+    stub_template "hyrax/dashboard/collections/_show_parent_collection_row.html.erb" => "parent collection"
+    assign(:presenter, presenter)
+    presenter.parent_collections = parent_collections
+
+    allow(collection1).to receive(:persisted?).and_return true
+    allow(collection2).to receive(:persisted?).and_return true
+    allow(collection3).to receive(:persisted?).and_return true
+    allow(collection4).to receive(:persisted?).and_return true
+    allow(collection5).to receive(:persisted?).and_return true
+  end
+
+  context 'when parent collections are nil' do
+    let(:parent_collections) { nil }
+
+    it "posts a warning message" do
+      subject
+      expect(rendered).to have_text("There are no visible parent collections.")
+      expect(subject).not_to render_template("_show_parent_collection_row")
+    end
+
+    it 'does not render pagination' do
+      expect(subject).not_to render_template("hyrax/collections/_paginate")
+    end
+  end
+
+  context 'when parent collection list is empty' do
+    let(:parent_docs) { [] }
+
+    it "posts a warning message" do
+      subject
+      expect(rendered).to have_text("There are no visible parent collections.")
+      expect(subject).not_to render_template("_show_parent_collection_row")
+    end
+
+    it 'does not render pagination' do
+      expect(subject).not_to render_template("hyrax/collections/_paginate")
+    end
+  end
+
+  context 'when parent collection list is not empty' do
+    let(:parent_docs) { [collection1, collection2, collection3, collection4, collection5] }
+
+    before do
+      stub_template "_modal_remove_from_collection.html.erb" => 'modal'
+    end
+
+    it "posts the collection's title with a link to the collection" do
+      assign(:events, parent_docs)
+      subject
+      expect(view).to render_template(partial: "_show_parent_collection_row", count: 5)
+    end
+
+    it 'renders pagination' do
+      expect(subject).to render_template("hyrax/collections/_paginate")
+    end
+
+    it 'renders the remove from list modal' do
+      expect(subject).to render_template("_modal_remove_from_collection")
+    end
+  end
+end

data/spec/views/hyrax/dashboard/collections/_show_subcollection_actions.html.erb_spec.rb

@@ -0,0 +1,62 @@
+RSpec.describe 'hyrax/dashboard/collections/_show_subcollection_actions.html.erb', type: :view do
+  let(:presenter) do
+    double('Hyrax::CollectionPresenter',
+           collection_type_is_nestable?: is_nestable,
+           collection: collection,
+           id: '123',
+           user_can_nest_collection?: can_deposit,
+           user_can_create_new_nest_collection?: can_create)
+  end
+  let(:collection) { double('A Collection') }
+  let(:is_nestable) { true }
+  let(:can_deposit) { true }
+  let(:can_create) { true }
+
+  before do
+    allow(view).to receive(:presenter).and_return(presenter)
+  end
+
+  describe 'when user has permission to create subcollections' do
+    before do
+      render
+    end
+
+    it 'renders a links to nest subcollection options' do
+      expect(rendered).to have_button(I18n.t('hyrax.collection.actions.nest_collections.desc'))
+      expect(rendered).to have_css(".btn[href='#{hyrax.dashboard_create_subcollection_under_path(parent_id: presenter.id)}']")
+    end
+  end
+
+  describe 'when the collection_type is not nestable' do
+    let(:is_nestable) { false }
+
+    it 'does not render a link to add_collections to this collection' do
+      render
+      expect(rendered).not_to have_css(".actions-controls-collections .btn[href='#{hyrax.dashboard_create_subcollection_under_path(parent_id: presenter.id)}']")
+    end
+  end
+
+  describe 'when user has no nesting permissions' do
+    let(:can_deposit) { false }
+
+    describe 'when the collection_type is nestable' do
+      it 'does not render a either nesting option' do
+        render
+        expect(rendered).not_to have_button(I18n.t('hyrax.collection.actions.nest_collections.desc'))
+        expect(rendered).not_to have_css(".actions-controls-collections .btn[href='#{hyrax.dashboard_create_subcollection_under_path(parent_id: presenter.id)}']")
+      end
+    end
+  end
+
+  describe 'when user cannot create new collection' do
+    let(:can_create) { false }
+
+    describe 'when the collection_type is nestable' do
+      it 'does not render a button to create a new collection' do
+        render
+        expect(rendered).to have_button(I18n.t('hyrax.collection.actions.nest_collections.desc'))
+        expect(rendered).not_to have_css(".actions-controls-collections .btn[href='#{hyrax.dashboard_create_subcollection_under_path(parent_id: presenter.id)}']")
+      end
+    end
+  end
+end