hyrax 2.9.6 → 3.0.0.pre.beta1

data/spec/services/hyrax/embargo_service_spec.rb

@@ -0,0 +1,59 @@
+RSpec.describe Hyrax::EmbargoService do
+  subject { described_class }
+
+  let(:future_date) { 2.days.from_now }
+  let(:past_date) { 2.days.ago }
+
+  let!(:work_with_expired_embargo1) do
+    build(:work, embargo_release_date: past_date.to_s).tap do |work|
+      work.save(validate: false)
+    end
+  end
+
+  let!(:work_with_expired_embargo2) do
+    build(:work, embargo_release_date: past_date.to_s).tap do |work|
+      work.save(validate: false)
+    end
+  end
+
+  let!(:work_with_embargo_in_effect) { create(:work, embargo_release_date: future_date.to_s) }
+  let!(:work_without_embargo) { create(:generic_work) }
+
+  describe '#assets_with_expired_embargoes' do
+    it 'returns an array of assets with expired embargoes' do
+      returned_pids = subject.assets_with_expired_embargoes.map(&:id)
+      expect(returned_pids).to include work_with_expired_embargo1.id, work_with_expired_embargo2.id
+      expect(returned_pids).not_to include work_with_embargo_in_effect.id, work_without_embargo.id
+    end
+  end
+
+  describe '#assets_under_embargo' do
+    it 'returns all assets with embargo release date set' do
+      returned_pids = subject.assets_under_embargo.map(&:id)
+      expect(returned_pids).to include work_with_expired_embargo1.id, work_with_expired_embargo2.id, work_with_embargo_in_effect.id
+      expect(returned_pids).not_to include work_without_embargo.id
+    end
+  end
+
+  describe '#assets_with_deactivated_embargoes' do
+    let(:id) { Noid::Rails::Service.new.mint }
+    let(:attributes) do
+      { 'embargo_history_ssim' => ['This is in the past'],
+        'id' => id }
+    end
+
+    before do
+      ActiveFedora::SolrService.add(attributes)
+      ActiveFedora::SolrService.commit
+    end
+
+    it 'returns all assets with embargo history set' do
+      returned_pids = subject.assets_with_deactivated_embargoes.map(&:id)
+      expect(returned_pids).to include id
+      expect(returned_pids).not_to include(work_without_embargo.id,
+                                           work_with_expired_embargo1.id,
+                                           work_with_expired_embargo2.id,
+                                           work_with_embargo_in_effect.id)
+    end
+  end
+end

data/spec/services/hyrax/file_set_csv_service_spec.rb

@@ -0,0 +1,83 @@
+RSpec.describe Hyrax::FileSetCSVService do
+  let(:mock_file) do
+    Hydra::PCDM::File.new
+  end
+  let(:file) do
+    FileSet.new(id: '123abc', title: ['My Title'], creator: ['Von, Creator'],
+                resource_type: ['Book', 'Other'], license: ['Mine']) do |f|
+      f.apply_depositor_metadata('jilluser@example.com')
+    end
+  end
+  let(:solr_document) { SolrDocument.new(file.to_solr) }
+
+  before do
+    allow(mock_file).to receive(:mime_type).and_return('application/pdf')
+    allow(file).to receive(:resource_type).and_return(['Book', 'Other'])
+    allow(file).to receive(:original_file).and_return(mock_file)
+  end
+
+  context "when using the defaults" do
+    let(:csv_service) { described_class.new(solr_document) }
+
+    describe "csv" do
+      subject { csv_service.csv }
+
+      it { is_expected.to eq "123abc,My Title,jilluser@example.com,\"Von, Creator\",restricted,Book|Other,Mine,pdf\n" }
+      it "parses as valid csv" do
+        expect(CSV.parse(subject)).to eq([["123abc", "My Title", "jilluser@example.com", "Von, Creator", "restricted", "Book|Other", "Mine", "pdf"]])
+      end
+    end
+
+    describe "csv_header" do
+      subject { csv_service.csv_header }
+
+      it { is_expected.to eq "id,title,depositor,creator,visibility,resource_type,license,file_format\n" }
+    end
+  end
+
+  context "when specifying terms" do
+    let(:csv_service) { described_class.new(file, [:id, :title, :resource_type]) }
+
+    describe "csv" do
+      subject { csv_service.csv }
+
+      it { is_expected.to eq "123abc,My Title,Book|Other\n" }
+    end
+    describe "csv_header" do
+      subject { csv_service.csv_header }
+
+      it { is_expected.to eq "id,title,resource_type\n" }
+    end
+  end
+
+  context "when specifying separator" do
+    let(:csv_service) { described_class.new(solr_document, nil, '&&') }
+
+    describe "csv" do
+      subject { csv_service.csv }
+
+      it { is_expected.to eq "123abc,My Title,jilluser@example.com,\"Von, Creator\",restricted,Book&&Other,Mine,pdf\n" }
+    end
+
+    describe "csv_header" do
+      subject { csv_service.csv_header }
+
+      it { is_expected.to eq "id,title,depositor,creator,visibility,resource_type,license,file_format\n" }
+    end
+  end
+
+  context "when specifying terms and separator" do
+    let(:csv_service) { described_class.new(file, [:id, :title, :resource_type], '*$*') }
+
+    describe "csv" do
+      subject { csv_service.csv }
+
+      it { is_expected.to eq "123abc,My Title,Book*$*Other\n" }
+    end
+    describe "csv_header" do
+      subject { csv_service.csv_header }
+
+      it { is_expected.to eq "id,title,resource_type\n" }
+    end
+  end
+end

data/spec/services/hyrax/file_set_derivatives_service_spec.rb

@@ -0,0 +1,13 @@
+require 'hyrax/specs/shared_specs'
+
+RSpec.describe Hyrax::FileSetDerivativesService do
+  let(:valid_file_set) do
+    FileSet.new.tap do |f|
+      allow(f).to receive(:mime_type).and_return(FileSet.image_mime_types.first)
+    end
+  end
+
+  subject { described_class.new(file_set) }
+
+  it_behaves_like "a Hyrax::DerivativeService"
+end

data/spec/services/hyrax/file_set_fixity_check_service_spec.rb

@@ -0,0 +1,77 @@
+RSpec.describe Hyrax::FileSetFixityCheckService do
+  let(:f)                 { create(:file_set, content: File.open(fixture_path + '/world.png')) }
+  let(:service_by_object) { described_class.new(f) }
+  let(:service_by_id)     { described_class.new(f.id) }
+
+  describe "async_jobs: false" do
+    let(:service_by_object) { described_class.new(f, async_jobs: false) }
+    let(:service_by_id)     { described_class.new(f.id, async_jobs: false) }
+
+    describe '#fixity_check' do
+      subject { service_by_object.fixity_check }
+
+      context 'when a file has two versions' do
+        before do
+          Hyrax::VersioningService.create(f.original_file) # create a second version -- the factory creates the first version when it attaches +content+
+        end
+        specify 'returns two log results' do
+          expect(subject.values.flatten.length).to eq(2)
+        end
+
+        context "with latest_version_only" do
+          let(:service_by_object) { described_class.new(f, async_jobs: false, latest_version_only: true) }
+
+          specify "returns one log result" do
+            expect(subject.values.length).to eq(1)
+          end
+        end
+      end
+
+      context "existing check and disabled max_days_between_fixity_checks" do
+        let(:service_by_object) { described_class.new(f, async_jobs: false, max_days_between_fixity_checks: -1) }
+        let(:service_by_id)     { described_class.new(f.id, async_jobs: false, max_days_between_fixity_checks: -1) }
+        let!(:existing_record) do
+          ChecksumAuditLog.create!(passed: true, file_set_id: f.id, checked_uri: f.original_file.versions.first.label, file_id: f.original_file.id)
+        end
+
+        it "re-checks" do
+          existing_record
+          expect(subject.length).to eq 1
+          expect(subject.values.flatten.first.id).not_to eq(existing_record.id)
+          expect(subject.values.flatten.first.created_at).to be > existing_record.created_at
+        end
+      end
+    end
+
+    describe '#fixity_check_file' do
+      subject { service_by_object.send(:fixity_check_file, f.original_file) }
+
+      specify 'returns a single result' do
+        expect(subject.length).to eq(1)
+      end
+      describe 'non-versioned file with latest version only' do
+        let(:service_by_object) { described_class.new(f, async_jobs: false, latest_version_only: true) }
+
+        before do
+          allow(f.original_file).to receive(:has_versions?).and_return(false)
+        end
+
+        subject { service_by_object.send(:fixity_check_file, f.original_file) }
+
+        specify 'returns a single result' do
+          expect(subject.length).to eq(1)
+        end
+      end
+    end
+
+    describe '#fixity_check_file_version' do
+      subject { service_by_object.send(:fixity_check_file_version, f.original_file.id, f.original_file.uri.to_s) }
+
+      specify 'returns a single ChecksumAuditLog for the given file' do
+        expect(subject).to be_kind_of ChecksumAuditLog
+        expect(subject.file_set_id).to eq(f.id)
+        expect(subject.checked_uri).to eq(f.original_file.uri)
+      end
+    end
+  end
+end

data/spec/services/hyrax/fixity_check_failure_service_spec.rb

@@ -0,0 +1,30 @@
+RSpec.describe Hyrax::FixityCheckFailureService do
+  let!(:depositor) { create(:user) }
+  let!(:log_date) { '2015-07-15 03:06:59' }
+  let(:inbox) { depositor.mailbox.inbox }
+  let(:file) { Hydra::PCDM::File.new }
+  let(:version_uri) { "#{file.uri}/fcr:versions/version1" }
+  let(:file_set) do
+    create(:file_set, user: depositor, title: ["World Icon"]).tap { |fs| fs.original_file = file }
+  end
+
+  let(:checksum_audit_log) do
+    ChecksumAuditLog.new(file_set_id: file_set.id,
+                         file_id: file_set.original_file.id,
+                         checked_uri: version_uri,
+                         created_at: log_date,
+                         updated_at: log_date,
+                         passed: false)
+  end
+
+  describe "#call" do
+    subject { described_class.new(file_set, checksum_audit_log: checksum_audit_log) }
+
+    it "sends failing mail" do
+      subject.call
+      expect(inbox.count).to eq(1)
+      inbox.each { |msg| expect(msg.last_message.subject).to eq('Failing Fixity Check') }
+      inbox.each { |msg| expect(msg.last_message.body).to eq('The fixity check run at ' + checksum_audit_log.created_at.to_s + ' for ' + file_set.to_s + ' (' + file.uri + ') failed.') }
+    end
+  end
+end

data/spec/services/hyrax/graph_exporter_spec.rb

@@ -0,0 +1,58 @@
+RSpec.describe Hyrax::GraphExporter do
+  let(:work) { create(:work_with_one_file, visibility: 'open') }
+  let(:document) { double(id: work.id) }
+  let(:request) { double(host: 'localhost') }
+  let(:service) { described_class.new(document, request) }
+
+  describe "fetch" do
+    subject { service.fetch }
+
+    let(:ttl) { subject.dump(:ntriples) }
+
+    it "transforms suburis to hashcodes" do
+      expect(ttl).to match %r{<http://localhost/concern/generic_works/#{work.id}> <http://www.w3.org/1999/02/22-rdf-syntax-ns#type> <http://projecthydra.org/works/models#Work>}
+      expect(ttl).to match %r{<http://purl\.org/dc/terms/title> "Test title"}
+      expect(ttl).to match %r{<http://www\.w3\.org/ns/auth/acl#accessControl> <http://localhost/catalog/}
+
+      query = subject.query([RDF::URI("http://localhost/concern/generic_works/#{work.id}"),
+                             RDF::URI("http://www.iana.org/assignments/relation/first"),
+                             nil])
+      proxy = query.to_a.first.object
+
+      expect(proxy.to_s).to match %r{http://localhost/concern/generic_works/#{work.id}/list_source#g\d+}
+
+      # It includes the list nodes on the graph
+      expect(subject.query([proxy, nil, nil]).count).to eq 2
+    end
+
+    context "when a Ldp::NotFound is raised" do
+      let(:mock_service) { instance_double(Hydra::ContentNegotiation::CleanGraphRepository) }
+
+      before do
+        allow(service).to receive(:clean_graph_repository).and_return(mock_service)
+        allow(mock_service).to receive(:find).and_raise(Ldp::NotFound)
+      end
+      it "raises a error that the controller catches and handles" do
+        expect { subject }.to raise_error ActiveFedora::ObjectNotFoundError
+      end
+    end
+
+    context 'with a nested work' do
+      let(:work) do
+        NamespacedWorks::NestedWork
+          .create(title: ['Comet in Moominland'],
+                  created_attributes: [{ start: DateTime.now.utc - 1, finish: DateTime.now.utc },
+                                       { start: DateTime.now.utc - 2, finish: DateTime.now.utc }])
+      end
+
+      it 'includes each nested resources once' do
+        resource_fragments = work.created.map { |ts| ts.rdf_subject.fragment }
+        mapped_fragments   = subject.query(predicate: RDF.type, object: RDF::Vocab::EDM.TimeSpan)
+                                    .subjects
+                                    .map(&:fragment)
+
+        expect(mapped_fragments).to contain_exactly(*resource_fragments)
+      end
+    end
+  end
+end

data/spec/services/hyrax/iiif_authorization_service_spec.rb

@@ -0,0 +1,43 @@
+RSpec.describe Hyrax::IIIFAuthorizationService do
+  let(:user) { create(:user) }
+  let(:ability) { Ability.new(user) }
+  let(:controller) { double(current_ability: ability) }
+  let(:service) { described_class.new(controller) }
+  let(:file_set_id) { 'mp48sc763' }
+  let(:image_id) { "#{file_set_id}/files/0b957460-99b4-4c31-902f-0fc23eefb972" }
+  let(:image) { Riiif::Image.new(image_id) }
+
+  describe "#can?" do
+    context "when the user has read access to the FileSet" do
+      before { allow(ability).to receive(:test_read).with(file_set_id).and_return(true) }
+
+      context "info" do
+        subject { service.can?(:info, image) }
+
+        it { is_expected.to be true }
+      end
+
+      context "show" do
+        subject { service.can?(:show, image) }
+
+        it { is_expected.to be true }
+      end
+    end
+
+    context "when the user doesn't have read access to the FileSet" do
+      before { allow(ability).to receive(:test_read).with(file_set_id).and_return(false) }
+
+      context "info" do
+        subject { service.can?(:info, image) }
+
+        it { is_expected.to be false }
+      end
+
+      context "show" do
+        subject { service.can?(:show, image) }
+
+        it { is_expected.to be false }
+      end
+    end
+  end
+end

data/spec/services/hyrax/import_url_failure_service_spec.rb

@@ -0,0 +1,23 @@
+
+RSpec.describe Hyrax::ImportUrlFailureService do
+  let!(:depositor) { create(:user) }
+  let(:inbox) { depositor.mailbox.inbox }
+  let(:file) do
+    create(:file_set, user: depositor)
+  end
+
+  before do
+    allow(file.errors).to receive(:full_messages).and_return(['huge mistake'])
+  end
+
+  describe "#call" do
+    before do
+      described_class.new(file, depositor).call
+    end
+
+    it "sends failing mail" do
+      expect(inbox.count).to eq(1)
+      expect(inbox.first.last_message.subject).to eq('File Import Error')
+    end
+  end
+end

data/spec/services/hyrax/lease_service_spec.rb

@@ -0,0 +1,50 @@
+RSpec.describe Hyrax::LeaseService do
+  subject { described_class }
+
+  let(:future_date) { 2.days.from_now }
+  let(:past_date) { 2.days.ago }
+
+  let!(:work_with_expired_lease1) do
+    build(:generic_work, lease_expiration_date: past_date.to_s).tap do |work|
+      work.save(validate: false)
+    end
+  end
+
+  let!(:work_with_expired_lease2) do
+    build(:generic_work, lease_expiration_date: past_date.to_s).tap do |work|
+      work.save(validate: false)
+    end
+  end
+
+  let!(:work_with_lease_in_effect) { create(:generic_work, lease_expiration_date: future_date.to_s) }
+  let!(:work_without_lease) { create(:generic_work) }
+
+  describe '#assets_with_expired_leases' do
+    it 'returns an array of assets with expired lease' do
+      returned_pids = subject.assets_with_expired_leases.map(&:id)
+      expect(returned_pids).to include work_with_expired_lease1.id, work_with_expired_lease2.id
+      expect(returned_pids).not_to include work_with_lease_in_effect.id, work_without_lease.id
+    end
+  end
+
+  describe '#assets_under_lease' do
+    it 'returns an array of assets with active leases' do
+      returned_pids = subject.assets_under_lease.map(&:id)
+      expect(returned_pids).to include work_with_expired_lease1.id, work_with_expired_lease2.id, work_with_lease_in_effect.id
+      expect(returned_pids).not_to include work_without_lease.id
+    end
+  end
+
+  describe '#assets_with_deactivated_leases' do
+    before do
+      work_with_expired_lease1.deactivate_lease!
+      work_with_expired_lease1.save!
+      work_with_lease_in_effect.deactivate_lease!
+      work_with_lease_in_effect.save!
+    end
+    it 'returns an array of assets with deactivated leases' do
+      returned_pids = subject.assets_with_deactivated_leases.map(&:id)
+      expect(returned_pids).to include work_with_expired_lease1.id, work_with_lease_in_effect.id
+    end
+  end
+end

data/spec/services/hyrax/license_service_spec.rb

@@ -0,0 +1,34 @@
+RSpec.describe Hyrax::LicenseService do
+  before do
+    # Configure QA to use fixtures
+    qa_fixtures = { local_path: File.expand_path('spec/fixtures/authorities') }
+    allow(Qa::Authorities::Local).to receive(:config).and_return(qa_fixtures)
+  end
+  let(:service) { described_class.new }
+
+  describe "#select_active_options" do
+    it "returns active terms" do
+      expect(service.select_active_options).to include(["First Active Term", "demo_id_01"], ["Second Active Term", "demo_id_02"])
+    end
+
+    it "does not return inactive terms" do
+      expect(service.select_active_options).not_to include(["Third is an Inactive Term", "demo_id_03"], ["Fourth is an Inactive Term", "demo_id_04"])
+    end
+  end
+
+  describe "#select_all_options" do
+    it "returns both active and inactive terms" do
+      expect(service.select_all_options).to include(["Fourth is an Inactive Term", "demo_id_04"], ["First Active Term", "demo_id_01"])
+    end
+  end
+
+  describe "#label" do
+    it "resolves for ids of active terms" do
+      expect(service.label('demo_id_01')).to eq("First Active Term")
+    end
+
+    it "resolves for ids of inactive terms" do
+      expect(service.label('demo_id_03')).to eq("Third is an Inactive Term")
+    end
+  end
+end

data/spec/services/hyrax/lock_manager_spec.rb

@@ -0,0 +1,13 @@
+RSpec.describe Hyrax::LockManager do
+  subject do
+    described_class.new(Hyrax.config.lock_time_to_live,
+                        Hyrax.config.lock_retry_count,
+                        Hyrax.config.lock_retry_delay)
+  end
+
+  describe "lock", unless: ENV['TRAVIS'] do
+    it "calls the block" do
+      expect { |probe| subject.lock('foobar', &probe) }.to yield_with_no_args
+    end
+  end
+end

data/spec/services/hyrax/messenger_service_spec.rb

@@ -0,0 +1,15 @@
+RSpec.describe Hyrax::MessengerService do
+  describe '#deliver' do
+    let(:sender) { create(:user) }
+    let(:recipients) { create(:user) }
+    let(:body) { 'Quite an excellent message' }
+    let(:subject) { 'IMPORTANT' }
+    let(:other_arg) { 'Did I make it?' }
+
+    it 'invokes Hyrax::MessengerService to deliver the message' do
+      expect(sender).to receive(:send_message).with(recipients, body, subject, other_arg)
+      expect(StreamNotificationsJob).to receive(:perform_later).with(recipients)
+      described_class.deliver(sender, recipients, body, subject, other_arg)
+    end
+  end
+end

data/spec/services/hyrax/microdata_spec.rb

@@ -0,0 +1,94 @@
+module Hyrax
+  RSpec.describe Microdata do
+    let(:yml_path) { File.join(fixture_path, 'config', 'schema_org.yml') }
+    let(:yml_path_secondary) { File.join(fixture_path, 'config', 'schema_org_second.yml') }
+
+    before do
+      described_class.load_paths = yml_path
+    end
+
+    after do
+      # Need to reset as this is an instance variable
+      described_class.clear_load_paths!
+    end
+
+    describe '.load_paths' do
+      subject { described_class.load_paths }
+
+      it { is_expected.to be_a(Array) }
+      it 'can be appended to' do
+        expect { subject << yml_path_secondary }.to change { described_class.load_paths.size }.by(1)
+      end
+    end
+    describe '.load_paths=' do
+      it 'replaces the existing' do
+        expect do
+          described_class.load_paths = yml_path_secondary
+        end.to change { described_class.load_paths }.to([yml_path_secondary])
+      end
+    end
+    describe '.fetch' do
+      describe 'with one file in the load path' do
+        describe 'with a default' do
+          describe 'and a miss on the key' do
+            it 'will be the given default value' do
+              expect(described_class.fetch('going.to.miss', default: "and a miss")).to eq('and a miss')
+            end
+          end
+          describe 'and hit on the key' do
+            subject { described_class.fetch('name.value') }
+
+            it 'will be the registered value' do
+              expect(subject).to eq('firstName')
+            end
+          end
+        end
+        describe 'without a default' do
+          describe 'and a miss on the key' do
+            subject { described_class.fetch('going.to.miss') }
+
+            it { is_expected.to be_nil }
+          end
+          describe 'and hit on the key' do
+            subject { described_class.fetch('name.value') }
+
+            it 'will be the registered value' do
+              expect(subject).to eq('firstName')
+            end
+          end
+        end
+      end
+      describe 'with multiple files in the load path' do
+        before do
+          described_class.load_paths = [yml_path, yml_path_secondary]
+        end
+        describe 'and a miss on the key' do
+          it 'will be the given default value' do
+            expect(described_class.fetch('going.to.miss', default: "and a miss")).to eq('and a miss')
+          end
+        end
+        describe 'and what would be a hit on the first and second loaded file' do
+          subject { described_class.fetch('name.value') }
+
+          it 'will be the second value loaded' do
+            expect(subject).to eq('secondFirstName')
+          end
+        end
+        describe 'and a hit on the first loaded file but not the second' do
+          subject { described_class.fetch('first_only.value') }
+
+          it 'will be the first loaded value' do
+            expect(subject).to eq('iAmTheFirstOnly')
+          end
+        end
+        describe 'and a hit on the second loaded file but not the first' do
+          subject { described_class.fetch('second_only.value') }
+
+          it 'will be the first loaded value' do
+            expect(subject).to eq('iAmTheSecondOnly')
+          end
+        end
+      end
+    end
+  end
+end