hyrax 2.9.6 → 3.0.0.pre.beta1

data/spec/features/collection_type_spec.rb

@@ -0,0 +1,393 @@
+RSpec.describe 'collection_type', type: :feature, clean_repo: true do
+  let(:admin_user) { create(:admin) }
+  let(:exhibit_title) { 'Exhibit' }
+  let(:exhibit_description) { 'Description for exhibit collection type.' }
+  let(:exhibit_collection_type) { create(:collection_type, title: exhibit_title, description: exhibit_description, creator_user: admin_user) }
+  let(:user_collection_type) { create(:user_collection_type) }
+  let(:admin_set_type) { create(:admin_set_collection_type) }
+  let(:solr_gid) { Collection.collection_type_gid_document_field_name }
+
+  describe 'index' do
+    before do
+      exhibit_collection_type
+      user_collection_type
+      admin_set_type
+      sign_in admin_user
+      visit '/admin/collection_types'
+    end
+
+    it 'has page title and lists collection types' do
+      expect(page).to have_content 'Collection Types'
+
+      expect(page).to have_content 'Admin Set'
+      expect(page).to have_content 'User Collection'
+      expect(page).to have_content 'Collection Type'
+
+      expect(page).to have_link('Edit', count: 3)
+      expect(page).to have_link('Edit', href: hyrax.edit_admin_collection_type_path(admin_set_type.id, locale: 'en'))
+      expect(page).to have_link('Edit', href: hyrax.edit_admin_collection_type_path(user_collection_type.id, locale: 'en'))
+      expect(page).to have_link('Edit', href: hyrax.edit_admin_collection_type_path(exhibit_collection_type.id, locale: 'en'))
+      expect(page).to have_button('Delete', count: 2) # 1: Collection Type, 2: delete modal
+    end
+  end
+
+  describe 'create collection type' do
+    let(:title) { 'Test Type' }
+    let(:description) { 'Description for collection type we are testing.' }
+
+    before do
+      sign_in admin_user
+      visit '/admin/collection_types'
+    end
+
+    it 'makes a new collection type', :js do
+      click_link 'Create new collection type'
+
+      expect(page).to have_content 'Create New Collection Type'
+
+      # confirm only Description tab is visible
+      expect(page).to have_link('Description', href: '#metadata')
+      expect(page).not_to have_link('Settings', href: '#settings')
+      expect(page).not_to have_link('Participants', href: '#participants')
+
+      # confirm metadata fields exist
+      expect(page).to have_selector 'input#collection_type_title'
+      expect(page).to have_selector 'textarea#collection_type_description'
+
+      # set values and save
+      fill_in('Type name', with: title)
+      fill_in('Type description', with: description)
+
+      click_button('Save')
+
+      # confirm values were set
+      expect(page).to have_selector "input#collection_type_title[value='#{title}']"
+      expect(page).to have_selector 'textarea#collection_type_description', text: description
+
+      # confirm all edit tabs are now visible
+      expect(page).to have_link('Description', href: '#metadata')
+      expect(page).to have_link('Settings', href: '#settings')
+      expect(page).to have_link('Participants', href: '#participants')
+    end
+
+    it 'tries to make a collection type with existing title, and receives error message', :js do
+      click_link 'Create new collection type'
+
+      expect(page).to have_content 'Create New Collection Type'
+
+      # confirm only Description tab is visible
+      expect(page).to have_link('Description', href: '#metadata')
+      expect(page).not_to have_link('Settings', href: '#settings')
+      expect(page).not_to have_link('Participants', href: '#participants')
+
+      # confirm metadata fields exist
+      expect(page).to have_selector 'input#collection_type_title'
+      expect(page).to have_selector 'textarea#collection_type_description'
+
+      # set values and save
+      fill_in('Type name', with: title)
+      fill_in('Type description', with: description)
+
+      click_button('Save')
+
+      visit '/admin/collection_types'
+      click_link 'Create new collection type'
+
+      expect(page).to have_content 'Create New Collection Type'
+
+      # confirm only Description tab is visible
+      expect(page).to have_link('Description', href: '#metadata')
+      expect(page).not_to have_link('Settings', href: '#settings')
+      expect(page).not_to have_link('Participants', href: '#participants')
+
+      # confirm metadata fields exist
+      expect(page).to have_selector 'input#collection_type_title'
+      expect(page).to have_selector 'textarea#collection_type_description'
+
+      # set values and save
+      fill_in('Type name', with: title)
+      fill_in('Type description', with: description)
+
+      click_button('Save')
+
+      # Confirm error message is displayed.
+      expect(page).to have_content 'Save was not successful because title has already been taken, and machine_id has already been taken.'
+    end
+  end
+
+  describe 'edit collection type' do
+    context 'when there are no collections of this type' do
+      let(:title_old) { exhibit_title }
+      let(:description_old) { exhibit_description }
+      let(:title_new) { 'Exhibit modified' }
+      let(:description_new) { 'Change in description for exhibit collection type.' }
+
+      before do
+        exhibit_collection_type
+        sign_in admin_user
+        visit "/admin/collection_types/#{exhibit_collection_type.id}/edit"
+      end
+
+      it 'modifies metadata values of a collection type', :js do
+        expect(page).to have_content "Edit Collection Type: #{title_old}"
+
+        # confirm all tabs are visible
+        expect(page).to have_link('Description', href: '#metadata')
+        expect(page).to have_link('Settings', href: '#settings')
+        expect(page).to have_link('Participants', href: '#participants')
+
+        # confirm metadata fields have original values
+        expect(page).to have_selector "input#collection_type_title[value='#{title_old}']"
+        expect(page).to have_selector 'textarea#collection_type_description', text: description_old
+
+        # set values and save
+        fill_in('Type name', with: title_new)
+        fill_in('Type description', with: description_new)
+
+        click_button('Save changes')
+
+        expect(page).to have_content "Edit Collection Type: #{title_new}"
+
+        # confirm values were set
+        expect(page).to have_selector "input#collection_type_title[value='#{title_new}']"
+        expect(page).to have_selector 'textarea#collection_type_description', text: description_new
+
+        click_link('Settings', href: '#settings')
+
+        # confirm all non-admin_set checkboxes are on
+        expect(page).to have_checked_field('collection_type_nestable')
+        expect(page).to have_checked_field('collection_type_brandable')
+        expect(page).to have_checked_field('collection_type_discoverable')
+        expect(page).to have_checked_field('collection_type_sharable')
+        expect(page).to have_checked_field('collection_type_share_applies_to_new_works')
+        expect(page).to have_checked_field('collection_type_allow_multiple_membership')
+
+        # confirm all admin_set only checkboxes are off and disabled
+        expect(page).to have_unchecked_field('collection_type_require_membership', disabled: true)
+        expect(page).to have_unchecked_field('collection_type_assigns_workflow', disabled: true)
+        expect(page).to have_unchecked_field('collection_type_assigns_visibility', disabled: true)
+
+        # change settings
+        page.uncheck('NESTING')
+        page.uncheck('DISCOVERY')
+        page.check('APPLY TO NEW WORKS')
+        page.uncheck('MULTIPLE MEMBERSHIP')
+
+        # confirm all non-admin_set checkboxes are now off
+        expect(page).to have_unchecked_field('collection_type_nestable')
+        expect(page).to have_checked_field('collection_type_brandable')
+        expect(page).to have_unchecked_field('collection_type_discoverable')
+        expect(page).to have_checked_field('collection_type_sharable')
+        expect(page).to have_checked_field('collection_type_share_applies_to_new_works')
+        expect(page).to have_unchecked_field('collection_type_allow_multiple_membership')
+
+        # uncheck sharable should disable sharable options
+        page.uncheck('SHARING')
+
+        expect(page).to have_unchecked_field('collection_type_sharable')
+        expect(page).to have_unchecked_field('collection_type_share_applies_to_new_works', disabled: true)
+
+        # check sharable should enable sharable options
+        page.check('SHARING')
+
+        expect(page).to have_checked_field('collection_type_sharable')
+        expect(page).to have_unchecked_field('collection_type_share_applies_to_new_works', disabled: false)
+
+        click_link('Participants')
+
+        # TODO: Test adding participants
+      end
+
+      context 'when editing default user collection type' do
+        let(:title_old) { user_collection_type.title }
+        let(:description_old) { user_collection_type.description }
+        let(:title_new) { 'User Collection modified' }
+        let(:description_new) { 'Change in description for user collection type.' }
+
+        before do
+          user_collection_type
+          sign_in admin_user
+          visit "/admin/collection_types/#{user_collection_type.id}/edit"
+        end
+
+        it 'allows editing of metadata, but not settings', :js do
+          expect(page).to have_content "Edit Collection Type: #{title_old}"
+
+          # confirm metadata fields have original values
+          expect(page).to have_selector "input#collection_type_title[value='#{title_old}']"
+          expect(page).to have_selector 'textarea#collection_type_description', text: description_old
+
+          # set values and save
+          fill_in('Type name', with: title_new)
+          fill_in('Type description', with: description_new)
+
+          click_button('Save changes')
+
+          expect(page).to have_content "Edit Collection Type: #{title_new}"
+
+          # confirm values were set
+          expect(page).to have_selector "input#collection_type_title[value='#{title_new}']"
+          expect(page).to have_selector 'textarea#collection_type_description', text: description_new
+
+          click_link('Settings', href: '#settings')
+
+          # confirm default user collection checkboxes are set to appropriate values
+          expect(page).to have_checked_field('collection_type_nestable', disabled: true)
+          expect(page).to have_checked_field('collection_type_brandable', disabled: true)
+          expect(page).to have_checked_field('collection_type_discoverable', disabled: true)
+          expect(page).to have_checked_field('collection_type_sharable', disabled: true)
+          expect(page).to have_unchecked_field('collection_type_share_applies_to_new_works', disabled: true)
+          expect(page).to have_checked_field('collection_type_allow_multiple_membership', disabled: true)
+
+          # confirm all admin_set only checkboxes are off and disabled
+          expect(page).to have_unchecked_field('collection_type_require_membership', disabled: true)
+          expect(page).to have_unchecked_field('collection_type_assigns_workflow', disabled: true)
+          expect(page).to have_unchecked_field('collection_type_assigns_visibility', disabled: true)
+        end
+      end
+
+      context 'when editing admin set collection type' do
+        let(:title_old) { admin_set_type.title }
+        let(:description_old) { admin_set_type.description }
+        let(:description_new) { 'Change in description for admin set collection type.' }
+
+        before do
+          admin_set_type
+          sign_in admin_user
+          visit "/admin/collection_types/#{admin_set_type.id}/edit"
+        end
+
+        it 'allows editing of metadata except title, but not settings', :js do
+          expect(page).to have_content "Edit Collection Type: #{title_old}"
+
+          # confirm metadata fields have original values
+          expect(page).to have_field("collection_type_title", disabled: true)
+          expect(page).to have_selector 'textarea#collection_type_description', text: description_old
+
+          # set values and save
+          fill_in('Type description', with: description_new)
+
+          click_button('Save changes')
+
+          expect(page).to have_content "Edit Collection Type: #{title_old}"
+
+          # confirm values were set
+          expect(page).to have_selector 'textarea#collection_type_description', text: description_new
+
+          click_link('Settings', href: '#settings')
+
+          # confirm default user collection checkboxes are set to appropriate values
+          expect(page).to have_unchecked_field('collection_type_nestable', disabled: true)
+          expect(page).to have_unchecked_field('collection_type_discoverable', disabled: true)
+          expect(page).to have_checked_field('collection_type_sharable', disabled: true)
+          expect(page).to have_checked_field('collection_type_share_applies_to_new_works', disabled: true)
+          expect(page).to have_unchecked_field('collection_type_allow_multiple_membership', disabled: true)
+
+          # confirm all admin_set only checkboxes are off and disabled
+          expect(page).to have_checked_field('collection_type_require_membership', disabled: true)
+          expect(page).to have_checked_field('collection_type_assigns_workflow', disabled: true)
+          expect(page).to have_checked_field('collection_type_assigns_visibility', disabled: true)
+        end
+      end
+    end
+
+    context 'when collections exist of this type' do
+      let!(:collection1) { create(:public_collection, user: build(:user), collection_type_gid: exhibit_collection_type.gid) }
+
+      before do
+        exhibit_collection_type
+        sign_in admin_user
+        visit "/admin/collection_types/#{exhibit_collection_type.id}/edit"
+      end
+
+      it 'all settings are disabled', :js do
+        expect(exhibit_collection_type.collections?).to be true
+
+        click_link('Settings', href: '#settings')
+
+        # confirm all checkboxes are disabled
+        expect(page).to have_field('collection_type_nestable', disabled: true)
+        expect(page).to have_field('collection_type_brandable', disabled: true)
+        expect(page).to have_field('collection_type_discoverable', disabled: true)
+        expect(page).to have_field('collection_type_sharable', disabled: true)
+        expect(page).to have_field('collection_type_share_applies_to_new_works', disabled: true)
+        expect(page).to have_field('collection_type_allow_multiple_membership', disabled: true)
+        expect(page).to have_field('collection_type_require_membership', disabled: true)
+        expect(page).to have_field('collection_type_assigns_workflow', disabled: true)
+        expect(page).to have_field('collection_type_assigns_visibility', disabled: true)
+      end
+    end
+  end
+
+  describe 'delete collection type' do
+    context 'when there are no collections of this type' do
+      let!(:empty_collection_type) { create(:collection_type, title: 'Empty Type', creator_user: admin_user) }
+      let!(:delete_modal_text) { 'Deleting this collection type will permanently remove the type and its settings from the repository.  Are you sure you want to delete this collection type?' }
+      let!(:deleted_flash_text) { "The collection type #{empty_collection_type.title} has been deleted." }
+
+      before do
+        sign_in admin_user
+        visit '/admin/collection_types'
+      end
+
+      it 'shows warning, deletes collection type, and shows flash message on success', :js do
+        expect(page).to have_content(empty_collection_type.title)
+
+        find(:xpath, "//tr[td[contains(.,'#{empty_collection_type.title}')]]/td/button", text: 'Delete').click
+
+        within('div#deleteModal') do
+          expect(page).to have_content(delete_modal_text)
+          click_button('Delete')
+        end
+
+        within('.alert-success') do
+          expect(page).to have_content(deleted_flash_text)
+        end
+
+        within('.collection-types-table') do
+          expect(page).not_to have_content(empty_collection_type.title)
+        end
+      end
+    end
+
+    context 'when collections exist of this type' do
+      let!(:not_empty_collection_type) { create(:collection_type, title: 'Not Empty Type', creator_user: admin_user) }
+      let!(:collection1) { create(:public_collection, user: admin_user, collection_type_gid: not_empty_collection_type.gid) }
+      let(:deny_delete_modal_text) do
+        'You cannot delete this collection type because one or more collections of this type have already been created. ' \
+        'To delete this collection type, first ensure that all collections of this type have been deleted.'
+      end
+
+      before do
+        sign_in admin_user
+        visit '/admin/collection_types'
+      end
+
+      it 'shows unable to delete dialog and forwards to All Collections with filter applied', :js do
+        expect(page).to have_content(not_empty_collection_type.title)
+
+        find(:xpath, "//tr[td[contains(.,'#{not_empty_collection_type.title}')]]/td/button", text: 'Delete').click
+
+        within('div#deleteDenyModal') do
+          expect(page).to have_content(deny_delete_modal_text)
+          click_link('View collections of this type')
+        end
+
+        # forwards to Dashboard -> Collections -> All Collections
+        within('li.active') do
+          expect(page).to have_link('All Collections')
+        end
+
+        # filter is applied
+        within('div#appliedParams') do
+          expect(page).to have_content('Filtering by:')
+          expect(page).to have_content('Type')
+          expect(page).to have_content(not_empty_collection_type.title)
+        end
+
+        # collection of this type is in the list of collections
+        expect(page).to have_content(collection1.title.first)
+      end
+    end
+  end
+end

data/spec/features/contact_form_spec.rb

@@ -0,0 +1,16 @@
+RSpec.describe "Sending an email via the contact form", type: :feature do
+  before { sign_in(:user) }
+
+  it "sends mail" do
+    visit '/'
+    click_link "Contact"
+    expect(page).to have_content "Contact Form"
+    fill_in "Your Name", with: "Test McPherson"
+    fill_in "Your Email", with: "archivist1@example.com"
+    fill_in "Message", with: "I am contacting you regarding ScholarSphere."
+    fill_in "Subject", with: "My Subject is Cool"
+    select "Depositing content", from: "Issue Type"
+    click_button "Send"
+    expect(page).to have_content "Thank you for your message!"
+  end
+end

data/spec/features/create_child_work_spec.rb

@@ -0,0 +1,82 @@
+require 'redlock'
+
+RSpec.describe 'Creating a new child Work', :workflow do
+  let(:user) { create(:user) }
+  let!(:sipity_entity) do
+    create(:sipity_entity, proxy_for_global_id: parent.to_global_id.to_s)
+  end
+  let(:redlock_client_stub) do # stub out redis connection
+    client = double('redlock client')
+    allow(client).to receive(:lock).and_yield(true)
+    allow(Redlock::Client).to receive(:new).and_return(client)
+    client
+  end
+  let!(:parent) { create(:generic_work, user: user, title: ["Parent First"]) }
+
+  before do
+    sign_in user
+    # stub out characterization. Travis doesn't have fits installed, and it's not relevant to the test.
+    allow(CharacterizeJob).to receive(:perform_later)
+    redlock_client_stub
+  end
+
+  it 'creates the child work' do
+    visit "/concern/parent/#{parent.id}/generic_works/new"
+    work_title = 'My Test Work'
+    within('form.new_generic_work') do
+      fill_in('Title', with: work_title)
+      click_on('Save')
+    end
+    visit "/concern/generic_works/#{parent.id}"
+    expect(page).to have_content work_title
+  end
+
+  context "when it's being updated" do
+    let(:curation_concern) { create(:generic_work, user: user) }
+    let(:new_parent) { create(:generic_work, user: user) }
+    let!(:cc_sipity_entity) do
+      create(:sipity_entity, proxy_for_global_id: curation_concern.to_global_id.to_s)
+    end
+    let!(:new_sipity_entity) do
+      create(:sipity_entity, proxy_for_global_id: new_parent.to_global_id.to_s)
+    end
+
+    before do
+      parent.ordered_members << curation_concern
+      parent.save!
+    end
+    it 'can be updated' do
+      visit "/concern/parent/#{parent.id}/generic_works/#{curation_concern.id}/edit"
+      click_on "Save"
+
+      expect(parent.reload.ordered_members.to_a.length).to eq 1
+    end
+    it "doesn't lose other memberships" do
+      new_parent.ordered_members << curation_concern
+      new_parent.save!
+
+      visit "/concern/parent/#{parent.id}/generic_works/#{curation_concern.id}/edit"
+      click_on "Save"
+
+      expect(parent.reload.ordered_members.to_a.length).to eq 1
+      expect(new_parent.reload.ordered_members.to_a.length).to eq 1
+
+      expect(curation_concern.reload.in_works_ids.length).to eq 2
+    end
+
+    context "with a parent that doesn't belong to this user" do
+      let(:new_user) { create(:user) }
+      let(:new_parent) { create(:generic_work, user: new_user) }
+
+      it "fails to update" do
+        visit "/concern/parent/#{parent.id}/generic_works/#{curation_concern.id}/edit"
+        first("input#generic_work_in_works_ids", visible: false).set new_parent.id
+        first("input#parent_id", visible: false).set new_parent.id
+        click_on "Save"
+
+        expect(new_parent.reload.ordered_members.to_a.length).to eq 0
+        expect(page).to have_content "Works can only be related to each other if user has ability to edit both."
+      end
+    end
+  end
+end

data/spec/features/create_work_admin_spec.rb

@@ -0,0 +1,44 @@
+RSpec.describe 'Creating a new Work as admin', :js, :workflow, perform_enqueued: [AttachFilesToWorkJob, IngestJob] do
+  let(:user) { create(:admin) }
+  let(:admin_set_1) do
+    create(:admin_set, id: AdminSet::DEFAULT_ID,
+                       title: ["Default Admin Set"],
+                       description: ["A description"],
+                       edit_users: [user.user_key])
+  end
+  let(:admin_set_2) do
+    create(:admin_set, title: ["Another Admin Set"],
+                       description: ["A description"],
+                       edit_users: [user.user_key])
+  end
+
+  context 'when there are multiple admin sets' do
+    before do
+      create(:permission_template_access,
+             :deposit,
+             permission_template: create(:permission_template, source_id: admin_set_1.id, with_admin_set: true, with_active_workflow: true),
+             agent_type: 'user',
+             agent_id: user.user_key)
+      create(:permission_template_access,
+             :deposit,
+             permission_template: create(:permission_template, source_id: admin_set_2.id, with_admin_set: true, with_active_workflow: true),
+             agent_type: 'user',
+             agent_id: user.user_key)
+      sign_in user
+    end
+
+    it "allows default admin set to be the first item in the select menu" do
+      visit '/dashboard'
+      click_link 'Works'
+      click_link "Add new work"
+      choose "payload_concern", option: "GenericWork"
+      click_button 'Create work'
+      click_link "Relationship" # switch tab
+      expect(page).to have_content('Administrative Set')
+      expect(page).to have_content('Another Admin Set')
+      expect(page).to have_content('Default Admin Set')
+      expect(page).to have_selector('select#generic_work_admin_set_id')
+      expect(page).to have_select('generic_work_admin_set_id', selected: 'Default Admin Set')
+    end
+  end
+end

data/spec/features/create_work_spec.rb

@@ -0,0 +1,124 @@
+RSpec.describe 'Creating a new Work', :js, :workflow do
+  let(:user) { create(:user) }
+  let!(:ability) { ::Ability.new(user) }
+  let(:file1) { File.open(fixture_path + '/world.png') }
+  let(:file2) { File.open(fixture_path + '/image.jp2') }
+  let!(:uploaded_file1) { Hyrax::UploadedFile.create(file: file1, user: user) }
+  let!(:uploaded_file2) { Hyrax::UploadedFile.create(file: file2, user: user) }
+
+  before do
+    # Grant the user access to deposit into an admin set.
+    create(:permission_template_access,
+           :deposit,
+           permission_template: create(:permission_template, with_admin_set: true, with_active_workflow: true),
+           agent_type: 'user',
+           agent_id: user.user_key)
+    # stub out characterization. Travis doesn't have fits installed, and it's not relevant to the test.
+    allow(CharacterizeJob).to receive(:perform_later)
+  end
+
+  context "when the user is not a proxy" do
+    before do
+      sign_in user
+      click_link 'Works'
+      click_link "Add new work"
+      choose "payload_concern", option: "GenericWork"
+      click_button 'Create work'
+    end
+
+    it 'creates the work' do
+      click_link "Files" # switch tab
+      expect(page).to have_content "Add files"
+      expect(page).to have_content "Add folder"
+      within('span#addfiles') do
+        attach_file("files[]", "#{Hyrax::Engine.root}/spec/fixtures/image.jp2", visible: false)
+        attach_file("files[]", "#{Hyrax::Engine.root}/spec/fixtures/jp2_fits.xml", visible: false)
+      end
+      click_link "Descriptions" # switch tab
+      fill_in('Title', with: 'My Test Work')
+      fill_in('Creator', with: 'Doe, Jane')
+      fill_in('Keyword', with: 'testing')
+      select('In Copyright', from: 'Rights statement')
+      # With selenium and the chrome driver, focus remains on the
+      # select box. Click outside the box so the next line can't find
+      # its element
+      find('body').click
+      choose('generic_work_visibility_open')
+      expect(page).to have_content('Please note, making something visible to the world (i.e. marking this as Public) may be viewed as publishing which could impact your ability to')
+      check('agreement')
+      # These lines are for debugging, should this test fail
+      # puts "Required metadata: #{page.evaluate_script(%{$('#form-progress').data('save_work_control').requiredFields.areComplete})}"
+      # puts "Required files: #{page.evaluate_script(%{$('#form-progress').data('save_work_control').uploads.hasFiles})}"
+      # puts "Agreement : #{page.evaluate_script(%{$('#form-progress').data('save_work_control').depositAgreement.isAccepted})}"
+      click_on('Save')
+      expect(page).to have_content('My Test Work')
+      expect(page).to have_content "Your files are being processed by Hyrax in the background."
+    end
+  end
+
+  context 'when the user is a proxy', perform_enqueued: [ContentDepositorChangeEventJob, AttachFilesToWorkJob, IngestJob] do
+    let(:second_user) { create(:user) }
+
+    before do
+      ProxyDepositRights.create!(grantor: second_user, grantee: user)
+      sign_in user
+      click_link 'Works'
+      click_link "Add new work"
+      choose "payload_concern", option: "GenericWork"
+      click_button 'Create work'
+    end
+
+    it "allows on-behalf-of deposit" do
+      click_link "Files" # switch tab
+      expect(page).to have_content "Add files"
+      within('span#addfiles') do
+        attach_file("files[]", "#{Hyrax::Engine.root}/spec/fixtures/image.jp2", visible: false)
+        attach_file("files[]", "#{Hyrax::Engine.root}/spec/fixtures/jp2_fits.xml", visible: false)
+      end
+      click_link "Descriptions" # switch tab
+      fill_in('Title', with: 'My Test Work')
+      fill_in('Creator', with: 'Doe, Jane')
+      fill_in('Keyword', with: 'testing')
+      select('In Copyright', from: 'Rights statement')
+      # With selenium and the chrome driver, focus remains on the
+      # select box. Click outside the box so the next line can't find
+      # its element
+      find('body').click
+      choose('generic_work_visibility_open')
+      expect(page).to have_content('Please note, making something visible to the world (i.e. marking this as Public) may be viewed as publishing which could impact your ability to')
+      select(second_user.user_key, from: 'On behalf of')
+      check('agreement')
+      # These lines are for debugging, should this test fail
+      # puts "Required metadata: #{page.evaluate_script(%{$('#form-progress').data('save_work_control').requiredFields.areComplete})}"
+      # puts "Required files: #{page.evaluate_script(%{$('#form-progress').data('save_work_control').uploads.hasFiles})}"
+      # puts "Agreement : #{page.evaluate_script(%{$('#form-progress').data('save_work_control').depositAgreement.isAccepted})}"
+      click_on('Save')
+      expect(page).to have_content('My Test Work')
+      expect(page).to have_content "Your files are being processed by Hyrax in the background."
+
+      sign_in second_user
+      click_link 'Works'
+      expect(page).to have_content "My Test Work"
+    end
+  end
+
+  context "when a file uploaded and then deleted" do
+    before do
+      sign_in user
+      click_link 'Works'
+      click_link "Add new work"
+      choose "payload_concern", option: "GenericWork"
+      click_button 'Create work'
+    end
+
+    it 'updates the required file check status' do
+      click_link "Files" # switch to the Files tab
+      within('span#addfiles') do
+        attach_file("files[]", "#{Hyrax::Engine.root}/spec/fixtures/image.jp2", visible: false)
+      end
+      expect(page).to have_css('ul li#required-files.complete', text: 'Add files')
+      click_button 'Delete' # delete the file
+      expect(page).to have_css('ul li#required-files.incomplete', text: 'Add files')
+    end
+  end
+end