hyrax 2.9.6 → 3.0.0.pre.beta1

data/spec/features/collection_multi_membership_spec.rb

@@ -0,0 +1,205 @@
+RSpec.describe 'Adding a work to multiple collections', type: :feature, clean_repo: true, js: true do
+  include Selectors::Dashboard
+  let(:admin_user) { create(:admin, email: 'admin@example.com') }
+  let(:single_membership_type_1) { create(:collection_type, :not_allow_multiple_membership, title: 'Single-membership 1') }
+  let(:single_membership_type_2) { create(:collection_type, :not_allow_multiple_membership, title: 'Single-membership 2') }
+  let(:multi_membership_type_1) { create(:collection_type, :allow_multiple_membership, title: 'Multi-membership 1') }
+  let(:multi_membership_type_2) { create(:collection_type, :allow_multiple_membership, title: 'Multi-membership 2') }
+
+  before do
+    sign_in admin_user
+  end
+
+  describe 'when both collections support multiple membership' do
+    let(:old_collection) { create(:collection_lw, user: admin_user, collection_type_gid: multi_membership_type_1.gid, title: ['OldCollectionTitle']) }
+    let!(:work) { create(:generic_work, user: admin_user, member_of_collections: [old_collection], title: ['The highly valued work that everyone wants in their collection']) }
+
+    context 'and are of different types' do
+      let!(:new_collection) { create(:collection_lw, user: admin_user, collection_type_gid: multi_membership_type_2.gid, title: ['NewCollectionTitle']) }
+
+      it 'then the work is added to both collections' do
+        optional 'ability to get capybara to find css select2-result (see Issue #3038)' if ci_build?
+        # Add to second multi-membership collection of a different type
+        visit '/dashboard/my/works'
+        check 'check_all'
+        click_button 'Add to collection' # opens the modal
+        select_member_of_collection(new_collection)
+        click_button 'Save changes'
+
+        # forwards to collection show page
+        expect(page).to have_content new_collection.title.first
+        expect(page).to have_content 'Works (1)'
+        expect(page).to have_content work.title.first
+        expect(page).to have_selector '.alert-success', text: 'Collection was successfully updated.'
+      end
+    end
+
+    context 'and are of the same type' do
+      let!(:new_collection) { create(:collection_lw, user: admin_user, collection_type_gid: multi_membership_type_1.gid, title: ['NewCollectionTitle']) }
+
+      it 'then the work is added to both collections' do
+        optional 'ability to get capybara to find css select2-result (see Issue #3038)' if ci_build?
+        # Add to second multi-membership collection of a different type
+        visit '/dashboard/my/works'
+        check 'check_all'
+        click_button 'Add to collection' # opens the modal
+        select_member_of_collection(new_collection)
+        click_button 'Save changes'
+
+        # forwards to collection show page
+        expect(page).to have_content new_collection.title.first
+        expect(page).to have_content 'Works (1)'
+        expect(page).to have_content work.title.first
+        expect(page).to have_selector '.alert-success', text: 'Collection was successfully updated.'
+      end
+    end
+  end
+
+  describe 'when both collections require single membership' do
+    let(:old_collection) { create(:collection_lw, user: admin_user, collection_type_gid: single_membership_type_1.gid, title: ['OldCollectionTitle']) }
+    let!(:work) do
+      create(:generic_work,
+             user: admin_user,
+             member_of_collections: [old_collection],
+             title: ['The highly valued work that everyone wants in their collection'],
+             creator: ["Fred"],
+             keyword: ['test'], rights_statement: ['http://rightsstatements.org/vocab/InC/1.0/'])
+    end
+
+    context 'and are of different types' do
+      let!(:new_collection) { create(:collection_lw, user: admin_user, collection_type_gid: single_membership_type_2.gid, title: ['NewCollectionTitle']) }
+
+      it 'then the work is added to both collections' do
+        optional 'ability to get capybara to find css select2-result (see Issue #3038)' if ci_build?
+        # Add to second single-membership collection of a different type
+        visit '/dashboard/my/works'
+        check 'check_all'
+        click_button 'Add to collection' # opens the modal
+        select_member_of_collection(new_collection)
+        click_button 'Save changes'
+
+        # forwards to collection show page
+        expect(page).to have_content new_collection.title.first
+        expect(page).to have_content 'Works (1)'
+        expect(page).to have_content work.title.first
+        expect(page).to have_selector '.alert-success', text: 'Collection was successfully updated.'
+      end
+    end
+
+    context 'and are of the same type' do
+      let!(:new_collection) { create(:collection_lw, user: admin_user, collection_type_gid: single_membership_type_1.gid, title: ['NewCollectionTitle']) }
+
+      context 'then the work fails to add to the second collection' do
+        it 'from the dashboard->works batch add to collection' do
+          optional 'ability to get capybara to find css select2-result (see Issue #3038)' if ci_build?
+          # Attempt to add to second single-membership collection of the same type
+          visit '/dashboard/my/works'
+          check 'check_all'
+          click_button 'Add to collection' # opens the modal
+          select_member_of_collection(new_collection)
+          click_button 'Save changes'
+
+          # forwards to collections index page and shows flash message
+          within('section.tabs-row') do
+            expect(page).to have_link 'All Collections'
+            expect(page).to have_link 'Your Collections'
+          end
+
+          err_message = "Error: You have specified more than one of the same single-membership collection type " \
+                        "(type: Single-membership 1, collections: #{new_collection.title.first} and #{old_collection.title.first})"
+          expect(page).to have_selector '.alert', text: err_message
+        end
+
+        it "from the work's edit form Relationships tab", js: true do
+          # Attempt to add to second single-membership collection of the same type
+          visit edit_hyrax_generic_work_path(work)
+          click_link "Relationships"
+
+          select_collection(new_collection)
+          check('agreement')
+          sleep 3
+          choose('generic_work_visibility_open')
+          sleep 3
+
+          within('div#savewidget') do
+            element = nil
+            all('input').each { |i| element = i if i.value == 'Save changes' }
+            element.click
+          end
+
+          err_message = "Error: You have specified more than one of the same single-membership collection type " \
+                        "(type: Single-membership 1, collections: #{old_collection.title.first} and #{new_collection.title.first})"
+          expect(page).to have_selector '.help-block', text: err_message
+        end
+
+        it "from the collection's show page Add to collection" do
+          # Attempt to add to second single-membership collection of the same type
+          visit "/dashboard/collections/#{new_collection.id}"
+          click_link 'Add existing works'
+          check 'check_all'
+          click_button 'Add to collection' # opens the modal
+          within('div#collection-list-container') do
+            expect(page).to have_selector "#member_of_collection_ids[value=\"#{new_collection.id}\"]", visible: false
+            expect(page).to have_selector "#member_of_collection_label[value=\"#{new_collection.title.first}\"]"
+            click_button 'Save changes'
+          end
+          # forwards to collections index page and shows flash message
+          within('section.tabs-row') do
+            expect(page).to have_link 'All Collections'
+            expect(page).to have_link 'Your Collections'
+          end
+
+          err_message = "Error: You have specified more than one of the same single-membership collection type " \
+                        "(type: Single-membership 1, collections: #{new_collection.title.first} and #{old_collection.title.first})"
+          expect(page).to have_selector '.alert', text: err_message
+        end
+      end
+    end
+  end
+
+  describe 'when adding a work already in a collection' do
+    let!(:work) { create(:generic_work, user: admin_user, member_of_collections: [old_collection], title: ['The highly valued work that everyone wants in their collection']) }
+
+    context 'allowing multi-membership' do
+      let(:old_collection) { create(:collection_lw, user: admin_user, collection_type_gid: multi_membership_type_1.gid, title: ['CollectionTitle']) }
+      let!(:new_collection) { old_collection }
+
+      it 'then the add is treated as a success' do
+        optional 'ability to get capybara to find css select2-result (see Issue #3038)' if ci_build?
+        # Re-add to same multi-membership collection
+        visit '/dashboard/my/works'
+        check 'check_all'
+        click_button 'Add to collection' # opens the modal
+        select_member_of_collection(new_collection)
+        click_button 'Save changes'
+
+        # forwards to collection show page
+        expect(page).to have_content new_collection.title.first
+        expect(page).to have_content 'Works (1)'
+        expect(page).to have_content work.title.first
+        expect(page).to have_selector '.alert-success', text: 'Collection was successfully updated.'
+      end
+    end
+
+    context 'requiring single-membership' do
+      let(:old_collection) { create(:collection_lw, user: admin_user, collection_type_gid: single_membership_type_1.gid, title: ['CollectionTitle']) }
+      let!(:new_collection) { old_collection }
+
+      it 'then the add is treated as a success' do
+        optional 'ability to get capybara to find css select2-result (see Issue #3038)' if ci_build?
+        # Re-add to same single-membership collection
+        visit '/dashboard/my/works'
+        check 'check_all'
+        click_button 'Add to collection' # opens the modal
+        select_member_of_collection(new_collection)
+        click_button 'Save changes'
+
+        # forwards to collection show page
+        expect(page).to have_content new_collection.title.first
+        expect(page).to have_content 'Works (1)'
+        expect(page).to have_content work.title.first
+        expect(page).to have_selector '.alert-success', text: 'Collection was successfully updated.'
+      end
+    end
+  end
+end

data/spec/features/collection_spec.rb

@@ -0,0 +1,122 @@
+RSpec.describe 'collection', type: :feature, clean_repo: true do
+  let(:user) { create(:user) }
+
+  let(:collection1) { create(:public_collection, user: user) }
+  let(:collection2) { create(:public_collection, user: user) }
+
+  describe 'collection show page' do
+    let(:collection) do
+      create(:public_collection, user: user, description: ['collection description'], collection_type_settings: :nestable)
+    end
+    let!(:work1) { create(:work, title: ["King Louie"], member_of_collections: [collection], user: user) }
+    let!(:work2) { create(:work, title: ["King Kong"], member_of_collections: [collection], user: user) }
+    let!(:col1) { create(:public_collection, title: ["Sub-collection 1"], member_of_collections: [collection], user: user) }
+    let!(:col2) { create(:public_collection, title: ["Sub-collection 2"], member_of_collections: [collection], user: user) }
+
+    before do
+      sign_in user
+      visit "/collections/#{collection.id}"
+    end
+
+    it "shows a collection with a listing of Descriptive Metadata and catalog-style search results" do
+      expect(page).to have_content(collection.title.first)
+      expect(page).to have_content(collection.description.first)
+      expect(page).to have_content("Collection Details")
+      # Should not show title and description a second time
+      expect(page).not_to have_css('.metadata-collections', text: collection.title.first)
+      expect(page).not_to have_css('.metadata-collections', text: collection.description.first)
+      # Should have search results / contents listing
+      expect(page).to have_content(work1.title.first)
+      expect(page).to have_content(work2.title.first)
+      expect(page).to have_content(col1.title.first)
+      expect(page).to have_content(col2.title.first)
+      expect(page).not_to have_css(".pagination")
+
+      click_link "Gallery"
+      expect(page).to have_content(work1.title.first)
+      expect(page).to have_content(work2.title.first)
+    end
+
+    it "hides collection descriptive metadata when searching a collection" do
+      expect(page).to have_content(collection.title.first)
+      expect(page).to have_content(collection.description.first)
+      expect(page).to have_content(work1.title.first)
+      expect(page).to have_content(work2.title.first)
+      fill_in('collection_search', with: work1.title.first)
+      click_button('collection_submit')
+      # Should not have Collection metadata table (only title and description)
+      expect(page).not_to have_content("Total works")
+      expect(page).to have_content(collection.title.first)
+      expect(page).to have_content(collection.description.first)
+      # Should have search results / contents listing
+      expect(page).to have_content("Search Results")
+      expect(page).to have_content(work1.title.first)
+      expect(page).not_to have_content(work2.title.first)
+    end
+
+    it "returns json results" do
+      visit "/collections/#{collection.id}.json"
+      expect(page).to have_http_status(:success)
+      json = JSON.parse(page.body)
+      expect(json['id']).to eq collection.id
+      expect(json['title']).to match_array collection.title
+    end
+
+    context "with a non-nestable collection type" do
+      let(:collection) do
+        build(:public_collection_lw, user: user, description: ['collection description'], collection_type_settings: :not_nestable, with_solr_document: true, with_permission_template: true)
+      end
+
+      it "displays basic information on its show page" do
+        expect(page).to have_content(collection.title.first)
+        expect(page).to have_content(collection.description.first)
+        expect(page).to have_content("Collection Details")
+      end
+    end
+  end
+
+  # TODO: this is just like the block above. Merge them.
+  describe 'show work pages of a collection' do
+    before do
+      docs = (0..12).map do |n|
+        { "has_model_ssim" => ["GenericWork"], :id => "zs25x871q#{n}",
+          "depositor_ssim" => [user.user_key],
+          "suppressed_bsi" => false,
+          "member_of_collection_ids_ssim" => [collection.id],
+          "nesting_collection__parent_ids_ssim" => [collection.id],
+          "edit_access_person_ssim" => [user.user_key] }
+      end
+      ActiveFedora::SolrService.add(docs, commit: true)
+
+      sign_in user
+    end
+    let(:collection) { create(:named_collection, user: user) }
+
+    it "shows a collection with a listing of Descriptive Metadata and catalog-style search results" do
+      visit "/collections/#{collection.id}"
+      expect(page).to have_css(".pagination")
+    end
+  end
+
+  describe 'show subcollection pages of a collection' do
+    before do
+      docs = (0..12).map do |n|
+        { "has_model_ssim" => ["Collection"], :id => "zs25x871q#{n}",
+          "depositor_ssim" => [user.user_key],
+          "suppressed_bsi" => false,
+          "member_of_collection_ids_ssim" => [collection.id],
+          "nesting_collection__parent_ids_ssim" => [collection.id],
+          "edit_access_person_ssim" => [user.user_key] }
+      end
+      ActiveFedora::SolrService.add(docs, commit: true)
+
+      sign_in user
+    end
+    let(:collection) { create(:named_collection, user: user) }
+
+    it "shows a collection with a listing of Descriptive Metadata and catalog-style search results" do
+      visit "/collections/#{collection.id}"
+      expect(page).to have_css(".pagination")
+    end
+  end
+end