hyrax 2.9.6 → 3.0.0.pre.beta1

data/spec/controllers/hyrax/admin/admin_sets_controller_spec.rb

@@ -0,0 +1,284 @@
+RSpec.describe Hyrax::Admin::AdminSetsController do
+  routes { Hyrax::Engine.routes }
+  let(:user) { create(:user) }
+
+  context "a non admin" do
+    describe "#index" do
+      it 'is unauthorized' do
+        get :index
+        expect(response).to be_redirect
+      end
+    end
+
+    describe "#new" do
+      it 'is unauthorized' do
+        get :new
+        expect(response).to be_redirect
+      end
+    end
+
+    describe "#show" do
+      before do
+        sign_in user
+        controller.instance_variable_set(:@admin_set, admin_set)
+      end
+
+      context "when user has access through public group" do
+        # Even though the user can view this admin set, they should not be able to view
+        # it on the admin page.
+        let(:admin_set) { create(:adminset_lw, with_solr_document: true, with_permission_template: { view_groups: ['public'] }) }
+
+        it 'is unauthorized' do
+          get :show, params: { id: admin_set }
+          expect(response).to be_redirect
+        end
+      end
+
+      context "when user has access through registered group" do
+        # Even though the user can view this admin set, the should not be able to view
+        # it on the admin page.
+        let(:admin_set) { create(:adminset_lw, with_solr_document: true, with_permission_template: { view_groups: ['registered'] }) }
+
+        it 'is unauthorized' do
+          get :show, params: { id: admin_set }
+          expect(response).to be_redirect
+        end
+      end
+
+      context "when user is directly granted view access" do
+        # Even though the user can view this admin set, the should not be able to view
+        # it on the admin page.
+        let(:admin_set) { create(:adminset_lw, with_solr_document: true, with_permission_template: { view_users: [user.user_key] }) }
+
+        before do
+          create(:work, :public, admin_set: admin_set)
+        end
+
+        it 'defines a presenter' do
+          get :show, params: { id: admin_set }
+          expect(response).to be_success
+          expect(assigns[:presenter]).to be_kind_of Hyrax::AdminSetPresenter
+          expect(assigns[:presenter].id).to eq admin_set.id
+        end
+      end
+    end
+
+    describe "#edit" do
+      before do
+        sign_in user
+      end
+
+      context "when user is directly granted manage access" do
+        # Even though the user can view this admin set, the should not be able to view
+        # it on the admin page.
+        let(:admin_set) { create(:adminset_lw, with_solr_document: true, with_permission_template: { manage_users: [user.user_key] }) }
+        let(:admin_set2) { create(:adminset_lw, with_solr_document: true, with_permission_template: true) }
+
+        context 'and user is accessing the managed set' do
+          before do
+            controller.instance_variable_set(:@admin_set, admin_set)
+          end
+
+          it 'defines a form' do
+            get :edit, params: { id: admin_set }
+            expect(response).to be_success
+            expect(assigns[:form]).to be_kind_of Hyrax::Forms::AdminSetForm
+          end
+        end
+
+        context 'and user attempts to access another admin set' do
+          before do
+            controller.instance_variable_set(:@admin_set, admin_set2)
+          end
+
+          it 'is unauthorized' do
+            get :edit, params: { id: admin_set2 }
+            expect(response).to be_redirect
+          end
+        end
+      end
+    end
+
+    describe "#files" do
+      let(:admin_set) { create(:admin_set) }
+
+      it 'is unauthorized' do
+        get :files, params: { id: admin_set }, format: :json
+        expect(response).to be_unauthorized
+      end
+    end
+  end
+
+  context "as an admin" do
+    before do
+      sign_in user
+      allow(controller).to receive(:authorize!).and_return(true)
+    end
+
+    describe "#index" do
+      it 'allows an authorized user to view the page' do
+        get :index
+        expect(response).to be_success
+        expect(assigns[:admin_sets]).to be_kind_of Array
+      end
+    end
+
+    describe "#new" do
+      it 'allows an authorized user to view the page' do
+        get :new
+        expect(response).to be_success
+      end
+    end
+
+    describe "#create" do
+      before do
+        controller.admin_set_create_service = service
+      end
+
+      context "when it's successful" do
+        let(:service) do
+          lambda do |admin_set:, **_kargs|
+            admin_set.id = 123
+            # https://github.com/samvera/active_fedora/issues/1251
+            allow(admin_set).to receive(:persisted?).and_return(true)
+            true
+          end
+        end
+
+        it 'creates file sets' do
+          post :create, params: { admin_set: { title: 'Test title',
+                                               description: 'test description',
+                                               workflow_name: 'default' } }
+          admin_set = assigns(:admin_set)
+          expect(response).to redirect_to(edit_admin_admin_set_path(admin_set))
+        end
+      end
+
+      context "when it fails" do
+        let(:service) { ->(**_kargs) { false } }
+
+        it 'shows the new form' do
+          post :create, params: { admin_set: { title: 'Test title',
+                                               description: 'test description' } }
+          expect(response).to render_template 'new'
+        end
+      end
+    end
+
+    describe "#show" do
+      context "when it's successful" do
+        let(:admin_set) { create(:admin_set, edit_users: [user]) }
+
+        before do
+          create(:work, :public, admin_set: admin_set)
+        end
+
+        it 'defines a presenter' do
+          get :show, params: { id: admin_set }
+          expect(response).to be_success
+          expect(assigns[:presenter]).to be_kind_of Hyrax::AdminSetPresenter
+          expect(assigns[:presenter].id).to eq admin_set.id
+        end
+      end
+    end
+
+    describe "#edit" do
+      let(:admin_set) { create(:admin_set, edit_users: [user]) }
+
+      it 'defines a form' do
+        get :edit, params: { id: admin_set }
+        expect(response).to be_success
+        expect(assigns[:form]).to be_kind_of Hyrax::Forms::AdminSetForm
+      end
+    end
+
+    describe "#files" do
+      let(:admin_set) { create(:admin_set, edit_users: [user]) }
+
+      it 'shows a list of member files' do
+        get :files, params: { id: admin_set }, format: :json
+        expect(response).to be_success
+      end
+    end
+
+    describe "#update" do
+      let(:admin_set) { create(:admin_set, edit_users: [user]) }
+
+      it 'updates a record' do
+        patch :update, params: { id: admin_set,
+                                 admin_set: { title: "Improved title" } }
+        expect(response).to redirect_to(edit_admin_admin_set_path)
+        expect(assigns[:admin_set].title).to eq ['Improved title']
+      end
+    end
+
+    describe "#destroy" do
+      let(:admin_set) { create(:admin_set, edit_users: [user]) }
+
+      context "with empty admin set" do
+        it "deletes the admin set" do
+          controller.request.set_header("HTTP_REFERER", "/admin/admin_sets")
+          delete :destroy, params: { id: admin_set }
+
+          expect(response).to have_http_status(:found)
+          expect(response).to redirect_to(my_collections_path)
+          expect(flash[:notice]).to eq "Administrative set successfully deleted"
+          expect(AdminSet.exists?(admin_set.id)).to be false
+        end
+      end
+
+      context "with empty admin set and referrer from the my/collections dashboard" do
+        it "deletes the admin set" do
+          controller.request.set_header("HTTP_REFERER", "/my/collections")
+          delete :destroy, params: { id: admin_set }
+
+          expect(response).to have_http_status(:found)
+          expect(response).to redirect_to(my_collections_path)
+          expect(flash[:notice]).to eq "Administrative set successfully deleted"
+          expect(AdminSet.exists?(admin_set.id)).to be false
+        end
+      end
+
+      context "with empty admin set and referrer from the /collections dashboard" do
+        it "deletes the admin set" do
+          controller.request.set_header("HTTP_REFERER", "/collections")
+          delete :destroy, params: { id: admin_set }
+
+          expect(response).to have_http_status(:found)
+          expect(response).to redirect_to(dashboard_collections_path)
+          expect(flash[:notice]).to eq "Administrative set successfully deleted"
+          expect(AdminSet.exists?(admin_set.id)).to be false
+        end
+      end
+
+      context "with a non-empty admin set" do
+        let(:work) { create(:generic_work, user: user) }
+
+        before do
+          admin_set.members << work
+          admin_set.reload
+        end
+        it "doesn't delete the admin set (or work)" do
+          delete :destroy, params: { id: admin_set }
+          expect(response).to have_http_status(:found)
+          expect(response).to redirect_to(admin_admin_set_path(admin_set))
+          expect(flash[:alert]).to eq "Administrative set cannot be deleted as it is not empty"
+          expect(AdminSet.exists?(admin_set.id)).to be true
+          expect(GenericWork.exists?(work.id)).to be true
+        end
+      end
+
+      context "with the default admin set" do
+        let(:admin_set) { create(:admin_set, edit_users: [user], id: AdminSet::DEFAULT_ID) }
+
+        it "doesn't delete the admin set" do
+          delete :destroy, params: { id: admin_set }
+          expect(response).to have_http_status(:found)
+          expect(response).to redirect_to(admin_admin_set_path(admin_set))
+          expect(flash[:alert]).to eq "Administrative set cannot be deleted as it is the default set"
+          expect(AdminSet.exists?(admin_set.id)).to be true
+        end
+      end
+    end
+  end
+end

data/spec/controllers/hyrax/admin/appearances_controller_spec.rb

@@ -0,0 +1,66 @@
+RSpec.describe Hyrax::Admin::AppearancesController do
+  describe "#show" do
+    before do
+      sign_in user
+    end
+    let(:user) { create(:user) }
+
+    context "when not authorized" do
+      it "renders the unauthorized template" do
+        get :show
+        expect(response).to render_template(:unauthorized)
+      end
+    end
+
+    context "when authorized" do
+      before do
+        allow(controller).to receive_messages(current_user: user)
+        expect(user).to receive(:groups).and_return(['admin', 'registered'])
+      end
+
+      it "is successful" do
+        expect(controller).to receive(:add_breadcrumb).with('Home', root_path)
+        expect(controller).to receive(:add_breadcrumb).with('Dashboard', dashboard_path)
+        expect(controller).to receive(:add_breadcrumb).with('Configuration', '#')
+        expect(controller).to receive(:add_breadcrumb).with('Appearance', "/admin/appearance")
+        get :show
+        expect(assigns[:form]).to be_kind_of Hyrax::Forms::Admin::Appearance
+        expect(response).to be_success
+      end
+    end
+  end
+
+  describe "#update" do
+    before do
+      sign_in user
+    end
+    let(:user) { create(:user) }
+
+    context "when authorized" do
+      before do
+        allow(controller).to receive_messages(current_user: user)
+        expect(user).to receive(:groups).and_return(['admin', 'registered'])
+      end
+
+      let(:form) { instance_double(Hyrax::Forms::Admin::Appearance, update!: true) }
+      let(:attributes) do
+        {
+          "header_background_color" => "#00ff00",
+          "link_color" => "#e02020",
+          "footer_link_color" => "#e02020",
+          "header_text_color" => "#17557b",
+          "primary_button_background_color" => "#00ff00"
+        }
+      end
+
+      it "is successful" do
+        expect(Hyrax::Forms::Admin::Appearance).to receive(:new)
+          .with(ActionController::Parameters.new(attributes).permit!)
+          .and_return(form)
+
+        patch :update, params: { admin_appearance: attributes }
+        expect(response).to be_redirect
+      end
+    end
+  end
+end

data/spec/controllers/hyrax/admin/collection_type_participants_controller_spec.rb

@@ -0,0 +1,152 @@
+RSpec.describe Hyrax::Admin::CollectionTypeParticipantsController, type: :controller do
+  context 'anonymous user' do
+    let(:collection_type) { create(:collection_type) }
+    let(:valid_attributes) do
+      {
+        hyrax_collection_type_id: collection_type.id,
+        access: 'creator',
+        agent_id: 'example@example.com',
+        agent_type: 'user'
+      }
+    end
+
+    describe '#create' do
+      it 'does not create a pariticpant' do
+        post :create
+        expect do
+          post :create, params: { collection_type_participant: valid_attributes }
+        end.to change(Hyrax::CollectionTypeParticipant, :count).by(0)
+      end
+
+      it "returns http redirect" do
+        post :create
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe '#destroy' do
+      let!(:collection_type_participant) { create(:collection_type_participant) }
+
+      it 'does not destroy a participant' do
+        expect do
+          delete :destroy, params: { id: collection_type_participant.to_param }
+        end.to change(Hyrax::CollectionTypeParticipant, :count).by(0)
+      end
+
+      it "returns http redirect" do
+        delete :destroy, params: { id: collection_type_participant.to_param }
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+  end
+
+  context "unauthorized user" do
+    let(:user) { create(:user) }
+    let(:collection_type) { create(:collection_type) }
+    let(:valid_attributes) do
+      {
+        hyrax_collection_type_id: collection_type.id,
+        access: 'creator',
+        agent_id: 'example@example.com',
+        agent_type: 'user'
+      }
+    end
+
+    before do
+      allow(controller.current_ability).to receive(:can?).with(any_args).and_return(false)
+      sign_in user
+    end
+
+    describe "#create" do
+      it 'does not create a pariticpant' do
+        post :create
+        expect do
+          post :create, params: { collection_type_participant: valid_attributes }
+        end.to change(Hyrax::CollectionTypeParticipant, :count).by(0)
+      end
+
+      it "returns http redirect" do
+        post :create
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+
+    describe "#destroy" do
+      let!(:collection_type_participant) { create(:collection_type_participant) }
+
+      it 'does not destroy a participants' do
+        expect do
+          delete :destroy, params: { id: collection_type_participant.to_param }
+        end.to change(Hyrax::CollectionTypeParticipant, :count).by(0)
+      end
+      it "returns http redirect" do
+        delete :destroy, params: { id: :id }
+        expect(response).to have_http_status(:redirect)
+      end
+    end
+  end
+
+  context "authorized user" do
+    let(:collection_type) { create(:collection_type) }
+    let(:valid_attributes) do
+      {
+        hyrax_collection_type_id: collection_type.id,
+        access: Hyrax::CollectionTypeParticipant::CREATE_ACCESS,
+        agent_id: 'example@example.com',
+        agent_type: 'user'
+      }
+    end
+
+    let(:valid_session) { {} }
+    let(:collection_type_participant) { create(:collection_type_participant) }
+    let(:user) { create(:user) }
+
+    before do
+      allow(controller.current_ability).to receive(:can?).with(any_args).and_return(true)
+      sign_in user
+    end
+
+    describe "#create" do
+      context "with valid params" do
+        it "creates a new CollectionTypeParticipant" do
+          expect do
+            post :create, params: { collection_type_participant: valid_attributes }, session: valid_session
+          end.to change(Hyrax::CollectionTypeParticipant, :count).by(1)
+        end
+
+        it "redirects to the edit_admin_collection_type with participants panel active" do
+          post :create, params: { collection_type_participant: valid_attributes }, session: valid_session
+          expect(response).to redirect_to(edit_admin_collection_type_path(collection_type.id, anchor: 'participants'))
+        end
+
+        it "assigns all attributes" do
+          post :create, params: { collection_type_participant: valid_attributes }, session: valid_session
+          expect(assigns[:collection_type_participant].attributes.symbolize_keys).to include(valid_attributes)
+        end
+      end
+
+      context "with invalid params" do
+        it "does not create a new CollectionTypeParticipant" do
+          post :create, params: { collection_type_participant: { hyrax_collection_type_id: '1' } }, session: valid_session
+          expect do
+            post :create, params: { collection_type_participant: { hyrax_collection_type_id: '1' } }, session: valid_session
+          end.to change(Hyrax::CollectionTypeParticipant, :count).by(0)
+        end
+      end
+    end
+
+    describe "#destroy" do
+      it "destroys the requested collection_type_participant" do
+        expect(collection_type_participant).to be_persisted
+        expect do
+          delete :destroy, params: { id: collection_type_participant.to_param }, session: valid_session
+        end.to change(Hyrax::CollectionTypeParticipant, :count).by(-1)
+      end
+
+      it "redirects to edit the collections participants list" do
+        delete :destroy, params: { id: collection_type_participant.to_param }, session: valid_session
+        expect(response).to redirect_to(edit_admin_collection_type_path(collection_type_participant.hyrax_collection_type_id, anchor: 'participants'))
+      end
+    end
+  end
+end